Re: [PATCH] btrfs: remove redundant replace_state init

2018-11-12 Thread David Sterba 
On Mon, Nov 12, 2018 at 01:05:15PM +0800, Anand Jain wrote:
> dev_replace::replace_state has been set to
> BTRFS_DEV_REPLACE_ITEM_STATE_NEVER_STARTED (0) in the same function,
> So delete the line which sets replace_state = 0;
> 
> Signed-off-by: Anand Jain 

Added to misc-next, thanks.

Re: [PATCH] btrfs: remove redundant replace_state init

2018-11-11 Thread Nikolay Borisov 



On 12.11.18 г. 7:05 ч., Anand Jain wrote:
> dev_replace::replace_state has been set to
> BTRFS_DEV_REPLACE_ITEM_STATE_NEVER_STARTED (0) in the same function,
> So delete the line which sets replace_state = 0;
> 
> Signed-off-by: Anand Jain 

Reviewed-by: Nikolay Borisov 

> ---
>  fs/btrfs/dev-replace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index cc25a34f87b0..cdc4313446a9 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -59,7 +59,6 @@ int btrfs_init_dev_replace(struct btrfs_fs_info *fs_info)
>   BTRFS_DEV_REPLACE_ITEM_STATE_NEVER_STARTED;
>   dev_replace->cont_reading_from_srcdev_mode =
>   BTRFS_DEV_REPLACE_ITEM_CONT_READING_FROM_SRCDEV_MODE_ALWAYS;
> - dev_replace->replace_state = 0;
>   dev_replace->time_started = 0;
>   dev_replace->time_stopped = 0;
>   atomic64_set(_replace->num_write_errors, 0);
>

[PATCH] btrfs: remove redundant replace_state init

2018-11-11 Thread Anand Jain 
dev_replace::replace_state has been set to
BTRFS_DEV_REPLACE_ITEM_STATE_NEVER_STARTED (0) in the same function,
So delete the line which sets replace_state = 0;

Signed-off-by: Anand Jain 
---
 fs/btrfs/dev-replace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index cc25a34f87b0..cdc4313446a9 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -59,7 +59,6 @@ int btrfs_init_dev_replace(struct btrfs_fs_info *fs_info)
BTRFS_DEV_REPLACE_ITEM_STATE_NEVER_STARTED;
dev_replace->cont_reading_from_srcdev_mode =
BTRFS_DEV_REPLACE_ITEM_CONT_READING_FROM_SRCDEV_MODE_ALWAYS;
-   dev_replace->replace_state = 0;
dev_replace->time_started = 0;
dev_replace->time_stopped = 0;
atomic64_set(_replace->num_write_errors, 0);
-- 
1.8.3.1