Re: [PATCH] btrfs: submit superblock io with REQ_META

[Liu Bo]

On Fri, Aug 18, 2017 at 06:21:53PM +0200, David Sterba wrote:
> The superblock is also metadata of the filesystem so the relevant IO
> should be tagged as such.
> 

Reviewed-by: Liu Bo 

-liubo
> Signed-off-by: David Sterba 
> ---
>  fs/btrfs/disk-io.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 90b967ae46d0..21b55e8caf33 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3433,9 +3433,11 @@ static int write_dev_supers(struct btrfs_device 
> *device,
>*/
>   if (i == 0) {
>   ret = btrfsic_submit_bh(REQ_OP_WRITE,
> - REQ_SYNC | REQ_FUA, bh);
> + REQ_SYNC | REQ_FUA | REQ_META,
> + bh);
>   } else {
> - ret = btrfsic_submit_bh(REQ_OP_WRITE, REQ_SYNC, bh);
> + ret = btrfsic_submit_bh(REQ_OP_WRITE,
> + REQ_SYNC | REQ_META, bh);
>   }
>   if (ret)
>   errors++;
> -- 
> 2.14.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] btrfs: submit superblock io with REQ_META

[David Sterba]

The superblock is also metadata of the filesystem so the relevant IO
should be tagged as such.

Signed-off-by: David Sterba 
---
 fs/btrfs/disk-io.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 90b967ae46d0..21b55e8caf33 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3433,9 +3433,11 @@ static int write_dev_supers(struct btrfs_device *device,
 */
if (i == 0) {
ret = btrfsic_submit_bh(REQ_OP_WRITE,
-   REQ_SYNC | REQ_FUA, bh);
+   REQ_SYNC | REQ_FUA | REQ_META,
+   bh);
} else {
-   ret = btrfsic_submit_bh(REQ_OP_WRITE, REQ_SYNC, bh);
+   ret = btrfsic_submit_bh(REQ_OP_WRITE,
+   REQ_SYNC | REQ_META, bh);
}
if (ret)
errors++;
-- 
2.14.0

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html