Re: [PATCH v2 00/11] btrfs: Add missing pairing mount options.

2014-01-05 Thread Qu Wenruo

On fri, 3 Jan 2014 18:58:28 +0100, David Sterba wrote:

On Fri, Jan 03, 2014 at 02:10:23PM +0800, Qu Wenruo wrote:

Some options should be paired to support triggering different functions
when remounting.
This patchset add these missing pairing mount options.

Thanks!


   btrfs: Add nocheck_int mount option.
   btrfs: Add noinode_cache mount option.

Commented separately, imho not to be merged in current state.


   btrfs: Add "barrier" option to support "-o remount,barrier"
   btrfs: Add noautodefrag mount option.
   btrfs: Add nodiscard mount option.
   btrfs: Add noenospc_debug mount option.
   btrfs: Add noflushoncommit mount option.
   btrfs: Add acl mount option.
   btrfs: Add datacow mount option.
   btrfs: Add datasum mount option.
   btrfs: Add treelog mount option.

All ok.

Reviewed-by: David Sterba 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Thanks for your commenting.
nocheck_int and noinode_cache will be remove in next version,
and noinode_cache will be resent as a independent patch after more
investigation and tests.

Also remounting test case will be added to xfstest soon.

Qu
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 00/11] btrfs: Add missing pairing mount options.

2014-01-05 Thread Qu Wenruo

On fri, 03 Jan 2014 11:52:07 -0600, Eric Sandeen wrote:

On 1/3/14, 12:10 AM, Qu Wenruo wrote:

Some options should be paired to support triggering different functions
when remounting.

This patchset add these missing pairing mount options.

I think this really would benefit from a regression test which
ensures that every remount transition works properly...

Thanks,
-Eric

Xfstests test case for the remounting test is under development and will
submit soon.(for both generic and btrfs mount options)

As far as I tested, no problem occurs in my test environment but since
the IO pressure is low, a more heavier test case is needed though.

Qu



changelog:
v1: Initial commit with only barrier option
v2: Add other missing pairing options

Qu Wenruo (11):
   btrfs: Add "barrier" option to support "-o remount,barrier"
   btrfs: Add noautodefrag mount option.
   btrfs: Add nocheck_int mount option.
   btrfs: Add nodiscard mount option.
   btrfs: Add noenospc_debug mount option.
   btrfs: Add noflushoncommit mount option.
   btrfs: Add noinode_cache mount option.
   btrfs: Add acl mount option.
   btrfs: Add datacow mount option.
   btrfs: Add datasum mount option.
   btrfs: Add treelog mount option.

  Documentation/filesystems/btrfs.txt | 56 ++--
  fs/btrfs/super.c| 74 -
  2 files changed, 110 insertions(+), 20 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 00/11] btrfs: Add missing pairing mount options.

2014-01-03 Thread David Sterba
On Fri, Jan 03, 2014 at 02:10:23PM +0800, Qu Wenruo wrote:
> Some options should be paired to support triggering different functions
> when remounting.
> This patchset add these missing pairing mount options.

Thanks!

>   btrfs: Add nocheck_int mount option.
>   btrfs: Add noinode_cache mount option.

Commented separately, imho not to be merged in current state.

>   btrfs: Add "barrier" option to support "-o remount,barrier"
>   btrfs: Add noautodefrag mount option.
>   btrfs: Add nodiscard mount option.
>   btrfs: Add noenospc_debug mount option.
>   btrfs: Add noflushoncommit mount option.
>   btrfs: Add acl mount option.
>   btrfs: Add datacow mount option.
>   btrfs: Add datasum mount option.
>   btrfs: Add treelog mount option.

All ok.

Reviewed-by: David Sterba 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 00/11] btrfs: Add missing pairing mount options.

2014-01-03 Thread Eric Sandeen
On 1/3/14, 12:10 AM, Qu Wenruo wrote:
> Some options should be paired to support triggering different functions
> when remounting.
> 
> This patchset add these missing pairing mount options.

I think this really would benefit from a regression test which
ensures that every remount transition works properly...

Thanks,
-Eric

> changelog:
> v1: Initial commit with only barrier option
> v2: Add other missing pairing options
> 
> Qu Wenruo (11):
>   btrfs: Add "barrier" option to support "-o remount,barrier"
>   btrfs: Add noautodefrag mount option.
>   btrfs: Add nocheck_int mount option.
>   btrfs: Add nodiscard mount option.
>   btrfs: Add noenospc_debug mount option.
>   btrfs: Add noflushoncommit mount option.
>   btrfs: Add noinode_cache mount option.
>   btrfs: Add acl mount option.
>   btrfs: Add datacow mount option.
>   btrfs: Add datasum mount option.
>   btrfs: Add treelog mount option.
> 
>  Documentation/filesystems/btrfs.txt | 56 ++--
>  fs/btrfs/super.c| 74 
> -
>  2 files changed, 110 insertions(+), 20 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 00/11] btrfs: Add missing pairing mount options.

2014-01-02 Thread Qu Wenruo
Some options should be paired to support triggering different functions
when remounting.

This patchset add these missing pairing mount options.

changelog:
v1: Initial commit with only barrier option
v2: Add other missing pairing options

Qu Wenruo (11):
  btrfs: Add "barrier" option to support "-o remount,barrier"
  btrfs: Add noautodefrag mount option.
  btrfs: Add nocheck_int mount option.
  btrfs: Add nodiscard mount option.
  btrfs: Add noenospc_debug mount option.
  btrfs: Add noflushoncommit mount option.
  btrfs: Add noinode_cache mount option.
  btrfs: Add acl mount option.
  btrfs: Add datacow mount option.
  btrfs: Add datasum mount option.
  btrfs: Add treelog mount option.

 Documentation/filesystems/btrfs.txt | 56 ++--
 fs/btrfs/super.c| 74 -
 2 files changed, 110 insertions(+), 20 deletions(-)

-- 
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html