Re: [PATCH v6 0/3] btrfs: balance: improve kernel logs

2018-11-20 Thread David Sterba 
On Tue, Nov 20, 2018 at 04:12:54PM +0800, Anand Jain wrote:
> v5->v6:
>  Mostly the defines non functional changes.
>  Use goto instead of return in middle of the define.
>  Pls ref individual patches 1/3 and 2/3 for more info.
> 
> v4->v5:
>  Mainly address David review comment [1].
>  [1]
>   https://patchwork.kernel.org/patch/10425987/
>  pls ref to individual patch 2/3 for details.
> 
> v3->v4:
>  Pls ref to individual patches.
> 
> Based on misc-next.
> 
> v2->v3:
>   Inspried by describe_relocation(), improves it, makes it a helper
>   function and use it to log the balance operations.
> 
> Kernel logs are very important for the forensic investigations of the
> issues, these patchs make balance logs easy to review.
> 
> Anand Jain (3):
>   btrfs: add helper function describe_block_group()
>   btrfs: balance: add args info during start and resume
>   btrfs: balance: add kernel log for end or paused

Now in topic branch ext/anand/balance-description in my devel repos, I
made some changes as I don't want to take the rounds through mail. There
are some cosmetic changes like reordering the balance args, added
comments and aligned the \ even farther to the right. Please check the
committed patches for some inspiration.

I'll add that to misc-next after passes some tests, until then it'll be
in for-next. Thanks.

[PATCH v6 0/3] btrfs: balance: improve kernel logs

2018-11-20 Thread Anand Jain 
v5->v6:
 Mostly the defines non functional changes.
 Use goto instead of return in middle of the define.
 Pls ref individual patches 1/3 and 2/3 for more info.

v4->v5:
 Mainly address David review comment [1].
 [1]
  https://patchwork.kernel.org/patch/10425987/
 pls ref to individual patch 2/3 for details.

v3->v4:
 Pls ref to individual patches.

Based on misc-next.

v2->v3:
  Inspried by describe_relocation(), improves it, makes it a helper
  function and use it to log the balance operations.

Kernel logs are very important for the forensic investigations of the
issues, these patchs make balance logs easy to review.

Anand Jain (3):
  btrfs: add helper function describe_block_group()
  btrfs: balance: add args info during start and resume
  btrfs: balance: add kernel log for end or paused

 fs/btrfs/relocation.c |  30 +--
 fs/btrfs/volumes.c| 216 +-
 fs/btrfs/volumes.h|   1 +
 3 files changed, 217 insertions(+), 30 deletions(-)

-- 
1.8.3.1