Re: [PATCH -next] crypto: api: Do not access module name directly from module structure
On Fri, Apr 24, 2015 at 08:58:03AM -0700, Guenter Roeck wrote:
> 'struct module' is only fully declared if CONFIG_MODULES is configured.
> If not, the build fails with
>
> crypto/algapi.c: In function 'crypto_check_module_sig':
> crypto/algapi.c:49:12: error: dereferencing pointer to incomplete type
>
> Fixes: 59afdc7b3214 ("crypto: api - Move module sig ifdef into accessor
> function")
> Cc: Herbert Xu
> Cc: Rusty Russell
> Signed-off-by: Guenter Roeck
> ---
> Seen in next-20150424.
Thanks but a similar patch has already been queued.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: CRYPTO_DEV_IMGTEC_HASH should depend on HAS_DMA
On Thu, Apr 23, 2015 at 08:03:58PM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `img_hash_write_via_dma_stop': > img-hash.c:(.text+0xa2b822): undefined reference to `dma_unmap_sg' > drivers/built-in.o: In function `img_hash_xmit_dma': > img-hash.c:(.text+0xa2b8d8): undefined reference to `dma_map_sg' > img-hash.c:(.text+0xa2b948): undefined reference to `dma_unmap_sg' > > Also move the "depends" section below the "tristate" line while we're at > it. > > Signed-off-by: Geert Uytterhoeven Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: x86/sha512_ssse3 - fixup for asm function prototype change
On Fri, Apr 24, 2015 at 08:37:09AM +0200, Ard Biesheuvel wrote:
> Patch e68410ebf626 ("crypto: x86/sha512_ssse3 - move SHA-384/512
> SSSE3 implementation to base layer") changed the prototypes of the
> core asm SHA-512 implementations so that they are compatible with
> the prototype used by the base layer.
>
> However, in one instance, the register that was used for passing the
> input buffer was reused as a scratch register later on in the code,
> and since the input buffer param changed places with the digest param
> -which needs to be written back before the function returns- this
> resulted in the scratch register to be dereferenced in a memory write
> operation, causing a GPF.
>
> Fix this by changing the scratch register to use the same register as
> the input buffer param again.
>
> Fixes: e68410ebf626 ("crypto: x86/sha512_ssse3 - move SHA-384/512 SSSE3
> implementation to base layer")
> Reported-By: Bobby Powers
> Tested-By: Bobby Powers
> Signed-off-by: Ard Biesheuvel
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
