Re: [crypto v8 04/12] chtls: structure and macro definiton

2018-03-04 Thread David Miller 
From: Atul Gupta 
Date: Thu,  1 Mar 2018 11:19:35 +0530

> + __u8   reneg_to_write_rx;
> + __u8   protocol;

You should use "u8" rather than "__u8" except in UAPI headers
which this file is not.

Please audit your entire patch series for this issue.

Thank you.

Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback

2018-03-04 Thread Herbert Xu 
On Sat, Mar 03, 2018 at 12:15:20AM +0100, Maciej S. Szmigiero wrote:
>
> However, what about the first patch from this series?
> Without it, while it no longer should cause a buffer overflow, in-kernel
> X.509 certificate verification will still fail with CCP driver loaded
> (since CCP RSA implementation has a higher priority than the software
> RSA implementation).

That normally goes through the security tree.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt