Re: [PATCH] crypto: doc - clarify hash callbacks state machine
On 3/16/2018 5:16 PM, Herbert Xu wrote: > On Mon, Mar 05, 2018 at 12:39:45PM +0200, Horia Geantă wrote: >> Even though it doesn't make too much sense, it is perfectly legal to: >> - call .init() and then (as many times) .update() >> - subseqently _not_ call any of .final(), .finup() or .export() > > Actually it makes perfect sense, because there can be an arbitrary > number of requests for a given tfm. There is no requirement that > you must finalise the first request before submitting new ones. > > IOW there can be an arbitrary number of outstanding requests even > without the user intentionally abandoning any hash request. > The fact that there can be multiple requests in parallel (for a given tfm) is a different topic. Each request object has its state in its own state machine, independent from the other request objects. I assume this is clear enough. Why I wanted to underline is that "abandoning" a hash request is allowed (even though doing this is at least questionable), thus implementations must take special care not to leak resources in this case. If you think the commit message should be updated, then probably so should the documentation update. Thanks, Horia
RE: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Geert Uytterhoeven > Sent: Friday, March 16, 2018 3:52 PM > To: Christoph Hellwig ; Marek Szyprowski > ; Robin Murphy ; > Felipe Balbi ; Greg Kroah-Hartman > ; James E . J . Bottomley > ; Martin K . Petersen > ; Andrew Morton foundation.org>; Mark Brown ; Liam Girdwood > ; Tejun Heo ; Herbert Xu > ; David S . Miller ; > Bartlomiej Zolnierkiewicz ; Stefan Richter > ; Alan Tull ; Moritz Fischer > ; Wolfram Sang ; Jonathan Cameron > ; Joerg Roedel ; Matias Bjorling > ; Jassi Brar ; Mauro Carvalho > Chehab ; Ulf Hansson ; David > Woodhouse ; Brian Norris > ; Marek Vasut ; > Cyrille Pitchen ; Boris Brezillon > ; Richard Weinberger ; > Kalle Valo ; Ohad Ben-Cohen ; > Bjorn Andersson ; Eric Anholt ; > Stefan Wahren > Cc: io...@lists.linux-foundation.org; linux-...@vger.kernel.org; linux- > s...@vger.kernel.org; alsa-de...@alsa-project.org; linux-...@vger.kernel.org; > linux-crypto@vger.kernel.org; linux-fb...@vger.kernel.org; linux1394- > de...@lists.sourceforge.net; linux-f...@vger.kernel.org; linux- > i...@vger.kernel.org; linux-...@vger.kernel.org; linux-bl...@vger.kernel.org; > linux-me...@vger.kernel.org; linux-...@vger.kernel.org; linux- > m...@lists.infradead.org; net...@vger.kernel.org; linux- > remotep...@vger.kernel.org; linux-ser...@vger.kernel.org; linux- > s...@vger.kernel.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; Geert Uytterhoeven > Subject: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of > platform dependency > > Remove dependencies on HAS_DMA where a Kconfig symbol depends on > another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol, or PCI. > > Generic symbols and drivers without platform dependencies keep their > dependencies on HAS_DMA, to prevent compiling subsystems or drivers that > cannot work anyway. > > This simplifies the dependencies, and allows to improve compile-testing. > > Notes: > - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(), > which does not exist if HAS_DMA=n (Do we need a dummy? The use of > set_dma_ops() in this driver is questionable), Hi, The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it. Thanks > - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their > dependency on HAS_DMA, as they are selected from > SND_SOC_APQ8016_SBC. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Mark Brown > Acked-by: Robin Murphy > --- > v2: > - Add Reviewed-by, Acked-by, > - Drop RFC state, > - Split per subsystem. > --- > drivers/lightnvm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig > index 10c08982185a572f..9c03f35d9df113c6 100644 > --- a/drivers/lightnvm/Kconfig > +++ b/drivers/lightnvm/Kconfig > @@ -4,7 +4,7 @@ > > menuconfig NVM > bool "Open-Channel SSD target support" > - depends on BLOCK && HAS_DMA && PCI > + depends on BLOCK && PCI > select BLK_DEV_NVME > help > Say Y here to get to enable Open-channel SSDs. > -- > 2.7.4
Re: [PATCH v11 crypto 00/12] Chelsio Inline TLS
On 3/18/2018 8:06 PM, David Miller wrote: > From: Atul Gupta > Date: Sun, 18 Mar 2018 14:30:30 + > >> Hi Dave/Herbert, >> >> This series is against crypto tree, should I submit two patch series: >> 1. netdev specific changes against net-next tree? >> 2. crypto changes against crypto tree? > Herbert, is it OK for this entire series to go via net-next? Once Herbert confirms I will create series against net-next. > Thanks!
Re: [PATCH v11 crypto 06/12] crypto: chtls - structure and macro for Inline TLS
On 3/19/2018 4:23 AM, Sabrina Dubroca wrote:
> 2018-03-16, 21:07:35 +0530, Atul Gupta wrote:
> [...]
>> +#define SOCK_INLINE (31)
> [...]
>
>> +static inline int csk_flag(const struct sock *sk, enum csk_flags flag)
>> +{
>> +struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
>> +
>> +if (!sock_flag(sk, SOCK_INLINE))
>> +return 0;
>> +return test_bit(flag, &csk->flags);
>> +}
> Should drivers really start defining their own socket flags?
this is for conn in Inline mode once transitioned to HW, will re-check if can
avoid this. Thanks
>
>
>> +static inline void set_queue(struct sk_buff *skb,
>> + unsigned int queue, const struct sock *sk)
>> +{
>> +skb->queue_mapping = queue;
>> +}
> That's skb_set_queue_mapping(), no need to define your own.
Yes, can avoid re-def. Thank you.
>
Re: [PATCH v11 crypto 06/12] crypto: chtls - structure and macro for Inline TLS
2018-03-16, 21:07:35 +0530, Atul Gupta wrote:
[...]
> +#define SOCK_INLINE (31)
[...]
> +static inline int csk_flag(const struct sock *sk, enum csk_flags flag)
> +{
> + struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
> +
> + if (!sock_flag(sk, SOCK_INLINE))
> + return 0;
> + return test_bit(flag, &csk->flags);
> +}
Should drivers really start defining their own socket flags?
> +static inline void set_queue(struct sk_buff *skb,
> + unsigned int queue, const struct sock *sk)
> +{
> + skb->queue_mapping = queue;
> +}
That's skb_set_queue_mapping(), no need to define your own.
--
Sabrina
Re: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency
On 03/16/2018 02:51 PM, Geert Uytterhoeven wrote: Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI. Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway. This simplifies the dependencies, and allows to improve compile-testing. Notes: - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(), which does not exist if HAS_DMA=n (Do we need a dummy? The use of set_dma_ops() in this driver is questionable), - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their dependency on HAS_DMA, as they are selected from SND_SOC_APQ8016_SBC. Signed-off-by: Geert Uytterhoeven Reviewed-by: Mark Brown Acked-by: Robin Murphy --- v2: - Add Reviewed-by, Acked-by, - Drop RFC state, - Split per subsystem. --- drivers/lightnvm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig index 10c08982185a572f..9c03f35d9df113c6 100644 --- a/drivers/lightnvm/Kconfig +++ b/drivers/lightnvm/Kconfig @@ -4,7 +4,7 @@ menuconfig NVM bool "Open-Channel SSD target support" - depends on BLOCK && HAS_DMA && PCI + depends on BLOCK && PCI select BLK_DEV_NVME help Say Y here to get to enable Open-channel SSDs. Looks good. Reviewed-by: Matias Bjørling
Re: [PATCH v12 1/9] iomap: Fix sparse endian check warnings
On Fri, Mar 16, 2018 at 09:48:44AM -0600, Logan Gunthorpe wrote: > Warnings of the form: > > lib/iomap.c:84:9: warning: cast to restricted __be16 > > Are found when running sparse checker with: > > make C=2 CF=-D__CHECK_ENDIAN__ > > This patch casts them with __force to suppress the warnings. Hi, it looks correct but if you should explain why the warning is not a valid one. Once done, you can then explain what problem you have fixed instead of saying you suppressed a warning. > Also, it looks like the wrong conversion function was used in I would suggest to split the patch in two since it does two different things which should have their own explanation. > diff --git a/lib/iomap.c b/lib/iomap.c > index 541d926da95e..a05d9fa21794 100644 > --- a/lib/iomap.c > +++ b/lib/iomap.c > @@ -106,8 +106,10 @@ EXPORT_SYMBOL(ioread32be); > #endif > > #ifndef mmio_write16be > -#define mmio_write16be(val,port) __raw_writew(be16_to_cpu(val),port) > -#define mmio_write32be(val,port) __raw_writel(be32_to_cpu(val),port) > +#define mmio_write16be(val, port) \ > + __raw_writew((u16 __force)cpu_to_be16(val), port) > +#define mmio_write32be(val, port) \ > + __raw_writel((u32 __force)cpu_to_be32(val), port) > #endif I think that in this sort of replacement, it's better to not split the lines (even if larger than 80, that's it). -- Luc Van Oostenryck
Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record (fwd)
ctx is dereferenced on line 258 but has been freed on line 229.
julia
-- Forwarded message --
Date: Sun, 18 Mar 2018 18:05:25 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v11 crypto 01/12] tls: support for Inline tls record
CC: kbuild-...@01.org
In-Reply-To: <1521214661-28928-1-git-send-email-atul.gu...@chelsio.com>
References: <1521214661-28928-1-git-send-email-atul.gu...@chelsio.com>
TO: Atul Gupta
CC: davejwat...@fb.com, da...@davemloft.net, herb...@gondor.apana.org.au,
s...@queasysnail.net, sbri...@redhat.com, linux-crypto@vger.kernel.org,
net...@vger.kernel.org, ganes...@chelsio.com
CC: s...@queasysnail.net, sbri...@redhat.com, linux-crypto@vger.kernel.org,
net...@vger.kernel.org, ganes...@chelsio.com
Hi Atul,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v4.16-rc4]
[cannot apply to next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Atul-Gupta/tls-support-for-Inline-tls-record/20180318-162840
:: branch date: 2 hours ago
:: commit date: 2 hours ago
>> net/tls/tls_main.c:258:5-8: ERROR: reference preceded by free on line 229
#
https://github.com/0day-ci/linux/commit/be47378786b9d9874dfc3ab57504565275c7b3ff
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout be47378786b9d9874dfc3ab57504565275c7b3ff
vim +258 net/tls/tls_main.c
3c4d75591 Dave Watson 2017-06-14 218
3c4d75591 Dave Watson 2017-06-14 219 static void tls_sk_proto_close(struct
sock *sk, long timeout)
3c4d75591 Dave Watson 2017-06-14 220 {
3c4d75591 Dave Watson 2017-06-14 221 struct tls_context *ctx =
tls_get_ctx(sk);
3c4d75591 Dave Watson 2017-06-14 222 long timeo = sock_sndtimeo(sk,
0);
3c4d75591 Dave Watson 2017-06-14 223 void (*sk_proto_close)(struct
sock *sk, long timeout);
3c4d75591 Dave Watson 2017-06-14 224
3c4d75591 Dave Watson 2017-06-14 225 lock_sock(sk);
ff45d820a Ilya Lesokhin 2017-11-13 226 sk_proto_close =
ctx->sk_proto_close;
ff45d820a Ilya Lesokhin 2017-11-13 227
ff45d820a Ilya Lesokhin 2017-11-13 228 if (ctx->tx_conf ==
TLS_BASE_TX) {
ff45d820a Ilya Lesokhin 2017-11-13 @229 kfree(ctx);
ff45d820a Ilya Lesokhin 2017-11-13 230 goto skip_tx_cleanup;
ff45d820a Ilya Lesokhin 2017-11-13 231 }
3c4d75591 Dave Watson 2017-06-14 232
3c4d75591 Dave Watson 2017-06-14 233 if
(!tls_complete_pending_work(sk, ctx, 0, &timeo))
3c4d75591 Dave Watson 2017-06-14 234
tls_handle_open_record(sk, 0);
3c4d75591 Dave Watson 2017-06-14 235
3c4d75591 Dave Watson 2017-06-14 236 if (ctx->partially_sent_record)
{
3c4d75591 Dave Watson 2017-06-14 237 struct scatterlist *sg
= ctx->partially_sent_record;
3c4d75591 Dave Watson 2017-06-14 238
3c4d75591 Dave Watson 2017-06-14 239 while (1) {
3c4d75591 Dave Watson 2017-06-14 240
put_page(sg_page(sg));
3c4d75591 Dave Watson 2017-06-14 241
sk_mem_uncharge(sk, sg->length);
3c4d75591 Dave Watson 2017-06-14 242
3c4d75591 Dave Watson 2017-06-14 243 if
(sg_is_last(sg))
3c4d75591 Dave Watson 2017-06-14 244 break;
3c4d75591 Dave Watson 2017-06-14 245 sg++;
3c4d75591 Dave Watson 2017-06-14 246 }
3c4d75591 Dave Watson 2017-06-14 247 }
ff45d820a Ilya Lesokhin 2017-11-13 248
3c4d75591 Dave Watson 2017-06-14 249 kfree(ctx->rec_seq);
3c4d75591 Dave Watson 2017-06-14 250 kfree(ctx->iv);
3c4d75591 Dave Watson 2017-06-14 251
ff45d820a Ilya Lesokhin 2017-11-13 252 if (ctx->tx_conf == TLS_SW_TX)
ff45d820a Ilya Lesokhin 2017-11-13 253
tls_sw_free_tx_resources(sk);
3c4d75591 Dave Watson 2017-06-14 254
ff45d820a Ilya Lesokhin 2017-11-13 255 skip_tx_cleanup:
3c4d75591 Dave Watson 2017-06-14 256 release_sock(sk);
3c4d75591 Dave Watson 2017-06-14 257 sk_proto_close(sk, timeout);
be4737878 Atul Gupta2018-03-16 @258 if (ctx->tx_conf ==
TLS_HW_RECORD)
be4737878 Atul Gupta2018-03-16 259 kfree(ctx);
3c4d75591 Dave Watson 2017-06-14 260 }
3c4d75591 Dave Watson 2017-06-14 261
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig (fwd)
Please check the indentation on line 1655.
thanks,
julia
-- Forwarded message --
Date: Sun, 18 Mar 2018 18:15:36 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig
CC: kbuild-...@01.org
In-Reply-To: <1521214661-28928-12-git-send-email-atul.gu...@chelsio.com>
References: <1521214661-28928-12-git-send-email-atul.gu...@chelsio.com>
TO: Atul Gupta
CC: davejwat...@fb.com, da...@davemloft.net, herb...@gondor.apana.org.au
CC: s...@queasysnail.net, sbri...@redhat.com, linux-crypto@vger.kernel.org,
net...@vger.kernel.org, ganes...@chelsio.com
Hi Atul,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4]
[cannot apply to next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Atul-Gupta/tls-support-for-Inline-tls-record/20180318-162840
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:: branch date: 2 hours ago
:: commit date: 2 hours ago
All error/warnings (new ones prefixed by >>):
drivers/crypto/chelsio/chtls/chtls_io.c: In function 'chtls_expansion_size':
>> drivers/crypto/chelsio/chtls/chtls_io.c:457:2: error: expected ',' or ';'
>> before 'int'
int expnsize, frcn, fraglast, fragsize;
^~~
>> drivers/crypto/chelsio/chtls/chtls_io.c:461:3: error: 'fragsize' undeclared
>> (first use in this function); did you mean 'ivs_size'?
fragsize = hws->mfs;
^~~~
ivs_size
drivers/crypto/chelsio/chtls/chtls_io.c:461:3: note: each undeclared
identifier is reported only once for each function it appears in
>> drivers/crypto/chelsio/chtls/chtls_io.c:465:4: error: 'frcnt' undeclared
>> (first use in this function); did you mean 'pducnt'?
frcnt = (data_len / fragsize);
^
pducnt
>> drivers/crypto/chelsio/chtls/chtls_io.c:468:4: error: 'expnsize' undeclared
>> (first use in this function); did you mean 'fragsize'?
expnsize = frcnt * expppdu;
^~~~
fragsize
>> drivers/crypto/chelsio/chtls/chtls_io.c:480:4: error: 'fraglast' undeclared
>> (first use in this function); did you mean 'rb_last'?
fraglast = data_len % fragsize;
^~~~
rb_last
drivers/crypto/chelsio/chtls/chtls_io.c: In function 'peekmsg':
>> drivers/crypto/chelsio/chtls/chtls_io.c:1653:5: warning: this 'if' clause
>> does not guard... [-Wmisleading-indentation]
if (!copied)
^~
drivers/crypto/chelsio/chtls/chtls_io.c:1655:6: note: ...this statement, but
the latter is misleadingly indented as if it were guarded by the 'if'
break;
^
drivers/crypto/chelsio/chtls/chtls_io.c: In function 'chtls_expansion_size':
>> drivers/crypto/chelsio/chtls/chtls_io.c:492:1: warning: control reaches end
>> of non-void function [-Wreturn-type]
}
^
coccinelle warnings: (new ones prefixed by >>)
>> drivers/crypto/chelsio/chtls/chtls_io.c:1654:5-22: code aligned with
>> following code on line 1655
#
https://github.com/0day-ci/linux/commit/635907fe348f84b525d7ce16ae8f2a9b82c631e3
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 635907fe348f84b525d7ce16ae8f2a9b82c631e3
vim +1654 drivers/crypto/chelsio/chtls/chtls_io.c
8ae18d74 Atul Gupta 2018-03-16 1542
8ae18d74 Atul Gupta 2018-03-16 1543 /*
8ae18d74 Atul Gupta 2018-03-16 1544 * Peek at data in a socket's receive
buffer.
8ae18d74 Atul Gupta 2018-03-16 1545 */
8ae18d74 Atul Gupta 2018-03-16 1546 static int peekmsg(struct sock *sk,
struct msghdr *msg,
8ae18d74 Atul Gupta 2018-03-16 1547 size_t len, int nonblock,
int flags)
8ae18d74 Atul Gupta 2018-03-16 1548 {
8ae18d74 Atul Gupta 2018-03-16 1549struct tcp_sock *tp = tcp_sk(sk);
8ae18d74 Atul Gupta 2018-03-16 1550struct sk_buff *skb;
8ae18d74 Atul Gupta 2018-03-16 1551u32 peek_seq, offset;
8ae18d74 Atul Gupta 2018-03-16 1552int copied = 0;
8ae18d74 Atul Gupta 2018-03-16 1553size_t avail; /* amount of
available data in current skb */
8ae18d74 Atul Gupta 2018-03-16 1554long timeo;
8ae18d74 Atul Gupta 2018-03-16 1555
8ae18d74 Atul Gupta 2018-03-16 1556lock_sock(sk);
8ae18d74 Atul Gupta 2018-03-16 1557timeo = sock_rcvtimeo(sk, nonblock);
8ae18d74 Atul Gupta 2018-03-16 1558peek_seq = tp->copied_seq;
8ae18d74 Atul Gupta 2018-03-16 1559
8ae18d74 Atul Gupta 2018-03-16 1560do {
8ae18d74 Atul Gupta 2018-03-16 1561
[PATCH] crypto: cavium: cpt: Replace mdelay with msleep in cpt_device_init
cpt_device_init() is never called in atomic context. The call chain ending up at cpt_device_init() is: [1] cpt_device_init() <- cpt_probe() cpt_probe() is only set as ".probe" in pci_driver structure "cpt_pci_driver". Despite never getting called from atomic context, cpt_device_init() calls mdelay(100), i.e. busy wait for 100ms. That is not necessary and can be replaced with msleep to avoid busy waiting. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/crypto/cavium/cpt/cptpf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cavium/cpt/cptpf_main.c b/drivers/crypto/cavium/cpt/cptpf_main.c index 34a6d8b..06ad85a 100644 --- a/drivers/crypto/cavium/cpt/cptpf_main.c +++ b/drivers/crypto/cavium/cpt/cptpf_main.c @@ -436,7 +436,7 @@ static int cpt_device_init(struct cpt_device *cpt) /* Reset the PF when probed first */ cpt_reset(cpt); - mdelay(100); + msleep(100); /*Check BIST status*/ bist = (u64)cpt_check_bist_status(cpt); -- 1.9.1
Re: [PATCH v11 crypto 00/12] Chelsio Inline TLS
From: Atul Gupta Date: Sun, 18 Mar 2018 14:30:30 + > Hi Dave/Herbert, > > This series is against crypto tree, should I submit two patch series: > 1. netdev specific changes against net-next tree? > 2. crypto changes against crypto tree? Herbert, is it OK for this entire series to go via net-next? Thanks!
RE: [PATCH v11 crypto 00/12] Chelsio Inline TLS
Hi Dave/Herbert, This series is against crypto tree, should I submit two patch series: 1. netdev specific changes against net-next tree? 2. crypto changes against crypto tree? Regards Atul -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, March 18, 2018 5:33 AM To: Atul Gupta Cc: davejwat...@fb.com; herb...@gondor.apana.org.au; s...@queasysnail.net; sbri...@redhat.com; linux-crypto@vger.kernel.org; net...@vger.kernel.org; Ganesh GR Subject: Re: [PATCH v11 crypto 00/12] Chelsio Inline TLS From: Atul Gupta Date: Fri, 16 Mar 2018 21:06:22 +0530 > Series for Chelsio Inline TLS driver (chtls) This series doesn't even come close to applying to the net-next tree, please respin. Thank you.
