Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-27 Thread Imre Kaloz
On Mon, 25 May 2015 13:17:13 +0200, Boris Brezillon  
 wrote:


Sorry, I didn't word it right - the series is missing the crypto nodes  
for

the orion, 375 and 38x platforms.


I only add nodes for platforms I have tested on.
If you're able to test on those platforms I'd be happy to include those
changes in the upcoming version.


I would test on 38x but I don't have access to the cpu datasheets to fill  
in the missing pieces.. Thomas, Gregory, could one of you add those?



Imre
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 14/16] ARM: marvell/dt: enable crypto on armada-xp-gp

2015-05-26 Thread Imre Kaloz
On Tue, 26 May 2015 10:59:36 +0200, Boris Brezillon  
 wrote:




As the crypto engine really depend on the SoC itself and not of the  
board,

what about updating the dts of the other board using an Armada XP?


But that means introducing changes I haven't tested. Are you okay with
that ?


Well, worst case send it as a separate patch as RFC - I'm sure people will  
test and report back.



Cheers,

Imre
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Imre Kaloz

Hi Boris,

On Mon, 25 May 2015 13:08:12 +0200, Boris Brezillon  
 wrote:



> Yep, I noticed that after submitting this version. I guess I only
> needed the import function for my test cases and thus forgot to
> implement the import function.
> Anyway, I just added the the import functions (they'll be available in
> my v4).

Given the driver is supposed to work on platforms up to 38x, could v4
include the missing bindings for those platforms, too?


Sure, what's missing ?
I already added the cesazX clocks and the "marvell,armada-38x-crypto"
compatible string ?



Sorry, I didn't word it right - the series is missing the crypto nodes for  
the orion, 375 and 38x platforms.


Imre
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Imre Kaloz

Hi Boris,

On Mon, 25 May 2015 10:10:16 +0200, Boris Brezillon  
 wrote:





Yep, I noticed that after submitting this version. I guess I only
needed the import function for my test cases and thus forgot to
implement the import function.
Anyway, I just added the the import functions (they'll be available in
my v4).


Given the driver is supposed to work on platforms up to 38x, could v4  
include the missing bindings for those platforms, too?



Thanks,

Imre
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] The IXP4xx crypto driver should select CRYPTO_AUTHENC

2008-07-11 Thread Imre Kaloz
Without CRYPTO_AUTHENC the driver fails to build:
drivers/built-in.o: In function `ixp_module_init':
ixp4xx_crypto.c:(.init.text+0x3250): undefined reference to `crypto_aead_type'

Signed-off-by: Imre Kaloz <[EMAIL PROTECTED]>
---
 drivers/crypto/Kconfig |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index eb2ec2e..e522144 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -195,6 +195,7 @@ config CRYPTO_DEV_IXP4XX
depends on ARCH_IXP4XX
select CRYPTO_DES
select CRYPTO_ALGAPI
+   select CRYPTO_AUTHENC
select CRYPTO_BLKCIPHER
help
  Driver for the IXP4xx NPE crypto engine.
-- 
1.5.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html