Re: [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres

[Herbert Xu]

On Wed, May 27, 2015 at 01:50:12PM +0200, Stephan Mueller wrote:
> The patch removes the use of timekeeping_valid_for_hres which is now
> marked as internal for the time keeping subsystem. The jitterentropy
> does not really require this verification as a coarse timer (when
> random_get_entropy is absent) is discovered by the initialization test
> of jent_entropy_init, which would cause the jitter rng to not load in
> that case.
> 
> Reported-by: kbuild test robot 
> Signed-off-by: Stephan Mueller 

Applied.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres

[Stephan Mueller]

The patch removes the use of timekeeping_valid_for_hres which is now
marked as internal for the time keeping subsystem. The jitterentropy
does not really require this verification as a coarse timer (when
random_get_entropy is absent) is discovered by the initialization test
of jent_entropy_init, which would cause the jitter rng to not load in
that case.

Reported-by: kbuild test robot 
Signed-off-by: Stephan Mueller 
---
 crypto/jitterentropy.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/crypto/jitterentropy.c b/crypto/jitterentropy.c
index 1ebe58a..a60147e 100644
--- a/crypto/jitterentropy.c
+++ b/crypto/jitterentropy.c
@@ -131,9 +131,6 @@ static inline void jent_get_nstime(__u64 *out)
 * and are registered with clocksource_register()
 */
if ((0 == tmp) &&
-#ifndef MODULE
-  (0 == timekeeping_valid_for_hres()) &&
-#endif
   (0 == __getnstimeofday(&ts))) {
tmp = ts.tv_sec;
tmp = tmp << 32;
-- 
2.1.0


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html