Re: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe()

[Herbert Xu]

On Wed, Jan 10, 2018 at 01:30:59PM +, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe()

[Łukasz Stelmach]

It was <2018-01-10 śro 14:30>, when Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun 

Acked-by: Łukasz Stelmach 

> ---
>  drivers/char/hw_random/exynos-trng.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/exynos-trng.c 
> b/drivers/char/hw_random/exynos-trng.c
> index 34d6f51..4c8a2be 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -129,10 +129,8 @@ static int exynos_trng_probe(struct platform_device 
> *pdev)
>  
>   res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   trng->mem = devm_ioremap_resource(>dev, res);
> - if (IS_ERR(trng->mem)) {
> - dev_err(>dev, "Could not map IO resources.\n");
> + if (IS_ERR(trng->mem))
>   return PTR_ERR(trng->mem);
> - }
>  
>   pm_runtime_enable(>dev);
>   ret = pm_runtime_get_sync(>dev);
>
>
>
>

-- 
Łukasz Stelmach
Samsung R Institute Poland
Samsung Electronics


signature.asc
Description: PGP signature

Re: [PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe()

[Krzysztof Kozlowski]

On Wed, Jan 10, 2018 at 2:30 PM, Wei Yongjun  wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/char/hw_random/exynos-trng.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

[PATCH -next] hwrng: exynos - remove redundant dev_err call in exynos_trng_probe()

[Wei Yongjun]

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun 
---
 drivers/char/hw_random/exynos-trng.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/char/hw_random/exynos-trng.c 
b/drivers/char/hw_random/exynos-trng.c
index 34d6f51..4c8a2be 100644
--- a/drivers/char/hw_random/exynos-trng.c
+++ b/drivers/char/hw_random/exynos-trng.c
@@ -129,10 +129,8 @@ static int exynos_trng_probe(struct platform_device *pdev)
 
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
trng->mem = devm_ioremap_resource(>dev, res);
-   if (IS_ERR(trng->mem)) {
-   dev_err(>dev, "Could not map IO resources.\n");
+   if (IS_ERR(trng->mem))
return PTR_ERR(trng->mem);
-   }
 
pm_runtime_enable(>dev);
ret = pm_runtime_get_sync(>dev);