Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
On Wed, Dec 28, 2016 at 09:11:03AM +, Ard Biesheuvel wrote: > > > On 28 Dec 2016, at 09:03, Herbert Xu wrote: > > > >> On Tue, Dec 27, 2016 at 02:26:35PM +, Ard Biesheuvel wrote: > >> > >> You just nacked the v2 of this series (due to the chunksize/walksize) and > >> i rewrote them as skciphers as well > > > > Sorry. Would you like me to revert or just send a new series > > on top of this? > > > > No worries. If you can, please drop them entirely, or revert them otherwise. > I will resend after the holidays OK I will revert. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
> On 28 Dec 2016, at 09:03, Herbert Xu wrote: > >> On Tue, Dec 27, 2016 at 02:26:35PM +, Ard Biesheuvel wrote: >> >> You just nacked the v2 of this series (due to the chunksize/walksize) and i >> rewrote them as skciphers as well > > Sorry. Would you like me to revert or just send a new series > on top of this? > No worries. If you can, please drop them entirely, or revert them otherwise. I will resend after the holidays > Thanks, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
On Tue, Dec 27, 2016 at 02:26:35PM +, Ard Biesheuvel wrote: > > You just nacked the v2 of this series (due to the chunksize/walksize) and i > rewrote them as skciphers as well Sorry. Would you like me to revert or just send a new series on top of this? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
On 27 December 2016 at 15:36, Jeffrey Walton wrote: >> ChaCha20 is a stream cipher described in RFC 7539, and is intended to be >> an efficient software implementable 'standby cipher', in case AES cannot >> be used. > > That's not quite correct. > > The IETF changed the algorithm a bit, and its not compatible with > Bernstein's ChaCha. They probably should have differentiated the name > to avoid this sort of confusion. > > You can find Bernstein's specification for ChaCha at > https://cr.yp.to/chacha.html, and the test vectors for Bernstein's > specification at > http://tools.ietf.org/html/draft-strombergson-chacha-test-vectors. > Thanks for the clarification. However, this should not affect the content of the patches: they simply reimplement in ARM SIMD what the kernel already knows as "chacha20", which is the IETF derivative rather than djb's original. I will mention this in the cover letter of the next respin (given that I need to respin these anyway) -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
> ChaCha20 is a stream cipher described in RFC 7539, and is intended to be > an efficient software implementable 'standby cipher', in case AES cannot > be used. That's not quite correct. The IETF changed the algorithm a bit, and its not compatible with Bernstein's ChaCha. They probably should have differentiated the name to avoid this sort of confusion. You can find Bernstein's specification for ChaCha at https://cr.yp.to/chacha.html, and the test vectors for Bernstein's specification at http://tools.ietf.org/html/draft-strombergson-chacha-test-vectors. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
> On 27 Dec 2016, at 10:04, Herbert Xu wrote: > >> On Thu, Dec 08, 2016 at 02:28:57PM +, Ard Biesheuvel wrote: >> Another port of existing x86 SSE code to NEON, again both for arm64 and ARM. >> >> ChaCha20 is a stream cipher described in RFC 7539, and is intended to be >> an efficient software implementable 'standby cipher', in case AES cannot >> be used. >> >> This NEON implementation is almost 2x as fast as the generic C code >> (measured on Cortex-A57 using the arm64 version) >> >> I'm aware that blkciphers are deprecated in favor of skciphers, but this >> code (like the x86 version) uses the init and setkey routines of the generic >> version, so it is probably better to port all implementations at once. >> >> Ard Biesheuvel (2): >> crypto: arm64/chacha20 - implement NEON version based on SSE3 code >> crypto: arm/chacha20 - implement NEON version based on SSE3 code > > Both patches applied. Thanks. You just nacked the v2 of this series (due to the chunksize/walksize) and i rewrote them as skciphers as well > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
On Thu, Dec 08, 2016 at 02:28:57PM +, Ard Biesheuvel wrote: > Another port of existing x86 SSE code to NEON, again both for arm64 and ARM. > > ChaCha20 is a stream cipher described in RFC 7539, and is intended to be > an efficient software implementable 'standby cipher', in case AES cannot > be used. > > This NEON implementation is almost 2x as fast as the generic C code > (measured on Cortex-A57 using the arm64 version) > > I'm aware that blkciphers are deprecated in favor of skciphers, but this > code (like the x86 version) uses the init and setkey routines of the generic > version, so it is probably better to port all implementations at once. > > Ard Biesheuvel (2): > crypto: arm64/chacha20 - implement NEON version based on SSE3 code > crypto: arm/chacha20 - implement NEON version based on SSE3 code Both patches applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] crypto: arm64/ARM: NEON accelerated ChaCha20
Another port of existing x86 SSE code to NEON, again both for arm64 and ARM. ChaCha20 is a stream cipher described in RFC 7539, and is intended to be an efficient software implementable 'standby cipher', in case AES cannot be used. This NEON implementation is almost 2x as fast as the generic C code (measured on Cortex-A57 using the arm64 version) I'm aware that blkciphers are deprecated in favor of skciphers, but this code (like the x86 version) uses the init and setkey routines of the generic version, so it is probably better to port all implementations at once. Ard Biesheuvel (2): crypto: arm64/chacha20 - implement NEON version based on SSE3 code crypto: arm/chacha20 - implement NEON version based on SSE3 code arch/arm/crypto/Kconfig| 6 + arch/arm/crypto/Makefile | 2 + arch/arm/crypto/chacha20-neon-core.S | 524 arch/arm/crypto/chacha20-neon-glue.c | 136 + arch/arm64/crypto/Kconfig | 6 + arch/arm64/crypto/Makefile | 3 + arch/arm64/crypto/chacha20-neon-core.S | 480 ++ arch/arm64/crypto/chacha20-neon-glue.c | 131 + 8 files changed, 1288 insertions(+) create mode 100644 arch/arm/crypto/chacha20-neon-core.S create mode 100644 arch/arm/crypto/chacha20-neon-glue.c create mode 100644 arch/arm64/crypto/chacha20-neon-core.S create mode 100644 arch/arm64/crypto/chacha20-neon-glue.c -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
