[PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

[Andy Shevchenko]

Instead of custom approach let's use recently introduced seq_hex_dump() helper.

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
 drivers/parisc/ccio-dma.c  | 14 +++---
 drivers/parisc/sba_iommu.c | 11 +++
 2 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
index 8b490d7..9d353d2 100644
--- a/drivers/parisc/ccio-dma.c
+++ b/drivers/parisc/ccio-dma.c
@@ -1101,20 +1101,12 @@ static const struct file_operations ccio_proc_info_fops 
= {
 
 static int ccio_proc_bitmap_info(struct seq_file *m, void *p)
 {
-   int len = 0;
struct ioc *ioc = ioc_list;
 
while (ioc != NULL) {
-   u32 *res_ptr = (u32 *)ioc-res_map;
-   int j;
-
-   for (j = 0; j  (ioc-res_size / sizeof(u32)); j++) {
-   if ((j  7) == 0)
-   len += seq_puts(m, \n   );
-   len += seq_printf(m, %08x, *res_ptr);
-   res_ptr++;
-   }
-   len += seq_puts(m, \n\n);
+   seq_hex_dump(m,, DUMP_PREFIX_NONE, 32, 4, ioc-res_map,
+ioc-res_size, false);
+   seq_putc(m, '\n');
ioc = ioc-next;
break; /* XXX - remove me */
}
diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
index 1ff1b67..fbc4db9 100644
--- a/drivers/parisc/sba_iommu.c
+++ b/drivers/parisc/sba_iommu.c
@@ -1857,15 +1857,10 @@ sba_proc_bitmap_info(struct seq_file *m, void *p)
 {
struct sba_device *sba_dev = sba_list;
struct ioc *ioc = sba_dev-ioc[0]; /* FIXME: Multi-IOC support! */
-   unsigned int *res_ptr = (unsigned int *)ioc-res_map;
-   int i, len = 0;
 
-   for (i = 0; i  (ioc-res_size/sizeof(unsigned int)); ++i, ++res_ptr) {
-   if ((i  7) == 0)
-   len += seq_printf(m, \n   );
-   len += seq_printf(m,  %08x, *res_ptr);
-   }
-   len += seq_printf(m, \n);
+   seq_hex_dump(m,, DUMP_PREFIX_NONE, 32, 4, ioc-res_map,
+ioc-res_size, false);
+   seq_printf(m, \n);
 
return 0;
 }
-- 
2.0.1

--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

[Joe Perches]

On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote:
 Instead of custom approach let's use recently introduced seq_hex_dump() 
 helper.

Doesn't this also change the output from
   
to
          


--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

[Andy Shevchenko]

In one case indeed it does, in another - no, though it seems it prints
same data (by meaning) in both cases. I would like driver maintainer
to say a word what they think about it.

On Wed, Jul 9, 2014 at 9:26 PM, Joe Perches j...@perches.com wrote:
 On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote:
 Instead of custom approach let's use recently introduced seq_hex_dump() 
 helper.

 Doesn't this also change the output from

 to
       


 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html