Re: [PATCH v11 0/2] crypto: AF_ALG memory management fix

2017-07-28 Thread Herbert Xu 
On Fri, Jul 28, 2017 at 03:53:55PM +0200, Stephan Müller wrote:
>
> I would add the common service code to crypto/af_alg.c or do you prefer a 
> separate or different file?

af_alg.c is OK.

> As the copy-AAD patch is also outstanding, in which order would you like to 
> receive the patches (first the code consolidation patches or first the copy-
> AAD patch)?

Either way is fine by me.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v11 0/2] crypto: AF_ALG memory management fix

2017-07-28 Thread Stephan Müller 
Am Freitag, 28. Juli 2017, 15:49:36 CEST schrieb Herbert Xu:

Hi Herbert,

> All patches applied.  Yes please post follow-up patches to clean
> up as necessary.

Thank you. I will do that asap.

I would add the common service code to crypto/af_alg.c or do you prefer a 
separate or different file?

As the copy-AAD patch is also outstanding, in which order would you like to 
receive the patches (first the code consolidation patches or first the copy-
AAD patch)?

Ciao
Stephan

Re: [PATCH v11 0/2] crypto: AF_ALG memory management fix

2017-07-28 Thread Herbert Xu 
On Sun, Jun 25, 2017 at 05:12:13PM +0200, Stephan Müller wrote:
> Hi Herbert,
> 
> Changes v11:
> - algif_skcipher: remove len < ctx->used in recvmsg as requested by Herbert
>   and verified by the latest test code in libkcapi.
> - algif_skcipher/algif_aead: simplify _recvmsg error code path
> 
> With the changes, you will see a lot of code duplication now
> as I deliberately tried to use the same struct and variable names,
> the same function names and even the same oder of functions.
> If you agree to this patch, I volunteer to provide a followup
> patch that will extract the code duplication into common
> functions.

All patches applied.  Yes please post follow-up patches to clean
up as necessary.

Thanks!
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt