On Fri, Sep 01, 2006 at 10:55:14AM +0200, [EMAIL PROTECTED] wrote:
Can you give some examples about what I missed from CodingStyle?
(I just reread it and I think my patch adheres pretty well to those
rules: tabs=8, KR bracing, don't pollute global namespace etc...)
It's only a few spots:
* Space before * for pointers, e.g., (u64 *) instead of (u64*).
* There is one line near the end b128ops.h that starts with spaces.
* Some lines terminate with spaces.
The last two issues can be caught if you test your patch with
git apply --check --whitespace=error-all diff
Yes, I just didn't know what tcrypt.[ch] was for, otherwise I would have put
those vectors there in the first place. The last testvector, however,
won't fit because it is an entire 512 byte sector. (which is not that
bad, because alle narrow blocks (16 bytes) are encrypted independently,
no realistic testvector of a wide block cipher mode would fit. (ABL uses
blocks of any size, say 512 bytes, and if 1 bit changes in the plaintext
block, the whole cypher block will be affected) I will propose something
to fix that if ABL is finished.
Feel free to extend the tcrypt cipher test buffer to 512 bytes.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
