Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file
Hello, On Fri, May 19, 2017 at 03:33:14PM -0400, Waiman Long wrote: > On 05/19/2017 03:21 PM, Tejun Heo wrote: > > Yeah but it also shows up as an integral part of stable interface > > rather than e.g. /sys/kernel/debug. This isn't of any interest to > > people who aren't developing cgroup core code. There is no reason to > > risk growing dependencies on it. > > The debug controller is used to show information relevant to the cgroup > its css'es are attached to. So it will be very hard to use if we > relocate to /sys/kernel/debug, for example. Currently, nothing in the > debug controller other than debug_cgrp_subsys are exported. I don't see > any risk of having dependency on that controller from other parts of the > kernel. Oh, sure, I wasn't suggesting moving it under /sys/kernel/debug but that we'd want to take extra precautions as we can't. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file
On 05/19/2017 03:21 PM, Tejun Heo wrote: > Hello, Waiman. > > On Thu, May 18, 2017 at 11:52:18AM -0400, Waiman Long wrote: >> The controller name is "debug" and so it is obvious what this controller >> is for. However, the config prompt "Example controller" is indeed vague > Yeah but it also shows up as an integral part of stable interface > rather than e.g. /sys/kernel/debug. This isn't of any interest to > people who aren't developing cgroup core code. There is no reason to > risk growing dependencies on it. The debug controller is used to show information relevant to the cgroup its css'es are attached to. So it will be very hard to use if we relocate to /sys/kernel/debug, for example. Currently, nothing in the debug controller other than debug_cgrp_subsys are exported. I don't see any risk of having dependency on that controller from other parts of the kernel. >> in meaning. So we can make the prompt more descriptive here. As for the >> boot param, are you saying something like "cgroup_debug" has to be >> specified in the command line even if CGROUP_DEBUG config is there for >> the debug controller to be enabled? I am fine with that if you think it >> is necessary. > Yeah, I think that'd be a good idea. cgroup_debug should do. While > at it, can you also please make CGROUP_DEBUG depend on DEBUG_KERNEL? > > Thanks. > Sure. I will do that. Cheers, Longman -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file
Hello, Waiman. On Thu, May 18, 2017 at 11:52:18AM -0400, Waiman Long wrote: > The controller name is "debug" and so it is obvious what this controller > is for. However, the config prompt "Example controller" is indeed vague Yeah but it also shows up as an integral part of stable interface rather than e.g. /sys/kernel/debug. This isn't of any interest to people who aren't developing cgroup core code. There is no reason to risk growing dependencies on it. > in meaning. So we can make the prompt more descriptive here. As for the > boot param, are you saying something like "cgroup_debug" has to be > specified in the command line even if CGROUP_DEBUG config is there for > the debug controller to be enabled? I am fine with that if you think it > is necessary. Yeah, I think that'd be a good idea. cgroup_debug should do. While at it, can you also please make CGROUP_DEBUG depend on DEBUG_KERNEL? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
