Re: [patch 1/9 v3] efi: remove unused variables in __map_region

[Borislav Petkov]

On Thu, Nov 21, 2013 at 02:17:05PM +0800, dyo...@redhat.com wrote:
 variables size and end is useless in this function, thus remove them.
 
 Reported-by: Toshi Kani toshi.k...@hp.com
 Signed-off-by: Dave Young dyo...@redhat.com

Good catch.

Acked-by: Borislav Petkov b...@suse.de

-- 
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line unsubscribe linux-efi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 1/9 v3] efi: remove unused variables in __map_region

[dyoung]

variables size and end is useless in this function, thus remove them.

Reported-by: Toshi Kani toshi.k...@hp.com
Signed-off-by: Dave Young dyo...@redhat.com
---
 arch/x86/platform/efi/efi_64.c |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

--- efi.orig/arch/x86/platform/efi/efi_64.c
+++ efi/arch/x86/platform/efi/efi_64.c
@@ -148,15 +148,11 @@ void efi_setup_page_tables(void)
 static void __init __map_region(efi_memory_desc_t *md, u64 va)
 {
pgd_t *pgd = (pgd_t *)__va(real_mode_header-trampoline_pgd);
-   unsigned long pf = 0, size;
-   u64 end;
+   unsigned long pf = 0;
 
if (!(md-attribute  EFI_MEMORY_WB))
pf |= _PAGE_PCD;
 
-   size = md-num_pages  PAGE_SHIFT;
-   end  = va + size;
-
if (kernel_map_pages_in_pgd(pgd, md-phys_addr, va, md-num_pages, pf))
pr_warn(Error mapping PA 0x%llx - VA 0x%llx!\n,
   md-phys_addr, va);

--
To unsubscribe from this list: send the line unsubscribe linux-efi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html