Re: [PATCH] erofs: use wrapper i_blocksize() in erofs_file_read_iter()

2023-03-09 Thread Chao Yu

On 2023/3/6 15:55, Yue Hu wrote:

From: Yue Hu 

linux/fs.h has a wrapper for this operation.

Signed-off-by: Yue Hu 


Reviewed-by: Chao Yu 

Thanks,


Re: [PATCH] erofs: use wrapper i_blocksize() in erofs_file_read_iter()

2023-03-06 Thread Gao Xiang




On 2023/3/6 15:55, Yue Hu wrote:

From: Yue Hu 

linux/fs.h has a wrapper for this operation.

Signed-off-by: Yue Hu 


Reviewed-by: Gao Xiang 

Thanks,
Gao Xiang


---
  fs/erofs/data.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 5bd0c956a142..7e8baf56faa5 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, 
struct iov_iter *to)
if (bdev)
blksize_mask = bdev_logical_block_size(bdev) - 1;
else
-   blksize_mask = (1 << inode->i_blkbits) - 1;
+   blksize_mask = i_blocksize(inode) - 1;
  
  		if ((iocb->ki_pos | iov_iter_count(to) |

 iov_iter_alignment(to)) & blksize_mask)