Re: [PATCH/RFC e2fsprogs] - replace MKINSTALLDIRS with MKDIR_P for newer autotools

2007-11-10 Thread Theodore Tso 
On Mon, Nov 05, 2007 at 03:55:20PM -0600, Eric Sandeen wrote:
 From: Thomas Woerner [EMAIL PROTECTED] mailto:[EMAIL PROTECTED]
 
 (Thomas was the original author of this patch)
 
 I do not claim to be an autotools guru, hence the RFC.
 RH bugzilla #220715 claims that newer autoconf/automake no longer
 support MKINSTALLDIRS, and the changelog seems to confirm that, as
 does testing.  :)


MKINSTALLDIRS is defined in aclocal.m4, so we're good.  This patch
isn't necessary, as far as I can tell.  Have you actually shown that
with some newer version of autoconf, it produces a configure script
which doesn't define MKINSTALLDIRS?  As far as I know e2fsprogs builds
Just Fine, and using autoconf 2.61 isn't a problem.

What version of autoconf are you using that triggers this problem?
(Note that e2fsprogs does not use automake, since automake is a
horrible kludge of backwards non-compatibility and ugliness)

At some point when we go to a newer version of gettext we may need to
update things, but I'd much rather save that for when we really uplift
gettext and aclocal.m4 all in one go.

For now, I suspect you could drop this patch without any problems,
since we don't use automake, and aclocal.m4 has a version of
AM_MKINSTALLDIRS that will do the right thing.

Regards,

- Ted
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH/RFC e2fsprogs] - replace MKINSTALLDIRS with MKDIR_P for newer autotools

2007-11-05 Thread Eric Sandeen 
From: Thomas Woerner [EMAIL PROTECTED] mailto:[EMAIL PROTECTED]

(Thomas was the original author of this patch)

I do not claim to be an autotools guru, hence the RFC.
RH bugzilla #220715 claims that newer autoconf/automake no longer
support MKINSTALLDIRS, and the changelog seems to confirm that, as
does testing.  :)

The following is the patch we've been carrying for Fedora:

Signed-off-by: Eric Sandeen [EMAIL PROTECTED]
Addresses-Red-Hat-Bugzilla: #220715

---

Index: e2fsprogs-git/debugfs/Makefile.in
===
--- e2fsprogs-git.orig/debugfs/Makefile.in
+++ e2fsprogs-git/debugfs/Makefile.in
@@ -48,8 +48,8 @@ debugfs.8: $(DEP_SUBSTITUTE) $(srcdir)/d
@$(SUBSTITUTE_UPTIME) $(srcdir)/debugfs.8.in debugfs.8
 
 installdirs:
-   @echo  MKINSTALLDIRS $(root_sbindir) $(man8dir)
-   @$(MKINSTALLDIRS) $(DESTDIR)$(root_sbindir) \
+   @echo  MKDIR_P $(root_sbindir) $(man8dir)
+   @$(MKDIR_P) $(DESTDIR)$(root_sbindir) \
$(DESTDIR)$(man8dir)
 
 install: $(PROGS) $(MANPAGES) installdirs
Index: e2fsprogs-git/intl/Makefile.in
===
--- e2fsprogs-git.orig/intl/Makefile.in
+++ e2fsprogs-git/intl/Makefile.in
@@ -40,8 +40,8 @@ subdir = intl
 
 INSTALL = @INSTALL@
 INSTALL_DATA = @INSTALL_DATA@
-MKINSTALLDIRS = @MKINSTALLDIRS@
-mkinstalldirs = $(SHELL) $(MKINSTALLDIRS)
+MKDIR_P = @MKDIR_P@
+mkdir_p = @MKDIR_P@
 
 l = @INTL_LIBTOOL_SUFFIX_PREFIX@
 
Index: e2fsprogs-git/po/Makefile.in.in
===
--- e2fsprogs-git.orig/po/Makefile.in.in
+++ e2fsprogs-git/po/Makefile.in.in
@@ -26,11 +26,10 @@ datarootdir = @datarootdir@
 datadir = @datadir@
 localedir = $(datadir)/locale
 gettextsrcdir = $(datadir)/gettext/po
+mkdir_p = @MKDIR_P@
 
 INSTALL = @INSTALL@
 INSTALL_DATA = @INSTALL_DATA@
-MKINSTALLDIRS = @MKINSTALLDIRS@
-mkinstalldirs = $(SHELL) $(MKINSTALLDIRS)
 
 GMSGFMT = @GMSGFMT@
 MSGFMT = @MSGFMT@
@@ -150,7 +149,7 @@ install: install-exec install-data
 install-exec:
 install-data: [EMAIL PROTECTED]@
if test $(PACKAGE) = gettext-tools; then \
- $(mkinstalldirs) $(DESTDIR)$(gettextsrcdir); \
+ $(mkdir_p) $(DESTDIR)$(gettextsrcdir); \
  for file in $(DISTFILES.common) Makevars.template; do \
$(INSTALL_DATA) $(srcdir)/$$file \
$(DESTDIR)$(gettextsrcdir)/$$file; \
@@ -163,13 +162,13 @@ install-data: [EMAIL PROTECTED]@
fi
 install-data-no: all
 install-data-yes: all
-   $(mkinstalldirs) $(DESTDIR)$(datadir)
+   $(mkdir_p) $(DESTDIR)$(datadir)
@catalogs='$(CATALOGS)'; \
for cat in $$catalogs; do \
  cat=`basename $$cat`; \
  lang=`echo $$cat | sed -e 's/\.gmo$$//'`; \
  dir=$(localedir)/$$lang/LC_MESSAGES; \
- $(mkinstalldirs) $(DESTDIR)$$dir; \
+ $(mkdir_p) $(DESTDIR)$$dir; \
  if test -r $$cat; then realcat=$$cat; else realcat=$(srcdir)/$$cat; 
fi; \
  $(INSTALL_DATA) $$realcat $(DESTDIR)$$dir/$(DOMAIN).mo; \
  echo installing $$realcat as $(DESTDIR)$$dir/$(DOMAIN).mo; \
@@ -209,19 +208,19 @@ installdirs: installdirs-exec installdir
 installdirs-exec:
 installdirs-data: [EMAIL PROTECTED]@
if test $(PACKAGE) = gettext-tools; then \
- $(mkinstalldirs) $(DESTDIR)$(gettextsrcdir); \
+ $(mkdir_p) $(DESTDIR)$(gettextsrcdir); \
else \
  : ; \
fi
 installdirs-data-no:
 installdirs-data-yes:
-   $(mkinstalldirs) $(DESTDIR)$(datadir)
+   $(mkdir_p) $(DESTDIR)$(datadir)
@catalogs='$(CATALOGS)'; \
for cat in $$catalogs; do \
  cat=`basename $$cat`; \
  lang=`echo $$cat | sed -e 's/\.gmo$$//'`; \
  dir=$(localedir)/$$lang/LC_MESSAGES; \
- $(mkinstalldirs) $(DESTDIR)$$dir; \
+ $(mkdir_p) $(DESTDIR)$$dir; \
  for lc in '' $(EXTRA_LOCALE_CATEGORIES); do \
if test -n $$lc; then \
  if (cd $(DESTDIR)$(localedir)/$$lang  LC_ALL=C ls -l -d $$lc 
2/dev/null) | grep ' - ' /dev/null; then \
Index: e2fsprogs-git/misc/Makefile.in
===
--- e2fsprogs-git.orig/misc/Makefile.in
+++ e2fsprogs-git/misc/Makefile.in
@@ -234,8 +234,8 @@ filefrag.8: $(DEP_SUBSTITUTE) $(srcdir)/
@$(SUBSTITUTE_UPTIME) $(srcdir)/filefrag.8.in filefrag.8
 
 installdirs:
-   @echo  MKINSTALLDIRS $(sbindir) $(root_sbindir) $(bindir) $(man1dir) 
$(man8dir) $(libdir) $(root_sysconfdir)
-   @$(MKINSTALLDIRS) $(DESTDIR)$(sbindir) \
+   @echo  MKDIR_P $(sbindir) $(root_sbindir) $(bindir) $(man1dir) 
$(man8dir) $(libdir) $(root_sysconfdir)
+   @$(MKDIR_P) $(DESTDIR)$(sbindir) \
$(DESTDIR)$(root_sbindir) $(DESTDIR)$(bindir) \
$(DESTDIR)$(man1dir) $(DESTDIR)$(man8dir) \
$(DESTDIR)$(man1dir) $(DESTDIR)$(man5dir) \
Index: