Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao 
On Tue, 2006-11-28 at 17:42 +, Hugh Dickins wrote:
> grp_goal 0 is a genuine goal (unlike -1),
> so ext2_try_to_allocate_with_rsv should treat it as such.
> 
> Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>

Acked.

Thanks,

Mingming
> ---
> 
>  fs/ext2/balloc.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- 2.6.19-rc6-mm2/fs/ext2/balloc.c   2006-11-24 08:18:02.0 +
> +++ linux/fs/ext2/balloc.c2006-11-27 19:28:41.0 +
> @@ -1053,7 +1053,7 @@ ext2_try_to_allocate_with_rsv(struct sup
>   }
>   /*
>* grp_goal is a group relative block number (if there is a goal)
> -  * 0 < grp_goal < EXT2_BLOCKS_PER_GROUP(sb)
> +  * 0 <= grp_goal < EXT2_BLOCKS_PER_GROUP(sb)
>* first block is a filesystem wide block number
>* first block is the block number of the first block in this group
>*/
> @@ -1089,7 +1089,7 @@ ext2_try_to_allocate_with_rsv(struct sup
>   if (!goal_in_my_reservation(&my_rsv->rsv_window,
>   grp_goal, group, sb))
>   grp_goal = -1;
> - } else if (grp_goal > 0) {
> + } else if (grp_goal >= 0) {
>   int curr = my_rsv->rsv_end -
>   (grp_goal + group_first_block) + 1;
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Hugh Dickins 
grp_goal 0 is a genuine goal (unlike -1),
so ext2_try_to_allocate_with_rsv should treat it as such.

Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
---

 fs/ext2/balloc.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24 08:18:02.0 +
+++ linux/fs/ext2/balloc.c  2006-11-27 19:28:41.0 +
@@ -1053,7 +1053,7 @@ ext2_try_to_allocate_with_rsv(struct sup
}
/*
 * grp_goal is a group relative block number (if there is a goal)
-* 0 < grp_goal < EXT2_BLOCKS_PER_GROUP(sb)
+* 0 <= grp_goal < EXT2_BLOCKS_PER_GROUP(sb)
 * first block is a filesystem wide block number
 * first block is the block number of the first block in this group
 */
@@ -1089,7 +1089,7 @@ ext2_try_to_allocate_with_rsv(struct sup
if (!goal_in_my_reservation(&my_rsv->rsv_window,
grp_goal, group, sb))
grp_goal = -1;
-   } else if (grp_goal > 0) {
+   } else if (grp_goal >= 0) {
int curr = my_rsv->rsv_end -
(grp_goal + group_first_block) + 1;
 
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html