Re: [f2fs-dev] [PATCH 2/3 v2] f2fs: clear writeback when compression failed

2024-04-24 Thread Chao Yu

On 2024/4/17 0:49, Jaegeuk Kim wrote:

Let's stop issuing compressed writes and clear their writeback flags.

Signed-off-by: Jaegeuk Kim 


Reviewed-by: Chao Yu 

Thanks,


___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [PATCH] f2fs: fix false alarm on invalid block address

2024-04-24 Thread Chao Yu

On 2024/4/25 1:35, Jaegeuk Kim wrote:

f2fs_ra_meta_pages can try to read ahead on invalid block address which is
not the corruption case.

Cc:  # v6.9+
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770
Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_blkaddr")
Signed-off-by: Jaegeuk Kim 


Reviewed-by: Chao Yu 

Thanks,


___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [PATCH 6/6] mm: Remove page_mapping()

2024-04-24 Thread Matthew Wilcox
On Wed, Apr 24, 2024 at 04:34:23PM -0700, Andrew Morton wrote:
> For some reason,
> 
> mm/hugetlb.c: In function 'hugetlb_page_mapping_lock_write':
> mm/hugetlb.c:2164:41: error: implicit declaration of function 'page_mapping'; 
> did you mean 'page_mapped'? [-Werror=implicit-function-declaration]
>  2164 | struct address_space *mapping = page_mapping(hpage);
>   | ^~~~
>   | page_mapped
> mm/hugetlb.c:2164:41: error: initialization of 'struct address_space *' from 
> 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 
> 
> I'll disable "mm: Remove page_mapping()" pending review of the below,
> please.

Looks pretty similar to
https://lore.kernel.org/linux-mm/20240412193510.2356957-7-wi...@infradead.org/

Sorry, I thought you'd picked up that series; I think it's fully
reviewed by now?



Re: [PATCH 6/6] mm: Remove page_mapping()

2024-04-24 Thread Andrew Morton
On Wed, 24 Apr 2024 13:55:32 +0200 David Hildenbrand  wrote:

> On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:
> > All callers are now converted, delete this compatibility wrapper.
> > 

For some reason,

mm/hugetlb.c: In function 'hugetlb_page_mapping_lock_write':
mm/hugetlb.c:2164:41: error: implicit declaration of function 'page_mapping'; 
did you mean 'page_mapped'? [-Werror=implicit-function-declaration]
 2164 | struct address_space *mapping = page_mapping(hpage);
  | ^~~~
  | page_mapped
mm/hugetlb.c:2164:41: error: initialization of 'struct address_space *' from 
'int' makes pointer from integer without a cast [-Werror=int-conversion]


I'll disable "mm: Remove page_mapping()" pending review of the below,
please.


From: Andrew Morton 
Subject: mm: convert hugetlb_page_mapping_lock_write() to 
hugetlb_folio_mapping_lock_write
Date: Wed Apr 24 04:20:30 PM PDT 2024

Convert this to use folios, so we can remove page_mapping()

Cc: David Hildenbrand 
Cc: "Matthew Wilcox (Oracle)" 
Signed-off-by: Andrew Morton 
---

 include/linux/hugetlb.h |6 +++---
 mm/hugetlb.c|6 +++---
 mm/memory-failure.c |4 ++--
 mm/migrate.c|2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

--- 
a/mm/hugetlb.c~mm-convert-hugetlb_page_mapping_lock_write-to-hugetlb_folio_mapping_lock_write
+++ a/mm/hugetlb.c
@@ -2155,13 +2155,13 @@ static bool prep_compound_gigantic_folio
 /*
  * Find and lock address space (mapping) in write mode.
  *
- * Upon entry, the page is locked which means that page_mapping() is
+ * Upon entry, the folio is locked which means that folio_mapping() is
  * stable.  Due to locking order, we can only trylock_write.  If we can
  * not get the lock, simply return NULL to caller.
  */
-struct address_space *hugetlb_page_mapping_lock_write(struct page *hpage)
+struct address_space *hugetlb_folio_mapping_lock_write(struct folio *folio)
 {
-   struct address_space *mapping = page_mapping(hpage);
+   struct address_space *mapping = folio_mapping(folio);
 
if (!mapping)
return mapping;
--- 
a/mm/memory-failure.c~mm-convert-hugetlb_page_mapping_lock_write-to-hugetlb_folio_mapping_lock_write
+++ a/mm/memory-failure.c
@@ -1595,7 +1595,7 @@ static bool hwpoison_user_mappings(struc
 * XXX: the dirty test could be racy: set_page_dirty() may not always
 * be called inside page lock (it's recommended but not enforced).
 */
-   mapping = page_mapping(hpage);
+   mapping = folio_mapping(folio);
if (!(flags & MF_MUST_KILL) && !PageDirty(hpage) && mapping &&
mapping_can_writeback(mapping)) {
if (page_mkclean(hpage)) {
@@ -1622,7 +1622,7 @@ static bool hwpoison_user_mappings(struc
 * TTU_RMAP_LOCKED to indicate we have taken the lock
 * at this higher level.
 */
-   mapping = hugetlb_page_mapping_lock_write(hpage);
+   mapping = hugetlb_folio_mapping_lock_write(folio);
if (mapping) {
try_to_unmap(folio, ttu|TTU_RMAP_LOCKED);
i_mmap_unlock_write(mapping);
--- 
a/include/linux/hugetlb.h~mm-convert-hugetlb_page_mapping_lock_write-to-hugetlb_folio_mapping_lock_write
+++ a/include/linux/hugetlb.h
@@ -178,7 +178,7 @@ bool hugetlbfs_pagecache_present(struct
 struct vm_area_struct *vma,
 unsigned long address);
 
-struct address_space *hugetlb_page_mapping_lock_write(struct page *hpage);
+struct address_space *hugetlb_folio_mapping_lock_write(struct folio *folio);
 
 extern int sysctl_hugetlb_shm_group;
 extern struct list_head huge_boot_pages[MAX_NUMNODES];
@@ -297,8 +297,8 @@ static inline unsigned long hugetlb_tota
return 0;
 }
 
-static inline struct address_space *hugetlb_page_mapping_lock_write(
-   struct page *hpage)
+static inline struct address_space *hugetlb_folio_mapping_lock_write(
+   struct folio *folio)
 {
return NULL;
 }
--- 
a/mm/migrate.c~mm-convert-hugetlb_page_mapping_lock_write-to-hugetlb_folio_mapping_lock_write
+++ a/mm/migrate.c
@@ -1425,7 +1425,7 @@ static int unmap_and_move_huge_page(new_
 * semaphore in write mode here and set TTU_RMAP_LOCKED
 * to let lower levels know we have taken the lock.
 */
-   mapping = hugetlb_page_mapping_lock_write(>page);
+   mapping = hugetlb_folio_mapping_lock_write(src);
if (unlikely(!mapping))
goto unlock_put_anon;
 
_




Re: [f2fs-dev] [PATCH 1/3] f2fs: use folio_test_writeback

2024-04-24 Thread patchwork-bot+f2fs
Hello:

This series was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim :

On Tue,  9 Apr 2024 20:34:09 + you wrote:
> Let's convert PageWriteback to folio_test_writeback.
> 
> Signed-off-by: Jaegeuk Kim 
> ---
>  fs/f2fs/compress.c |  2 +-
>  fs/f2fs/data.c |  3 +--
>  fs/f2fs/f2fs.h |  2 +-
>  fs/f2fs/gc.c   |  2 +-
>  fs/f2fs/inline.c   |  2 +-
>  fs/f2fs/inode.c|  3 ++-
>  fs/f2fs/node.c |  2 +-
>  fs/f2fs/segment.c  | 10 +-
>  8 files changed, 13 insertions(+), 13 deletions(-)

Here is the summary with links:
  - [f2fs-dev,1/3] f2fs: use folio_test_writeback
(no matching commit)
  - [f2fs-dev,2/3] f2fs: clear writeback when compression failed
(no matching commit)
  - [f2fs-dev,3/3] f2fs: fix false alarm on invalid block address
https://git.kernel.org/jaegeuk/f2fs/c/04890641bf1f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] Patchwork summary for: f2fs

2024-04-24 Thread patchwork-bot+f2fs
Hello:

The following patches were marked "accepted", because they were applied to
jaegeuk/f2fs.git (dev):

Series: [f2fs-dev,1/3] f2fs: use folio_test_writeback
  Submitter: Jaegeuk Kim 
  Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=842987
  Lore link: 
https://lore.kernel.org/r/20240409203411.1885121-1-jaeg...@kernel.org
Patches: [f2fs-dev,1/3] f2fs: use folio_test_writeback
 [f2fs-dev,3/3] f2fs: fix false alarm on invalid block address


Total patches: 2

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [PATCH] f2fs: fix false alarm on invalid block address

2024-04-24 Thread Jaegeuk Kim
f2fs_ra_meta_pages can try to read ahead on invalid block address which is
not the corruption case.

Cc:  # v6.9+
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770
Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_blkaddr")
Signed-off-by: Jaegeuk Kim 
---
 fs/f2fs/checkpoint.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 5d05a413f451..55d444bec5c0 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info 
*sbi,
break;
case META_SIT:
if (unlikely(blkaddr >= SIT_BLK_CNT(sbi)))
-   goto err;
+   goto check_only;
break;
case META_SSA:
if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) ||
blkaddr < SM_I(sbi)->ssa_blkaddr))
-   goto err;
+   goto check_only;
break;
case META_CP:
if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr ||
blkaddr < __start_cp_addr(sbi)))
-   goto err;
+   goto check_only;
break;
case META_POR:
if (unlikely(blkaddr >= MAX_BLKADDR(sbi) ||
blkaddr < MAIN_BLKADDR(sbi)))
-   goto err;
+   goto check_only;
break;
case DATA_GENERIC:
case DATA_GENERIC_ENHANCE:
@@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info 
*sbi,
return true;
 err:
f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR);
+check_only:
return false;
 }
 
-- 
2.44.0.769.g3c40516874-goog



___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

Jaegeuk Kim (jaeg...@kernel.org) changed:

   What|Removed |Added

 CC||jaeg...@kernel.org

--- Comment #6 from Jaegeuk Kim (jaeg...@kernel.org) ---
Thank you for the report. It seems I need to reapply that patch indeed.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread Tor Vic via Linux-f2fs-devel




On 4/24/24 14:42, guido iodice wrote:

Thank you.

For clarity, can you confirm that this is a false alarm and in fact there
should be no corruption?


I'm not a developer, but my computer runs just fine with this patch 
applied since a week or so.


I didn't notice any data corruption or error messages in the log.



Best


Guido Iodice



Il giorno mer 24 apr 2024 alle ore 14:40 Tor Vic  ha
scritto:




On 4/24/24 14:30, bugzilla-dae...@kernel.org wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #5 from Guido (guido.iod...@gmail.com) ---
(In reply to Artem S. Tashkinov from comment #4)

On 4/24/24 12:21 PM, Tor Vic wrote:


I can confirm the constant fsck issue, and it was fixed in my case by
the following patch:






https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaeg...@kernel.org/


I have 6.9.rc5 (dated 2024-04-21 on kernel.org) Is that patch already

applied

to it? If yes, it doesn't solve the bug.



No, not applied yet.






___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread Tor Vic via Linux-f2fs-devel




On 4/24/24 14:30, bugzilla-dae...@kernel.org wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #5 from Guido (guido.iod...@gmail.com) ---
(In reply to Artem S. Tashkinov from comment #4)

On 4/24/24 12:21 PM, Tor Vic wrote:


I can confirm the constant fsck issue, and it was fixed in my case by
the following patch:




https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaeg...@kernel.org/


I have 6.9.rc5 (dated 2024-04-21 on kernel.org) Is that patch already applied
to it? If yes, it doesn't solve the bug.



No, not applied yet.


___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #5 from Guido (guido.iod...@gmail.com) ---
(In reply to Artem S. Tashkinov from comment #4)
> On 4/24/24 12:21 PM, Tor Vic wrote:
> > 
> > I can confirm the constant fsck issue, and it was fixed in my case by 
> > the following patch:
> >
> >
> >
> https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaeg...@kernel.org/

I have 6.9.rc5 (dated 2024-04-21 on kernel.org) Is that patch already applied
to it? If yes, it doesn't solve the bug.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

Artem S. Tashkinov (a...@gmx.com) changed:

   What|Removed |Added

 Resolution|ANSWERED|CODE_FIX
 Regression|No  |Yes

--- Comment #4 from Artem S. Tashkinov (a...@gmx.com) ---

On 4/24/24 12:21 PM, Tor Vic wrote:
> 
> I can confirm the constant fsck issue, and it was fixed in my case by 
> the following patch:
>
>
> https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaeg...@kernel.org/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

Artem S. Tashkinov (a...@gmx.com) changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |ANSWERED

--- Comment #3 from Artem S. Tashkinov (a...@gmx.com) ---
> Even running fsck several times always finds problems.

This looks like a f2fs fsck issue, not the kernel issue.

Please post here:

https://github.com/jaegeuk/f2fs-tools

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [Bug 218769] New: fsck seems unable to solve corruption

2024-04-24 Thread Tor Vic via Linux-f2fs-devel




On 4/24/24 13:38, bugzilla-dae...@kernel.org wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=218769

 Bug ID: 218769
Summary: fsck seems unable to solve corruption
Product: File System
Version: 2.5
   Hardware: All
 OS: Linux
 Status: NEW
   Severity: high
   Priority: P3
  Component: f2fs
   Assignee: filesystem_f...@kernel-bugs.kernel.org
   Reporter: guido.iod...@gmail.com
 Regression: No

Created attachment 306204
   --> https://bugzilla.kernel.org/attachment.cgi?id=306204=edit
fsck

After installing kernel 6.9rc5 it seems that all my f2fs partitions are
corrupted, according to fsck. On boot the check-repair is always performed. I
also tried running f2fs from a live usb (with kernel 6.6) but the problem is
not solved. Even running fsck several times always finds problems.


I can confirm the constant fsck issue, and it was fixed in my case by 
the following patch:


https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaeg...@kernel.org/



I attach the output of fsck -f -d 1 on one of the partitions.




___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #2 from Artem S. Tashkinov (a...@gmx.com) ---
*** Bug 218769 has been marked as a duplicate of this bug. ***

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218769] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218769

Artem S. Tashkinov (a...@gmx.com) changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Artem S. Tashkinov (a...@gmx.com) ---


*** This bug has been marked as a duplicate of bug 218770 ***

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [PATCH 6/6] mm: Remove page_mapping()

2024-04-24 Thread David Hildenbrand

On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:

All callers are now converted, delete this compatibility wrapper.

Signed-off-by: Matthew Wilcox (Oracle) 
---
  include/linux/pagemap.h | 1 -
  mm/folio-compat.c   | 6 --
  2 files changed, 7 deletions(-)

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index b6f14e9a2d98..941f7ed714b9 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -399,7 +399,6 @@ static inline void filemap_nr_thps_dec(struct address_space 
*mapping)
  #endif
  }
  
-struct address_space *page_mapping(struct page *);

  struct address_space *folio_mapping(struct folio *);
  struct address_space *swapcache_mapping(struct folio *);
  
diff --git a/mm/folio-compat.c b/mm/folio-compat.c

index f31e0ce65b11..f05906006b3c 100644
--- a/mm/folio-compat.c
+++ b/mm/folio-compat.c
@@ -10,12 +10,6 @@
  #include 
  #include "internal.h"
  
-struct address_space *page_mapping(struct page *page)

-{
-   return folio_mapping(page_folio(page));
-}
-EXPORT_SYMBOL(page_mapping);
-
  void unlock_page(struct page *page)
  {
return folio_unlock(page_folio(page));


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb




Re: [PATCH 5/6] userfault; Expand folio use in mfill_atomic_install_pte()

2024-04-24 Thread David Hildenbrand

On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:

Call page_folio() a little earlier so we can use folio_mapping()
instead of page_mapping(), saving a call to compound_head().

Signed-off-by: Matthew Wilcox (Oracle) 
---


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb




Re: [PATCH 4/6] migrate: Expand the use of folio in __migrate_device_pages()

2024-04-24 Thread David Hildenbrand

On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:

Removes a few calls to compound_head() and a call to page_mapping().

Signed-off-by: Matthew Wilcox (Oracle) 
---


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb




Re: [PATCH 3/6] memory-failure: Remove calls to page_mapping()

2024-04-24 Thread David Hildenbrand

On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:

This is mostly just inlining page_mapping() into the two callers.

Signed-off-by: Matthew Wilcox (Oracle) 
---


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb




Re: [PATCH 2/6] f2fs: Convert f2fs_clear_page_cache_dirty_tag to use a folio

2024-04-24 Thread David Hildenbrand

On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:

Removes uses of page_mapping() and page_index().

Signed-off-by: Matthew Wilcox (Oracle) 
---
  fs/f2fs/data.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5d641fac02ba..9f74c867d790 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -4100,11 +4100,12 @@ const struct address_space_operations f2fs_dblock_aops 
= {
  
  void f2fs_clear_page_cache_dirty_tag(struct page *page)

  {
-   struct address_space *mapping = page_mapping(page);
+   struct folio *folio = page_folio(page);
+   struct address_space *mapping = folio->mapping;
unsigned long flags;
  
  	xa_lock_irqsave(>i_pages, flags);

-   __xa_clear_mark(>i_pages, page_index(page),
+   __xa_clear_mark(>i_pages, folio->index,
PAGECACHE_TAG_DIRTY);
xa_unlock_irqrestore(>i_pages, flags);
  }


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb




Re: [PATCH 1/6] fscrypt: Convert bh_get_inode_and_lblk_num to use a folio

2024-04-24 Thread David Hildenbrand

On 24.04.24 00:55, Matthew Wilcox (Oracle) wrote:

Remove uses of page->index, page_mapping() and b_page.  Saves a call
to compound_head().

Signed-off-by: Matthew Wilcox (Oracle) 
---


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb




[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #1 from Guido (guido.iod...@gmail.com) ---
Created attachment 306205
  --> https://bugzilla.kernel.org/attachment.cgi?id=306205=edit
fsck

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218770] New: fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770

Bug ID: 218770
   Summary: fsck seems unable to solve corruption
   Product: File System
   Version: 2.5
  Hardware: All
OS: Linux
Status: NEW
  Severity: high
  Priority: P3
 Component: f2fs
  Assignee: filesystem_f...@kernel-bugs.kernel.org
  Reporter: guido.iod...@gmail.com
Regression: No

After installing kernel 6.9rc5 it seems that all my f2fs partitions are
corrupted, according to fsck. On boot the check-repair is always performed. I
also tried running f2fs from a live usb (with kernel 6.6) but the problem is
not solved. Even running fsck several times always finds problems.

I attach the output of fsck -f -d 1 on one of the partitions.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [Bug 218769] New: fsck seems unable to solve corruption

2024-04-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218769

Bug ID: 218769
   Summary: fsck seems unable to solve corruption
   Product: File System
   Version: 2.5
  Hardware: All
OS: Linux
Status: NEW
  Severity: high
  Priority: P3
 Component: f2fs
  Assignee: filesystem_f...@kernel-bugs.kernel.org
  Reporter: guido.iod...@gmail.com
Regression: No

Created attachment 306204
  --> https://bugzilla.kernel.org/attachment.cgi?id=306204=edit
fsck

After installing kernel 6.9rc5 it seems that all my f2fs partitions are
corrupted, according to fsck. On boot the check-repair is always performed. I
also tried running f2fs from a live usb (with kernel 6.6) but the problem is
not solved. Even running fsck several times always finds problems.

I attach the output of fsck -f -d 1 on one of the partitions.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel