[f2fs-dev] Patch "f2fs: fix defined but not used build warnings" has been added to the 4.18-stable tree
This is a note to let you know that I've just added the patch titled f2fs: fix defined but not used build warnings to the 4.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2fs-fix-defined-but-not-used-build-warnings.patch and it can be found in the queue-4.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Mon Sep 17 12:37:52 CEST 2018 From: Randy Dunlap Date: Fri, 6 Jul 2018 20:50:57 -0700 Subject: f2fs: fix defined but not used build warnings From: Randy Dunlap [ Upstream commit cb15d1e43db0a6341c1e26ac6a2c74e61b74f1aa ] Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function] ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function] ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc: Jaegeuk Kim Cc: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/sysfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -9,6 +9,7 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#include #include #include #include @@ -516,7 +517,8 @@ static struct kobject f2fs_feat = { .kset = _kset, }; -static int segment_info_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused segment_info_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); @@ -543,7 +545,8 @@ static int segment_info_seq_show(struct return 0; } -static int segment_bits_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused segment_bits_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); @@ -567,7 +570,8 @@ static int segment_bits_seq_show(struct return 0; } -static int iostat_info_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused iostat_info_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); Patches currently in stable-queue which might be from rdun...@infradead.org are queue-4.18/f2fs-fix-defined-but-not-used-build-warnings.patch ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
[f2fs-dev] Patch "f2fs: fix defined but not used build warnings" has been added to the 4.14-stable tree
This is a note to let you know that I've just added the patch titled f2fs: fix defined but not used build warnings to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: f2fs-fix-defined-but-not-used-build-warnings.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Mon Sep 17 12:33:31 CEST 2018 From: Randy Dunlap Date: Fri, 6 Jul 2018 20:50:57 -0700 Subject: f2fs: fix defined but not used build warnings From: Randy Dunlap [ Upstream commit cb15d1e43db0a6341c1e26ac6a2c74e61b74f1aa ] Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function] ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function] ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc: Jaegeuk Kim Cc: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/sysfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -9,6 +9,7 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#include #include #include #include @@ -381,7 +382,8 @@ static struct kobject f2fs_feat = { .kset = _kset, }; -static int segment_info_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused segment_info_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); @@ -408,7 +410,8 @@ static int segment_info_seq_show(struct return 0; } -static int segment_bits_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused segment_bits_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); @@ -432,7 +435,8 @@ static int segment_bits_seq_show(struct return 0; } -static int iostat_info_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused iostat_info_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); Patches currently in stable-queue which might be from rdun...@infradead.org are queue-4.14/f2fs-fix-defined-but-not-used-build-warnings.patch ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH] f2fs: fix defined but not used build warnings
On 2018/7/12 11:35, Randy Dunlap wrote: > On 07/09/2018 06:09 PM, Chao Yu wrote: >> On 2018/7/7 11:50, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled >>> by marking the unused functions as __maybe_unused. >>> >>> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not >>> used [-Wunused-function] >>> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not >>> used [-Wunused-function] >>> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not >>> used [-Wunused-function] >>> >>> Signed-off-by: Randy Dunlap >>> Cc: Jaegeuk Kim >>> Cc: Chao Yu >>> Cc: linux-f2fs-devel@lists.sourceforge.net >> >> Reviewed-by: Chao Yu > > Hi, > Who would you like to merge this patch? or could you do so? Hello, Jaegeuk will merge it. :) Thanks, > > thanks, > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH] f2fs: fix defined but not used build warnings
On 07/11, Randy Dunlap wrote: > On 07/09/2018 06:09 PM, Chao Yu wrote: > > On 2018/7/7 11:50, Randy Dunlap wrote: > >> From: Randy Dunlap > >> > >> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled > >> by marking the unused functions as __maybe_unused. > >> > >> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but > >> not used [-Wunused-function] > >> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but > >> not used [-Wunused-function] > >> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not > >> used [-Wunused-function] > >> > >> Signed-off-by: Randy Dunlap > >> Cc: Jaegeuk Kim > >> Cc: Chao Yu > >> Cc: linux-f2fs-devel@lists.sourceforge.net > > > > Reviewed-by: Chao Yu > > Hi, > Who would you like to merge this patch? or could you do so? Hi Randy, I'll merge it in -next for Linus. Thanks, > > thanks, > -- > ~Randy -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH] f2fs: fix defined but not used build warnings
On 07/09/2018 06:09 PM, Chao Yu wrote: > On 2018/7/7 11:50, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled >> by marking the unused functions as __maybe_unused. >> >> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not >> used [-Wunused-function] >> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not >> used [-Wunused-function] >> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not >> used [-Wunused-function] >> >> Signed-off-by: Randy Dunlap >> Cc: Jaegeuk Kim >> Cc: Chao Yu >> Cc: linux-f2fs-devel@lists.sourceforge.net > > Reviewed-by: Chao Yu Hi, Who would you like to merge this patch? or could you do so? thanks, -- ~Randy -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH] f2fs: fix defined but not used build warnings
On 2018/7/7 11:50, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled > by marking the unused functions as __maybe_unused. > > ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not > used [-Wunused-function] > ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not > used [-Wunused-function] > ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not > used [-Wunused-function] > > Signed-off-by: Randy Dunlap > Cc: Jaegeuk Kim > Cc: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net Reviewed-by: Chao Yu Thanks, -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
[f2fs-dev] [PATCH] f2fs: fix defined but not used build warnings
From: Randy Dunlap Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function] ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function] ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc: Jaegeuk Kim Cc: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net --- fs/f2fs/sysfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- linux-next-20180706.orig/fs/f2fs/sysfs.c +++ linux-next-20180706/fs/f2fs/sysfs.c @@ -9,6 +9,7 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ +#include #include #include #include @@ -516,7 +517,8 @@ static struct kobject f2fs_feat = { .kset = _kset, }; -static int segment_info_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused segment_info_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); @@ -543,7 +545,8 @@ static int segment_info_seq_show(struct return 0; } -static int segment_bits_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused segment_bits_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); @@ -567,7 +570,8 @@ static int segment_bits_seq_show(struct return 0; } -static int iostat_info_seq_show(struct seq_file *seq, void *offset) +static int __maybe_unused iostat_info_seq_show(struct seq_file *seq, + void *offset) { struct super_block *sb = seq->private; struct f2fs_sb_info *sbi = F2FS_SB(sb); -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel