Re: [f2fs-dev] [PATCH] f2fs: use f2fs_{err, info}_ratelimited() for cleanup

[patchwork-bot+f2fs]

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim :

On Mon,  6 May 2024 18:47:42 +0800 you wrote:
> Commit b1c9d3f833ba ("f2fs: support printk_ratelimited() in f2fs_printk()")
> missed some cases, cover all remains for cleanup.
> 
> Signed-off-by: Chao Yu 
> ---
>  fs/f2fs/compress.c | 54 +-
>  fs/f2fs/segment.c  |  5 ++---
>  2 files changed, 26 insertions(+), 33 deletions(-)

Here is the summary with links:
  - [f2fs-dev] f2fs: use f2fs_{err, info}_ratelimited() for cleanup
https://git.kernel.org/jaegeuk/f2fs/c/a78118406d52

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH] f2fs: use f2fs_{err, info}_ratelimited() for cleanup

[Chao Yu]

Commit b1c9d3f833ba ("f2fs: support printk_ratelimited() in f2fs_printk()")
missed some cases, cover all remains for cleanup.

Signed-off-by: Chao Yu 
---
 fs/f2fs/compress.c | 54 +-
 fs/f2fs/segment.c  |  5 ++---
 2 files changed, 26 insertions(+), 33 deletions(-)

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 8892c8262141..3c70a9697063 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -198,8 +198,8 @@ static int lzo_compress_pages(struct compress_ctx *cc)
ret = lzo1x_1_compress(cc->rbuf, cc->rlen, cc->cbuf->cdata,
>clen, cc->private);
if (ret != LZO_E_OK) {
-   printk_ratelimited("%sF2FS-fs (%s): lzo compress failed, 
ret:%d\n",
-   KERN_ERR, F2FS_I_SB(cc->inode)->sb->s_id, ret);
+   f2fs_err_ratelimited(F2FS_I_SB(cc->inode),
+   "lzo compress failed, ret:%d", ret);
return -EIO;
}
return 0;
@@ -212,17 +212,15 @@ static int lzo_decompress_pages(struct decompress_io_ctx 
*dic)
ret = lzo1x_decompress_safe(dic->cbuf->cdata, dic->clen,
dic->rbuf, >rlen);
if (ret != LZO_E_OK) {
-   printk_ratelimited("%sF2FS-fs (%s): lzo decompress failed, 
ret:%d\n",
-   KERN_ERR, F2FS_I_SB(dic->inode)->sb->s_id, ret);
+   f2fs_err_ratelimited(F2FS_I_SB(dic->inode),
+   "lzo decompress failed, ret:%d", ret);
return -EIO;
}
 
if (dic->rlen != PAGE_SIZE << dic->log_cluster_size) {
-   printk_ratelimited("%sF2FS-fs (%s): lzo invalid rlen:%zu, "
-   "expected:%lu\n", KERN_ERR,
-   F2FS_I_SB(dic->inode)->sb->s_id,
-   dic->rlen,
-   PAGE_SIZE << dic->log_cluster_size);
+   f2fs_err_ratelimited(F2FS_I_SB(dic->inode),
+   "lzo invalid rlen:%zu, expected:%lu",
+   dic->rlen, PAGE_SIZE << dic->log_cluster_size);
return -EIO;
}
return 0;
@@ -294,16 +292,15 @@ static int lz4_decompress_pages(struct decompress_io_ctx 
*dic)
ret = LZ4_decompress_safe(dic->cbuf->cdata, dic->rbuf,
dic->clen, dic->rlen);
if (ret < 0) {
-   printk_ratelimited("%sF2FS-fs (%s): lz4 decompress failed, 
ret:%d\n",
-   KERN_ERR, F2FS_I_SB(dic->inode)->sb->s_id, ret);
+   f2fs_err_ratelimited(F2FS_I_SB(dic->inode),
+   "lz4 decompress failed, ret:%d", ret);
return -EIO;
}
 
if (ret != PAGE_SIZE << dic->log_cluster_size) {
-   printk_ratelimited("%sF2FS-fs (%s): lz4 invalid ret:%d, "
-   "expected:%lu\n", KERN_ERR,
-   F2FS_I_SB(dic->inode)->sb->s_id, ret,
-   PAGE_SIZE << dic->log_cluster_size);
+   f2fs_err_ratelimited(F2FS_I_SB(dic->inode),
+   "lz4 invalid ret:%d, expected:%lu",
+   ret, PAGE_SIZE << dic->log_cluster_size);
return -EIO;
}
return 0;
@@ -350,9 +347,8 @@ static int zstd_init_compress_ctx(struct compress_ctx *cc)
 
stream = zstd_init_cstream(, 0, workspace, workspace_size);
if (!stream) {
-   printk_ratelimited("%sF2FS-fs (%s): %s zstd_init_cstream 
failed\n",
-   KERN_ERR, F2FS_I_SB(cc->inode)->sb->s_id,
-   __func__);
+   f2fs_err_ratelimited(F2FS_I_SB(cc->inode),
+   "%s zstd_init_cstream failed", __func__);
kvfree(workspace);
return -EIO;
}
@@ -390,16 +386,16 @@ static int zstd_compress_pages(struct compress_ctx *cc)
 
ret = zstd_compress_stream(stream, , );
if (zstd_is_error(ret)) {
-   printk_ratelimited("%sF2FS-fs (%s): %s zstd_compress_stream 
failed, ret: %d\n",
-   KERN_ERR, F2FS_I_SB(cc->inode)->sb->s_id,
+   f2fs_err_ratelimited(F2FS_I_SB(cc->inode),
+   "%s zstd_compress_stream failed, ret: %d",
__func__, zstd_get_error_code(ret));
return -EIO;
}
 
ret = zstd_end_stream(stream, );
if (zstd_is_error(ret)) {
-   printk_ratelimited("%sF2FS-fs (%s): %s zstd_end_stream returned 
%d\n",
-   KERN_ERR, F2FS_I_SB(cc->inode)->sb->s_id,
+   f2fs_err_ratelimited(F2FS_I_SB(cc->inode),
+   "%s