Re: [f2fs-dev] [PATCH] sload.f2fs: give correct file type

[Jaegeuk Kim]

On 05/08, Junling Zheng wrote:
> Hi, Jaegeuk
> 
> My previous patch (sload.f2fs: fix the missing of bit mask for file type) had
> already fix this bug :)

I guessed it before, but this is also reasonable to me where de->file_type
is based on F2FS_FT_DIR.

> 
> Thanks,
> Junling
> 
> On 2018/5/8 2:58, Jaegeuk Kim wrote:
> > From: Lianjun Huang 
> > 
> > This fixes permission error due to wrong file type.
> > 
> > Signed-off-by: Lianjun Huang 
> > Signed-off-by: Jaegeuk Kim 
> > ---
> >  fsck/sload.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fsck/sload.c b/fsck/sload.c
> > index 2842f2c..2fb13f2 100644
> > --- a/fsck/sload.c
> > +++ b/fsck/sload.c
> > @@ -106,7 +106,7 @@ static int set_perms_and_caps(struct dentry *de)
> >  
> > /* Permissions */
> > if (fs_config_func != NULL) {
> > -   fs_config_func(mnt_path, S_ISDIR(de->mode),
> > +   fs_config_func(mnt_path, de->file_type == F2FS_FT_DIR,
> > c.target_out_dir, , , ,
> > );
> > de->uid = uid & 0x;
> > 
> 

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] sload.f2fs: give correct file type

[Junling Zheng]

Hi, Jaegeuk

My previous patch (sload.f2fs: fix the missing of bit mask for file type) had
already fix this bug :)

Thanks,
Junling

On 2018/5/8 2:58, Jaegeuk Kim wrote:
> From: Lianjun Huang 
> 
> This fixes permission error due to wrong file type.
> 
> Signed-off-by: Lianjun Huang 
> Signed-off-by: Jaegeuk Kim 
> ---
>  fsck/sload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsck/sload.c b/fsck/sload.c
> index 2842f2c..2fb13f2 100644
> --- a/fsck/sload.c
> +++ b/fsck/sload.c
> @@ -106,7 +106,7 @@ static int set_perms_and_caps(struct dentry *de)
>  
>   /* Permissions */
>   if (fs_config_func != NULL) {
> - fs_config_func(mnt_path, S_ISDIR(de->mode),
> + fs_config_func(mnt_path, de->file_type == F2FS_FT_DIR,
>   c.target_out_dir, , , ,
>   );
>   de->uid = uid & 0x;
> 



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH] sload.f2fs: give correct file type

[Jaegeuk Kim]

From: Lianjun Huang 

This fixes permission error due to wrong file type.

Signed-off-by: Lianjun Huang 
Signed-off-by: Jaegeuk Kim 
---
 fsck/sload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fsck/sload.c b/fsck/sload.c
index 2842f2c..2fb13f2 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -106,7 +106,7 @@ static int set_perms_and_caps(struct dentry *de)
 
/* Permissions */
if (fs_config_func != NULL) {
-   fs_config_func(mnt_path, S_ISDIR(de->mode),
+   fs_config_func(mnt_path, de->file_type == F2FS_FT_DIR,
c.target_out_dir, , , ,
);
de->uid = uid & 0x;
-- 
2.17.0.484.g0c8726318c-goog


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel