Re: [f2fs-dev] [PATCH] dump.f2fs: correct the seg type in ssa_dump

[Chao Yu]

On 2018/2/6 16:47, Junling Zheng wrote:
> Fix the mixed using of "ret" in ssa_dump.
> 
> Signed-off-by: Junling Zheng 

Reviewed-by: Chao Yu 

Thanks,

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH] dump.f2fs: correct the seg type in ssa_dump

[Junling Zheng]

Fix the mixed using of "ret" in ssa_dump.

Signed-off-by: Junling Zheng 
---
 fsck/dump.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fsck/dump.c b/fsck/dump.c
index 8772a62..23e4f47 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -195,7 +195,7 @@ void ssa_dump(struct f2fs_sb_info *sbi, int start_ssa, int 
end_ssa)
 {
struct f2fs_summary_block *sum_blk;
char buf[BUF_SZ];
-   int segno, i, ret;
+   int segno, type, i, ret;
int fd;
 
fd = open("dump_ssa", O_CREAT|O_WRONLY|O_TRUNC, 0666);
@@ -208,10 +208,10 @@ void ssa_dump(struct f2fs_sb_info *sbi, int start_ssa, 
int end_ssa)
ASSERT(ret >= 0);
 
for (segno = start_ssa; segno < end_ssa; segno++) {
-   sum_blk = get_sum_block(sbi, segno, );
+   sum_blk = get_sum_block(sbi, segno, );
 
memset(buf, 0, BUF_SZ);
-   switch (ret) {
+   switch (type) {
case SEG_TYPE_CUR_NODE:
snprintf(buf, BUF_SZ, "\n\nsegno: %x, Current Node\n", 
segno);
break;
@@ -240,8 +240,8 @@ void ssa_dump(struct f2fs_sb_info *sbi, int start_ssa, int 
end_ssa)
ret = write(fd, buf, strlen(buf));
ASSERT(ret >= 0);
}
-   if (ret == SEG_TYPE_NODE || ret == SEG_TYPE_DATA ||
-   ret == SEG_TYPE_MAX)
+   if (type == SEG_TYPE_NODE || type == SEG_TYPE_DATA ||
+   type == SEG_TYPE_MAX)
free(sum_blk);
}
close(fd);
-- 
2.15.1


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel