Re: [f2fs-dev] [RFC PATCH 0/2] f2fs: introduce lost+found feature

2018-02-11 Thread Jaegeuk Kim
On 02/11, Sheng Yong wrote:
> Hi, Jaegeuk
> 
> On 2018/2/10 10:50, Jaegeuk Kim wrote:
> > On 02/06, Sheng Yong wrote:
> > > This patchset introduces lost+found feature in f2fs. If the feature is
> > > enabled, f2fs should avoid to encrypting root directory.
> > 
> > In that case, we need to add test_dummy_encryption likewise ext4.
> > 
> If the test_dummy_encryption is only used for some a testcase, I think
> it's ok not to add it. The lost_found feature is not enabled by default,
> so if we don't specify "-O lost_found" for mkfs, root directory is allowed
> to be encrypted. If I miss something, please let me know :)

No, we have to be able to test lost_found with encryption. :)

Thanks,

> 
> thanks,
> Sheng
> 
> > > 
> > > For more information, please check the mail "f2fs-tools: introduce lost+
> > > found feature".
> > > 
> > > Thanks,
> > > Sheng
> > > 
> > > Sheng Yong (2):
> > >f2fs: clean up f2fs_sb_has_xxx functions
> > >f2fs: introduce lost+found feature
> > > 
> > >   fs/f2fs/data.c|  2 +-
> > >   fs/f2fs/f2fs.h| 53 
> > > +++--
> > >   fs/f2fs/file.c|  6 +++---
> > >   fs/f2fs/segment.c |  4 ++--
> > >   fs/f2fs/super.c   | 26 +++---
> > >   fs/f2fs/sysfs.c   |  4 ++--
> > >   6 files changed, 42 insertions(+), 53 deletions(-)
> > > 
> > > -- 
> > > 2.11.0
> > 
> > .
> > 

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [RFC PATCH 0/2] f2fs: introduce lost+found feature

2018-02-10 Thread Sheng Yong

Hi, Jaegeuk

On 2018/2/10 10:50, Jaegeuk Kim wrote:

On 02/06, Sheng Yong wrote:

This patchset introduces lost+found feature in f2fs. If the feature is
enabled, f2fs should avoid to encrypting root directory.


In that case, we need to add test_dummy_encryption likewise ext4.


If the test_dummy_encryption is only used for some a testcase, I think
it's ok not to add it. The lost_found feature is not enabled by default,
so if we don't specify "-O lost_found" for mkfs, root directory is allowed
to be encrypted. If I miss something, please let me know :)

thanks,
Sheng



For more information, please check the mail "f2fs-tools: introduce lost+
found feature".

Thanks,
Sheng

Sheng Yong (2):
   f2fs: clean up f2fs_sb_has_xxx functions
   f2fs: introduce lost+found feature

  fs/f2fs/data.c|  2 +-
  fs/f2fs/f2fs.h| 53 +++--
  fs/f2fs/file.c|  6 +++---
  fs/f2fs/segment.c |  4 ++--
  fs/f2fs/super.c   | 26 +++---
  fs/f2fs/sysfs.c   |  4 ++--
  6 files changed, 42 insertions(+), 53 deletions(-)

--
2.11.0


.




--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [RFC PATCH 0/2] f2fs: introduce lost+found feature

2018-02-09 Thread Jaegeuk Kim
On 02/06, Sheng Yong wrote:
> This patchset introduces lost+found feature in f2fs. If the feature is
> enabled, f2fs should avoid to encrypting root directory.

In that case, we need to add test_dummy_encryption likewise ext4.

> 
> For more information, please check the mail "f2fs-tools: introduce lost+
> found feature".
> 
> Thanks,
> Sheng
> 
> Sheng Yong (2):
>   f2fs: clean up f2fs_sb_has_xxx functions
>   f2fs: introduce lost+found feature
> 
>  fs/f2fs/data.c|  2 +-
>  fs/f2fs/f2fs.h| 53 +++--
>  fs/f2fs/file.c|  6 +++---
>  fs/f2fs/segment.c |  4 ++--
>  fs/f2fs/super.c   | 26 +++---
>  fs/f2fs/sysfs.c   |  4 ++--
>  6 files changed, 42 insertions(+), 53 deletions(-)
> 
> -- 
> 2.11.0

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel