Re: [f2fs-dev] [PATCH 3/5] block: remove support for the host aware zone model

2023-12-19 Thread h...@lst.de
On Tue, Dec 19, 2023 at 05:12:41PM +0900, Damien Le Moal wrote:
> >> Since we cannot create lambda as in other fancy languages, we need
> >> two
> >> functions...
> > 
> > Not really, there is a "void *data" can be used.
> > 
> > The device_is_zoned_model() is just the same as the device_not_zoned()
> > with (bool *)data = false.
> > 
> > It's very minor, so is okay to ignore my preference.
> 
> Send a patch on top of Christoph's series if you want to clean this up.

I'll need to respin anyway, so I'll look into incorporating the
suggestion.


___
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [PATCH 3/5] block: remove support for the host aware zone model

2023-12-19 Thread h...@lst.de
On Tue, Dec 19, 2023 at 11:38:25AM +0100, [email protected] wrote:
> > > It's very minor, so is okay to ignore my preference.
> > 
> > Send a patch on top of Christoph's series if you want to clean this up.
> 
> I'll need to respin anyway, so I'll look into incorporating the
> suggestion.

I did look into it and the iterate callbacks confuse the heck out of me.
So I'm not going to touch them in non-trivial ways here and will leave
it for follow on cleanups as needed.


___
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


Re: [f2fs-dev] [PATCH V3 6/6] xfs: ignore discard return value

2025-11-26 Thread h...@lst.de
On Wed, Nov 26, 2025 at 08:07:21AM +, Chaitanya Kulkarni wrote:
> The retry for discard bio memory allocation is not desired I think,
> since it's only a hint to the controller.

Yes, it is.  The command is defined as a hint, but it's required for
a lot of workloads to work.  It's not just a speculative readahead.



___
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel