possible circular lock dependency in reiserfs

2007-10-17 Thread Oliver Neukum
Hi,

I got the following report in syslog:

Oct 17 10:56:35 oenone kernel: =
Oct 17 10:56:35 oenone kernel: [ INFO: possible recursive locking detected ]
Oct 17 10:56:35 oenone kernel: 2.6.23-default #1
Oct 17 10:56:35 oenone kernel: -
Oct 17 10:56:35 oenone kernel: beagled/4092 is trying to acquire lock:
Oct 17 10:56:35 oenone kernel:  (inode-i_mutex){--..}, at: 
[88090081] reiserfs_xattr_set+0xf3/0x30e [reiserfs]
Oct 17 10:56:35 oenone kernel:
Oct 17 10:56:35 oenone kernel: but task is already holding lock:
Oct 17 10:56:35 oenone kernel:  (inode-i_mutex){--..}, at: 
[802adef5] vfs_setxattr+0x4d/0x1e0
Oct 17 10:56:35 oenone kernel:
Oct 17 10:56:35 oenone kernel: other info that might help us debug this:
Oct 17 10:56:35 oenone kernel: 3 locks held by beagled/4092:
Oct 17 10:56:35 oenone kernel:  #0:  (inode-i_mutex){--..}, at: 
[802adef5] vfs_setxattr+0x4d/0x1e0
Oct 17 10:56:35 oenone kernel:  #1:  (REISERFS_I(inode)-xattr_sem){}, at: 
[8808fb56] reiserfs_setxattr+0x6b/0x11f [reiserfs]
Oct 17 10:56:35 oenone kernel:  #2:  (REISERFS_SB(s)-xattr_dir_sem){}, 
at: [8808fb89] reiserfs_setxattr+0x9e/0x11f [reiserfs]
Oct 17 10:56:35 oenone kernel:
Oct 17 10:56:35 oenone kernel: stack backtrace:
Oct 17 10:56:35 oenone kernel:
Oct 17 10:56:35 oenone kernel: Call Trace:
Oct 17 10:56:35 oenone kernel:  [80250528] __lock_acquire+0x1b7/0xcaf
Oct 17 10:56:35 oenone kernel:  [8025140d] lock_acquire+0x51/0x6c
Oct 17 10:56:35 oenone kernel:  [88090081] 
:reiserfs:reiserfs_xattr_set+0xf3/0x30e
Oct 17 10:56:35 oenone kernel:  [8024ddd1] 
debug_mutex_lock_common+0x16/0x23
Oct 17 10:56:35 oenone kernel:  [8044b824] 
__mutex_lock_slowpath+0xe1/0x277
Oct 17 10:56:35 oenone kernel:  [88090081] 
:reiserfs:reiserfs_xattr_set+0xf3/0x30e
Oct 17 10:56:35 oenone kernel:  [8024feec] 
trace_hardirqs_on+0x115/0x139
Oct 17 10:56:35 oenone kernel:  [8044d1f4] _spin_unlock_irq+0x24/0x27
Oct 17 10:56:35 oenone kernel:  [8044c85a] 
__down_write_nested+0x34/0x9e
Oct 17 10:56:35 oenone kernel:  [8808fbb2] 
:reiserfs:reiserfs_setxattr+0xc7/0x11f
Oct 17 10:56:35 oenone kernel:  [802adf56] vfs_setxattr+0xae/0x1e0
Oct 17 10:56:35 oenone kernel:  [802ae148] setxattr+0xc0/0xdd
Oct 17 10:56:35 oenone kernel:  [8028f376] kmem_cache_free+0x1c4/0x1d6
Oct 17 10:56:35 oenone kernel:  [8024feec] 
trace_hardirqs_on+0x115/0x139
Oct 17 10:56:35 oenone kernel:  [8029dae5] do_path_lookup+0x1ae/0x22c
Oct 17 10:56:35 oenone kernel:  [8029e340] __user_walk_fd+0x41/0x4c
Oct 17 10:56:35 oenone kernel:  [802ae1ae] sys_lsetxattr+0x49/0x6a
Oct 17 10:56:35 oenone kernel:  [8020bdfa] tracesys+0x71/0xe1
Oct 17 10:56:35 oenone kernel:  [8020be65] tracesys+0xdc/0xe1
Oct 17 10:56:35 oenone kernel:
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs

2007-10-17 Thread Christoph Hellwig
On Mon, Oct 15, 2007 at 02:31:03PM -0400, Jeff Mahoney wrote:
 Here's a patch I worked up the other night that kills off struct file
 completely from the xattr code. I've tested it locally.

Looks like a merge of Dave's and my patch :)

ACK from me, I don't care whether it's one or two patches.
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs

2007-10-17 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Christoph Hellwig wrote:
 On Mon, Oct 15, 2007 at 02:31:03PM -0400, Jeff Mahoney wrote:
 Here's a patch I worked up the other night that kills off struct file
 completely from the xattr code. I've tested it locally.
 
 Looks like a merge of Dave's and my patch :)
 
 ACK from me, I don't care whether it's one or two patches.

Yeah, it probably is. I did it from scratch since it was my mess, and
the patches I saw were against -mm.

*shrug* Likewise, I don't care if it's one or two.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHFiJHLPWxlyuTD7IRAojqAJwKS+eL1yCtUVHzBSFUxjjkW6KgPwCcDRUE
Q1V7tCPcT9h0a8ahVmYn+ms=
=5kMt
-END PGP SIGNATURE-
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html