Re: [PATCH 23/27] NFS: Fix memory leak [try #2]

2008-01-24 Thread Trond Myklebust 

On Wed, 2008-01-23 at 17:22 +, David Howells wrote:
 Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite
 the duplicated client_address option pointer, without freeing the old memory.
 
 Signed-off-by: David Howells [EMAIL PROTECTED]
 ---
 
  fs/nfs/super.c |1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
 
 
 diff --git a/fs/nfs/super.c b/fs/nfs/super.c
 index 0b0c72a..7f5e747 100644
 --- a/fs/nfs/super.c
 +++ b/fs/nfs/super.c
 @@ -936,6 +936,7 @@ static int nfs_parse_mount_options(char *raw,
   string = match_strdup(args);
   if (string == NULL)
   goto out_nomem;
 + kfree(mnt-client_address);
   mnt-client_address = string;
   break;
   case Opt_mountaddr:

Thanks. This fix has already been applied to the NFS git tree.
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 23/27] NFS: Fix memory leak [try #2]

2008-01-23 Thread David Howells 
Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite
the duplicated client_address option pointer, without freeing the old memory.

Signed-off-by: David Howells [EMAIL PROTECTED]
---

 fs/nfs/super.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 0b0c72a..7f5e747 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -936,6 +936,7 @@ static int nfs_parse_mount_options(char *raw,
string = match_strdup(args);
if (string == NULL)
goto out_nomem;
+   kfree(mnt-client_address);
mnt-client_address = string;
break;
case Opt_mountaddr:

-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html