Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Hi Wolfram,
Thanks for your input!
Replies below.
On 08/14/2019 09:47 PM, Wolfram Sang wrote:
>> +static int clock = 0x1c;
>> +module_param(clock, int, 0444);
>
> 'clock' determines the bus speed?
Yes, but it also determines the frequency of the oscillator driving the
PCF8584. It doesn't usually need to be touched, the current setting drives at
the maximum I2C bus speed, with the maximum oscillator (12 MHz).
I kept it in because i2c-elektor also exposes it in the same way, and it seems
useful.
>> +i2c->adapter.class = I2C_CLASS_DEPRECATED;
>
> This is only needed for drivers which used to have a class and decided
> to drop it. You can leave it empty.
Thanks, I'll drop it.
>> +algo_data->data = (void *)i2c;
>
> You don't need the cast, do you?
True. Dropped, thanks.
>> +MODULE_LICENSE("GPL");
>
> Your SPDX header says GPL 2.0 only.
Thanks! I'll change it to "GPL v2", but unfortunately there is no option for
"only" in include/linux/module.h.
Cheers
Max
[PATCH v5 00/18] compat_ioctl.c removal, part 2/3
This is a follow-up to part 1/3 that I posted after -rc2. I hope these are still largely uncontroversial changes, and I would like to get them into linux-5.4. Part 1 was in https://lore.kernel.org/lkml/capcyv4i_nhzv155rcgnaq189aq2lfd2g8pa1d5nbzqo9e_u...@mail.gmail.com/ Part 3 will be one kernel release after part 2 is merged, as that still needs a little extra work. The entire series is available at git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git compat_ioctl Arnd Al Viro (2): compat_ioctl: unify copy-in of ppp filters compat_ioctl: move PPPIOCSCOMPRESS to ppp_generic Arnd Bergmann (16): xfs: compat_ioctl: use compat_ptr() xfs: compat_ioctl: add missing conversions gfs2: add compat_ioctl support fs: compat_ioctl: move FITRIM emulation into file systems watchdog: cpwd: use generic compat_ptr_ioctl compat_ioctl: move WDIOC handling into wdt drivers compat_ioctl: reimplement SG_IO handling af_unix: add compat_ioctl support compat_ioctl: handle SIOCOUTQNSD compat_ioctl: move SIOCOUTQ out of compat_ioctl.c tty: handle compat PPP ioctls compat_ioctl: handle PPPIOCGIDLE for 64-bit time_t compat_ioctl: ppp: move simple commands into ppp_generic.c compat_ioctl: move SG_GET_REQUEST_TABLE handling pktcdvd: add compat_ioctl handler scsi: sd: enable compat ioctls for sed-opal Documentation/networking/ppp_generic.txt | 2 + arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 1 + arch/um/drivers/harddog_kern.c| 1 + block/scsi_ioctl.c| 132 - drivers/block/pktcdvd.c | 25 ++ drivers/char/ipmi/ipmi_watchdog.c | 1 + drivers/hwmon/fschmd.c| 1 + drivers/net/ppp/ppp_generic.c | 245 ++- drivers/rtc/rtc-ds1374.c | 1 + drivers/scsi/sd.c | 14 +- drivers/scsi/sg.c | 59 +++- drivers/tty/tty_io.c | 5 + drivers/watchdog/acquirewdt.c | 1 + drivers/watchdog/advantechwdt.c | 1 + drivers/watchdog/alim1535_wdt.c | 1 + drivers/watchdog/alim7101_wdt.c | 1 + drivers/watchdog/ar7_wdt.c| 1 + drivers/watchdog/at91rm9200_wdt.c | 1 + drivers/watchdog/ath79_wdt.c | 1 + drivers/watchdog/bcm63xx_wdt.c| 1 + drivers/watchdog/cpu5wdt.c| 1 + drivers/watchdog/cpwd.c | 25 +- drivers/watchdog/eurotechwdt.c| 1 + drivers/watchdog/f71808e_wdt.c| 1 + drivers/watchdog/gef_wdt.c| 1 + drivers/watchdog/geodewdt.c | 1 + drivers/watchdog/ib700wdt.c | 1 + drivers/watchdog/ibmasr.c | 1 + drivers/watchdog/indydog.c| 1 + drivers/watchdog/intel_scu_watchdog.c | 1 + drivers/watchdog/iop_wdt.c| 1 + drivers/watchdog/it8712f_wdt.c| 1 + drivers/watchdog/ixp4xx_wdt.c | 1 + drivers/watchdog/ks8695_wdt.c | 1 + drivers/watchdog/m54xx_wdt.c | 1 + drivers/watchdog/machzwd.c| 1 + drivers/watchdog/mixcomwd.c | 1 + drivers/watchdog/mtx-1_wdt.c | 1 + drivers/watchdog/mv64x60_wdt.c| 1 + drivers/watchdog/nuc900_wdt.c | 1 + drivers/watchdog/nv_tco.c | 1 + drivers/watchdog/pc87413_wdt.c| 1 + drivers/watchdog/pcwd.c | 1 + drivers/watchdog/pcwd_pci.c | 1 + drivers/watchdog/pcwd_usb.c | 1 + drivers/watchdog/pika_wdt.c | 1 + drivers/watchdog/pnx833x_wdt.c| 1 + drivers/watchdog/rc32434_wdt.c| 1 + drivers/watchdog/rdc321x_wdt.c| 1 + drivers/watchdog/riowd.c | 1 + drivers/watchdog/sa1100_wdt.c | 1 + drivers/watchdog/sb_wdog.c| 1 + drivers/watchdog/sbc60xxwdt.c | 1 + drivers/watchdog/sbc7240_wdt.c| 1 + drivers/watchdog/sbc_epx_c3.c | 1 + drivers/watchdog/sbc_fitpc2_wdt.c | 1 + drivers/watchdog/sc1200wdt.c | 1 + drivers/watchdog/sc520_wdt.c | 1 + drivers/watchdog/sch311x_wdt.c| 1 + drivers/watchdog/scx200_wdt.c | 1 + drivers/watchdog/smsc37b787_wdt.c | 1 + drivers/watchdog/w83877f_wdt.c| 1 + drivers/watchdog/w83977f_wdt.c| 1 + drivers/watchdog/wafer5823wdt.c | 1 + drivers/watchdog/watchdog_dev.c | 1 + drivers/watchdog/wdrtas.c | 1 + drivers/watchdog/wdt.c| 1 + drivers/watchdog/wdt285.c | 1 + drivers/watchdog/wdt977.c | 1 + drivers/watchdog/wdt_pci.c| 1 + fs/compat_ioctl.c |
Re: [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision
> However, I'm not sure I'm supposed to do that. I went by > Documentation/i2c/instantiating-devices, which in "Method 2" says: > > The driver which instantiated the I2C device is responsible for destroying > it on cleanup. This is done by calling i2c_unregister_device() on the > pointer that was earlier returned by i2c_new_device() or > i2c_new_probed_device(). > > > So, what is preferred and why? What the documentation says is preferred. For consistency and because of the general "free what you allocated" rule. If we have arguments to change that for i2c_unregister_device(), we would need to do this tree-wide anyhow. Until then, the above is valid. signature.asc Description: PGP signature
Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Hi,
Thanks for the patch. It looks mostly good.
> +static int clock = 0x1c;
> +module_param(clock, int, 0444);
'clock' determines the bus speed?
> + i2c->adapter.class = I2C_CLASS_DEPRECATED;
This is only needed for drivers which used to have a class and decided
to drop it. You can leave it empty.
> + algo_data->data = (void *)i2c;
You don't need the cast, do you?
> +MODULE_LICENSE("GPL");
Your SPDX header says GPL 2.0 only.
Kind regards,
Wolfram
signature.asc
Description: PGP signature
Re: [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support
Hi Guenter, Thanks for your feedback! Reply below. On 08/13/2019 03:24 PM, Guenter Roeck wrote: > Sorry, I don't understand. Why exactly can't you replace > of_property_read_u32_array() > with device_property_read_u32_array() and use fwnode_create_software_node() > in the calling code to set the properties ? Thanks for this hint. Turns out wcove is the only user of fwnode_create_software_node(), and intel_cht_int33fe is the only other driver to contain the string "software_node". Please bear with us if we didn't know about this handy trick yet. And handy it is! device_property_read_*() is also really helpful to know about, as it covers both the DT case, as well as other firmware interfaces - thanks for the hint. Is there any reason to ever use of_property_read_*() anymore? I've applied your suggested changes, and will send another patch round soon (I want to try one last thing). Please let me/us know what you think once it's on the list. Max
Re: [PATCH 2/3] hwmon: raspberrypi: update MODULE_AUTHOR() email address
On Tue, Aug 13, 2019 at 08:17:28PM +0200, Stefan Wahren wrote:
> The email address listed in MODULE_AUTHOR() will be disabled in the
> near future. Replace it with my private one.
>
> Signed-off-by: Stefan Wahren
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/raspberrypi-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.7.4
>
> diff --git a/drivers/hwmon/raspberrypi-hwmon.c
> b/drivers/hwmon/raspberrypi-hwmon.c
> index efe4bb1..d3a64a3 100644
> --- a/drivers/hwmon/raspberrypi-hwmon.c
> +++ b/drivers/hwmon/raspberrypi-hwmon.c
> @@ -146,7 +146,7 @@ static struct platform_driver rpi_hwmon_driver = {
> };
> module_platform_driver(rpi_hwmon_driver);
>
> -MODULE_AUTHOR("Stefan Wahren ");
> +MODULE_AUTHOR("Stefan Wahren ");
> MODULE_DESCRIPTION("Raspberry Pi voltage sensor driver");
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:raspberrypi-hwmon");
PLEASE CONFIRM PURCHASE ORDER
Could you please confirm if your recieved our purchase order last week. If no please confirm let me resend it to you. NARESH KUMAR Executive Purchase Saiapextrading Ltd Dubai, KSA. (T/F): +96-2667-264 777 / 778 (Mo): +96 94284 02803 Website - http://www.saiapexgeneraltrading.com
