Re: [PATCH 2/2] hwmon: Remove multiple space after dot

[Randy Dunlap]

On 12/1/18 12:27 PM, Joe Perches wrote:
> On Thu, 2018-11-29 at 20:09 +, Corentin Labbe wrote:
>> This patch remove extra space after a dot.
> []
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> ---
>>  drivers/hwmon/Kconfig | 236 +-
>>  1 file changed, 118 insertions(+), 118 deletions(-)
> []
>> @@ -11,7 +11,7 @@ menuconfig HWMON
>>of a system. Most modern motherboards include such a device. It
>>can include temperature sensors, voltage sensors, fan speed
>>sensors and various additional features such as the ability to
>> -  control the speed of the fans.  If you want this support you
>> +  control the speed of the fans. If you want this support you
>>should say Y here and also to the specific driver(s) for your
>>sensors chip(s) below.
> 
> Please no.

Ack.  No need for such a patch.


-- 
~Randy

Re: [PATCH v5 03/10] Documentation: hwmon: Add OCC documentation

[Randy Dunlap]

On 08/30/2018 02:32 PM, Eddie James wrote:
> Document the hwmon interface for the OCC.
> 
> Signed-off-by: Eddie James 

Hi,
Please see comments below.

> ---
>  Documentation/hwmon/occ | 112 
> 
>  1 file changed, 112 insertions(+)
>  create mode 100644 Documentation/hwmon/occ
> 
> diff --git a/Documentation/hwmon/occ b/Documentation/hwmon/occ
> new file mode 100644
> index 000..adc2fa4
> --- /dev/null
> +++ b/Documentation/hwmon/occ
> @@ -0,0 +1,112 @@
> +Kernel driver occ-hwmon
> +===
> +
> +Supported chips:
> +  * POWER8
> +  * POWER9
> +
> +Author: Eddie James 
> +
> +Description
> +---
> +
> +This driver supports hardware monitoring for the On-Chip Controller (OCC)
> +embedded on POWER processors. The OCC is a device that collects and 
> aggregates
> +sensor data from the processor and the system. The OCC can provide the raw
> +sensor data as well as perform thermal and power management on the system.
> +
> +The P8 version of this driver is a client driver of I2C. It may be probed
> +manually if an "ibm,p8-occ-hwmon" compatible device is found under the
> +appropriate I2C bus node in the device-tree.
> +
> +The P9 version of this driver is a client driver of the FSI-based OCC driver.
> +It will be probed automatically by the FSI-based OCC driver.
> +
> +Sysfs entries
> +-
> +
> +The following attributes are supported. All attributes are read-only unless
> +specified.
> +
> +The OCC sensor ID is an integer that represents the unique identififer of the

  identifier

> +sensor with respect to the OCC. For example, a temperature sensor for the 3rd

prefer s/3rd/third/

> +DIMM slot in the system may have a sensor ID of 7. This mapping is 
> unavailable
> +to the device driver, which must therefore export the sensor ID as-is.
> +
> +Some entries are only present with certain OCC sensor versions or only on
> +certain OCCs in the system. The version number is not exported to the user
> +but can be inferred.

[snip]


-- 
~Randy

Re: [PATCH v7 08/12] mfd: intel-peci-client: Add PECI client MFD driver

[Randy Dunlap]

On 07/23/2018 02:47 PM, Jae Hyun Yoo wrote:
> This commit adds PECI client MFD driver.
> 
> Signed-off-by: Jae Hyun Yoo 
> Cc: Lee Jones 
> Cc: Rob Herring 
> Cc: Andrew Jeffery 
> Cc: James Feist 
> Cc: Jason M Biils 
> Cc: Joel Stanley 
> Cc: Vernon Mauery 
> ---
>  drivers/mfd/Kconfig   |  14 ++
>  drivers/mfd/Makefile  |   1 +
>  drivers/mfd/intel-peci-client.c   | 182 ++
>  include/linux/mfd/intel-peci-client.h |  81 
>  4 files changed, 278 insertions(+)
>  create mode 100644 drivers/mfd/intel-peci-client.c
>  create mode 100644 include/linux/mfd/intel-peci-client.h
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index f3fa516011ec..e38b591479d4 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -595,6 +595,20 @@ config MFD_INTEL_MSIC
> Passage) chip. This chip embeds audio, battery, GPIO, etc.
> devices used in Intel Medfield platforms.
>  
> +config MFD_INTEL_PECI_CLIENT
> + bool "Intel PECI client"
> + depends on (PECI || COMPILE_TEST)
> + select MFD_CORE
> + help
> +   If you say yes to this option, support will be included for the
> +   multi-funtional Intel PECI (Platform Environment Control Interface)

  multi-functional

> +   client. PECI is a one-wire bus interface that provides a communication
> +   channel from PECI clients in Intel processors and chipset components
> +   to external monitoring or control devices.
> +
> +   Additional drivers must be enabled in order to use the functionality
> +   of the device.
> +
>  config MFD_IPAQ_MICRO
>   bool "Atmel Micro ASIC (iPAQ h3100/h3600/h3700) Support"
>   depends on SA1100_H3100 || SA1100_H3600


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: Add a document for PECI hwmon client driver

[Randy Dunlap]

Hi,

On 02/21/2018 08:16 AM, Jae Hyun Yoo wrote:

> +temp_labelProvides DDR DIMM temperature if this label 
> indicates
> + 'DIMM #'.
> +temp_inputProvides current temperature of the DDR DIMM.
> +
> +Note:
> + DIMM temperature group will be appeared when the client CPU's BIOS

   will appear when

> + completes memory training and testing.
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC 2/4] mfd: add Gateworks System Controller core driver

[Randy Dunlap]

On 02/27/2018 05:21 PM, Tim Harvey wrote:
> The Gateworks System Controller (GSC) is an I2C slave controller
> implemented with an MSP430 micro-controller whose firmware embeds the
> following features:
>  - I/O expander (16 GPIO's) using PCA955x protocol
>  - Real Time Clock using DS1672 protocol
>  - User EEPROM using AT24 protocol
>  - HWMON using custom protocol
>  - Interrupt controller with tamper detect, user pushbotton
>  - Watchdog controller capable of full board power-cycle
>  - Power Control capable of full board power-cycle
> 
> see http://trac.gateworks.com/wiki/gsc for more details
> 
> Signed-off-by: Tim Harvey 
> ---
>  drivers/mfd/Kconfig |  10 ++
>  drivers/mfd/Makefile|   1 +
>  drivers/mfd/gsc.c   | 330 
> 
>  include/linux/mfd/gsc.h |  79 
>  4 files changed, 420 insertions(+)
>  create mode 100644 drivers/mfd/gsc.c
>  create mode 100644 include/linux/mfd/gsc.h
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1d20a80..16dd486 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -341,6 +341,16 @@ config MFD_EXYNOS_LPASS
> Select this option to enable support for Samsung Exynos Low Power
> Audio Subsystem.
>  
> +config MFD_GSC
> + tristate "Gateworks System Controller"
> + depends on (I2C && OF) || COMPILE_TEST

Do both I2C and OF have stubs so that a driver will build when they are
both disabled?  I.e., only COMPILE_TEST is enabled?


> + select MFD_CORE
> + select REGMAP_I2C
> + select REGMAP_IRQ
> + help
> +   Enable support for the Gateworks System Controller found
> +   on Gateworks Single Board Computers.
> +
>  config MFD_MC13XXX
>   tristate
>   depends on (SPI_MASTER || I2C)
thanks,
-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hwmon/coretemp: requires CONFIG_PCI

[Randy Dunlap]

On 11/28/2017 01:41 PM, Guenter Roeck wrote:
> On Tue, Nov 28, 2017 at 09:39:02AM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdun...@infradead.org>
>>
>> Fix coretemp.c build when CONFIG_PCI is not enabled.
>> Fixes these build errors:
>>
>> ../drivers/hwmon/coretemp.c: In function 'adjust_tjmax':
>> ../drivers/hwmon/coretemp.c:250:9: error: implicit declaration of function 
>> 'pci_get_domain_bus_and_slot' [-Werror=implicit-function-declaration]
>>   struct pci_dev *host_bridge = pci_get_domain_bus_and_slot(0, 0, devfn);
>> ../drivers/hwmon/coretemp.c:250:32: warning: initialization makes pointer 
>> from integer without a cast [enabled by default]
>>   struct pci_dev *host_bridge = pci_get_domain_bus_and_slot(0, 0, devfn);
>>
> 
> nack, sorry.

No problem.

> The dependency is artificial, and the code using it is only needed for old
> CPUs. There should be a dummy function for pci_get_domain_bus_and_slot()
> if PCI is disabled, similar to pci_get_bus_and_slot() and all the other
> pci functions. If that is unacceptable for some reason, I rather revert
> the patch introducing the use of pci_get_domain_bus_and_slot().

I sent a patch with that function stub addition.

> After all, it doesn't add any real value to enforce the use of
> pci_get_domain_bus_and_slot() in the driver, a dummy function for
> pci_get_bus_and_slot() _is_ available, and the new function is quite
> obviously not a 1:1 replacement of pci_get_bus_and_slot().
> 
> Guenter
> 
>> Signed-off-by: Randy Dunlap <rdun...@infradead.org>
>> Cc: Rudolf Marek <r.ma...@assembler.cz>
>> Cc: Jean Delvare <jdelv...@suse.com>
>> Cc: Guenter Roeck <li...@roeck-us.net>
>> Cc: linux-hwmon@vger.kernel.org
>> Cc: Fenghua Yu <fenghua...@intel.com>
>> Cc: Thomas Gleixner <t...@linutronix.de>
>> ---
>>  drivers/hwmon/Kconfig |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] hwmon/coretemp: requires CONFIG_PCI

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Fix coretemp.c build when CONFIG_PCI is not enabled.
Fixes these build errors:

../drivers/hwmon/coretemp.c: In function 'adjust_tjmax':
../drivers/hwmon/coretemp.c:250:9: error: implicit declaration of function 
'pci_get_domain_bus_and_slot' [-Werror=implicit-function-declaration]
  struct pci_dev *host_bridge = pci_get_domain_bus_and_slot(0, 0, devfn);
../drivers/hwmon/coretemp.c:250:32: warning: initialization makes pointer from 
integer without a cast [enabled by default]
  struct pci_dev *host_bridge = pci_get_domain_bus_and_slot(0, 0, devfn);

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: Rudolf Marek <r.ma...@assembler.cz>
Cc: Jean Delvare <jdelv...@suse.com>
Cc: Guenter Roeck <li...@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Cc: Fenghua Yu <fenghua...@intel.com>
Cc: Thomas Gleixner <t...@linutronix.de>
---
 drivers/hwmon/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-415-rc1.orig/drivers/hwmon/Kconfig
+++ lnx-415-rc1/drivers/hwmon/Kconfig
@@ -631,7 +631,7 @@ config SENSORS_I5500
 
 config SENSORS_CORETEMP
tristate "Intel Core/Core2/Atom temperature sensor"
-   depends on X86
+   depends on X86 && PCI
help
  If you say yes here you get support for the temperature
  sensor inside your CPU. Most of the family 6 CPUs

--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html