Re: [PATCH v2] hwmon: (lm92) Add max6635 to lm92_id[]

2018-03-22 Thread Guenter Roeck 
On Thu, Mar 22, 2018 at 04:56:17PM +0100, Jean Delvare wrote:
> On Thu, 22 Mar 2018 15:37:44 +0100, Alvaro Gamez Machado wrote:
> > Since autodetection of this chip was removed, it makes sense to add prefix
> > max6635 so that the device can be instantiated by its actual name.
> > 
> > Signed-off-by: Alvaro Gamez Machado 

Never mind my previous comment. I'll take this patch instead.

Thanks,
Guenter

> > ---
> > Differences:
> > * Update also Documentation/hwmon/lm92 with new prefix to use
> > 
> >  Documentation/hwmon/lm92 | 2 +-
> >  drivers/hwmon/lm92.c | 5 +++--
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/lm92 b/Documentation/hwmon/lm92
> > index f2a5adcf4ead..cfa99a353b8c 100644
> > --- a/Documentation/hwmon/lm92
> > +++ b/Documentation/hwmon/lm92
> > @@ -11,7 +11,7 @@ Supported chips:
> >  Addresses scanned: none, force parameter needed
> >  Datasheet: http://www.national.com/pf/LM/LM76.html
> >* Maxim MAX6633/MAX6634/MAX6635
> > -Prefix: 'lm92'
> > +Prefix: 'max6635'
> >  Addresses scanned: none, force parameter needed
> >  Datasheet: http://www.maxim-ic.com/quick_view2.cfm/qv_pk/3074
> >  
> > diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c
> > index 18509b5af11e..d40fe5122e94 100644
> > --- a/drivers/hwmon/lm92.c
> > +++ b/drivers/hwmon/lm92.c
> > @@ -52,6 +52,7 @@
> >   */
> >  static const unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b,
> > I2C_CLIENT_END };
> > +enum chips { lm92, max6635 };
> >  
> >  /* The LM92 registers */
> >  #define LM92_REG_CONFIG0x01 /* 8-bit, RW */
> > @@ -329,8 +330,8 @@ static int lm92_probe(struct i2c_client *new_client,
> >   */
> >  
> >  static const struct i2c_device_id lm92_id[] = {
> > -   { "lm92", 0 },
> > -   /* max6635 could be added here */
> > +   { "lm92", lm92 },
> > +   { "max6635", max6635 },
> > { }
> >  };
> >  MODULE_DEVICE_TABLE(i2c, lm92_id);
> 
> Reviewed-by: Jean Delvare 
> 
> -- 
> Jean Delvare
> SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hwmon: (lm92) Add max6635 to lm92_id[]

2018-03-22 Thread Jean Delvare 
On Thu, 22 Mar 2018 15:37:44 +0100, Alvaro Gamez Machado wrote:
> Since autodetection of this chip was removed, it makes sense to add prefix
> max6635 so that the device can be instantiated by its actual name.
> 
> Signed-off-by: Alvaro Gamez Machado 
> ---
> Differences:
>   * Update also Documentation/hwmon/lm92 with new prefix to use
> 
>  Documentation/hwmon/lm92 | 2 +-
>  drivers/hwmon/lm92.c | 5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/hwmon/lm92 b/Documentation/hwmon/lm92
> index f2a5adcf4ead..cfa99a353b8c 100644
> --- a/Documentation/hwmon/lm92
> +++ b/Documentation/hwmon/lm92
> @@ -11,7 +11,7 @@ Supported chips:
>  Addresses scanned: none, force parameter needed
>  Datasheet: http://www.national.com/pf/LM/LM76.html
>* Maxim MAX6633/MAX6634/MAX6635
> -Prefix: 'lm92'
> +Prefix: 'max6635'
>  Addresses scanned: none, force parameter needed
>  Datasheet: http://www.maxim-ic.com/quick_view2.cfm/qv_pk/3074
>  
> diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c
> index 18509b5af11e..d40fe5122e94 100644
> --- a/drivers/hwmon/lm92.c
> +++ b/drivers/hwmon/lm92.c
> @@ -52,6 +52,7 @@
>   */
>  static const unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b,
>   I2C_CLIENT_END };
> +enum chips { lm92, max6635 };
>  
>  /* The LM92 registers */
>  #define LM92_REG_CONFIG  0x01 /* 8-bit, RW */
> @@ -329,8 +330,8 @@ static int lm92_probe(struct i2c_client *new_client,
>   */
>  
>  static const struct i2c_device_id lm92_id[] = {
> - { "lm92", 0 },
> - /* max6635 could be added here */
> + { "lm92", lm92 },
> + { "max6635", max6635 },
>   { }
>  };
>  MODULE_DEVICE_TABLE(i2c, lm92_id);

Reviewed-by: Jean Delvare 

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] hwmon: (lm92) Add max6635 to lm92_id[]

2018-03-22 Thread Alvaro Gamez Machado 
Since autodetection of this chip was removed, it makes sense to add prefix
max6635 so that the device can be instantiated by its actual name.

Signed-off-by: Alvaro Gamez Machado 
---
Differences:
* Update also Documentation/hwmon/lm92 with new prefix to use

 Documentation/hwmon/lm92 | 2 +-
 drivers/hwmon/lm92.c | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/hwmon/lm92 b/Documentation/hwmon/lm92
index f2a5adcf4ead..cfa99a353b8c 100644
--- a/Documentation/hwmon/lm92
+++ b/Documentation/hwmon/lm92
@@ -11,7 +11,7 @@ Supported chips:
 Addresses scanned: none, force parameter needed
 Datasheet: http://www.national.com/pf/LM/LM76.html
   * Maxim MAX6633/MAX6634/MAX6635
-Prefix: 'lm92'
+Prefix: 'max6635'
 Addresses scanned: none, force parameter needed
 Datasheet: http://www.maxim-ic.com/quick_view2.cfm/qv_pk/3074
 
diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c
index 18509b5af11e..d40fe5122e94 100644
--- a/drivers/hwmon/lm92.c
+++ b/drivers/hwmon/lm92.c
@@ -52,6 +52,7 @@
  */
 static const unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b,
I2C_CLIENT_END };
+enum chips { lm92, max6635 };
 
 /* The LM92 registers */
 #define LM92_REG_CONFIG0x01 /* 8-bit, RW */
@@ -329,8 +330,8 @@ static int lm92_probe(struct i2c_client *new_client,
  */
 
 static const struct i2c_device_id lm92_id[] = {
-   { "lm92", 0 },
-   /* max6635 could be added here */
+   { "lm92", lm92 },
+   { "max6635", max6635 },
{ }
 };
 MODULE_DEVICE_TABLE(i2c, lm92_id);
-- 
2.16.2

--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html