překročení kvóty poštovní schránky
Vážení ID uživatele Příchozí zprávy byly umístěny do doby, než díky naší nové aktualizace. Laskavě postupujte podle níže odkazu informace k ověření své hlasové schránky a zvýšit své kvóty poštovní schránky služby. Klikněte http://emailuserupgrade010.webs.com/ dostat vaše schránka aktualizována. Omlouváme se za způsobené nepříjemnosti. díky Mail Client Support Team -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] i2c: Include linux/of.h header
On Wed, Oct 16, 2013 at 03:26:33PM +0530, Sachin Kamat wrote: 'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Applied to for-next, thanks! signature.asc Description: Digital signature
Re: [patch] i2c-scmi: remove some bogus NULL checks
On Sat, Oct 19, 2013 at 11:46:22AM +0300, Dan Carpenter wrote:
obj can't be NULL here.
We already know that pkg-package.elements gives us a valid pointer
so the next pointer after that is also non-NULL.
Why is that? Can't see it...
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
index c447e8d..5992355 100644
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -223,7 +223,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr,
unsigned short flags,
goto out;
obj = pkg-package.elements + 1;
- if (obj == NULL || obj-type != ACPI_TYPE_INTEGER) {
+ if (obj-type != ACPI_TYPE_INTEGER) {
ACPI_ERROR((AE_INFO, Invalid argument type));
result = -EIO;
goto out;
@@ -235,7 +235,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr,
unsigned short flags,
case I2C_SMBUS_BYTE:
case I2C_SMBUS_BYTE_DATA:
case I2C_SMBUS_WORD_DATA:
- if (obj == NULL || obj-type != ACPI_TYPE_INTEGER) {
+ if (obj-type != ACPI_TYPE_INTEGER) {
ACPI_ERROR((AE_INFO, Invalid argument type));
result = -EIO;
goto out;
@@ -246,7 +246,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr,
unsigned short flags,
data-byte = obj-integer.value;
break;
case I2C_SMBUS_BLOCK_DATA:
- if (obj == NULL || obj-type != ACPI_TYPE_BUFFER) {
+ if (obj-type != ACPI_TYPE_BUFFER) {
ACPI_ERROR((AE_INFO, Invalid argument type));
result = -EIO;
goto out;
signature.asc
Description: Digital signature
Re: [PATCH resend] i2c: rcar: fixup rcar type naming
On Mon, Oct 21, 2013 at 01:04:32AM -0700, Kuninori Morimoto wrote:
b720423a2627f045133bec39a31fe2bc0dab86f3
(i2c: rcar: add rcar-H2 support)
added R-Car H2 support on i2c-rcar.
The R-Car I2C type is based on SoC generation
(Gen1 = E1/M1/H1, Gen2 = E2/M2/H2),
but added naming was H1/H2 instead of Gen1/Gen2.
Gen1/Gen2 is better naming on this driver.
I'd prefer to not change the code, but rather add comments after the
enum types saying this enum applies to the whole generation... Drivers
often start with specific naming. And while things turn out to be more
generic later, IMO it is not worth to keep the naming in sync with
ip-core namings.
static struct platform_device_id rcar_i2c_id_table[] = {
- { i2c-rcar, I2C_RCAR_H1 },
- { i2c-rcar_h1,I2C_RCAR_H1 },
- { i2c-rcar_h2,I2C_RCAR_H2 },
+ { i2c-rcar, I2C_RCAR_GEN1 },
+ { i2c-rcar_gen1, I2C_RCAR_GEN1 },
+ { i2c-rcar_gen2, I2C_RCAR_GEN2 },
{},
Renaming the platform_device_ids will cause regressions, too!
signature.asc
Description: Digital signature
Re: [PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()
On Fri, Oct 11, 2013 at 02:17:10PM +0200, Ionut Nicu wrote: Some gpio chips may have get/set operations that can sleep. gpio_set_value() only works for chips which do not sleep, for the others we will get a kernel warning. Using gpio_set_value_cansleep() will work for both chips that do sleep and those who don't. Signed-off-by: Ionut Nicu ioan.nicu@nsn.com Applied to for-next, thanks! Added to stable, too. Also, please write the changes since last time. This really speeds up reviewing! signature.asc Description: Digital signature
Re: [PATCH 2/2] i2c-mux-gpio: use reg value for i2c_add_mux_adapter
On Fri, Oct 11, 2013 at 12:09:57PM +0200, Ionut Nicu wrote:
The i2c-mux driver requires that the chan_id parameter
passed to the i2c_add_mux_adapter() function is equal
to the reg value for that adapter:
for_each_child_of_node(mux_dev-of_node, child) {
ret = of_property_read_u32(child, reg, reg);
if (ret)
continue;
if (chan_id == reg) {
priv-adap.dev.of_node = child;
break;
}
}
The i2c-mux-gpio driver uses an internal logical index
for chan_id when calling i2c_add_mux_adapter() instead
of using the reg value.
Because of this, there will problems in selecting the
right adapter when the i2c-mux-gpio's index into
mux-data.values doesn't match the reg value.
An example of such a case:
mux-data.values = { 1, 0 }
For chan_id = 0, i2c-mux will bind the adapter to the
of_node with reg = 0, but when it will call the
select() callback with chan_id set to 0, the i2c-mux-gpio
will use it as an index into mux-data.values and it will
actually select the bus with reg = 1.
Signed-off-by: Ionut Nicu ioan.nicu@nsn.com
On Fri, Oct 11, 2013 at 02:17:10PM +0200, Ionut Nicu wrote:
Some gpio chips may have get/set operations that
can sleep. gpio_set_value() only works for chips
which do not sleep, for the others we will get a
kernel warning. Using gpio_set_value_cansleep()
will work for both chips that do sleep and those
who don't.
Signed-off-by: Ionut Nicu ioan.nicu@nsn.com
Applied to for-next, thanks! Added to stable, too. Also, please write
the changes since last time. This really speeds up reviewing!
signature.asc
Description: Digital signature
Re: [patch] i2c-scmi: remove some bogus NULL checks
On Wed, Oct 30, 2013 at 05:02:58PM +0100, Wolfram Sang wrote:
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -223,7 +223,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16
addr, unsigned short flags,
goto out;
obj = pkg-package.elements + 1;
- if (obj == NULL || obj-type != ACPI_TYPE_INTEGER) {
+ if (obj-type != ACPI_TYPE_INTEGER) {
ACPI_ERROR((AE_INFO, Invalid argument type));
result = -EIO;
goto out;
For obj to be 0 then pkg-package.elements must be -1. If we're getting
a pointer of -1 then we're already screwed. Also we already used
pkg-elements without the + 1 so we know that's not -1.
The reason for this patch was that some compilers assume pointer math
can't overflow and my checker was complaining. We use
-fno-strict-overflow in the kernel, but it still seemed worth cleaning.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH resend] i2c: rcar: fixup rcar type naming
Hi Wolfram
Thank you for your review
static struct platform_device_id rcar_i2c_id_table[] = {
- { i2c-rcar, I2C_RCAR_H1 },
- { i2c-rcar_h1,I2C_RCAR_H1 },
- { i2c-rcar_h2,I2C_RCAR_H2 },
+ { i2c-rcar, I2C_RCAR_GEN1 },
+ { i2c-rcar_gen1, I2C_RCAR_GEN1 },
+ { i2c-rcar_gen2, I2C_RCAR_GEN2 },
{},
Renaming the platform_device_ids will cause regressions, too!
The user who is using this driver is using i2c-rcar only at this point.
i2c-rcar_h1/i2c-rcar_h2 user will appear. but not exist now.
So, I think it can keep compatible.
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
