RE: [PATCH V6 6/6] dts/ls1043a: add LS1043ARDB board support
> -Original Message- > From: pku@gmail.com [mailto:pku@gmail.com] On Behalf Of Li Yang > Sent: 2015年10月30日 4:33 > To: Hou Zhiqiang-B48286 > Cc: linux-arm-ker...@lists.infradead.org; Catalin Marinas; Will Deacon; > linux-i2c@vger.kernel.org; linux-watch...@vger.kernel.org; linux- > d...@vger.kernel.org; linux-...@vger.kernel.org; Mark Rutland; Xie > Shaohui-B21989; Jonathan Corbet; Sharma Bhupesh-B45370; Michael Turquette; > w...@the-dreams.de; sb...@codeaurora.org; w...@iguana.be; Song Wenbin- > B53747; Wood Scott-B07421; Hu Mingkai-B21284; li...@roeck-us.net > Subject: Re: [PATCH V6 6/6] dts/ls1043a: add LS1043ARDB board support > > On Fri, Oct 23, 2015 at 3:01 AM, Zhiqiang Hou <b48...@freescale.com> > wrote: > > From: Shaohui Xie <shaohui@freescale.com> > > > > Signed-off-by: Shaohui Xie <shaohui@freescale.com> > > Signed-off-by: Mingkai Hu <mingkai...@freescale.com> > > Signed-off-by: Wenbin Song <wenbin.s...@freescale.com> > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > --- > > V6: V5 V4 V3 > > - No change. > > > > V2: > > - Remove the useless compatible "simple-bus" from cpld node. > > > > arch/arm64/boot/dts/freescale/Makefile| 2 +- > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 116 > > ++ > > 2 files changed, 117 insertions(+), 1 deletion(-) create mode 100644 > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile > > index 57b41c7..33b1e57 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -1,4 +1,4 @@ > > -dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb > > fsl-ls2080a-rdb.dtb fsl-ls2080a-simu.dtb > > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-qds.dtb > > +fsl-ls2080a-rdb.dtb fsl-ls2080a-simu.dtb fsl-ls1043a-rdb.dtb > > I tried to apply the patch, but it can not be applied due to the change > from a depending ls2080 patch. I will help to respin this patch and > resend the three device tree related patches. ok. Thanks, Zhiqiang
RE: [PATCH V5 1/6] i2c: Add i2c support to Freescale Layerscape platforms
> -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: 2015年10月20日 23:53 > To: Hou Zhiqiang-B48286 > Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org; mark.rutl...@arm.com; li...@roeck-us.net; > w...@iguana.be; cor...@lwn.net; mturque...@baylibre.com; > sb...@codeaurora.org; Hu Mingkai-B21284; Xie Shaohui-B21989; Wood Scott- > B07421; Sharma Bhupesh-B45370; Song Wenbin-B53747 > Subject: Re: [PATCH V5 1/6] i2c: Add i2c support to Freescale Layerscape > platforms > > On Mon, Oct 19, 2015 at 07:56:09PM +0800, Zhiqiang Hou wrote: > > From: Shaohui Xie <shaohui@freescale.com> > > > > Modify the I2C_IMX config to support to Layerscape platforms. > > > > Signed-off-by: Mingkai Hu <mingkai...@freescale.com> > > Signed-off-by: Wenbin Song <wenbin.s...@freescale.com> > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > Three signed offs for a simple Kconfig change? And the person doing the > patch has no signed off?? That looks wrong. Maybe the above signed offs > should be acked by? > Will add the signed-off of the author. Thanks, Zhiqiang
RE: [PATCH V4 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
> -Original Message- > From: Sharma Bhupesh-B45370 > Sent: 2015年10月16日 13:12 > To: Hou Zhiqiang-B48286; Wood Scott-B07421 > Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org; mark.rutl...@arm.com; li...@roeck-us.net; wsa@the- > dreams.de; w...@iguana.be; cor...@lwn.net; mturque...@baylibre.com; > sb...@codeaurora.org; Hu Mingkai-B21284; Xie Shaohui-B21989; Song Wenbin- > B53747; Li Yang-Leo-R58472 > Subject: RE: [PATCH V4 4/6] arm64/ls1043a: add DTS for Freescale LS1043A > SoC > > > From: Hou Zhiqiang-B48286 > > Sent: Friday, October 16, 2015 9:07 AM > > > > > > > -Original Message----- > > > From: Wood Scott-B07421 > > > Sent: 2015年10月16日 4:46 > > > To: Hou Zhiqiang-B48286 > > > Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > > > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > > > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > > > c...@vger.kernel.org; mark.rutl...@arm.com; li...@roeck-us.net; > > > wsa@the- dreams.de; w...@iguana.be; cor...@lwn.net; > > > mturque...@baylibre.com; sb...@codeaurora.org; Hu Mingkai-B21284; > > > Xie Shaohui-B21989; Sharma Bhupesh-B45370; Song Wenbin-B53747; Li > > > Yang-Leo-R58472; Sharma Bhupesh- > > > B45370 > > > Subject: Re: [PATCH V4 4/6] arm64/ls1043a: add DTS for Freescale > > > LS1043A SoC > > > > > > On Thu, 2015-10-15 at 20:12 +0800, Zhiqiang Hou wrote: > > > > From: Mingkai Hu <mingkai...@freescale.com> > > > > > > > > LS1043a is an SoC with 4 ARMv8 A53 cores and most other IP blocks > > > > similar to LS1021a which complies to Chassis 2.1 spec. > > > > > > > > Following levels of DTSI/DTS files have been created for the > > > > LS1043A SoC family: > > > > > > > > - fsl-ls1043a.dtsi: > > > > DTS-Include file for FSL LS1043A SoC. > > > > > > > > Signed-off-by: Li Yang <le...@freescale.com> > > > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > > > Signed-off-by: Mingkai Hu <mingkai...@freescale.com> > > > > Signed-off-by: Wenbin Song <wenbin.s...@freescale.com> > > > > --- > > > > V4: > > > > - Add soc node with simple-bus compatible. > > > > - Add property interrupt-affinity for armv8 pmuv3 node. > > > > > > > > V3: > > > > - Add device tree node for SATA. > > > > - Remove properity enable-method for all cpu node. > > > >Remove reserved memory region for spin-table. > > > > > > > > V2: > > > > - Add secondary core boot method. > > > > - Move out the sysclk node from the clockgen node. > > > > - Correct the reg size of GICC. > > > > > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 525 > > > > + > > > > 1 file changed, 525 insertions(+) create mode 100644 > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > > > new file mode 100644 > > > > index 000..1a5bf79 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > > > @@ -0,0 +1,525 @@ > > > > +/* > > > > + * Device Tree Include file for Freescale Layerscape-1043A family > > SoC. > > > > + * > > > > + * Copyright 2014-2015, Freescale Semiconductor > > > > + * > > > > + * Mingkai Hu <mingkai...@freescale.com> > > > > + * > > > > + * This file is dual-licensed: you can use it either under the > > > > +terms > > > > + * of the GPLv2 or the X11 license, at your option. Note that > > > > +this dual > > > > + * licensing only applies to this file, and not this project as a > > > > + * whole. > > > > + * > > > > + * a) This library is free software; you can redistribute it > and/or > > > > + * modify it under the terms of the GNU General Public License > > as > > > > + * published by the Free Software Foundation; either version 2 > > of > > > the > > >
RE: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
> -Original Message- > From: Wood Scott-B07421 > Sent: 2015年10月15日 11:57 > To: Hou Zhiqiang-B48286 > Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org; mark.rutl...@arm.com; Hu Mingkai-B21284; Xie > Shaohui-B21989; Sharma Bhupesh-B45370; Li Yang-Leo-R58472; wsa@the- > dreams.de; w...@iguana.be; cor...@lwn.net; mturque...@baylibre.com; > sb...@codeaurora.org; Song Wenbin-B53747 > Subject: Re: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A > SoC > > On Wed, 2015-10-14 at 19:34 +0800, Zhiqiang Hou wrote: > > From: Mingkai Hu <mingkai...@freescale.com> > > > > LS1043a is an SoC with 4 ARMv8 A53 cores and most other IP blocks > > similar to LS1021a which complies to Chassis 2.1 spec. > > > > Following levels of DTSI/DTS files have been created for the LS1043A > > SoC family: > > > > - fsl-ls1043a.dtsi: > > DTS-Include file for FSL LS1043A SoC. > > > > Signed-off-by: Li Yang <le...@freescale.com> > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > Signed-off-by: Mingkai Hu <mingkai...@freescale.com> > > Signed-off-by: Wenbin Song <wenbin.s...@freescale.com> > > --- > > V3: > > - Add device tree node for SATA. > > - Remove properity enable-method for all cpu node. > >Remove reserved memory region for spin-table. > > > > V2: > > - Add secondary core boot method. > > - Move out the sysclk node from the clockgen node. > > - Correct the reg size of GICC. > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 513 > > + > > 1 file changed, 513 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > On the ls208x device tree we were asked to put devices under a bus node, > such as an soc node with a simple-bus compatible. > Thanks, will reform. Thanks, Zhiqiang
RE: [PATCH V4 5/6] clk: qoriq: Add ls1043a support.
> -Original Message- > From: Stephen Boyd [mailto:sb...@codeaurora.org] > Sent: 2015年10月16日 2:02 > To: Hou Zhiqiang-B48286 > Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org; mark.rutl...@arm.com; li...@roeck-us.net; wsa@the- > dreams.de; w...@iguana.be; cor...@lwn.net; mturque...@baylibre.com; Hu > Mingkai-B21284; Xie Shaohui-B21989; Wood Scott-B07421; Sharma Bhupesh- > B45370; Song Wenbin-B53747 > Subject: Re: [PATCH V4 5/6] clk: qoriq: Add ls1043a support. > > On 10/15, Zhiqiang Hou wrote: > > From: Hou Zhiqiang <b48...@freescale.com> > > > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > --- > > This patch has been acked in V3 by Stephen Boyd [sb...@codeaurora.org]. > > Yes, please add it into the patches that you send instead of putting it > below the --- line. Ok, thanks. Zhiqiang
RE: [PATCH V4 2/6] watchdog: Add support for Freescale Layerscape platforms
> -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2015年10月15日 22:25 > To: Hou Zhiqiang-B48286; linux-arm-ker...@lists.infradead.org; > catalin.mari...@arm.com; will.dea...@arm.com; linux-i2c@vger.kernel.org; > linux-watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org > Cc: mark.rutl...@arm.com; w...@the-dreams.de; w...@iguana.be; > cor...@lwn.net; mturque...@baylibre.com; sb...@codeaurora.org; Hu > Mingkai-B21284; Xie Shaohui-B21989; Wood Scott-B07421; Sharma Bhupesh- > B45370; Song Wenbin-B53747 > Subject: Re: [PATCH V4 2/6] watchdog: Add support for Freescale > Layerscape platforms > > On 10/15/2015 05:12 AM, Zhiqiang Hou wrote: > > From: Shaohui Xie <shaohui@freescale.com> > > > > Modify watchdog/Kconfig file to support Layerscape platforms. > > > > Signed-off-by: Shaohui Xie <shaohui@freescale.com> > > Signed-off-by: Wenbin Song <wenbin.s...@freescale.com> > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > --- > > This patch has been acked in V3 by Guenter Roeck [li...@roeck-us.net]. > > > Here it is again, but if there is no change, please just add the Ack to > subsequent versions of the patch. > Ok, thanks. > Acked-by: Guenter Roeck <li...@roeck-us.net> > > > > V4: V3 V2 > > - No change. > > > > drivers/watchdog/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index > > 79e1aa1..448dbaf 100644 > > --- a/drivers/watchdog/Kconfig > > +++ b/drivers/watchdog/Kconfig > > @@ -446,7 +446,7 @@ config MAX63XX_WATCHDOG > > > > config IMX2_WDT > > tristate "IMX2+ Watchdog" > > - depends on ARCH_MXC > > + depends on ARCH_MXC || ARCH_LAYERSCAPE > > select REGMAP_MMIO > > select WATCHDOG_CORE > > help > > Thanks, Zhiqiang
RE: [PATCH V4 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
> -Original Message- > From: Wood Scott-B07421 > Sent: 2015年10月16日 4:46 > To: Hou Zhiqiang-B48286 > Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org; mark.rutl...@arm.com; li...@roeck-us.net; wsa@the- > dreams.de; w...@iguana.be; cor...@lwn.net; mturque...@baylibre.com; > sb...@codeaurora.org; Hu Mingkai-B21284; Xie Shaohui-B21989; Sharma > Bhupesh-B45370; Song Wenbin-B53747; Li Yang-Leo-R58472; Sharma Bhupesh- > B45370 > Subject: Re: [PATCH V4 4/6] arm64/ls1043a: add DTS for Freescale LS1043A > SoC > > On Thu, 2015-10-15 at 20:12 +0800, Zhiqiang Hou wrote: > > From: Mingkai Hu <mingkai...@freescale.com> > > > > LS1043a is an SoC with 4 ARMv8 A53 cores and most other IP blocks > > similar to LS1021a which complies to Chassis 2.1 spec. > > > > Following levels of DTSI/DTS files have been created for the LS1043A > > SoC family: > > > > - fsl-ls1043a.dtsi: > > DTS-Include file for FSL LS1043A SoC. > > > > Signed-off-by: Li Yang <le...@freescale.com> > > Signed-off-by: Hou Zhiqiang <b48...@freescale.com> > > Signed-off-by: Mingkai Hu <mingkai...@freescale.com> > > Signed-off-by: Wenbin Song <wenbin.s...@freescale.com> > > --- > > V4: > > - Add soc node with simple-bus compatible. > > - Add property interrupt-affinity for armv8 pmuv3 node. > > > > V3: > > - Add device tree node for SATA. > > - Remove properity enable-method for all cpu node. > >Remove reserved memory region for spin-table. > > > > V2: > > - Add secondary core boot method. > > - Move out the sysclk node from the clockgen node. > > - Correct the reg size of GICC. > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 525 > > + > > 1 file changed, 525 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > new file mode 100644 > > index 000..1a5bf79 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > @@ -0,0 +1,525 @@ > > +/* > > + * Device Tree Include file for Freescale Layerscape-1043A family SoC. > > + * > > + * Copyright 2014-2015, Freescale Semiconductor > > + * > > + * Mingkai Hu <mingkai...@freescale.com> > > + * > > + * This file is dual-licensed: you can use it either under the terms > > + * of the GPLv2 or the X11 license, at your option. Note that this > > +dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + * a) This library is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation; either version 2 of > the > > + * License, or (at your option) any later version. > > + * > > + * This library is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * Or, alternatively, > > + * > > + * b) Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without > > + * restriction, including without limitation the rights to use, > > + * copy, modify, merge, publish, distribute, sublicense, and/or > > + * sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following > > + * conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > > +
RE: [PATCH V3 0/6] Add LS1043A SoC support
Hi all, Sorry for my late response due to Chinese National Day holidays. > From: Zhiqiang Hou [mailto:b48...@freescale.com] > Sent: Wednesday, October 14, 2015 7:35 PM > To: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com; > will.dea...@arm.com; linux-i2c@vger.kernel.org; linux- > watch...@vger.kernel.org; linux-...@vger.kernel.org; linux- > c...@vger.kernel.org; mark.rutl...@arm.com > Cc: Hu Mingkai-B21284; Xie Shaohui-B21989; Wood Scott-B07421; Sharma > Bhupesh-B45370; Li Yang-Leo-R58472; w...@the-dreams.de; w...@iguana.be; > cor...@lwn.net; mturque...@baylibre.com; sb...@codeaurora.org; Song > Wenbin-B53747 > Subject: [PATCH V3 0/6] Add LS1043A SoC support > > This patchest adds support for Freescale's LS1043A SoC which is based on > ARMv8 architecture. > > Some pending patches are depended on: > 1. The LS1043A is belong to Freescale's ARMv8 Layerscape SoC family, so > depends on the updating ARCH kconfig patch. > https://patchwork.kernel.org/patch/7120101/ > > 2. The LS1043A use the new clockgen binding updated by Scott Wood, > depends on the patchset: > https://patchwork.kernel.org/patch/7225421/ > https://patchwork.kernel.org/patch/7225461/ > https://patchwork.kernel.org/patch/7225431/ > https://patchwork.kernel.org/patch/7225441/ > https://patchwork.kernel.org/patch/7225451/ > > [PATCH V3 1/6] i2c: Add i2c support to Freescale Layerscape platforms > [PATCH V3 2/6] watchdog: Add support for Freescale Layerscape [PATCH V3 > 3/6] Documentation: DT: Add entry for FSL LS1043ARDB board [PATCH V3 4/6] > arm64/ls1043a: add DTS for Freescale LS1043A SoC [PATCH V3 5/6] clk: > qoriq: Add ls1043a support. > [PATCH V3 6/6] dts/ls1043a: add LS1043ARDB board support Thanks, Zhiqiang -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
> -Original Message-
> From: Mark Rutland [mailto:mark.rutl...@arm.com]
> Sent: 2015年10月14日 20:44
> To: Hou Zhiqiang-B48286
> Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com;
> will.dea...@arm.com; linux-i2c@vger.kernel.org; linux-
> watch...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> c...@vger.kernel.org; Hu Mingkai-B21284; Xie Shaohui-B21989; Wood Scott-
> B07421; Sharma Bhupesh-B45370; Li Yang-Leo-R58472; w...@the-dreams.de;
> w...@iguana.be; cor...@lwn.net; mturque...@baylibre.com;
> sb...@codeaurora.org; Song Wenbin-B53747
> Subject: Re: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A
> SoC
>
> Hi,
>
> > + pmu {
> > + compatible = "arm,armv8-pmuv3";
> > + interrupts = <0 106 0x4>,
> > +<0 107 0x4>,
> > +<0 95 0x4>,
> > +<0 97 0x4>;
> > + };
>
> You should have interrupt-affinity here. See
> Documentation/devicetree/bindings/arm/pmu.txt
>
> Otherwise this looks ok.
>
Thanks for your correction.
Thanks,
Zhiqiang
RE: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
> -Original Message-
> From: Li Yang-Leo-R58472
> Sent: 2015年9月23日 1:23
> To: Hou Zhiqiang-B48286; Mark Rutland; marc.zyng...@arm.com
> Cc: linux-arm-ker...@lists.infradead.org; Catalin Marinas; Will Deacon;
> linux-i2c@vger.kernel.org; linux-watch...@vger.kernel.org; linux-
> d...@vger.kernel.org; linux-...@vger.kernel.org; Xie Shaohui-B21989;
> cor...@lwn.net; Sharma Bhupesh-B45370; mturque...@baylibre.com; wsa@the-
> dreams.de; sb...@codeaurora.org; w...@iguana.be; Song Wenbin-B53747; Wood
> Scott-B07421; Hu Mingkai-B21284
> Subject: RE: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
>
> > >
> > > Hi,
> > >
> > > > +/memreserve/ 0x8000 0x0001;
> > >
> > > Why is this necessary?
> >
> > This memory region is pre-reserved for the spin-table/psci, although
> > didn't add Enable method of secondary cores.
>
> Can this be reserved by bootloader?
Yes, the memory for psci was reserved by u-boot code. But due to spin-table
need the release address, is it better adding the /memreserve/ in dts file?
Or add it by bootloader and fix the release address accordingly?
>
> >
> > > If this is necessary, please add a comment stating what this is for.
> > >
> > > > + cpu@3 {
> > > > + device_type = "cpu";
> > > > + compatible = "arm,cortex-a53";
> > > > + reg = <0x0 0x3>;
> > > > + clocks = < 1 0>;
> > > > + };
> > >
> > > Missing enable-method properties on all the secondary CPUs.
> > >
> >
> > There are two methods (spin-table and psci) to bring up secondary
> > cores, which one do you think is better?
>
> Do we have the PSCI support ready in both UEFI and u-boot? If not, we
> should use spin-table for now.
>
our internal u-boot supports PSCI but opensource doesn't support it for ARMv8.
Thanks,
Zhiqiang
N�Р骒r��yb�X�肚�v�^�)藓{.n�+�伐�{��g"��^n�r■�z���h�ㄨ��&Ⅷ �G���h�(�茛j"���m赇z罐��帼f＂�h���~�m�
RE: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
> -Original Message-
> From: Mark Rutland [mailto:mark.rutl...@arm.com]
> Sent: 2015年9月23日 6:15
> To: Hou Zhiqiang-B48286
> Cc: Marc Zyngier; linux-arm-ker...@lists.infradead.org; Catalin Marinas;
> Will Deacon; linux-i2c@vger.kernel.org; linux-watch...@vger.kernel.org;
> linux-...@vger.kernel.org; linux-...@vger.kernel.org; Xie Shaohui-B21989;
> cor...@lwn.net; Sharma Bhupesh-B45370; mturque...@baylibre.com; wsa@the-
> dreams.de; sb...@codeaurora.org; w...@iguana.be; Song Wenbin-B53747; Wood
> Scott-B07421; Hu Mingkai-B21284; Li Yang-Leo-R58472
> Subject: Re: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
>
> On Tue, Sep 22, 2015 at 10:50:21AM +0100, Hou Zhiqiang wrote:
> > Hi Mark,
> >
> > > -Original Message-
> > > From: Mark Rutland [mailto:mark.rutl...@arm.com]
> > > Sent: 2015年9月22日 9:24
> > > To: Hou Zhiqiang-B48286; marc.zyng...@arm.com
> > > Cc: linux-arm-ker...@lists.infradead.org; Catalin Marinas; Will
> > > Deacon; linux-i2c@vger.kernel.org; linux-watch...@vger.kernel.org;
> > > linux- d...@vger.kernel.org; linux-...@vger.kernel.org; Xie
> > > Shaohui-B21989; cor...@lwn.net; Sharma Bhupesh-B45370;
> > > mturque...@baylibre.com; wsa@the- dreams.de; sb...@codeaurora.org;
> > > w...@iguana.be; Song Wenbin-B53747; Wood Scott-B07421; Hu
> > > Mingkai-B21284; Li Yang-Leo-R58472
> > > Subject: Re: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale
> > > LS1043A SoC
> > >
> > > Hi,
> > >
> > > > +/memreserve/ 0x8000 0x0001;
> > >
> > > Why is this necessary?
> >
> > This memory region is pre-reserved for the spin-table/psci, although
> > didn't add Enable method of secondary cores.
>
> Your PSCI implementation isn't in secure memory?
>
Sorry, this is for spin-table, psci will fix it in u-boot.
> > > > + ifc: ifc@153 {
> > > > + compatible = "fsl,ifc", "simple-bus";
> > > > + reg = <0x0 0x153 0x0 0x1>;
> > > > + interrupts = <0 43 0x4>;
> > > > + };
> > >
> > > Why simple-bus?
> >
> > There are 3 child node located in dtsi file that should be created and
> > added to platform device list.
>
> Are they usable even if the kernel knew nothing about the IFC node? If
> not, the IFC driver should probe them, and simple-bus should go.
>
> > > > + memory@8000 {
> > > > + device_type = "memory";
> > > > + reg = <0x0 0x8000 0 0x8000>;
> > > > + /* DRAM space 1 - 2 GB DRAM */
> > >
> > > I don't understand the comment. This describes 2GB at 2GB.
> > >
> >
> > Yes, there is a 2GB space for DRAM from address 2G.
> > The DRAM address 0x0 will be remapped to SoC address 2G, this remap is
> done by hardware.
>
> I just realised my mistake -- I read this as "1 to 2 GB", when this is
> actually "DRAM space 1". Sorry for the noise.
>
Thanks,
Zhiqiang
N�r��yb�X��ǧv�^�){.n�+{��g"��^n�r���z���h�&�� �G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�
RE: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Hi Mark,
> -Original Message-
> From: Mark Rutland [mailto:mark.rutl...@arm.com]
> Sent: 2015年9月22日 9:24
> To: Hou Zhiqiang-B48286; marc.zyng...@arm.com
> Cc: linux-arm-ker...@lists.infradead.org; Catalin Marinas; Will Deacon;
> linux-i2c@vger.kernel.org; linux-watch...@vger.kernel.org; linux-
> d...@vger.kernel.org; linux-...@vger.kernel.org; Xie Shaohui-B21989;
> cor...@lwn.net; Sharma Bhupesh-B45370; mturque...@baylibre.com; wsa@the-
> dreams.de; sb...@codeaurora.org; w...@iguana.be; Song Wenbin-B53747; Wood
> Scott-B07421; Hu Mingkai-B21284; Li Yang-Leo-R58472
> Subject: Re: [PATCH 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
>
> Hi,
>
> > +/memreserve/ 0x8000 0x0001;
>
> Why is this necessary?
This memory region is pre-reserved for the spin-table/psci, although didn't add
Enable method of secondary cores.
> If this is necessary, please add a comment stating what this is for.
>
> > + cpu@3 {
> > + device_type = "cpu";
> > + compatible = "arm,cortex-a53";
> > + reg = <0x0 0x3>;
> > + clocks = < 1 0>;
> > + };
>
> Missing enable-method properties on all the secondary CPUs.
>
There are two methods (spin-table and psci) to bring up secondary cores, which
one
do you think is better?
> [...]
>
> > + gic: interrupt-controller@140 {
> > + compatible = "arm,gic-400";
> > + #interrupt-cells = <3>;
> > + interrupt-controller;
> > + reg = <0x0 0x1401000 0 0x1000>, /* GICD */
> > + <0x0 0x1402000 0 0x1000>, /* GICC */
> > + <0x0 0x1404000 0 0x2000>, /* GICH */
> > + <0x0 0x1406000 0 0x2000>; /* GICV */
> > + interrupts = <1 9 0xf08>;
> > + };
>
> These sizes don't look right.
>
> To the best of my knowledge, GICC (and GICV) should be 0x2000 in size,
> while GICD and GICH should be 0x1000.
Thanks for your correction.
>
> [...]
>
> > + ifc: ifc@153 {
> > + compatible = "fsl,ifc", "simple-bus";
> > + reg = <0x0 0x153 0x0 0x1>;
> > + interrupts = <0 43 0x4>;
> > + };
>
> Why simple-bus?
There are 3 child node located in dtsi file that should be created and added
to platform device list.
>
> > + clockgen: clocking@1ee1000 {
> > + compatible = "fsl,ls1043a-clockgen";
> > + reg = <0x0 0x1ee1000 0x0 0x1000>;
> > + #clock-cells = <2>;
> > + clocks = <>;
> > + sysclk: sysclk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <1>;
> > + clock-output-names = "sysclk";
> > + };
> > + };
>
> Why does this fixed clock live under the clockgen? It should live
> directly under the root node.
>
Thanks and will move it out in v2.
> [...]
>
> > + pcie@340 {
> > + compatible = "fsl,ls1043a-pcie", "snps,dw-pcie";
> > + reg = <0x00 0x0340 0x0 0x0010 /* controller
> registers */
> > + 0x40 0x 0x0 0x2000>; /*
> configuration space */
> > + reg-names = "regs", "config";
> > + interrupts = <0 118 0x4>, /* controller interrupt */
> > +<0 117 0x4>; /* PME interrupt */
> > + interrupt-names = "intr", "pme";
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > + device_type = "pci";
> > + num-lanes = <4>;
> > + bus-range = <0x0 0xff>;
> > + ranges = <0x8100 0x0 0x 0x40 0x0001 0x0
> 0x0001 /* downstream I/O */
> > + 0x8200 0x0 0x4000 0x40 0x4000 0x0
> 0x4000>; /* non-prefetchable memory */
> > + msi-parent = <>;
> > + #interrupt-cells = <1>;
> > + interrupt-map-mask = <0 0 0 7>;
> > + interrupt-map = < 0 0 1 0 110 0x4>,
> > +
RE: [PATCH 6/6] dts/ls1043a: add LS1043ARDB board support
Hi Scott,
> -Original Message-
> From: Wood Scott-B07421
> Sent: 2015年9月22日 7:14
> To: Hou Zhiqiang-B48286
> Cc: linux-arm-ker...@lists.infradead.org; catalin.mari...@arm.com;
> will.dea...@arm.com; linux-i2c@vger.kernel.org; linux-
> watch...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> c...@vger.kernel.org; w...@the-dreams.de; w...@iguana.be; cor...@lwn.net;
> mturque...@baylibre.com; sb...@codeaurora.org; Hu Mingkai-B21284; Xie
> Shaohui-B21989; Song Wenbin-B53747; Sharma Bhupesh-B45370; Li Yang-Leo-
> R58472
> Subject: Re: [PATCH 6/6] dts/ls1043a: add LS1043ARDB board support
>
> On Mon, 2015-09-21 at 20:22 +0800, Zhiqiang Hou wrote:
>
> > + cpld: board-control@2,0 {
> > + compatible = "fsl,ls1043ardb-cpld", "simple-bus";
> > + reg = <0x2 0x0 0x100>;
> > + };
>
> Again, why "simple-bus"?
Thanks and will remove it in v2.
Thanks,
Zhiqiang
