Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
On Thu, Mar 8, 2012 at 8:41 AM, Wolfram Sang w.s...@pengutronix.de wrote: Acked-by: Linus Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. Uhm, why? What's wrong with going in via I2C? So it can be merged without bisect regressions for this merge window, Laxman seems to prefer that it get in now. If it doesn't get merged until v3.5, no issue. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
On Thu, Mar 08, 2012 at 07:24:39AM +0100, Linus Walleij wrote: but note that this is a new gpiolib feature in -next and will need to either be applied via Grant's tree or wait until after the merge window. Acked-by: Linus Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. You're looking for Wolfram or Ben there, I don't really do much I2C stuff. signature.asc Description: Digital signature
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver, just require to pass the OPEN_DRAIN type flag when requesting the gpio. Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com but note that this is a new gpiolib feature in -next and will need to either be applied via Grant's tree or wait until after the merge window. signature.asc Description: Digital signature
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
On Wed, Mar 07, 2012 at 05:31:57PM +, Mark Brown wrote: On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver, just require to pass the OPEN_DRAIN type flag when requesting the gpio. Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com Typo ;) but note that this is a new gpiolib feature in -next and will need to either be applied via Grant's tree or wait until after the merge window. I'll pick it for v3.5 later. Thanks for the review! Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
The open drain support is already available from next-20120306. I was waiting for the change to be in tree before sending this patch. Hope I am not missing anything here. On Wednesday 07 March 2012 11:14 PM, Mark Brown wrote: * PGP Signed by an unknown key On Wed, Mar 07, 2012 at 06:39:22PM +0100, Wolfram Sang wrote: On Wed, Mar 07, 2012 at 05:31:57PM +, Mark Brown wrote: Reviwed-by: Mark Brownbroo...@opensource.wolfsonmicro.com Typo ;) Not at all, it's a direct demonstration of the quick review I did! :P * Unknown Key * 0x6E30FDDD -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
On Wed, Mar 07, 2012 at 11:38:25PM +0530, Laxman Dewangan wrote: The open drain support is already available from next-20120306. I was waiting for the change to be in tree before sending this patch. Hope I am not missing anything here. Nobody should be merging -next into their trees, it's rebuilt every day - you can only rely on things in Linus tree or things which have been explicitly cross merged into other trees. Otherwise the individual tree won't build as it doesn't contain the patch you depend on which breaks bisection. signature.asc Description: Digital signature
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
On Wed, Mar 7, 2012 at 6:31 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver, just require to pass the OPEN_DRAIN type flag when requesting the gpio. Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com but note that this is a new gpiolib feature in -next and will need to either be applied via Grant's tree or wait until after the merge window. Acked-by: Linus Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver
Acked-by: Linus Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. Uhm, why? What's wrong with going in via I2C? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
