Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-03-21 Thread Mathieu Bérard
Tejun Heo a écrit :
 Jeff Garzik wrote:

 Mathieu, just to be sure, can you post the result of 'hdparm -I
 /dev/sdX' and 'lspci -nn'?

Hi,
no problem :

lspci -nn:
00:00.0 Host bridge [0600]: Intel Corporation Mobile 915GM/PM/GMS/910GML
Express Processor to DRAM Controller [8086:2590] (rev 03)
00:01.0 PCI bridge [0604]: Intel Corporation Mobile 915GM/PM Express PCI
Express Root Port [8086:2591] (rev 03)
00:1c.0 PCI bridge [0604]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) PCI Express Port 1 [8086:2660] (rev 03)
00:1c.1 PCI bridge [0604]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) PCI Express Port 2 [8086:2662] (rev 03)
00:1d.0 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW
(ICH6 Family) USB UHCI #1 [8086:2658] (rev 03)
00:1d.1 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW
(ICH6 Family) USB UHCI #2 [8086:2659] (rev 03)
00:1d.2 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW
(ICH6 Family) USB UHCI #3 [8086:265a] (rev 03)
00:1d.3 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW
(ICH6 Family) USB UHCI #4 [8086:265b] (rev 03)
00:1d.7 USB Controller [0c03]: Intel Corporation 82801FB/FBM/FR/FW/FRW
(ICH6 Family) USB2 EHCI Controller [8086:265c] (rev 03)
00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge
[8086:2448] (rev d3)
00:1e.2 Multimedia audio controller [0401]: Intel Corporation
82801FB/FBM/FR/FW/FRW (ICH6 Family) AC'97 Audio Controller [8086:266e]
(rev 03)
00:1e.3 Modem [0703]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) AC'97 Modem Controller [8086:266d] (rev 03)
00:1f.0 ISA bridge [0601]: Intel Corporation 82801FBM (ICH6M) LPC
Interface Bridge [8086:2641] (rev 03)
00:1f.1 IDE interface [0101]: Intel Corporation 82801FB/FBM/FR/FW/FRW
(ICH6 Family) IDE Controller [8086:266f] (rev 03)
00:1f.2 IDE interface [0101]: Intel Corporation 82801FBM (ICH6M) SATA
Controller [8086:2653] (rev 03)
00:1f.3 SMBus [0c05]: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) SMBus Controller [8086:266a] (rev 03)
01:00.0 VGA compatible controller [0300]: ATI Technologies Inc M24
[Radeon Mobility X600] [1002:5462]
06:01.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ [10ec:8139] (rev 10)
06:02.0 Network controller [0280]: Intel Corporation PRO/Wireless 2200BG
Network Connection [8086:4220] (rev 05)
06:04.0 CardBus bridge [0607]: Texas Instruments PCIxx21/x515 Cardbus
Controller [104c:8031]
06:04.2 FireWire (IEEE 1394) [0c00]: Texas Instruments OHCI Compliant
IEEE 1394 Host Controller [104c:8032]
06:04.3 Mass storage controller [0180]: Texas Instruments PCIxx21
Integrated FlashMedia Controller [104c:8033]
06:04.4 Generic system peripheral [0805]: Texas Instruments
PCI6411/6421/6611/6621/7411/7421/7611/7621 Secure Digital Controller
[104c:8034]

hdparm -I /dev/sda:

/dev/sda:

ATA device, with non-removable media
Model Number:   HTS541010G9SA00
Serial Number:  MP2ZM4X0GSWJKR
Firmware Revision:  MBZOC60D
Standards:
Used: ATA/ATAPI-7 T13 1532D revision 1
Supported: 7 6 5 4
Configuration:
Logical max current
cylinders   16383   16383
heads   16  16
sectors/track   63  63
--
CHS current addressable sectors:   16514064
LBAuser addressable sectors:  195371568
LBA48  user addressable sectors:  195371568
device size with M = 1024*1024:   95396 MBytes
device size with M = 1000*1000:  100030 MBytes (100 GB)
Capabilities:
LBA, IORDY(can be disabled)
Queue depth: 32
Standby timer values: spec'd by Vendor, no device specific minimum
R/W multiple sector transfer: Max = 16  Current = 0
Advanced power management level: 128 (0x80)
Recommended acoustic management value: 128, current value: 254
DMA: mdma0 mdma1 mdma2 udma0 udma1 udma2 udma3 udma4 *udma5
 Cycle time: min=120ns recommended=120ns
PIO: pio0 pio1 pio2 pio3 pio4
 Cycle time: no flow control=240ns  IORDY flow control=120ns
Commands/features:
Enabled Supported:
   *SMART feature set
Security Mode feature set
   *Power Management feature set
   *Write cache
   *Look-ahead
   *Host Protected Area feature set
   *WRITE_BUFFER command
   *READ_BUFFER command
   *NOP cmd
   *DOWNLOAD_MICROCODE
   *Advanced Power Management feature set
Power-Up In Standby feature set
   *SET_FEATURES required to spinup after power up
SET_MAX security extension
Automatic Acoustic Management feature set
   *48-bit Address feature set
   *Device Configuration Overlay feature set
   *Mandatory FLUSH_CACHE
   *FLUSH_CACHE_EXT
   *

Re: [3/6] 2.6.21-rc2: known regressions

2007-03-14 Thread Mathieu Bérard
Tejun Heo a écrit :
 Hello,


 Due to blacklisting, NCQ
 won't be turned on your drive in future kernels.

   
Hello thanks.
I have found on Hitachi website the technical datasheets of my drive
model:
http://www.hitachigst.com/tech/techlib.nsf/techdocs/28DCCB17E0EEC5A086256F4E006E2F5B/$file/5K100_SATA_sp1.2.pdf
It seems to state that the drive does not support NCQ...

--
Mathieu

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [3/6] 2.6.21-rc2: known regressions

2007-03-13 Thread Mathieu Bérard
Tejun Heo a écrit :
  Mathieu Bérard wrote:
  Jeff Garzik a écrit :
  Adrian Bunk wrote:
  Subject: NCQ problem with ahci and Hitachi drive
  References : http://lkml.org/lkml/2007/3/4/178
  Submitter  : Mathieu Bérard [EMAIL PROTECTED]
  Status : unknown
  according to the last message in that thread, it sounds like
ACPI and
  interrupt problems
 
  Hi,
  after more testing with a 2.6.21-rc3, it appears that after
several ata
  errors the boot process
  somehow continued as normal, after a NCQ disabled due to excessive
  errors message.
  pci=noacpi or noacpi parameters workarounds the problem irqpoll
  does nothing.
 
  I was mistaken.  It can't be IRQ routing problem.  I somehow thought the
  port was a ata_piix one.  Considering the reported broken NCQ feature on
  the device GTF might be mangling with the drive to disable NCQ or
  something.  Does giving libata.noacpi=1 make any difference?
 

Hi,
libata.noacpi=1 worked. The drive is up and running with NCQ on.
Here is the PATA/SATA related part of my DSDT table with the _GTF methods:

Device (PATA)
{
Name (_ADR, 0x001F0001)
OperationRegion (PACS, PCI_Config, 0x40, 0xC0)
Field (PACS, DWordAcc, NoLock, Preserve)
{
PRIT,   16,
Offset (0x04),
PSIT,   4,
Offset (0x08),
SYNC,   4,
Offset (0x0A),
SDT0,   2,
,   2,
SDT1,   2,
Offset (0x14),
ICR0,   4,
ICR1,   4,
ICR2,   4,
ICR3,   4,
ICR4,   4,
ICR5,   4
}

Device (PRID)
{
Name (_ADR, 0x00)
Method (_GTM, 0, NotSerialized)
{
Name (PBUF, Buffer (0x14)
{
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00
})
CreateDWordField (PBUF, 0x00, PIO0)
CreateDWordField (PBUF, 0x04, DMA0)
CreateDWordField (PBUF, 0x08, PIO1)
CreateDWordField (PBUF, 0x0C, DMA1)
CreateDWordField (PBUF, 0x10, FLAG)
Store (GETP (PRIT), PIO0)
Store (GDMA (And (SYNC, 0x01), And (ICR3, 0x01), And (ICR0,
0x01), SDT0, And (ICR1, 0x01)), DMA0)
If (LEqual (DMA0, 0x))
{
Store (PIO0, DMA0)
}

If (And (PRIT, 0x4000))
{
If (LEqual (And (PRIT, 0x90), 0x80))
{
Store (0x0384, PIO1)
}
Else
{
Store (GETT (PSIT), PIO1)
}
}
Else
{
Store (0x, PIO1)
}

Store (GDMA (And (SYNC, 0x02), And (ICR3, 0x02), And (ICR0,
0x02), SDT1, And (ICR1, 0x02)), DMA1)
If (LEqual (DMA1, 0x))
{
Store (PIO1, DMA1)
}

Store (GETF (And (SYNC, 0x01), And (SYNC, 0x02), PRIT), FLAG)
If (And (LEqual (PIO0, 0x), LEqual (DMA0, 0x)))
{
Store (0x78, PIO0)
Store (0x14, DMA0)
Store (0x03, FLAG)
}

Return (PBUF)
}

Method (_STM, 3, NotSerialized)
{
CreateDWordField (Arg0, 0x00, PIO0)
CreateDWordField (Arg0, 0x04, DMA0)
CreateDWordField (Arg0, 0x08, PIO1)
CreateDWordField (Arg0, 0x0C, DMA1)
CreateDWordField (Arg0, 0x10, FLAG)
If (LEqual (SizeOf (Arg1), 0x0200))
{
And (PRIT, 0x40F0, PRIT)
And (SYNC, 0x02, SYNC)
Store (0x00, SDT0)
And (ICR0, 0x02, ICR0)
And (ICR1, 0x02, ICR1)
And (ICR3, 0x02, ICR3)
And (ICR5, 0x02, ICR5)
CreateWordField (Arg1, 0x62, W490)
CreateWordField (Arg1, 0x6A, W530)
CreateWordField (Arg1, 0x7E, W630)
CreateWordField (Arg1, 0x80, W640)
CreateWordField (Arg1, 0xB0, W880)
CreateWordField (Arg1, 0xBA, W930)
Or (PRIT, 0x8004, PRIT)
If (LAnd (And (FLAG, 0x02), And (W490, 0x0800)))
{
Or (PRIT, 0x02, PRIT)
}

Or (PRIT, SETP (PIO0, W530, W640), PRIT)
If (And (FLAG, 0x01))
{
Or (SYNC, 0x01, SYNC)
Store (SDMA (DMA0), SDT0)
If (LLess (DMA0, 0x1E))
{
Or (ICR3, 0x01, ICR3)
}

If (LLess (DMA0, 0x3C))
{
Or (ICR0, 0x01, ICR0)
}

If (And (W930, 0x2000))
{
Or (ICR1, 0x01, ICR1

Re: [3/6] 2.6.21-rc2: known regressions

2007-03-09 Thread Mathieu Bérard
Jeff Garzik a écrit :
 Adrian Bunk wrote:
 Subject: NCQ problem with ahci and Hitachi drive
 References : http://lkml.org/lkml/2007/3/4/178
 Submitter  : Mathieu Bérard [EMAIL PROTECTED]
 Status : unknown

 according to the last message in that thread, it sounds like ACPI and
 interrupt problems

Hi,
after more testing with a 2.6.21-rc3, it appears that after several ata
errors the boot process
somehow continued as normal, after a NCQ disabled due to excessive
errors message.
pci=noacpi or noacpi parameters workarounds the problem irqpoll
does nothing.

lspci:
00:00.0 Host bridge: Intel Corporation Mobile 915GM/PM/GMS/910GML
Express Processor to DRAM Controller (rev 03)
00:01.0 PCI bridge: Intel Corporation Mobile 915GM/PM Express PCI
Express Root Port (rev 03)
00:1c.0 PCI bridge: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) PCI Express Port 1 (rev 03)
00:1c.1 PCI bridge: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) PCI Express Port 2 (rev 03)
00:1d.0 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) USB UHCI #1 (rev 03)
00:1d.1 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) USB UHCI #2 (rev 03)
00:1d.2 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) USB UHCI #3 (rev 03)
00:1d.3 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) USB UHCI #4 (rev 03)
00:1d.7 USB Controller: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) USB2 EHCI Controller (rev 03)
00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev d3)
00:1e.2 Multimedia audio controller: Intel Corporation
82801FB/FBM/FR/FW/FRW (ICH6 Family) AC'97 Audio Controller (rev 03)
00:1e.3 Modem: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family)
AC'97 Modem Controller (rev 03)
00:1f.0 ISA bridge: Intel Corporation 82801FBM (ICH6M) LPC Interface
Bridge (rev 03)
00:1f.1 IDE interface: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6
Family) IDE Controller (rev 03)
00:1f.2 IDE interface: Intel Corporation 82801FBM (ICH6M) SATA
Controller (rev 03)
00:1f.3 SMBus: Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family)
SMBus Controller (rev 03)
01:00.0 VGA compatible controller: ATI Technologies Inc M24 [Radeon
Mobility X600]
06:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ (rev 10)
06:02.0 Network controller: Intel Corporation PRO/Wireless 2200BG
Network Connection (rev 05)
06:04.0 CardBus bridge: Texas Instruments PCIxx21/x515 Cardbus Controller
06:04.2 FireWire (IEEE 1394): Texas Instruments OHCI Compliant IEEE 1394
Host Controller
06:04.3 Mass storage controller: Texas Instruments PCIxx21 Integrated
FlashMedia Controller
06:04.4 Generic system peripheral [0805]: Texas Instruments
PCI6411/6421/6611/6621/7411/7421/7611/7621 Secure Digital Controller


/proc/interrupts:
CPU0  
  0:   3242   IO-APIC-edge  timer
  1:863   IO-APIC-edge  i8042
  8:  3   IO-APIC-edge  rtc
  9:  1   IO-APIC-fasteoi   acpi
 12:116   IO-APIC-edge  i8042
 14:128   IO-APIC-edge  libata
 15:  0   IO-APIC-edge  libata
 16:  1   IO-APIC-fasteoi   uhci_hcd:usb4, yenta
 17:  0   IO-APIC-fasteoi   tifm_7xx1, Intel ICH6
 18:249   IO-APIC-fasteoi   eth0
 19:   2712   IO-APIC-fasteoi   libata, uhci_hcd:usb2, sdhci:slot0,
sdhci:slot1, sdhci:slot2
 20: 47   IO-APIC-fasteoi   uhci_hcd:usb1, ehci_hcd:usb5
 21:  3   IO-APIC-fasteoi   uhci_hcd:usb3, ohci1394
 22:  1   IO-APIC-fasteoi   ipw2200
NMI:  0
LOC:  15767
ERR:  0
MIS:  0


/proc/interrupts with pci=noacpi:
CPU0  
  0:   2886XT-PIC-XTtimer
  1: 79XT-PIC-XTi8042
  2:  0XT-PIC-XTcascade
  8:  3XT-PIC-XTrtc
  9:  1XT-PIC-XTacpi
 10:  1XT-PIC-XTuhci_hcd:usb4, tifm_7xx1, yenta,
sdhci:slot0, sdhci:slot1, sdhci:slot2, Intel ICH6
 11:   3415XT-PIC-XTeth0, libata, uhci_hcd:usb1,
uhci_hcd:usb2, uhci_hcd:usb3, ehci_hcd:usb5, ohci1394, ipw2200
 12:116XT-PIC-XTi8042
 14:129XT-PIC-XTlibata
 15:  0XT-PIC-XTlibata
NMI:  0
LOC:   6594
ERR:  0
MIS:  0

Full 2.6.21-rc3 boot log:
[0.00] Linux version 2.6.21-rc3 ([EMAIL PROTECTED]) (gcc version 4.1.2
(Ubuntu 4.1.2-0ubuntu4)) #1 PREEMPT Fri Mar 9 01:54:11 CET 2007
[0.00] BIOS-provided physical RAM map:
[0.00] sanitize start
[0.00] sanitize end
[0.00] copy_e820_map() start:  size:
0009f800 end: 0009f800 type: 1
[0.00] copy_e820_map() type is E820_RAM
[0.00] copy_e820_map() start: 0009f800 size:
0800 end: 000a type: 2
[0.00] copy_e820_map() start: 000d2000 size:
2000 end: 000d4000 type: 2
[0.00] copy_e820_map

Re: Regression between 2.6.20 and 2.6.21-rc1: NCQ problem with ahci and Hitachi drive

2007-03-05 Thread Mathieu Bérard
Tejun Heo a écrit :

Hi,
 No, your drive isn't blacklisted yet.  NCQ is still being enabled.

   
Sorry, I wasn't very clear: The NCQ blacklist patch is not in
the 2.6.21-rc tree, just in -mm. I tried a 2.6.21-rc2-mm1 and
the drive is blacklisted. The logs I pasted were from 2.6.20 and
2.6.21-rc1.
 [   16.091804] ata1.00: configured for UDMA/100
 [   18.151756] SCSI device sda: write cache: enabled, read cache:
 enabled, doesn't support DPO or FUA
 
 [--snip--]
   
 [   18.151856] SCSI device sda: 195371568 512-byte hdwr sectors (100030 MB)
 [   18.151911] sda: Write Protect is off
 [   18.151977] SCSI device sda: write cache: enabled, read cache:
 enabled, doesn't support DPO or FUA
 []
 [   48.143940] ata1.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2
 frozen
 [   48.143999] ata1.00: cmd 60/08:00:00:00:00/00:00:00:00:00/40 tag 0
 cdb 0x0 data 4096 in
 [   48.144000]  res 40/00:00:00:00:00/00:00:00:00:00/00 Emask
 0x4 (timeout)
 

 It looks like IRQ isn't getting through.  Does giving acpi=off kernel
 parameter make any difference?

   

Yes It works with acpi=off (2.6.21-rc1):
Please notice that IRQ is changed from 19 with ACPI to 11 without.

[   24.226291] SCSI subsystem initialized
[   24.230178] libata version 2.10 loaded.
[   24.231315] ahci :00:1f.2: version 2.0
[   25.231137] PCI: Setting latency timer of device :00:1f.2 to 64
[   25.231144] ahci :00:1f.2: AHCI 0001. 32 slots 4 ports 1.5
Gbps 0x5 impl SATA mode
[   25.231202] ahci :00:1f.2: flags: 64bit ncq pm led slum part
[   25.231341] ata1: SATA max UDMA/133 cmd 0xf880ed00 ctl 0x
bmdma 0x irq 11
[   25.231468] ata2: SATA max UDMA/133 cmd 0xf880ed80 ctl 0x
bmdma 0x irq 11
[   25.231596] ata3: SATA max UDMA/133 cmd 0xf880ee00 ctl 0x
bmdma 0x irq 11
[   25.231722] ata4: SATA max UDMA/133 cmd 0xf880ee80 ctl 0x
bmdma 0x irq 11
[   25.231783] scsi0 : ahci
[   25.688849] ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
[   25.689915] ata1.00: ATA-7: HTS541010G9SA00, MBZOC60D, max UDMA/100
[   25.689964] ata1.00: 195371568 sectors, multi 0: LBA48 NCQ (depth 31/32)
[   25.691271] ata1.00: configured for UDMA/100
[   25.691321] scsi1 : ahci
[   25.993653] ata2: SATA link down (SStatus 0 SControl 0)
[   25.993706] scsi2 : ahci
[   26.296471] ata3: SATA link down (SStatus 0 SControl 300)
[   26.296524] scsi3 : ahci
[   26.599288] ata4: SATA link down (SStatus 0 SControl 0)
[   26.599423] scsi 0:0:0:0: Direct-Access ATA  HTS541010G9SA00 
MBZO PQ: 0 ANSI: 5
[]
[   27.741608] SCSI device sda: 195371568 512-byte hdwr sectors (100030 MB)
[   27.741706] sda: Write Protect is off
[   27.741753] sda: Mode Sense: 00 3a 00 00
[   27.741921] SCSI device sda: write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[   27.742037] SCSI device sda: 195371568 512-byte hdwr sectors (100030 MB)
[   27.742091] sda: Write Protect is off
[   27.742171] sda: Mode Sense: 00 3a 00 00
[   27.742182] SCSI device sda: write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[   27.742238]  sda: sda1 sda2  sda5 sda6  sda3
[   28.204850] sd 0:0:0:0: Attached scsi disk sda
[   28.207809] sd 0:0:0:0: Attached scsi generic sg0 type 0


-- 
Mathieu
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html