Re: 2.6.26-git0: IDE oops during boot

2008-02-24 Thread Yinghai Lu
On Fri, Feb 15, 2008 at 3:15 AM, Kamalesh Babulal
[EMAIL PROTECTED] wrote:


  Thanks for pointing the patch, I do not have the SES config option enabled,
  then too i tried your patch, but that does not solve the panic. The kernel
  panic's with the same panic message as before. I have attached the .config
  file which i am using, please let me know if i am missing out/getting wrong
  any option in the configuration.

can you try x86.git#testing?

http://people.redhat.com/mingo/x86.git/README

YH
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-24 Thread Yinghai Lu
On Sun, Feb 24, 2008 at 11:05 PM, Yinghai Lu [EMAIL PROTECTED] wrote:
 On Fri, Feb 15, 2008 at 3:15 AM, Kamalesh Babulal

 [EMAIL PROTECTED] wrote:
  
  

   Thanks for pointing the patch, I do not have the SES config option enabled,
then too i tried your patch, but that does not solve the panic. The kernel
panic's with the same panic message as before. I have attached the .config
file which i am using, please let me know if i am missing out/getting 
 wrong
any option in the configuration.

  can you try x86.git#testing?

  http://people.redhat.com/mingo/x86.git/README


and try attached patch.

YH
diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
index 6fd804f..f0d6a80 100644
--- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -801,7 +801,7 @@ static void __cpuinit srat_detect_node(void)
 	/* Don't do the funky fallback heuristics the AMD version employs
 	   for now. */
 	node = apicid_to_node[apicid];
-	if (node == NUMA_NO_NODE)
+	if (node == NUMA_NO_NODE || !node_online(node))
 		node = first_node(node_online_map);
 	numa_set_node(cpu, node);
 


Re: 2.6.26-git0: IDE oops during boot

2008-02-15 Thread Kamalesh Babulal
Yinghai Lu wrote:
 On Thu, Feb 14, 2008 at 1:46 AM, Kamalesh Babulal
 [EMAIL PROTECTED] wrote:
 Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Tuesday 12 February 2008, Kamalesh Babulal wrote:
   Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Monday 11 February 2008, Kamalesh Babulal wrote:
   Nish Aravamudan wrote:
   On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
   On Thursday 07 February 2008, Kamalesh Babulal wrote:
   Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Wednesday 06 February 2008, Pavel Machek wrote:
   On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
   Hi!
  
   Trying to boot 2.6.25-git0 (few days old), I get
  
   BUG: unable to handle kernel paging request at ..ffb0
   IP at init_irq+0x42e
   init_irq? hmm...
  
   Call trace:
   ide_device_add_all
   this comes from ide-generic
   (Generic IDE host driver)
  
   ide_generic_init
   kernel_init
   child_rip
   vgacon_cursor
   kernel_init
   child_rip
  
   Excerpt from config:
  
   CONFIG_IDE=y
   CONFIG_BLK_DEV_IDE=y
   Disabling CONFIG_IDE made my machine boot, as it was using libata
   anyway.
   Kamalesh/Pavel:
  
   Could you try latest git and see if the OOPS is still there?
  
   [ Yeah, I'm unable to reproduce it. :( ]
  
   Thanks,
   Bart
   Hi Bart,
  
   The panic is reproducible with the 2.6.24-git16 kernel, the call 
 trace is
   similar to the previous one
   Thanks, I again reviewed ide-probe.c changes but nothing seems 
 wrong...
  
   Could you please bisect it down to the guilty commit?
   Kamalesh, were you able to bisect this down? I just got hit by the
   same panic on a 4-way x86_64, with 2.6.24-git22.
  
   Thanks,
   Nish
   Hi Nish,
  
   I tried bisecting and the guilty patch seems to be
  
   36501650ec45b1db308c3b51886044863be2d762 is first bad commit
   commit 36501650ec45b1db308c3b51886044863be2d762
   Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
   Date:   Fri Feb 1 23:09:31 2008 +0100
  
   ide: keep pointer to struct device instead of struct pci_dev in 
 ide_hwif_t
  
  
   the gdb output, also points to the changes made by the guilty patch
  
   (gdb) p ide_device_add_all
   $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
 ide_device_add_all
   (gdb) p/x 0x804176ac+0xb60
   $2 = 0x8041820c
   (gdb) l *0x8041820c
   0x8041820c is in ide_device_add_all 
 (drivers/ide/ide-probe.c:1249).
   1244goto out;
   1245}
   1246
   1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
   1248
   1249if (init_irq(hwif) == 0)
   1250goto done;
   1251
   1252old_irq = hwif-irq;
   1253/*
   (gdb)
  
  
   (gdb) p init_irq
   $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
   (gdb) p/x 0x8041721f+0x1a4
   $2 = 0x804173c3
   (gdb) l *0x804173c3
   0x804173c3 is in init_irq (include/asm/pci.h:101).
   96  /* Returns the node based on pci bus */
   97  static inline int __pcibus_to_node(struct pci_bus *bus)
   98  {
   99  struct pci_sysdata *sd = bus-sysdata;
   100
   101 return sd-node;
   102 }
   103
   104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus 
 *bus)
   105 {
   (gdb)
   Thanks for the detailed analysis and sorry for the bug.
  
   I think that this may has been just fixed by Andi's recent 
 hwif_to_node()
   fix (patch below, it is in Linus' tree already), could please verify 
 this?
  
   commit 1f07e988290fc45932f5028c9e2a862c37a57336
   Author: Andi Kleen [EMAIL PROTECTED]
   Date:   Mon Feb 11 01:35:20 2008 +0100
  
   Prevent IDE boot ops on NUMA system
  
   Without this patch a Opteron test system here oopses at boot with
   current git.
  
   Calling to_pci_dev() on a NULL pointer gives a negative value so the
   following NULL pointer check never triggers and then an illegal 
 address
   is referenced.  Check the unadjusted original device pointer for 
 NULL
   instead.
  
   Signed-off-by: Andi Kleen [EMAIL PROTECTED]
   Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
  
   diff --git a/include/linux/ide.h b/include/linux/ide.h
   index 23fad89..a3b69c1 100644
   --- a/include/linux/ide.h
   +++ b/include/linux/ide.h
   @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
static inline int hwif_to_node(ide_hwif_t *hwif)
{
   struct pci_dev *dev = to_pci_dev(hwif-dev);
   -   return dev ? pcibus_to_node(dev-bus) : -1;
   +   return hwif-dev ? pcibus_to_node(dev-bus) : -1;
}
  
static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
   Hi Bart,
   Thanks !! the patch solves the kernel panic but when after applying the 
 patch,kernel is not
   able to mount the filesystem and panics, am i not sure what is likely 
 causing the panic.
  
   Is
  
   - the commit 36501650ec45b1db308c3b51886044863be2d762 with Andi's fix 
 applied
  
   

Re: 2.6.26-git0: IDE oops during boot

2008-02-14 Thread Kamalesh Babulal
Bartlomiej Zolnierkiewicz wrote:
 Hi,
 
 On Tuesday 12 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
 Hi,

 On Monday 11 February 2008, Kamalesh Babulal wrote:
 Nish Aravamudan wrote:
 On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
 On Thursday 07 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
 Hi,

 On Wednesday 06 February 2008, Pavel Machek wrote:
 On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
 Hi!

 Trying to boot 2.6.25-git0 (few days old), I get

 BUG: unable to handle kernel paging request at ..ffb0
 IP at init_irq+0x42e
 init_irq? hmm...

 Call trace:
 ide_device_add_all
 this comes from ide-generic
 (Generic IDE host driver)

 ide_generic_init
 kernel_init
 child_rip
 vgacon_cursor
 kernel_init
 child_rip

 Excerpt from config:

 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDE=y
 Disabling CONFIG_IDE made my machine boot, as it was using libata
 anyway.
 Kamalesh/Pavel:

 Could you try latest git and see if the OOPS is still there?

 [ Yeah, I'm unable to reproduce it. :( ]

 Thanks,
 Bart
 Hi Bart,

 The panic is reproducible with the 2.6.24-git16 kernel, the call trace 
 is
 similar to the previous one
 Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...

 Could you please bisect it down to the guilty commit?
 Kamalesh, were you able to bisect this down? I just got hit by the
 same panic on a 4-way x86_64, with 2.6.24-git22.

 Thanks,
 Nish
 Hi Nish,

 I tried bisecting and the guilty patch seems to be 

 36501650ec45b1db308c3b51886044863be2d762 is first bad commit
 commit 36501650ec45b1db308c3b51886044863be2d762
 Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
 Date:   Fri Feb 1 23:09:31 2008 +0100

 ide: keep pointer to struct device instead of struct pci_dev in 
 ide_hwif_t


 the gdb output, also points to the changes made by the guilty patch

 (gdb) p ide_device_add_all
 $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
 ide_device_add_all
 (gdb) p/x 0x804176ac+0xb60
 $2 = 0x8041820c
 (gdb) l *0x8041820c
 0x8041820c is in ide_device_add_all (drivers/ide/ide-probe.c:1249).
 1244goto out;
 1245}
 1246
 1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
 1248
 1249if (init_irq(hwif) == 0)
 1250goto done;
 1251
 1252old_irq = hwif-irq;
 1253/*
 (gdb) 


 (gdb) p init_irq
 $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
 (gdb) p/x 0x8041721f+0x1a4
 $2 = 0x804173c3
 (gdb) l *0x804173c3
 0x804173c3 is in init_irq (include/asm/pci.h:101).
 96  /* Returns the node based on pci bus */
 97  static inline int __pcibus_to_node(struct pci_bus *bus)
 98  {
 99  struct pci_sysdata *sd = bus-sysdata;
 100
 101 return sd-node;
 102 }
 103
 104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus *bus)
 105 {
 (gdb) 
 Thanks for the detailed analysis and sorry for the bug.

 I think that this may has been just fixed by Andi's recent hwif_to_node()
 fix (patch below, it is in Linus' tree already), could please verify this?

 commit 1f07e988290fc45932f5028c9e2a862c37a57336
 Author: Andi Kleen [EMAIL PROTECTED]
 Date:   Mon Feb 11 01:35:20 2008 +0100

 Prevent IDE boot ops on NUMA system
 
 Without this patch a Opteron test system here oopses at boot with
 current git.
 
 Calling to_pci_dev() on a NULL pointer gives a negative value so the
 following NULL pointer check never triggers and then an illegal address
 is referenced.  Check the unadjusted original device pointer for NULL
 instead.
 
 Signed-off-by: Andi Kleen [EMAIL PROTECTED]
 Signed-off-by: Linus Torvalds [EMAIL PROTECTED]

 diff --git a/include/linux/ide.h b/include/linux/ide.h
 index 23fad89..a3b69c1 100644
 --- a/include/linux/ide.h
 +++ b/include/linux/ide.h
 @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
  static inline int hwif_to_node(ide_hwif_t *hwif)
  {
 struct pci_dev *dev = to_pci_dev(hwif-dev);
 -   return dev ? pcibus_to_node(dev-bus) : -1;
 +   return hwif-dev ? pcibus_to_node(dev-bus) : -1;
  }

  static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
 Hi Bart,
 Thanks !! the patch solves the kernel panic but when after applying the 
 patch,kernel is not
 able to mount the filesystem and panics, am i not sure what is likely 
 causing the panic.
 
 Is
 
 - the commit 36501650ec45b1db308c3b51886044863be2d762 with Andi's fix applied
 
 or
 
 - the commit f6fb786d6dcdd7d730e4fba620b071796f487e1b
   (the one before commit 36501650ec45b1db308c3b51886044863be2d762)
 
 working for you?

No, the commit before the commit 36501650ec45b1db308c3b51886044863be2d762 did 
not either work, i
get the same kernel panic.

 
 Creating root device.
 Mounting root filesystem.
 mount: could not  find filesystem
 Kernel panic - not syncing: Attempted 

Re: 2.6.26-git0: IDE oops during boot

2008-02-14 Thread Yinghai Lu
On Thu, Feb 14, 2008 at 1:46 AM, Kamalesh Babulal
[EMAIL PROTECTED] wrote:

 Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Tuesday 12 February 2008, Kamalesh Babulal wrote:
   Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Monday 11 February 2008, Kamalesh Babulal wrote:
   Nish Aravamudan wrote:
   On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
   On Thursday 07 February 2008, Kamalesh Babulal wrote:
   Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Wednesday 06 February 2008, Pavel Machek wrote:
   On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
   Hi!
  
   Trying to boot 2.6.25-git0 (few days old), I get
  
   BUG: unable to handle kernel paging request at ..ffb0
   IP at init_irq+0x42e
   init_irq? hmm...
  
   Call trace:
   ide_device_add_all
   this comes from ide-generic
   (Generic IDE host driver)
  
   ide_generic_init
   kernel_init
   child_rip
   vgacon_cursor
   kernel_init
   child_rip
  
   Excerpt from config:
  
   CONFIG_IDE=y
   CONFIG_BLK_DEV_IDE=y
   Disabling CONFIG_IDE made my machine boot, as it was using libata
   anyway.
   Kamalesh/Pavel:
  
   Could you try latest git and see if the OOPS is still there?
  
   [ Yeah, I'm unable to reproduce it. :( ]
  
   Thanks,
   Bart
   Hi Bart,
  
   The panic is reproducible with the 2.6.24-git16 kernel, the call 
 trace is
   similar to the previous one
   Thanks, I again reviewed ide-probe.c changes but nothing seems 
 wrong...
  
   Could you please bisect it down to the guilty commit?
   Kamalesh, were you able to bisect this down? I just got hit by the
   same panic on a 4-way x86_64, with 2.6.24-git22.
  
   Thanks,
   Nish
   Hi Nish,
  
   I tried bisecting and the guilty patch seems to be
  
   36501650ec45b1db308c3b51886044863be2d762 is first bad commit
   commit 36501650ec45b1db308c3b51886044863be2d762
   Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
   Date:   Fri Feb 1 23:09:31 2008 +0100
  
   ide: keep pointer to struct device instead of struct pci_dev in 
 ide_hwif_t
  
  
   the gdb output, also points to the changes made by the guilty patch
  
   (gdb) p ide_device_add_all
   $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
 ide_device_add_all
   (gdb) p/x 0x804176ac+0xb60
   $2 = 0x8041820c
   (gdb) l *0x8041820c
   0x8041820c is in ide_device_add_all 
 (drivers/ide/ide-probe.c:1249).
   1244goto out;
   1245}
   1246
   1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
   1248
   1249if (init_irq(hwif) == 0)
   1250goto done;
   1251
   1252old_irq = hwif-irq;
   1253/*
   (gdb)
  
  
   (gdb) p init_irq
   $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
   (gdb) p/x 0x8041721f+0x1a4
   $2 = 0x804173c3
   (gdb) l *0x804173c3
   0x804173c3 is in init_irq (include/asm/pci.h:101).
   96  /* Returns the node based on pci bus */
   97  static inline int __pcibus_to_node(struct pci_bus *bus)
   98  {
   99  struct pci_sysdata *sd = bus-sysdata;
   100
   101 return sd-node;
   102 }
   103
   104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus *bus)
   105 {
   (gdb)
   Thanks for the detailed analysis and sorry for the bug.
  
   I think that this may has been just fixed by Andi's recent hwif_to_node()
   fix (patch below, it is in Linus' tree already), could please verify 
 this?
  
   commit 1f07e988290fc45932f5028c9e2a862c37a57336
   Author: Andi Kleen [EMAIL PROTECTED]
   Date:   Mon Feb 11 01:35:20 2008 +0100
  
   Prevent IDE boot ops on NUMA system
  
   Without this patch a Opteron test system here oopses at boot with
   current git.
  
   Calling to_pci_dev() on a NULL pointer gives a negative value so the
   following NULL pointer check never triggers and then an illegal 
 address
   is referenced.  Check the unadjusted original device pointer for NULL
   instead.
  
   Signed-off-by: Andi Kleen [EMAIL PROTECTED]
   Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
  
   diff --git a/include/linux/ide.h b/include/linux/ide.h
   index 23fad89..a3b69c1 100644
   --- a/include/linux/ide.h
   +++ b/include/linux/ide.h
   @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
static inline int hwif_to_node(ide_hwif_t *hwif)
{
   struct pci_dev *dev = to_pci_dev(hwif-dev);
   -   return dev ? pcibus_to_node(dev-bus) : -1;
   +   return hwif-dev ? pcibus_to_node(dev-bus) : -1;
}
  
static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
   Hi Bart,
   Thanks !! the patch solves the kernel panic but when after applying the 
 patch,kernel is not
   able to mount the filesystem and panics, am i not sure what is likely 
 causing the panic.
  
   Is
  
   - the commit 36501650ec45b1db308c3b51886044863be2d762 with Andi's fix 
 applied
  
   or
  
   - the commit 

mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz

Hi,

On Thursday 14 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
  Hi,
  
  On Tuesday 12 February 2008, Kamalesh Babulal wrote:
  Bartlomiej Zolnierkiewicz wrote:
  Hi,
 
  On Monday 11 February 2008, Kamalesh Babulal wrote:
  Nish Aravamudan wrote:
  On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
  On Thursday 07 February 2008, Kamalesh Babulal wrote:
  Bartlomiej Zolnierkiewicz wrote:
  Hi,
 
  On Wednesday 06 February 2008, Pavel Machek wrote:
  On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
  Hi!
 
  Trying to boot 2.6.25-git0 (few days old), I get
 
  BUG: unable to handle kernel paging request at ..ffb0
  IP at init_irq+0x42e
  init_irq? hmm...
 
  Call trace:
  ide_device_add_all
  this comes from ide-generic
  (Generic IDE host driver)
 
  ide_generic_init
  kernel_init
  child_rip
  vgacon_cursor
  kernel_init
  child_rip
 
  Excerpt from config:
 
  CONFIG_IDE=y
  CONFIG_BLK_DEV_IDE=y
  Disabling CONFIG_IDE made my machine boot, as it was using libata
  anyway.
  Kamalesh/Pavel:
 
  Could you try latest git and see if the OOPS is still there?
 
  [ Yeah, I'm unable to reproduce it. :( ]
 
  Thanks,
  Bart
  Hi Bart,
 
  The panic is reproducible with the 2.6.24-git16 kernel, the call 
  trace is
  similar to the previous one
  Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...
 
  Could you please bisect it down to the guilty commit?
  Kamalesh, were you able to bisect this down? I just got hit by the
  same panic on a 4-way x86_64, with 2.6.24-git22.
 
  Thanks,
  Nish
  Hi Nish,
 
  I tried bisecting and the guilty patch seems to be 
 
  36501650ec45b1db308c3b51886044863be2d762 is first bad commit
  commit 36501650ec45b1db308c3b51886044863be2d762
  Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
  Date:   Fri Feb 1 23:09:31 2008 +0100
 
  ide: keep pointer to struct device instead of struct pci_dev in 
  ide_hwif_t
 
 
  the gdb output, also points to the changes made by the guilty patch
 
  (gdb) p ide_device_add_all
  $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
  ide_device_add_all
  (gdb) p/x 0x804176ac+0xb60
  $2 = 0x8041820c
  (gdb) l *0x8041820c
  0x8041820c is in ide_device_add_all 
  (drivers/ide/ide-probe.c:1249).
  1244goto out;
  1245}
  1246
  1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
  1248
  1249if (init_irq(hwif) == 0)
  1250goto done;
  1251
  1252old_irq = hwif-irq;
  1253/*
  (gdb) 
 
 
  (gdb) p init_irq
  $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
  (gdb) p/x 0x8041721f+0x1a4
  $2 = 0x804173c3
  (gdb) l *0x804173c3
  0x804173c3 is in init_irq (include/asm/pci.h:101).
  96  /* Returns the node based on pci bus */
  97  static inline int __pcibus_to_node(struct pci_bus *bus)
  98  {
  99  struct pci_sysdata *sd = bus-sysdata;
  100
  101 return sd-node;
  102 }
  103
  104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus *bus)
  105 {
  (gdb) 
  Thanks for the detailed analysis and sorry for the bug.
 
  I think that this may has been just fixed by Andi's recent hwif_to_node()
  fix (patch below, it is in Linus' tree already), could please verify this?
 
  commit 1f07e988290fc45932f5028c9e2a862c37a57336
  Author: Andi Kleen [EMAIL PROTECTED]
  Date:   Mon Feb 11 01:35:20 2008 +0100
 
  Prevent IDE boot ops on NUMA system
  
  Without this patch a Opteron test system here oopses at boot with
  current git.
  
  Calling to_pci_dev() on a NULL pointer gives a negative value so the
  following NULL pointer check never triggers and then an illegal 
  address
  is referenced.  Check the unadjusted original device pointer for NULL
  instead.
  
  Signed-off-by: Andi Kleen [EMAIL PROTECTED]
  Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
 
  diff --git a/include/linux/ide.h b/include/linux/ide.h
  index 23fad89..a3b69c1 100644
  --- a/include/linux/ide.h
  +++ b/include/linux/ide.h
  @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
   static inline int hwif_to_node(ide_hwif_t *hwif)
   {
struct pci_dev *dev = to_pci_dev(hwif-dev);
  - return dev ? pcibus_to_node(dev-bus) : -1;
  + return hwif-dev ? pcibus_to_node(dev-bus) : -1;
   }
 
   static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
  Hi Bart,
  Thanks !! the patch solves the kernel panic but when after applying the 
  patch,kernel is not
  able to mount the filesystem and panics, am i not sure what is likely 
  causing the panic.
  
  Is
  
  - the commit 36501650ec45b1db308c3b51886044863be2d762 with Andi's fix 
  applied
  
  or
  
  - the commit f6fb786d6dcdd7d730e4fba620b071796f487e1b
(the one before commit 36501650ec45b1db308c3b51886044863be2d762)
  
  working for you?
 
 No, the commit 

Re: mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Bartlomiej Zolnierkiewicz wrote:
 
 Hi,
 
 On Thursday 14 February 2008, Kamalesh Babulal wrote:
  Bartlomiej Zolnierkiewicz wrote:
   Hi,
   
   On Tuesday 12 February 2008, Kamalesh Babulal wrote:
   Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Monday 11 February 2008, Kamalesh Babulal wrote:
   Nish Aravamudan wrote:
   On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
   On Thursday 07 February 2008, Kamalesh Babulal wrote:
   Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Wednesday 06 February 2008, Pavel Machek wrote:
   On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
   Hi!
  
   Trying to boot 2.6.25-git0 (few days old), I get
  
   BUG: unable to handle kernel paging request at ..ffb0
   IP at init_irq+0x42e
   init_irq? hmm...
  
   Call trace:
   ide_device_add_all
   this comes from ide-generic
   (Generic IDE host driver)
  
   ide_generic_init
   kernel_init
   child_rip
   vgacon_cursor
   kernel_init
   child_rip
  
   Excerpt from config:
  
   CONFIG_IDE=y
   CONFIG_BLK_DEV_IDE=y
   Disabling CONFIG_IDE made my machine boot, as it was using libata
   anyway.
   Kamalesh/Pavel:
  
   Could you try latest git and see if the OOPS is still there?
  
   [ Yeah, I'm unable to reproduce it. :( ]
  
   Thanks,
   Bart
   Hi Bart,
  
   The panic is reproducible with the 2.6.24-git16 kernel, the call 
   trace is
   similar to the previous one
   Thanks, I again reviewed ide-probe.c changes but nothing seems 
   wrong...
  
   Could you please bisect it down to the guilty commit?
   Kamalesh, were you able to bisect this down? I just got hit by the
   same panic on a 4-way x86_64, with 2.6.24-git22.
  
   Thanks,
   Nish
   Hi Nish,
  
   I tried bisecting and the guilty patch seems to be 
  
   36501650ec45b1db308c3b51886044863be2d762 is first bad commit
   commit 36501650ec45b1db308c3b51886044863be2d762
   Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
   Date:   Fri Feb 1 23:09:31 2008 +0100
  
   ide: keep pointer to struct device instead of struct pci_dev in 
   ide_hwif_t
  
  
   the gdb output, also points to the changes made by the guilty patch
  
   (gdb) p ide_device_add_all
   $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
   ide_device_add_all
   (gdb) p/x 0x804176ac+0xb60
   $2 = 0x8041820c
   (gdb) l *0x8041820c
   0x8041820c is in ide_device_add_all 
   (drivers/ide/ide-probe.c:1249).
   1244goto out;
   1245}
   1246
   1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
   1248
   1249if (init_irq(hwif) == 0)
   1250goto done;
   1251
   1252old_irq = hwif-irq;
   1253/*
   (gdb) 
  
  
   (gdb) p init_irq
   $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
   (gdb) p/x 0x8041721f+0x1a4
   $2 = 0x804173c3
   (gdb) l *0x804173c3
   0x804173c3 is in init_irq (include/asm/pci.h:101).
   96  /* Returns the node based on pci bus */
   97  static inline int __pcibus_to_node(struct pci_bus *bus)
   98  {
   99  struct pci_sysdata *sd = bus-sysdata;
   100
   101 return sd-node;
   102 }
   103
   104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus 
   *bus)
   105 {
   (gdb) 
   Thanks for the detailed analysis and sorry for the bug.
  
   I think that this may has been just fixed by Andi's recent 
   hwif_to_node()
   fix (patch below, it is in Linus' tree already), could please verify 
   this?
  
   commit 1f07e988290fc45932f5028c9e2a862c37a57336
   Author: Andi Kleen [EMAIL PROTECTED]
   Date:   Mon Feb 11 01:35:20 2008 +0100
  
   Prevent IDE boot ops on NUMA system
   
   Without this patch a Opteron test system here oopses at boot with
   current git.
   
   Calling to_pci_dev() on a NULL pointer gives a negative value so the
   following NULL pointer check never triggers and then an illegal 
   address
   is referenced.  Check the unadjusted original device pointer for 
   NULL
   instead.
   
   Signed-off-by: Andi Kleen [EMAIL PROTECTED]
   Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
  
   diff --git a/include/linux/ide.h b/include/linux/ide.h
   index 23fad89..a3b69c1 100644
   --- a/include/linux/ide.h
   +++ b/include/linux/ide.h
   @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
static inline int hwif_to_node(ide_hwif_t *hwif)
{
   struct pci_dev *dev = to_pci_dev(hwif-dev);
   -   return dev ? pcibus_to_node(dev-bus) : -1;
   +   return hwif-dev ? pcibus_to_node(dev-bus) : -1;
}
  
static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
   Hi Bart,
   Thanks !! the patch solves the kernel panic but when after applying the 
   patch,kernel is not
   able to mount the filesystem and panics, am i not sure what is likely 
   causing the panic.
   
   Is
   

Re: mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread James Bottomley
On Thu, 2008-02-14 at 13:07 +0100, Bartlomiej Zolnierkiewicz wrote:
  I worry that another git-bisect session will be needed unless SCSI
  developers are already aware of the problem source.
 
 Yinghai Lu noticed that it may be actually a SES problem:
 
 http://lkml.org/lkml/2008/2/14/88
 
 [ I overlooked the above mail, sorry ]

Only if SES is enabled, is it (CONFIG_SCSI_ENCLOSURE)? ... is there
actually a dmesg of the failing system somewhere, I couldn't find it in
the (somewhat long) thread?

James




-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bug 9962] New: 2.6.26-git0: IDE oops during boot

2008-02-13 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9962

   Summary: 2.6.26-git0: IDE oops during boot
   Product: IO/Storage
   Version: 2.5
 KernelVersion: 2.6.25-git0
  Platform: All
OS/Version: Linux
  Tree: Mainline
Status: NEW
  Severity: normal
  Priority: P1
 Component: IDE
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
OtherBugsDependingO 9832
 nThis:
Regression: 1


Subject : 2.6.26-git0: IDE oops during boot
Submitter   : Kamalesh Babulal [EMAIL PROTECTED]
Date: 2008-02-12 14:34
References  : http://lkml.org/lkml/2008/2/12/91
Handled-By  : Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

This entry is being used for tracking a regression from 2.6.24.  Please don't
close it until the problem is fixed in the mainline.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-13 Thread Bartlomiej Zolnierkiewicz

Hi,

On Tuesday 12 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
  Hi,
  
  On Monday 11 February 2008, Kamalesh Babulal wrote:
  Nish Aravamudan wrote:
  On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
  On Thursday 07 February 2008, Kamalesh Babulal wrote:
  Bartlomiej Zolnierkiewicz wrote:
  Hi,
 
  On Wednesday 06 February 2008, Pavel Machek wrote:
  On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
  Hi!
 
  Trying to boot 2.6.25-git0 (few days old), I get
 
  BUG: unable to handle kernel paging request at ..ffb0
  IP at init_irq+0x42e
  init_irq? hmm...
 
  Call trace:
  ide_device_add_all
  this comes from ide-generic
  (Generic IDE host driver)
 
  ide_generic_init
  kernel_init
  child_rip
  vgacon_cursor
  kernel_init
  child_rip
 
  Excerpt from config:
 
  CONFIG_IDE=y
  CONFIG_BLK_DEV_IDE=y
  Disabling CONFIG_IDE made my machine boot, as it was using libata
  anyway.
  Kamalesh/Pavel:
 
  Could you try latest git and see if the OOPS is still there?
 
  [ Yeah, I'm unable to reproduce it. :( ]
 
  Thanks,
  Bart
  Hi Bart,
 
  The panic is reproducible with the 2.6.24-git16 kernel, the call trace 
  is
  similar to the previous one
  Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...
 
  Could you please bisect it down to the guilty commit?
  Kamalesh, were you able to bisect this down? I just got hit by the
  same panic on a 4-way x86_64, with 2.6.24-git22.
 
  Thanks,
  Nish
  Hi Nish,
 
  I tried bisecting and the guilty patch seems to be 
 
  36501650ec45b1db308c3b51886044863be2d762 is first bad commit
  commit 36501650ec45b1db308c3b51886044863be2d762
  Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
  Date:   Fri Feb 1 23:09:31 2008 +0100
 
  ide: keep pointer to struct device instead of struct pci_dev in 
  ide_hwif_t
 
 
  the gdb output, also points to the changes made by the guilty patch
 
  (gdb) p ide_device_add_all
  $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
  ide_device_add_all
  (gdb) p/x 0x804176ac+0xb60
  $2 = 0x8041820c
  (gdb) l *0x8041820c
  0x8041820c is in ide_device_add_all (drivers/ide/ide-probe.c:1249).
  1244goto out;
  1245}
  1246
  1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
  1248
  1249if (init_irq(hwif) == 0)
  1250goto done;
  1251
  1252old_irq = hwif-irq;
  1253/*
  (gdb) 
 
 
  (gdb) p init_irq
  $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
  (gdb) p/x 0x8041721f+0x1a4
  $2 = 0x804173c3
  (gdb) l *0x804173c3
  0x804173c3 is in init_irq (include/asm/pci.h:101).
  96  /* Returns the node based on pci bus */
  97  static inline int __pcibus_to_node(struct pci_bus *bus)
  98  {
  99  struct pci_sysdata *sd = bus-sysdata;
  100
  101 return sd-node;
  102 }
  103
  104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus *bus)
  105 {
  (gdb) 
  
  Thanks for the detailed analysis and sorry for the bug.
  
  I think that this may has been just fixed by Andi's recent hwif_to_node()
  fix (patch below, it is in Linus' tree already), could please verify this?
  
  commit 1f07e988290fc45932f5028c9e2a862c37a57336
  Author: Andi Kleen [EMAIL PROTECTED]
  Date:   Mon Feb 11 01:35:20 2008 +0100
  
  Prevent IDE boot ops on NUMA system
  
  Without this patch a Opteron test system here oopses at boot with
  current git.
  
  Calling to_pci_dev() on a NULL pointer gives a negative value so the
  following NULL pointer check never triggers and then an illegal address
  is referenced.  Check the unadjusted original device pointer for NULL
  instead.
  
  Signed-off-by: Andi Kleen [EMAIL PROTECTED]
  Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
  
  diff --git a/include/linux/ide.h b/include/linux/ide.h
  index 23fad89..a3b69c1 100644
  --- a/include/linux/ide.h
  +++ b/include/linux/ide.h
  @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
   static inline int hwif_to_node(ide_hwif_t *hwif)
   {
  struct pci_dev *dev = to_pci_dev(hwif-dev);
  -   return dev ? pcibus_to_node(dev-bus) : -1;
  +   return hwif-dev ? pcibus_to_node(dev-bus) : -1;
   }
  
   static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
 Hi Bart,
 Thanks !! the patch solves the kernel panic but when after applying the 
 patch,kernel is not
 able to mount the filesystem and panics, am i not sure what is likely causing 
 the panic.

Is

- the commit 36501650ec45b1db308c3b51886044863be2d762 with Andi's fix applied

or

- the commit f6fb786d6dcdd7d730e4fba620b071796f487e1b
  (the one before commit 36501650ec45b1db308c3b51886044863be2d762)

working for you?

 Creating root device.
 Mounting root filesystem.
 mount: could not  find filesystem
 Kernel panic - not syncing: Attempted to kill init!

Is 

[Bug 9962] 2.6.26-git0: IDE oops during boot

2008-02-13 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9962





--- Comment #2 from [EMAIL PROTECTED]  2008-02-13 15:02 ---
As stated above, the Bugzilla entry is for tracking the regression.  If you
think it should be reassigned, please let me know and I'll do that.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bug 9962] 2.6.26-git0: IDE oops during boot

2008-02-13 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9962





--- Comment #1 from [EMAIL PROTECTED]  2008-02-13 14:38 ---
What makes you think that it is actually an IDE problem?  The initial problem
(which Andi fixed) was with *ide_generic* oopsing and could be just
work-arounded by disabling ide_generic (like reported by Pavel).

Asking Kamalesh to provide dmesg output instead would be far more useful than
opening this bugzilla entry...


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bug 9962] 2.6.26-git0: IDE oops during boot

2008-02-13 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9962





--- Comment #3 from [EMAIL PROTECTED]  2008-02-13 15:58 ---
Yes, it should be reassigned to under investigation department.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Bug 9962] 2.6.26-git0: IDE oops during boot

2008-02-13 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9962





--- Comment #4 from [EMAIL PROTECTED]  2008-02-13 16:09 ---
Also the bug summary is totally wrong now since IDE OOPS has been already
fixed,
the problem now is:

Creating root device.
Mounting root filesystem.
mount: could not  find filesystem
Kernel panic - not syncing: Attempted to kill init!

but hopefully we will know more soon.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-12 Thread Kamalesh Babulal
Bartlomiej Zolnierkiewicz wrote:
 Hi,
 
 On Monday 11 February 2008, Kamalesh Babulal wrote:
 Nish Aravamudan wrote:
 On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
 On Thursday 07 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
 Hi,

 On Wednesday 06 February 2008, Pavel Machek wrote:
 On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
 Hi!

 Trying to boot 2.6.25-git0 (few days old), I get

 BUG: unable to handle kernel paging request at ..ffb0
 IP at init_irq+0x42e
 init_irq? hmm...

 Call trace:
 ide_device_add_all
 this comes from ide-generic
 (Generic IDE host driver)

 ide_generic_init
 kernel_init
 child_rip
 vgacon_cursor
 kernel_init
 child_rip

 Excerpt from config:

 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDE=y
 Disabling CONFIG_IDE made my machine boot, as it was using libata
 anyway.
 Kamalesh/Pavel:

 Could you try latest git and see if the OOPS is still there?

 [ Yeah, I'm unable to reproduce it. :( ]

 Thanks,
 Bart
 Hi Bart,

 The panic is reproducible with the 2.6.24-git16 kernel, the call trace is
 similar to the previous one
 Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...

 Could you please bisect it down to the guilty commit?
 Kamalesh, were you able to bisect this down? I just got hit by the
 same panic on a 4-way x86_64, with 2.6.24-git22.

 Thanks,
 Nish
 Hi Nish,

 I tried bisecting and the guilty patch seems to be 

 36501650ec45b1db308c3b51886044863be2d762 is first bad commit
 commit 36501650ec45b1db308c3b51886044863be2d762
 Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
 Date:   Fri Feb 1 23:09:31 2008 +0100

 ide: keep pointer to struct device instead of struct pci_dev in 
 ide_hwif_t


 the gdb output, also points to the changes made by the guilty patch

 (gdb) p ide_device_add_all
 $1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
 ide_device_add_all
 (gdb) p/x 0x804176ac+0xb60
 $2 = 0x8041820c
 (gdb) l *0x8041820c
 0x8041820c is in ide_device_add_all (drivers/ide/ide-probe.c:1249).
 1244goto out;
 1245}
 1246
 1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
 1248
 1249if (init_irq(hwif) == 0)
 1250goto done;
 1251
 1252old_irq = hwif-irq;
 1253/*
 (gdb) 


 (gdb) p init_irq
 $1 = {int (ide_hwif_t *)} 0x8041721f init_irq
 (gdb) p/x 0x8041721f+0x1a4
 $2 = 0x804173c3
 (gdb) l *0x804173c3
 0x804173c3 is in init_irq (include/asm/pci.h:101).
 96  /* Returns the node based on pci bus */
 97  static inline int __pcibus_to_node(struct pci_bus *bus)
 98  {
 99  struct pci_sysdata *sd = bus-sysdata;
 100
 101 return sd-node;
 102 }
 103
 104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus *bus)
 105 {
 (gdb) 
 
 Thanks for the detailed analysis and sorry for the bug.
 
 I think that this may has been just fixed by Andi's recent hwif_to_node()
 fix (patch below, it is in Linus' tree already), could please verify this?
 
 commit 1f07e988290fc45932f5028c9e2a862c37a57336
 Author: Andi Kleen [EMAIL PROTECTED]
 Date:   Mon Feb 11 01:35:20 2008 +0100
 
 Prevent IDE boot ops on NUMA system
 
 Without this patch a Opteron test system here oopses at boot with
 current git.
 
 Calling to_pci_dev() on a NULL pointer gives a negative value so the
 following NULL pointer check never triggers and then an illegal address
 is referenced.  Check the unadjusted original device pointer for NULL
 instead.
 
 Signed-off-by: Andi Kleen [EMAIL PROTECTED]
 Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
 
 diff --git a/include/linux/ide.h b/include/linux/ide.h
 index 23fad89..a3b69c1 100644
 --- a/include/linux/ide.h
 +++ b/include/linux/ide.h
 @@ -1295,7 +1295,7 @@ static inline void ide_dump_identify(u8 *id)
  static inline int hwif_to_node(ide_hwif_t *hwif)
  {
   struct pci_dev *dev = to_pci_dev(hwif-dev);
 - return dev ? pcibus_to_node(dev-bus) : -1;
 + return hwif-dev ? pcibus_to_node(dev-bus) : -1;
  }
 
  static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)
Hi Bart,
Thanks !! the patch solves the kernel panic but when after applying the 
patch,kernel is not
able to mount the filesystem and panics, am i not sure what is likely causing 
the panic.

Creating root device.
Mounting root filesystem.
mount: could not  find filesystem
Kernel panic - not syncing: Attempted to kill init!


-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-10 Thread Nish Aravamudan
On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:

 On Thursday 07 February 2008, Kamalesh Babulal wrote:
  Bartlomiej Zolnierkiewicz wrote:
   Hi,
  
   On Wednesday 06 February 2008, Pavel Machek wrote:
   On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
   Hi!
  
   Trying to boot 2.6.25-git0 (few days old), I get
  
   BUG: unable to handle kernel paging request at ..ffb0
   IP at init_irq+0x42e
  
   init_irq? hmm...
  
   Call trace:
   ide_device_add_all
  
   this comes from ide-generic
   (Generic IDE host driver)
  
   ide_generic_init
   kernel_init
   child_rip
   vgacon_cursor
   kernel_init
   child_rip
  
   Excerpt from config:
  
   CONFIG_IDE=y
   CONFIG_BLK_DEV_IDE=y
   Disabling CONFIG_IDE made my machine boot, as it was using libata
   anyway.
  
   Kamalesh/Pavel:
  
   Could you try latest git and see if the OOPS is still there?
  
   [ Yeah, I'm unable to reproduce it. :( ]
  
   Thanks,
   Bart
  Hi Bart,
 
  The panic is reproducible with the 2.6.24-git16 kernel, the call trace is
  similar to the previous one

 Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...

 Could you please bisect it down to the guilty commit?

Kamalesh, were you able to bisect this down? I just got hit by the
same panic on a 4-way x86_64, with 2.6.24-git22.

Thanks,
Nish
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-10 Thread Kamalesh Babulal
Nish Aravamudan wrote:
 On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
 On Thursday 07 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
 Hi,

 On Wednesday 06 February 2008, Pavel Machek wrote:
 On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
 Hi!

 Trying to boot 2.6.25-git0 (few days old), I get

 BUG: unable to handle kernel paging request at ..ffb0
 IP at init_irq+0x42e
 init_irq? hmm...

 Call trace:
 ide_device_add_all
 this comes from ide-generic
 (Generic IDE host driver)

 ide_generic_init
 kernel_init
 child_rip
 vgacon_cursor
 kernel_init
 child_rip

 Excerpt from config:

 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDE=y
 Disabling CONFIG_IDE made my machine boot, as it was using libata
 anyway.
 Kamalesh/Pavel:

 Could you try latest git and see if the OOPS is still there?

 [ Yeah, I'm unable to reproduce it. :( ]

 Thanks,
 Bart
 Hi Bart,

 The panic is reproducible with the 2.6.24-git16 kernel, the call trace is
 similar to the previous one
 Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...

 Could you please bisect it down to the guilty commit?
 
 Kamalesh, were you able to bisect this down? I just got hit by the
 same panic on a 4-way x86_64, with 2.6.24-git22.
 
 Thanks,
 Nish

Hi Nish,

I tried bisecting and the guilty patch seems to be 

36501650ec45b1db308c3b51886044863be2d762 is first bad commit
commit 36501650ec45b1db308c3b51886044863be2d762
Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Date:   Fri Feb 1 23:09:31 2008 +0100

ide: keep pointer to struct device instead of struct pci_dev in ide_hwif_t


the gdb output, also points to the changes made by the guilty patch

(gdb) p ide_device_add_all
$1 = {int (u8 *, const struct ide_port_info *)} 0x804176ac 
ide_device_add_all
(gdb) p/x 0x804176ac+0xb60
$2 = 0x8041820c
(gdb) l *0x8041820c
0x8041820c is in ide_device_add_all (drivers/ide/ide-probe.c:1249).
1244goto out;
1245}
1246
1247sg_init_table(hwif-sg_table, hwif-sg_max_nents);
1248
1249if (init_irq(hwif) == 0)
1250goto done;
1251
1252old_irq = hwif-irq;
1253/*
(gdb) 


(gdb) p init_irq
$1 = {int (ide_hwif_t *)} 0x8041721f init_irq
(gdb) p/x 0x8041721f+0x1a4
$2 = 0x804173c3
(gdb) l *0x804173c3
0x804173c3 is in init_irq (include/asm/pci.h:101).
96  /* Returns the node based on pci bus */
97  static inline int __pcibus_to_node(struct pci_bus *bus)
98  {
99  struct pci_sysdata *sd = bus-sysdata;
100
101 return sd-node;
102 }
103
104 static inline cpumask_t __pcibus_to_cpumask(struct pci_bus *bus)
105 {
(gdb) 


-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-07 Thread Kamalesh Babulal
Bartlomiej Zolnierkiewicz wrote:
 Hi,
 
 On Wednesday 06 February 2008, Pavel Machek wrote:
 On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
 Hi!

 Trying to boot 2.6.25-git0 (few days old), I get

 BUG: unable to handle kernel paging request at ..ffb0
 IP at init_irq+0x42e
 
 init_irq? hmm...
 
 Call trace:
 ide_device_add_all
 
 this comes from ide-generic
 (Generic IDE host driver)
 
 ide_generic_init
 kernel_init
 child_rip
 vgacon_cursor
 kernel_init
 child_rip

 Excerpt from config:

 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDE=y
 Disabling CONFIG_IDE made my machine boot, as it was using libata
 anyway.
 
 Kamalesh/Pavel:
 
 Could you try latest git and see if the OOPS is still there?
 
 [ Yeah, I'm unable to reproduce it. :( ]
 
 Thanks,
 Bart
Hi Bart,

The panic is reproducible with the 2.6.24-git16 kernel, the call trace is
similar to the previous one

BUG: unable to handle kernel paging request at ffa0
IP: [80415673] init_irq+0x188/0x444
PGD 203067 PUD 204067 PMD 0 
Oops:  [1] SMP 
CPU 3 
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.24-git16 #1
RIP: 0010:[80415673]  [80415673] init_irq+0x188/0x444
RSP: :81022f093e00  EFLAGS: 00010282
RAX: ff80 RBX: 808ad200 RCX: 
RDX:  RSI: 81022fc039c0 RDI: 807512c0
RBP: 81022f093e30 R08: 81022f093d70 R09: 0002
R10: 0001 R11: 81022f093c00 R12: 808b4500
R13: 808b4510 R14:  R15: 
FS:  () GS:81022f0e7ac0() knlGS:
CS:  0010 DS: 0018 ES: 0018 CR0: 8005003b
CR2: ffa0 CR3: 00201000 CR4: 06e0
DR0:  DR1:  DR2: 
DR3:  DR6: 0ff0 DR7: 0400
Process swapper (pid: 1, threadinfo 81022f092000, task 81022f0797e0)
Stack:  81022f093e30  808ad200 808ad220
 808add80  81022f093eb0 8041648f
 81022f093ec0  80751ee0 0246
Call Trace:
 [8041648f] ide_device_add_all+0xb60/0xe54
 [807d6d48] ide_generic_init+0x46/0x4a
 [807b873b] kernel_init+0x175/0x2e7
 [8020bff8] child_rip+0xa/0x12
 [8037476c] acpi_ds_init_one_object+0x0/0x88
 [807b85c6] kernel_init+0x0/0x2e7
 [8020bfee] child_rip+0x0/0x12


Code: 89 03 49 8b 45 18 48 89 18 48 39 1b 75 04 0f 0b eb fe fe 05 20 71 38 00 
fb eb 5b 48 8b 83 20 07 00 00 83 ca ff 48 83 c0 80 74 0e 48 8b 40 20 48 8b 80 
88 00 00 00 8b 50 04 48 8b 3d 48 11 30 00 
RIP  [80415673] init_irq+0x188/0x444
 RSP 81022f093e00
CR2: ffa0
---[ end trace 165798c72d52c3e3 ]---


-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-07 Thread Bartlomiej Zolnierkiewicz

On Thursday 07 February 2008, Kamalesh Babulal wrote:
 Bartlomiej Zolnierkiewicz wrote:
  Hi,
  
  On Wednesday 06 February 2008, Pavel Machek wrote:
  On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
  Hi!
 
  Trying to boot 2.6.25-git0 (few days old), I get
 
  BUG: unable to handle kernel paging request at ..ffb0
  IP at init_irq+0x42e
  
  init_irq? hmm...
  
  Call trace:
  ide_device_add_all
  
  this comes from ide-generic
  (Generic IDE host driver)
  
  ide_generic_init
  kernel_init
  child_rip
  vgacon_cursor
  kernel_init
  child_rip
 
  Excerpt from config:
 
  CONFIG_IDE=y
  CONFIG_BLK_DEV_IDE=y
  Disabling CONFIG_IDE made my machine boot, as it was using libata
  anyway.
  
  Kamalesh/Pavel:
  
  Could you try latest git and see if the OOPS is still there?
  
  [ Yeah, I'm unable to reproduce it. :( ]
  
  Thanks,
  Bart
 Hi Bart,
 
 The panic is reproducible with the 2.6.24-git16 kernel, the call trace is
 similar to the previous one

Thanks, I again reviewed ide-probe.c changes but nothing seems wrong...

Could you please bisect it down to the guilty commit?

 BUG: unable to handle kernel paging request at ffa0
 IP: [80415673] init_irq+0x188/0x444

Please also try disassembling init_irq using gdb so we see where it fails.

Bart

 PGD 203067 PUD 204067 PMD 0 
 Oops:  [1] SMP 
 CPU 3 
 Modules linked in:
 Pid: 1, comm: swapper Not tainted 2.6.24-git16 #1
 RIP: 0010:[80415673]  [80415673] init_irq+0x188/0x444
 RSP: :81022f093e00  EFLAGS: 00010282
 RAX: ff80 RBX: 808ad200 RCX: 
 RDX:  RSI: 81022fc039c0 RDI: 807512c0
 RBP: 81022f093e30 R08: 81022f093d70 R09: 0002
 R10: 0001 R11: 81022f093c00 R12: 808b4500
 R13: 808b4510 R14:  R15: 
 FS:  () GS:81022f0e7ac0() knlGS:
 CS:  0010 DS: 0018 ES: 0018 CR0: 8005003b
 CR2: ffa0 CR3: 00201000 CR4: 06e0
 DR0:  DR1:  DR2: 
 DR3:  DR6: 0ff0 DR7: 0400
 Process swapper (pid: 1, threadinfo 81022f092000, task 81022f0797e0)
 Stack:  81022f093e30  808ad200 808ad220
  808add80  81022f093eb0 8041648f
  81022f093ec0  80751ee0 0246
 Call Trace:
  [8041648f] ide_device_add_all+0xb60/0xe54
  [807d6d48] ide_generic_init+0x46/0x4a
  [807b873b] kernel_init+0x175/0x2e7
  [8020bff8] child_rip+0xa/0x12
  [8037476c] acpi_ds_init_one_object+0x0/0x88
  [807b85c6] kernel_init+0x0/0x2e7
  [8020bfee] child_rip+0x0/0x12
 
 
 Code: 89 03 49 8b 45 18 48 89 18 48 39 1b 75 04 0f 0b eb fe fe 05 20 71 38 00 
 fb eb 5b 48 8b 83 20 07 00 00 83 ca ff 48 83 c0 80 74 0e 48 8b 40 20 48 8b 
 80 88 00 00 00 8b 50 04 48 8b 3d 48 11 30 00 
 RIP  [80415673] init_irq+0x188/0x444
  RSP 81022f093e00
 CR2: ffa0
 ---[ end trace 165798c72d52c3e3 ]---
 
 
 -- 
 Thanks  Regards,
 Kamalesh Babulal,
 Linux Technology Center,
 IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-06 Thread Pavel Machek
On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
 Hi!
 
 Trying to boot 2.6.25-git0 (few days old), I get
 
 BUG: unable to handle kernel paging request at ..ffb0
 IP at init_irq+0x42e
 
 Call trace:
 ide_device_add_all
 ide_generic_init
 kernel_init
 child_rip
 vgacon_cursor
 kernel_init
 child_rip
 
 Excerpt from config:
 
 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDE=y

Disabling CONFIG_IDE made my machine boot, as it was using libata
anyway.
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.26-git0: IDE oops during boot

2008-02-06 Thread Bartlomiej Zolnierkiewicz

Hi,

On Wednesday 06 February 2008, Pavel Machek wrote:
 On Wed 2008-02-06 11:53:34, Pavel Machek wrote:
  Hi!
  
  Trying to boot 2.6.25-git0 (few days old), I get
  
  BUG: unable to handle kernel paging request at ..ffb0
  IP at init_irq+0x42e

init_irq? hmm...

  Call trace:
  ide_device_add_all

this comes from ide-generic
(Generic IDE host driver)

  ide_generic_init
  kernel_init
  child_rip
  vgacon_cursor
  kernel_init
  child_rip
  
  Excerpt from config:
  
  CONFIG_IDE=y
  CONFIG_BLK_DEV_IDE=y
 
 Disabling CONFIG_IDE made my machine boot, as it was using libata
 anyway.

Kamalesh/Pavel:

Could you try latest git and see if the OOPS is still there?

[ Yeah, I'm unable to reproduce it. :( ]

Thanks,
Bart
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html