Re: [PATCH 3/3] input: goodix: Add bindings documentation

2015-01-19 Thread Arnd Bergmann 
On Saturday 17 January 2015 17:36:50 Aleksei Mamlin wrote:
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt
 @@ -0,0 +1,23 @@
 +Device tree bindings for Goodix GT9xx series touchscreen controller
 +
 +Required properties:
 +
 + - compatible  : Should be goodix,gt9xx
 + - reg : I2C address of the chip
 + - interrupt-parent: Interrupt controller to which the chip is connected
 + - interrupts  : Interrupt to which the chip is connected
 +
 

You should avoid the use of wildcards in compatible strings. Better list
all the known part numbers, or (if they are 100% compatible with one another)
pick the oldest one we support and use that as the compatible string.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] input: goodix: Add bindings documentation

2015-01-17 Thread Aleksei Mamlin 
Signed-off-by: Aleksei Mamlin mamli...@gmail.com
---
 .../bindings/input/touchscreen/gt9xx.txt   | 23 ++
 1 file changed, 23 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt

diff --git a/Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt 
b/Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt
new file mode 100644
index 000..96c17f0
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt
@@ -0,0 +1,23 @@
+Device tree bindings for Goodix GT9xx series touchscreen controller
+
+Required properties:
+
+ - compatible  : Should be goodix,gt9xx
+ - reg : I2C address of the chip
+ - interrupt-parent: Interrupt controller to which the chip is connected
+ - interrupts  : Interrupt to which the chip is connected
+
+Example:
+
+   i2c@ {
+   /* ... */
+
+   gt9xx@5d {
+   compatible = goodix,gt9xx;
+   reg = 0x5d;
+   interrupt-parent = gpio;
+   interrupts = 0 2;
+   };
+
+   /* ... */
+   };
-- 
2.0.5

--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html