[PATCH] staging: wilc1000: Added spaces

2015-09-16 Thread Aparna Karuthodi
Added spaces around '=' to remove coding style errors detected by
checkpatch.The errors are given below:
drivers/staging/wilc1000/host_interface.c:7951: ERROR: spaces required
around that '=' (ctx:VxV)
drivers/staging/wilc1000/host_interface.c:7952: ERROR: spaces required
around that '=' (ctx:VxW)

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/wilc1000/host_interface.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 6b10bbb..d1fe73d 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -7945,8 +7945,8 @@ s32 host_int_get_ipaddress(WILC_WFIDrvHandle hWFIDrv, u8 
*u16ipadd, u8 idx)
strHostIFmsg.u16MsgId = HOST_IF_MSG_GET_IPADDRESS;
 
strHostIFmsg.uniHostIFmsgBody.strHostIfSetIP.au8IPAddr = u16ipadd;
-   strHostIFmsg.drvHandler=hWFIDrv;
-   strHostIFmsg.uniHostIFmsgBody.strHostIfSetIP.idx= idx;
+   strHostIFmsg.drvHandler = hWFIDrv;
+   strHostIFmsg.uniHostIFmsgBody.strHostIfSetIP.idx = idx;
 
s32Error = WILC_MsgQueueSend(, , 
sizeof(tstrHostIFmsg), NULL);
if (s32Error) {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Removed unwanted curly braces

2015-09-16 Thread Aparna Karuthodi
Removed unwanted curly braces of a single statement if-else block to
remove a coding style warning detected by checkpatch. The warning is
given below:

58: WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/wilc1000/fifo_buffer.c |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/fifo_buffer.c 
b/drivers/staging/wilc1000/fifo_buffer.c
index b6c07cf..4fbac3d 100644
--- a/drivers/staging/wilc1000/fifo_buffer.c
+++ b/drivers/staging/wilc1000/fifo_buffer.c
@@ -52,11 +52,10 @@ u32 FIFO_ReadBytes(tHANDLE hFifo, u8 *pu8Buffer, u32 
u32BytesToRead, u32 *pu32By
if (pstrFifoHandler->u32TotalBytes) {
down(>SemBuffer);
 
-   if (u32BytesToRead > pstrFifoHandler->u32TotalBytes) {
+   if (u32BytesToRead > pstrFifoHandler->u32TotalBytes)
*pu32BytesRead = pstrFifoHandler->u32TotalBytes;
-   } else {
+else
*pu32BytesRead = u32BytesToRead;
-   }
if ((pstrFifoHandler->u32ReadOffset + u32BytesToRead) 
<= pstrFifoHandler->u32BufferLength) {
WILC_memcpy(pu8Buffer, 
pstrFifoHandler->pu8Buffer + pstrFifoHandler->u32ReadOffset,
*pu32BytesRead);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Added new lines

2015-09-16 Thread Aparna Karuthodi
Added new lines after declarations for removing coding style warnings
detected by checkpatch.The warnings are given below:

1561: WARNING: Missing a blank line after declarations
1551: WARNING: Missing a blank line after declarations
1329: WARNING: Missing a blank line after declarations
1213: WARNING: Missing a blank line after declarations
1158: WARNING: Missing a blank line after declarations
1104: WARNING: Missing a blank line after declarations
675: WARNING: Missing a blank line after declarations

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/wilc1000/coreconfigurator.c |7 +++
 1 file changed, 7 insertions(+)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index 5241699..dad03f3 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -669,6 +669,7 @@ INLINE u16 get_asoc_id(u8 *data)
 s32 CoreConfiguratorInit(void)
 {
s32 s32Error = WILC_SUCCESS;
+
PRINT_D(CORECONFIG_DBG, "CoreConfiguratorInit()\n");
 
sema_init(, 1);
@@ -1098,6 +1099,7 @@ void ProcessCharWid(char *pcPacket, s32 *ps32PktLen,
u8 *pu8val = (u8 *)ps8WidVal;
u8 u8val = 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set CHAR val 0x%x ,NULL 
structure\n", u8val);
return;
@@ -1152,6 +1154,7 @@ void ProcessShortWid(char *pcPacket, s32 *ps32PktLen,
u16 *pu16val = (u16 *)ps8WidVal;
u16 u16val = 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set SHORT val 0x%x ,NULL 
structure\n", u16val);
return;
@@ -1207,6 +1210,7 @@ void ProcessIntWid(char *pcPacket, s32 *ps32PktLen,
u32 *pu32val = (u32 *)ps8WidVal;
u32 u32val = 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set INT val 0x%x , NULL 
structure\n", u32val);
return;
@@ -1323,6 +1327,7 @@ void ProcessStrWid(char *pcPacket, s32 *ps32PktLen,
u16 u16MsgLen = 0;
u16 idx= 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set STR val, NULL 
structure\n");
return;
@@ -1545,6 +1550,7 @@ s32 further_process_response(u8 *resp,
case WID_SHORT:
{
u16 *pu16val = (u16 *)(pstrWIDresult->ps8WidVal);
+
cfg_sht = MAKE_WORD16(resp[idx], resp[idx + 1]);
/*Set local copy of WID*/
/* pstrWIDresult->ps8WidVal = (s8*)(s32)cfg_sht; */
@@ -1555,6 +1561,7 @@ s32 further_process_response(u8 *resp,
case WID_INT:
{
u32 *pu32val = (u32 *)(pstrWIDresult->ps8WidVal);
+
cfg_int = MAKE_WORD32(
MAKE_WORD16(resp[idx], resp[idx + 1]),
MAKE_WORD16(resp[idx + 2], resp[idx + 3])
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Added new lines

2015-09-16 Thread Aparna Karuthodi
Added new lines after declarations for removing coding style warnings
detected by checkpatch.The warnings are given below:

1561: WARNING: Missing a blank line after declarations
1551: WARNING: Missing a blank line after declarations
1329: WARNING: Missing a blank line after declarations
1213: WARNING: Missing a blank line after declarations
1158: WARNING: Missing a blank line after declarations
1104: WARNING: Missing a blank line after declarations
675: WARNING: Missing a blank line after declarations

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c |7 +++
 1 file changed, 7 insertions(+)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index 5241699..dad03f3 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -669,6 +669,7 @@ INLINE u16 get_asoc_id(u8 *data)
 s32 CoreConfiguratorInit(void)
 {
s32 s32Error = WILC_SUCCESS;
+
PRINT_D(CORECONFIG_DBG, "CoreConfiguratorInit()\n");
 
sema_init(, 1);
@@ -1098,6 +1099,7 @@ void ProcessCharWid(char *pcPacket, s32 *ps32PktLen,
u8 *pu8val = (u8 *)ps8WidVal;
u8 u8val = 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set CHAR val 0x%x ,NULL 
structure\n", u8val);
return;
@@ -1152,6 +1154,7 @@ void ProcessShortWid(char *pcPacket, s32 *ps32PktLen,
u16 *pu16val = (u16 *)ps8WidVal;
u16 u16val = 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set SHORT val 0x%x ,NULL 
structure\n", u16val);
return;
@@ -1207,6 +1210,7 @@ void ProcessIntWid(char *pcPacket, s32 *ps32PktLen,
u32 *pu32val = (u32 *)ps8WidVal;
u32 u32val = 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set INT val 0x%x , NULL 
structure\n", u32val);
return;
@@ -1323,6 +1327,7 @@ void ProcessStrWid(char *pcPacket, s32 *ps32PktLen,
u16 u16MsgLen = 0;
u16 idx= 0;
s32 s32PktLen = *ps32PktLen;
+
if (pstrWID == NULL) {
PRINT_WRN(CORECONFIG_DBG, "Can't set STR val, NULL 
structure\n");
return;
@@ -1545,6 +1550,7 @@ s32 further_process_response(u8 *resp,
case WID_SHORT:
{
u16 *pu16val = (u16 *)(pstrWIDresult->ps8WidVal);
+
cfg_sht = MAKE_WORD16(resp[idx], resp[idx + 1]);
/*Set local copy of WID*/
/* pstrWIDresult->ps8WidVal = (s8*)(s32)cfg_sht; */
@@ -1555,6 +1561,7 @@ s32 further_process_response(u8 *resp,
case WID_INT:
{
u32 *pu32val = (u32 *)(pstrWIDresult->ps8WidVal);
+
cfg_int = MAKE_WORD32(
MAKE_WORD16(resp[idx], resp[idx + 1]),
MAKE_WORD16(resp[idx + 2], resp[idx + 3])
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Removed unwanted curly braces

2015-09-16 Thread Aparna Karuthodi
Removed unwanted curly braces of a single statement if-else block to
remove a coding style warning detected by checkpatch. The warning is
given below:

58: WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/wilc1000/fifo_buffer.c |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/fifo_buffer.c 
b/drivers/staging/wilc1000/fifo_buffer.c
index b6c07cf..4fbac3d 100644
--- a/drivers/staging/wilc1000/fifo_buffer.c
+++ b/drivers/staging/wilc1000/fifo_buffer.c
@@ -52,11 +52,10 @@ u32 FIFO_ReadBytes(tHANDLE hFifo, u8 *pu8Buffer, u32 
u32BytesToRead, u32 *pu32By
if (pstrFifoHandler->u32TotalBytes) {
down(>SemBuffer);
 
-   if (u32BytesToRead > pstrFifoHandler->u32TotalBytes) {
+   if (u32BytesToRead > pstrFifoHandler->u32TotalBytes)
*pu32BytesRead = pstrFifoHandler->u32TotalBytes;
-   } else {
+else
*pu32BytesRead = u32BytesToRead;
-   }
if ((pstrFifoHandler->u32ReadOffset + u32BytesToRead) 
<= pstrFifoHandler->u32BufferLength) {
WILC_memcpy(pu8Buffer, 
pstrFifoHandler->pu8Buffer + pstrFifoHandler->u32ReadOffset,
*pu32BytesRead);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Added spaces

2015-09-16 Thread Aparna Karuthodi
Added spaces around '=' to remove coding style errors detected by
checkpatch.The errors are given below:
drivers/staging/wilc1000/host_interface.c:7951: ERROR: spaces required
around that '=' (ctx:VxV)
drivers/staging/wilc1000/host_interface.c:7952: ERROR: spaces required
around that '=' (ctx:VxW)

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index 6b10bbb..d1fe73d 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -7945,8 +7945,8 @@ s32 host_int_get_ipaddress(WILC_WFIDrvHandle hWFIDrv, u8 
*u16ipadd, u8 idx)
strHostIFmsg.u16MsgId = HOST_IF_MSG_GET_IPADDRESS;
 
strHostIFmsg.uniHostIFmsgBody.strHostIfSetIP.au8IPAddr = u16ipadd;
-   strHostIFmsg.drvHandler=hWFIDrv;
-   strHostIFmsg.uniHostIFmsgBody.strHostIfSetIP.idx= idx;
+   strHostIFmsg.drvHandler = hWFIDrv;
+   strHostIFmsg.uniHostIFmsgBody.strHostIfSetIP.idx = idx;
 
s32Error = WILC_MsgQueueSend(, , 
sizeof(tstrHostIFmsg), NULL);
if (s32Error) {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Removed curly braces

2015-09-15 Thread Aparna Karuthodi
Removed the curly braces of a single statement if block to remove a
coding style warning detected by checkpatch.
The warning is given below:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/wilc1000/coreconfigurator.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index 0c964c6..5241699 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -1944,9 +1944,8 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
gstrConfigPktInfo.bRespRequired = bRespRequired;
 
s32Error = SendRawPacket(gps8ConfigPacket, s32ConfigPacketLen);
-   if (s32Error != WILC_SUCCESS) {
+   if (s32Error != WILC_SUCCESS)
goto End_ConfigPkt;
-   }
 
WILC_memset((void *)gps8ConfigPacket, 0, MAX_PACKET_BUFF_SIZE);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Removed curly braces

2015-09-15 Thread Aparna Karuthodi
Removed the curly braces of a single statement if block to remove a
coding style warning detected by checkpatch.
The warning is given below:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index 0c964c6..5241699 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -1944,9 +1944,8 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
gstrConfigPktInfo.bRespRequired = bRespRequired;
 
s32Error = SendRawPacket(gps8ConfigPacket, s32ConfigPacketLen);
-   if (s32Error != WILC_SUCCESS) {
+   if (s32Error != WILC_SUCCESS)
goto End_ConfigPkt;
-   }
 
WILC_memset((void *)gps8ConfigPacket, 0, MAX_PACKET_BUFF_SIZE);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Added a new line

2015-09-13 Thread Aparna Karuthodi
Added a new line after declaration to remove a coding style warning
detected by checkpatch. The warning is given below
WARNING: Missing a blank line after declarations

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/wilc1000/coreconfigurator.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index ed6ac45..0c964c6 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -2101,6 +2101,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
  u32 u32WIDsCount, bool bRespRequired, u32 drvHandler)
 {
s32 counter = 0, ret = 0;
+
if (gpstrWlanOps == NULL) {
PRINT_D(CORECONFIG_DBG, "Net Dev is still not initialized\n");
return 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wilc1000: Added a new line

2015-09-13 Thread Aparna Karuthodi
Added a new line after declaration to remove a coding style warning
detected by checkpatch. The warning is given below
WARNING: Missing a blank line after declarations

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c 
b/drivers/staging/wilc1000/coreconfigurator.c
index ed6ac45..0c964c6 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -2101,6 +2101,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
  u32 u32WIDsCount, bool bRespRequired, u32 drvHandler)
 {
s32 counter = 0, ret = 0;
+
if (gpstrWlanOps == NULL) {
PRINT_D(CORECONFIG_DBG, "Net Dev is still not initialized\n");
return 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: speakup: Changed simple_strtoul to kstrtoul

2015-09-11 Thread Aparna Karuthodi
Used kstrtoul instead of simple_strtoul to remove a warning detected by
checkpatch.The warning is given below:
drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
obsolete, use kstrtoul instead

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/speakup/varhandlers.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/varhandlers.c 
b/drivers/staging/speakup/varhandlers.c
index 1b0d1c0..00fd67e 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
 {
int val = 0;
 
-   val = simple_strtoul(skip_spaces(start), , 10);
+   val = kstrtoul(skip_spaces(start), , 10);
if (*start == ',')
start++;
*dest = (u_char)val;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul

2015-09-11 Thread Aparna Karuthodi
Used kstrtoul instead of simple_strtoul inorder to fix a warning
detected by checkpatch.
The warning is given below:
drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
obsolete, use kstrtoul instead

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/speakup/kobjects.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c 
b/drivers/staging/speakup/kobjects.c
index 3708bc1..05de0b7 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
continue;
}
 
-   index = simple_strtoul(cp, , 10);
+   index = kstrtoul(cp, , 10);
if (index > 255) {
rejected++;
cp = linefeed + 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul

2015-09-11 Thread Aparna Karuthodi
Used kstrtoul instead of simple_strtoul inorder to fix a warning
detected by checkpatch.
The warning is given below:
drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
obsolete, use kstrtoul instead

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/speakup/kobjects.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c 
b/drivers/staging/speakup/kobjects.c
index 3708bc1..05de0b7 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
continue;
}
 
-   index = simple_strtoul(cp, , 10);
+   index = kstrtoul(cp, , 10);
if (index > 255) {
rejected++;
cp = linefeed + 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: speakup: Changed simple_strtoul to kstrtoul

2015-09-11 Thread Aparna Karuthodi
Used kstrtoul instead of simple_strtoul to remove a warning detected by
checkpatch.The warning is given below:
drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
obsolete, use kstrtoul instead

Signed-off-by: Aparna Karuthodi <kdasapa...@gmail.com>
---
 drivers/staging/speakup/varhandlers.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/varhandlers.c 
b/drivers/staging/speakup/varhandlers.c
index 1b0d1c0..00fd67e 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
 {
int val = 0;
 
-   val = simple_strtoul(skip_spaces(start), , 10);
+   val = kstrtoul(skip_spaces(start), , 10);
if (*start == ',')
start++;
*dest = (u_char)val;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Made into two lines

2015-08-23 Thread Aparna Karuthodi
Oh! Sorry! I made the changes to correct the faults you figured out.
Is it okay now?

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_pcd8544.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c 
b/drivers/staging/fbtft/fb_pcd8544.c
index cf87ce8..925511f 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,8 +34,8 @@
 #define WIDTH  84
 #define HEIGHT 48
 #define TXBUFLEN   (84*6)
-#define DEFAULT_GAMMA  "40"
 /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA  "40"
 
 static unsigned tc;
 module_param(tc, uint, 0);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Made into two lines

2015-08-23 Thread Aparna Karuthodi
Oh! Sorry! I made the changes to correct the faults you figured out.
Is it okay now?

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_pcd8544.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c 
b/drivers/staging/fbtft/fb_pcd8544.c
index cf87ce8..925511f 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,8 +34,8 @@
 #define WIDTH  84
 #define HEIGHT 48
 #define TXBUFLEN   (84*6)
-#define DEFAULT_GAMMA  40
 /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA  40
 
 static unsigned tc;
 module_param(tc, uint, 0);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed space before parenthesis

2015-08-21 Thread Aparna Karuthodi
Removed space before parenthesis in two different lines to remove coding
style errors detected by checkpatch.
The errors are given below:
drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before
that close parenthesis ')'
drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before
that close parenthesis ')'

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fbtft-bus.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c 
b/drivers/staging/fbtft/fbtft-bus.c
index b3cddb0..791fab3 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...)
\
 } \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-21 Thread Aparna Karuthodi
Now I understood my mistake. I was calling git fetch or git pull not from 
master branch. Now when I ran that command from master branch it's working.

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Made into two lines

2015-08-21 Thread Aparna Karuthodi
Made the comment into a new lineto remove a coding style error detected
by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_pcd8544.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c 
b/drivers/staging/fbtft/fb_pcd8544.c
index 8b9ebfb..cf87ce8 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,7 +34,8 @@
 #define WIDTH  84
 #define HEIGHT 48
 #define TXBUFLEN   (84*6)
-#define DEFAULT_GAMMA  "40" /* gamma is used to control contrast in this 
driver */
+#define DEFAULT_GAMMA  "40"
+/* gamma is used to control contrast in this driver */
 
 static unsigned tc;
 module_param(tc, uint, 0);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-21 Thread Aparna Karuthodi
I fetched it yesterday using git fetch origin master. So, I thought I am in the 
recent kernel tree.

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-21 Thread Aparna Karuthodi
Okay. I will make the necessary changes and send it again.
If I am making changes in each of the lines, should I send it as a
patchset?

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Made into two lines

2015-08-21 Thread Aparna Karuthodi
Made the comment into a new lineto remove a coding style error detected
by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_pcd8544.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c 
b/drivers/staging/fbtft/fb_pcd8544.c
index 8b9ebfb..cf87ce8 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,7 +34,8 @@
 #define WIDTH  84
 #define HEIGHT 48
 #define TXBUFLEN   (84*6)
-#define DEFAULT_GAMMA  40 /* gamma is used to control contrast in this 
driver */
+#define DEFAULT_GAMMA  40
+/* gamma is used to control contrast in this driver */
 
 static unsigned tc;
 module_param(tc, uint, 0);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-21 Thread Aparna Karuthodi
I fetched it yesterday using git fetch origin master. So, I thought I am in the 
recent kernel tree.

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-21 Thread Aparna Karuthodi
Now I understood my mistake. I was calling git fetch or git pull not from 
master branch. Now when I ran that command from master branch it's working.

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-21 Thread Aparna Karuthodi
Okay. I will make the necessary changes and send it again.
If I am making changes in each of the lines, should I send it as a
patchset?

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed space before parenthesis

2015-08-21 Thread Aparna Karuthodi
Removed space before parenthesis in two different lines to remove coding
style errors detected by checkpatch.
The errors are given below:
drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before
that close parenthesis ')'
drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before
that close parenthesis ')'

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fbtft-bus.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c 
b/drivers/staging/fbtft/fbtft-bus.c
index b3cddb0..791fab3 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...)
\
 } \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space before comma

2015-08-20 Thread Aparna Karuthodi
Removed a space before coma to remove a coding style error detected by
checkpatch.
The error is given below:
drivers/staging/fbtft/fb_ili9340.c:47: ERROR: space prohibited before
that ',' (ctx:WxW)

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_ili9340.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_ili9340.c 
b/drivers/staging/fbtft/fb_ili9340.c
index 985687d..5753f03 100644
--- a/drivers/staging/fbtft/fb_ili9340.c
+++ b/drivers/staging/fbtft/fb_ili9340.c
@@ -44,7 +44,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xE8, 0x85 , 0x00 , 0x78);
write_reg(par, 0xCB, 0x39 , 0x2C , 0x00 , 0x34 , 0x02);
write_reg(par, 0xF7, 0x20);
-   write_reg(par, 0xEA, 0x00 , 0x00);
+   write_reg(par, 0xEA, 0x00, 0x00);
 
/* Power Control 1 */
write_reg(par, 0xC0, 0x23);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-20 Thread Aparna Karuthodi
Removed a space before parenthesis to remove a coding style error
detected by checkpatch.
The error is given below:
drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before
that close parenthesis ')'

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space

2015-08-20 Thread Aparna Karuthodi
Removed a space before parenthesis to remove a coding style error
detected by checkpatch.
The error is given below:
drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before
that close parenthesis ')'

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_bd663474.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0x100, 0x7120 );
write_reg(par, 0x007, 0x0103 );
mdelay( 10 );
-   write_reg(par, 0x007, 0x0113 );
+   write_reg(par, 0x007, 0x0113);
 
return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: fbtft: Removed a space before comma

2015-08-20 Thread Aparna Karuthodi
Removed a space before coma to remove a coding style error detected by
checkpatch.
The error is given below:
drivers/staging/fbtft/fb_ili9340.c:47: ERROR: space prohibited before
that ',' (ctx:WxW)

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/fbtft/fb_ili9340.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_ili9340.c 
b/drivers/staging/fbtft/fb_ili9340.c
index 985687d..5753f03 100644
--- a/drivers/staging/fbtft/fb_ili9340.c
+++ b/drivers/staging/fbtft/fb_ili9340.c
@@ -44,7 +44,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xE8, 0x85 , 0x00 , 0x78);
write_reg(par, 0xCB, 0x39 , 0x2C , 0x00 , 0x34 , 0x02);
write_reg(par, 0xF7, 0x20);
-   write_reg(par, 0xEA, 0x00 , 0x00);
+   write_reg(par, 0xEA, 0x00, 0x00);
 
/* Power Control 1 */
write_reg(par, 0xC0, 0x23);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: i2o: Used

2015-08-18 Thread Aparna Karuthodi
Used #include  instead of  #include  to
remove a coding style warning detected by checkpatch.

The warning is given below:
drivers/staging/i2o/config-osm.c:22: WARNING: Use #include
 instead of 

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/i2o/config-osm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i2o/config-osm.c b/drivers/staging/i2o/config-osm.c
index 519f52f..45091ac 100644
--- a/drivers/staging/i2o/config-osm.c
+++ b/drivers/staging/i2o/config-osm.c
@@ -19,7 +19,7 @@
 #include 
 #include 
 
-#include 
+#include 
 
 #define OSM_NAME   "config-osm"
 #define OSM_VERSION"1.323"
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: i2o: Used linux/uaccess.h

2015-08-18 Thread Aparna Karuthodi
Used #include linux/uaccess.h instead of  #include asm/uaccess.h to
remove a coding style warning detected by checkpatch.

The warning is given below:
drivers/staging/i2o/config-osm.c:22: WARNING: Use #include
linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/i2o/config-osm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i2o/config-osm.c b/drivers/staging/i2o/config-osm.c
index 519f52f..45091ac 100644
--- a/drivers/staging/i2o/config-osm.c
+++ b/drivers/staging/i2o/config-osm.c
@@ -19,7 +19,7 @@
 #include linux/namei.h
 #include linux/fs.h
 
-#include asm/uaccess.h
+#include linux/uaccess.h
 
 #define OSM_NAME   config-osm
 #define OSM_VERSION1.323
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wlan-ng: Made into two lines

2015-08-13 Thread Aparna Karuthodi
Broke the line into two lines to remove a coding style warning detected
by checkpatch.

The warning is given below:
drivers/staging/wlan-ng/cfg80211.c:755: WARNING: line over 80
characters

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/wlan-ng/cfg80211.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c 
b/drivers/staging/wlan-ng/cfg80211.c
index 7c87aec..53e0681 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -752,7 +752,8 @@ static const struct cfg80211_ops prism2_usb_cfg_ops = {
 
 
 /* Functions to create/free wiphy interface */
-static struct wiphy *wlan_create_wiphy(struct device *dev, wlandevice_t 
*wlandev)
+static struct wiphy *wlan_create_wiphy(struct device *dev,
+wlandevice_t *wlandev)
 {
struct wiphy *wiphy;
struct prism2_wiphy_private *priv;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: wlan-ng: Made into two lines

2015-08-13 Thread Aparna Karuthodi
Broke the line into two lines to remove a coding style warning detected
by checkpatch.

The warning is given below:
drivers/staging/wlan-ng/cfg80211.c:755: WARNING: line over 80
characters

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/wlan-ng/cfg80211.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c 
b/drivers/staging/wlan-ng/cfg80211.c
index 7c87aec..53e0681 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -752,7 +752,8 @@ static const struct cfg80211_ops prism2_usb_cfg_ops = {
 
 
 /* Functions to create/free wiphy interface */
-static struct wiphy *wlan_create_wiphy(struct device *dev, wlandevice_t 
*wlandev)
+static struct wiphy *wlan_create_wiphy(struct device *dev,
+wlandevice_t *wlandev)
 {
struct wiphy *wiphy;
struct prism2_wiphy_private *priv;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: media:lirc: Added a newline character after declaration

2015-08-12 Thread Aparna Karuthodi
Added a newline character to remove a coding style warning detected
by checkpatch.

The warning is given below:
drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
across lines

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/media/lirc/lirc_serial.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_serial.c 
b/drivers/staging/media/lirc/lirc_serial.c
index 19628d0..628577f 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1165,7 +1165,7 @@ module_init(lirc_serial_init_module);
 module_exit(lirc_serial_exit_module);
 
 MODULE_DESCRIPTION("Infra-red receiver driver for serial ports.");
-MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
+MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff,\n"
  "Christoph Bartelmus, Andrei Tanas");
 MODULE_LICENSE("GPL");
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: media:lirc: Added a newline character after declaration

2015-08-12 Thread Aparna Karuthodi
Added a newline character to remove a coding style warning detected
by checkpatch.

The warning is given below:
drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
across lines

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/media/lirc/lirc_serial.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_serial.c 
b/drivers/staging/media/lirc/lirc_serial.c
index 19628d0..628577f 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1165,7 +1165,7 @@ module_init(lirc_serial_init_module);
 module_exit(lirc_serial_exit_module);
 
 MODULE_DESCRIPTION(Infra-red receiver driver for serial ports.);
-MODULE_AUTHOR(Ralph Metzler, Trent Piepho, Ben Pfaff, 
+MODULE_AUTHOR(Ralph Metzler, Trent Piepho, Ben Pfaff,\n
  Christoph Bartelmus, Andrei Tanas);
 MODULE_LICENSE(GPL);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: lustre: lustre: llite: Added a new line after declaration

2015-08-10 Thread Aparna Karuthodi
Added a new line to fix a coding style error no space after
declaration detected by checkpatch.

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c 
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct 
list_head *head)
 static inline int obd_capa_open_count(struct obd_capa *oc)
 {
struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
+
return atomic_read(>lli_open_count);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: lustre: lustre: llite: Added a new line after declaration

2015-08-10 Thread Aparna Karuthodi
Added a new line to fix a coding style error no space after
declaration detected by checkpatch.

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c 
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct 
list_head *head)
 static inline int obd_capa_open_count(struct obd_capa *oc)
 {
struct ll_inode_info *lli = ll_i2info(oc-u.cli.inode);
+
return atomic_read(lli-lli_open_count);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks

2015-07-24 Thread Aparna Karuthodi
Removed the braces of if else statements which contain only one
statement

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/dgnc/dgnc_tty.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f81a375..6cd0b6a 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 * 3) NONE - Do nothing. Since we didn't do anything to turn off the
 *  other side, we don't need to do anything now.
 */
-   if (qleft > (RQUEUESIZE / 2)) {
+   if (qleft > (RQUEUESIZE / 2))
/* HWFLOW */
if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & 
CRTSCTS) {
if (ch->ch_flags & CH_RECEIVER_OFF) {
@@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
ch->ch_bd->bd_ops->send_start_character(ch);
}
/* No FLOW */
-   else {
+   else 
/* Nothing needed. */
-   }
-   }
+   
+   
 }
 
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/3] [PATCH] staging: lustre: llite: Fix space required before the open parenthesis '('

2015-07-24 Thread Aparna Karuthodi
Added a space before the open parenthesis '('

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/lustre/lustre/llite/lproc_llite.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c 
b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index aaa13bd..f7b632c 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -1346,7 +1346,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
lprocfs_oh_clear(_extents->pp_extents[cur].pp_w_hist);
}
 
-   for(i = 0; (count >= (1 << LL_HIST_START << i)) &&
+   for (i = 0; (count >= (1 << LL_HIST_START << i)) &&
 (i < (LL_HIST_MAX - 1)); i++);
if (rw == 0) {
io_extents->pp_extents[cur].pp_r_hist.oh_buckets[i]++;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 1/3] [PATCH] staging: lustre: llite: Fix No space after the declaration

2015-07-24 Thread Aparna Karuthodi
Added a new line

Signed-off-by:Aparna Karuthodi 
---
 drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c 
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct 
list_head *head)
 static inline int obd_capa_open_count(struct obd_capa *oc)
 {
struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
+
return atomic_read(>lli_open_count);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 1/3] [PATCH] staging: lustre: llite: Fix No space after the declaration

2015-07-24 Thread Aparna Karuthodi
Added a new line

Signed-off-by:Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c 
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct 
list_head *head)
 static inline int obd_capa_open_count(struct obd_capa *oc)
 {
struct ll_inode_info *lli = ll_i2info(oc-u.cli.inode);
+
return atomic_read(lli-lli_open_count);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks

2015-07-24 Thread Aparna Karuthodi
Removed the braces of if else statements which contain only one
statement

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/dgnc/dgnc_tty.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f81a375..6cd0b6a 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 * 3) NONE - Do nothing. Since we didn't do anything to turn off the
 *  other side, we don't need to do anything now.
 */
-   if (qleft  (RQUEUESIZE / 2)) {
+   if (qleft  (RQUEUESIZE / 2))
/* HWFLOW */
if (ch-ch_digi.digi_flags  RTSPACE || ch-ch_c_cflag  
CRTSCTS) {
if (ch-ch_flags  CH_RECEIVER_OFF) {
@@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
ch-ch_bd-bd_ops-send_start_character(ch);
}
/* No FLOW */
-   else {
+   else 
/* Nothing needed. */
-   }
-   }
+   
+   
 }
 
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/3] [PATCH] staging: lustre: llite: Fix space required before the open parenthesis '('

2015-07-24 Thread Aparna Karuthodi
Added a space before the open parenthesis '('

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/lustre/lustre/llite/lproc_llite.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c 
b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index aaa13bd..f7b632c 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -1346,7 +1346,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
lprocfs_oh_clear(io_extents-pp_extents[cur].pp_w_hist);
}
 
-   for(i = 0; (count = (1  LL_HIST_START  i)) 
+   for (i = 0; (count = (1  LL_HIST_START  i)) 
 (i  (LL_HIST_MAX - 1)); i++);
if (rw == 0) {
io_extents-pp_extents[cur].pp_r_hist.oh_buckets[i]++;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-ker...@vger.kernel.org,

2015-06-06 Thread Aparna Karuthodi

On Sat, Jun 06, 2015 at 02:26:28PM +0530, Aparna wrote:

> From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
> From: Aparna Karuthodi 
> Date: Sat, 6 Jun 2015 11:01:16 +0530
> Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
>  for single statement blocks
> 
> Removed the braces of if else statements which contain only one
> statement
> 
> Signed-off-by: Aparna Karuthodi 
> ---
>  drivers/staging/dgnc/dgnc_tty.c |8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index f81a375..6cd0b6a 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>* 3) NONE - Do nothing. Since we didn't do anything to turn off the
>*  other side, we don't need to do anything now.
>*/
> - if (qleft > (RQUEUESIZE / 2)) {
> + if (qleft > (RQUEUESIZE / 2))
>   /* HWFLOW */
>   if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & 
> CRTSCTS) {
>   if (ch->ch_flags & CH_RECEIVER_OFF) {
> @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>   ch->ch_bd->bd_ops->send_start_character(ch);
>   }
>   /* No FLOW */
> - else {
> + else 
>   /* Nothing needed. */
> - }
> -     }
> + 
> + 
>  }
>  
>  
> -- 
> 1.7.9.5
> 

>From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
From: Aparna Karuthodi 
Date: Sat, 6 Jun 2015 11:01:16 +0530
Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
 for single statement blocks

Removed the braces of if else statements which contain only one
statement

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/dgnc/dgnc_tty.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f81a375..6cd0b6a 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 	 * 3) NONE - Do nothing. Since we didn't do anything to turn off the
 	 *	other side, we don't need to do anything now.
 	 */
-	if (qleft > (RQUEUESIZE / 2)) {
+	if (qleft > (RQUEUESIZE / 2))
 		/* HWFLOW */
 		if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) {
 			if (ch->ch_flags & CH_RECEIVER_OFF) {
@@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 			ch->ch_bd->bd_ops->send_start_character(ch);
 		}
 		/* No FLOW */
-		else {
+		else 
 			/* Nothing needed. */
-		}
-	}
+		
+	
 }
 
 
-- 
1.7.9.5



Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-ker...@vger.kernel.org,

2015-06-06 Thread Aparna Karuthodi

On Sat, Jun 06, 2015 at 02:26:28PM +0530, Aparna wrote:

 From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
 From: Aparna Karuthodi kdasapa...@gmail.com
 Date: Sat, 6 Jun 2015 11:01:16 +0530
 Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
  for single statement blocks
 
 Removed the braces of if else statements which contain only one
 statement
 
 Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
 ---
  drivers/staging/dgnc/dgnc_tty.c |8 
  1 file changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
 index f81a375..6cd0b6a 100644
 --- a/drivers/staging/dgnc/dgnc_tty.c
 +++ b/drivers/staging/dgnc/dgnc_tty.c
 @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
* 3) NONE - Do nothing. Since we didn't do anything to turn off the
*  other side, we don't need to do anything now.
*/
 - if (qleft  (RQUEUESIZE / 2)) {
 + if (qleft  (RQUEUESIZE / 2))
   /* HWFLOW */
   if (ch-ch_digi.digi_flags  RTSPACE || ch-ch_c_cflag  
 CRTSCTS) {
   if (ch-ch_flags  CH_RECEIVER_OFF) {
 @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
   ch-ch_bd-bd_ops-send_start_character(ch);
   }
   /* No FLOW */
 - else {
 + else 
   /* Nothing needed. */
 - }
 - }
 + 
 + 
  }
  
  
 -- 
 1.7.9.5
 

From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
From: Aparna Karuthodi kdasapa...@gmail.com
Date: Sat, 6 Jun 2015 11:01:16 +0530
Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
 for single statement blocks

Removed the braces of if else statements which contain only one
statement

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/dgnc/dgnc_tty.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f81a375..6cd0b6a 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 	 * 3) NONE - Do nothing. Since we didn't do anything to turn off the
 	 *	other side, we don't need to do anything now.
 	 */
-	if (qleft  (RQUEUESIZE / 2)) {
+	if (qleft  (RQUEUESIZE / 2))
 		/* HWFLOW */
 		if (ch-ch_digi.digi_flags  RTSPACE || ch-ch_c_cflag  CRTSCTS) {
 			if (ch-ch_flags  CH_RECEIVER_OFF) {
@@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 			ch-ch_bd-bd_ops-send_start_character(ch);
 		}
 		/* No FLOW */
-		else {
+		else 
 			/* Nothing needed. */
-		}
-	}
+		
+	
 }
 
 
-- 
1.7.9.5



[PATCH 2/2] [PATCH] staging: lustre: llite: Fix space required before the open paranthesis '('

2015-06-03 Thread Aparna Karuthodi
Added a space before the open paranthesis '('

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/lustre/lustre/llite/lproc_llite.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c 
b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index aaa13bd..f7b632c 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -1346,7 +1346,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
lprocfs_oh_clear(_extents->pp_extents[cur].pp_w_hist);
}
 
-   for(i = 0; (count >= (1 << LL_HIST_START << i)) &&
+   for (i = 0; (count >= (1 << LL_HIST_START << i)) &&
 (i < (LL_HIST_MAX - 1)); i++);
if (rw == 0) {
io_extents->pp_extents[cur].pp_r_hist.oh_buckets[i]++;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: lustre: llite: Fix No space after the declaration

2015-06-03 Thread Aparna Karuthodi
Added a new line

Signed-off-by: Aparna Karuthodi 
---
 drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c 
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct 
list_head *head)
 static inline int obd_capa_open_count(struct obd_capa *oc)
 {
struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
+
return atomic_read(>lli_open_count);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: lustre: llite: Fix No space after the declaration

2015-06-03 Thread Aparna Karuthodi
Added a new line

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/lustre/lustre/llite/llite_capa.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c 
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct 
list_head *head)
 static inline int obd_capa_open_count(struct obd_capa *oc)
 {
struct ll_inode_info *lli = ll_i2info(oc-u.cli.inode);
+
return atomic_read(lli-lli_open_count);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/2] [PATCH] staging: lustre: llite: Fix space required before the open paranthesis '('

2015-06-03 Thread Aparna Karuthodi
Added a space before the open paranthesis '('

Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
 drivers/staging/lustre/lustre/llite/lproc_llite.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c 
b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index aaa13bd..f7b632c 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -1346,7 +1346,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
lprocfs_oh_clear(io_extents-pp_extents[cur].pp_w_hist);
}
 
-   for(i = 0; (count = (1  LL_HIST_START  i)) 
+   for (i = 0; (count = (1  LL_HIST_START  i)) 
 (i  (LL_HIST_MAX - 1)); i++);
if (rw == 0) {
io_extents-pp_extents[cur].pp_r_hist.oh_buckets[i]++;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/