[PATCH v2] Staging: comedi: drivers:
Fixed a coding style issue in ke_counter.c Signed-off-by: Aruna Hewapathirane --- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c index 15589f6..cebf818 100644 --- a/drivers/staging/comedi/drivers/ke_counter.c +++ b/drivers/staging/comedi/drivers/ke_counter.c @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, dev->read_subdev = s; s->type = COMEDI_SUBD_COUNTER; - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */; s->n_chan = 3; s->maxdata = 0x00ff; s->insn_read = cnt_rinsn; @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, outb(0, dev->iobase + 0x40); dev_info(dev->class_dev, "%s: %s attached\n", - dev->driver->driver_name, dev->board_name); + dev->driver->driver_name, dev->board_name); return 0; } -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane
To be honest I almost fell off the chair when your email pooped up in my in-box, that has to be the fastest anyone has ever responded and it is yet very much a learning process for me, have so much to learn.I am humbled and thankful you have not forgotten what it was like when you sent in that first patch :-) On Mon, Jan 6, 2014 at 4:23 AM, Dan Carpenter wrote: > On Mon, Jan 06, 2014 at 04:18:05AM -0500, Aruna Hewapathirane wrote: >> my apologies, it's my very first patch :-) >> > > No worries. Take your time. We were all newbies once. > > regards, > dan carpenter > -- Aruna Hewapathirane Consultant/Trainer Phone : 647-709-9269 Website: Open Source Solutions -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane
my apologies, it's my very first patch :-) On Mon, Jan 6, 2014 at 4:09 AM, Dan Carpenter wrote: > > Changelog mangled. You need a blank after the subject. > > On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote: >> --- >> drivers/staging/comedi/drivers/ke_counter.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/ke_counter.c >> b/drivers/staging/comedi/drivers/ke_counter.c >> index 15589f6..cebf818 100644 >> --- a/drivers/staging/comedi/drivers/ke_counter.c >> +++ b/drivers/staging/comedi/drivers/ke_counter.c >> @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, >> dev->read_subdev = s; >> s->type = COMEDI_SUBD_COUNTER; >> - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; >> + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */; >> s->n_chan = 3; >> s->maxdata = 0x00ff; >> s->insn_read = cnt_rinsn; >> @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, >> outb(0, dev->iobase + 0x40); >> dev_info(dev->class_dev, "%s: %s attached\n", >> - dev->driver->driver_name, dev->board_name); >> + dev->driver->driver_name, dev->board_name); > > Nope. The original was better. > > regards, > dan carpenter > >> return 0; >> } >> -- >> 1.7.0.4 >> >> ___ >> devel mailing list >> de...@linuxdriverproject.org >> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- Aruna Hewapathirane Consultant/Trainer Phone : 647-709-9269 Website: Open Source Solutions -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane
--- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c index 15589f6..cebf818 100644 --- a/drivers/staging/comedi/drivers/ke_counter.c +++ b/drivers/staging/comedi/drivers/ke_counter.c @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, dev->read_subdev = s; s->type = COMEDI_SUBD_COUNTER; - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */; s->n_chan = 3; s->maxdata = 0x00ff; s->insn_read = cnt_rinsn; @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, outb(0, dev->iobase + 0x40); dev_info(dev->class_dev, "%s: %s attached\n", - dev->driver->driver_name, dev->board_name); + dev->driver->driver_name, dev->board_name); return 0; } -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane aruna.hewapathir...@gmail.com
--- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c index 15589f6..cebf818 100644 --- a/drivers/staging/comedi/drivers/ke_counter.c +++ b/drivers/staging/comedi/drivers/ke_counter.c @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, dev-read_subdev = s; s-type = COMEDI_SUBD_COUNTER; - s-subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; + s-subdev_flags = SDF_READABLE /* | SDF_COMMON */; s-n_chan = 3; s-maxdata = 0x00ff; s-insn_read = cnt_rinsn; @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, outb(0, dev-iobase + 0x40); dev_info(dev-class_dev, %s: %s attached\n, - dev-driver-driver_name, dev-board_name); + dev-driver-driver_name, dev-board_name); return 0; } -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane aruna.hewapathir...@gmail.com
my apologies, it's my very first patch :-) On Mon, Jan 6, 2014 at 4:09 AM, Dan Carpenter dan.carpen...@oracle.com wrote: Changelog mangled. You need a blank after the subject. On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote: --- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c index 15589f6..cebf818 100644 --- a/drivers/staging/comedi/drivers/ke_counter.c +++ b/drivers/staging/comedi/drivers/ke_counter.c @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, dev-read_subdev = s; s-type = COMEDI_SUBD_COUNTER; - s-subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; + s-subdev_flags = SDF_READABLE /* | SDF_COMMON */; s-n_chan = 3; s-maxdata = 0x00ff; s-insn_read = cnt_rinsn; @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, outb(0, dev-iobase + 0x40); dev_info(dev-class_dev, %s: %s attached\n, - dev-driver-driver_name, dev-board_name); + dev-driver-driver_name, dev-board_name); Nope. The original was better. regards, dan carpenter return 0; } -- 1.7.0.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- Aruna Hewapathirane Consultant/Trainer Phone : 647-709-9269 Website: Open Source Solutions -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane aruna.hewapathir...@gmail.com
To be honest I almost fell off the chair when your email pooped up in my in-box, that has to be the fastest anyone has ever responded and it is yet very much a learning process for me, have so much to learn.I am humbled and thankful you have not forgotten what it was like when you sent in that first patch :-) On Mon, Jan 6, 2014 at 4:23 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Mon, Jan 06, 2014 at 04:18:05AM -0500, Aruna Hewapathirane wrote: my apologies, it's my very first patch :-) No worries. Take your time. We were all newbies once. regards, dan carpenter -- Aruna Hewapathirane Consultant/Trainer Phone : 647-709-9269 Website: Open Source Solutions -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] Staging: comedi: drivers:
Fixed a coding style issue in ke_counter.c Signed-off-by: Aruna Hewapathirane aruna.hewapathir...@gmail.com --- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c index 15589f6..cebf818 100644 --- a/drivers/staging/comedi/drivers/ke_counter.c +++ b/drivers/staging/comedi/drivers/ke_counter.c @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, dev-read_subdev = s; s-type = COMEDI_SUBD_COUNTER; - s-subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; + s-subdev_flags = SDF_READABLE /* | SDF_COMMON */; s-n_chan = 3; s-maxdata = 0x00ff; s-insn_read = cnt_rinsn; @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, outb(0, dev-iobase + 0x40); dev_info(dev-class_dev, %s: %s attached\n, - dev-driver-driver_name, dev-board_name); + dev-driver-driver_name, dev-board_name); return 0; } -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
