[PATCH 1/1] drivers:staging:vt6656: remove usb_device_reset in main_usb.c:
Removed the usb_device_reset(), replace with call to usb_reset_device()
directly. Plus it removes the confusing function name and addressed
the checkpatch warning. This change also swaps string in the dev_warn() call
with __func__ argument to "vt6656_probe" instead of literal string
"usb_reset_device".
WARNING: Prefer using "%s", __func__ to embedded function names
#417: FILE: main_usb.c:417:
+"usb_device_reset fail status=%d\n", status);
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.c has no obvious style problems and is ready for submission.
Signed-off-by: Chewie Lin <li...@oregonstate.edu>
---
drivers/staging/vt6656/main_usb.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index 9e074e9daf4e..028f54b453d0 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -407,16 +407,6 @@ static void vnt_free_rx_bufs(struct vnt_private *priv)
}
}
-static void usb_device_reset(struct vnt_private *priv)
-{
- int status;
-
- status = usb_reset_device(priv->usb);
- if (status)
- dev_warn(>usb->dev,
-"usb_device_reset fail status=%d\n", status);
-}
-
static void vnt_free_int_bufs(struct vnt_private *priv)
{
kfree(priv->int_buf.data_buf);
@@ -995,7 +985,10 @@ vt6656_probe(struct usb_interface *intf, const struct
usb_device_id *id)
SET_IEEE80211_DEV(priv->hw, >dev);
- usb_device_reset(priv);
+ rc = usb_reset_device(priv->usb);
+ if (rc)
+ dev_warn(>usb->dev,
+"%s reset fail status=%d\n", __func__, rc);
clear_bit(DEVICE_FLAGS_DISCONNECTED, >flags);
vnt_reset_command_timer(priv);
--
2.12.2
[PATCH 1/1] drivers:staging:vt6656: remove usb_device_reset in main_usb.c:
Removed the usb_device_reset(), replace with call to usb_reset_device()
directly. Plus it removes the confusing function name and addressed
the checkpatch warning. This change also swaps string in the dev_warn() call
with __func__ argument to "vt6656_probe" instead of literal string
"usb_reset_device".
WARNING: Prefer using "%s", __func__ to embedded function names
#417: FILE: main_usb.c:417:
+"usb_device_reset fail status=%d\n", status);
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.c has no obvious style problems and is ready for submission.
Signed-off-by: Chewie Lin
---
drivers/staging/vt6656/main_usb.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index 9e074e9daf4e..028f54b453d0 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -407,16 +407,6 @@ static void vnt_free_rx_bufs(struct vnt_private *priv)
}
}
-static void usb_device_reset(struct vnt_private *priv)
-{
- int status;
-
- status = usb_reset_device(priv->usb);
- if (status)
- dev_warn(>usb->dev,
-"usb_device_reset fail status=%d\n", status);
-}
-
static void vnt_free_int_bufs(struct vnt_private *priv)
{
kfree(priv->int_buf.data_buf);
@@ -995,7 +985,10 @@ vt6656_probe(struct usb_interface *intf, const struct
usb_device_id *id)
SET_IEEE80211_DEV(priv->hw, >dev);
- usb_device_reset(priv);
+ rc = usb_reset_device(priv->usb);
+ if (rc)
+ dev_warn(>usb->dev,
+"%s reset fail status=%d\n", __func__, rc);
clear_bit(DEVICE_FLAGS_DISCONNECTED, >flags);
vnt_reset_command_timer(priv);
--
2.12.2
[PATCH 0/1] drivers/staging/vt6656/main_usb.c: usb_device_reset
Hi, This is a simple patch as a part of learning about kernel device driver in the Eudyptula challenge. thanks again for your time! linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: usb_device_reset drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) -- 2.12.2
[PATCH 0/1] drivers/staging/vt6656/main_usb.c: usb_device_reset
Hi, This is a simple patch as a part of learning about kernel device driver in the Eudyptula challenge. thanks again for your time! linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: usb_device_reset drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) -- 2.12.2
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset
Removed the usb_device_reset(), replace with call to usb_reset_device()
directly. Plus it removes the confusing function name and addressed
the checkpatch warning as well by swap string in the dev_warn() call with
__func__ argument, instead of explicitly calling the function name in
the string:
WARNING: Prefer using "%s", __func__ to embedded function names
#417: FILE: main_usb.c:417:
+"usb_device_reset fail status=%d\n", status);
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.c has no obvious style problems and is ready for submission.
Signed-off-by: Chewie Lin <li...@oregonstate.edu>
---
drivers/staging/vt6656/main_usb.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index 9e074e9daf4e..028f54b453d0 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -407,16 +407,6 @@ static void vnt_free_rx_bufs(struct vnt_private *priv)
}
}
-static void usb_device_reset(struct vnt_private *priv)
-{
- int status;
-
- status = usb_reset_device(priv->usb);
- if (status)
- dev_warn(>usb->dev,
-"usb_device_reset fail status=%d\n", status);
-}
-
static void vnt_free_int_bufs(struct vnt_private *priv)
{
kfree(priv->int_buf.data_buf);
@@ -995,7 +985,10 @@ vt6656_probe(struct usb_interface *intf, const struct
usb_device_id *id)
SET_IEEE80211_DEV(priv->hw, >dev);
- usb_device_reset(priv);
+ rc = usb_reset_device(priv->usb);
+ if (rc)
+ dev_warn(>usb->dev,
+"%s reset fail status=%d\n", __func__, rc);
clear_bit(DEVICE_FLAGS_DISCONNECTED, >flags);
vnt_reset_command_timer(priv);
--
2.12.2
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset
Removed the usb_device_reset(), replace with call to usb_reset_device()
directly. Plus it removes the confusing function name and addressed
the checkpatch warning as well by swap string in the dev_warn() call with
__func__ argument, instead of explicitly calling the function name in
the string:
WARNING: Prefer using "%s", __func__ to embedded function names
#417: FILE: main_usb.c:417:
+"usb_device_reset fail status=%d\n", status);
total: 0 errors, 1 warnings, 1058 lines checked
And after fix:
main_usb.c has no obvious style problems and is ready for submission.
Signed-off-by: Chewie Lin
---
drivers/staging/vt6656/main_usb.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index 9e074e9daf4e..028f54b453d0 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -407,16 +407,6 @@ static void vnt_free_rx_bufs(struct vnt_private *priv)
}
}
-static void usb_device_reset(struct vnt_private *priv)
-{
- int status;
-
- status = usb_reset_device(priv->usb);
- if (status)
- dev_warn(>usb->dev,
-"usb_device_reset fail status=%d\n", status);
-}
-
static void vnt_free_int_bufs(struct vnt_private *priv)
{
kfree(priv->int_buf.data_buf);
@@ -995,7 +985,10 @@ vt6656_probe(struct usb_interface *intf, const struct
usb_device_id *id)
SET_IEEE80211_DEV(priv->hw, >dev);
- usb_device_reset(priv);
+ rc = usb_reset_device(priv->usb);
+ if (rc)
+ dev_warn(>usb->dev,
+"%s reset fail status=%d\n", __func__, rc);
clear_bit(DEVICE_FLAGS_DISCONNECTED, >flags);
vnt_reset_command_timer(priv);
--
2.12.2
Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > #417: FILE: main_usb.c:417: > > +"usb_device_reset fail status=%d\n", > > status); > > > > total: 0 errors, 1 warnings, 1058 lines checked > > > > And after fix: > > > > main_usb.c has no obvious style problems and is ready for > > submission. > > > > Signed-off-by: Chewie Lin <li...@oregonstate.edu> > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c > > b/drivers/staging/vt6656/main_usb.c > > index 9e074e9daf4e..71c4511b4cff 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(>usb->dev, > > -"usb_device_reset fail status=%d\n", status); > > +"%s fail status=%d\n", __func__, status); > > But the call that failed was called usb_device_reset(), right? Why is > this function even needed at all, have the caller call the correct > function instead please, and then this whole function can be deleted. > thanks greg. Yes, I think that's a good approach as well. I initially wanted to fix a coding style problem without touching the function calls, but I can definitely do that as well. linsh
Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > #417: FILE: main_usb.c:417: > > +"usb_device_reset fail status=%d\n", > > status); > > > > total: 0 errors, 1 warnings, 1058 lines checked > > > > And after fix: > > > > main_usb.c has no obvious style problems and is ready for > > submission. > > > > Signed-off-by: Chewie Lin > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c > > b/drivers/staging/vt6656/main_usb.c > > index 9e074e9daf4e..71c4511b4cff 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(>usb->dev, > > -"usb_device_reset fail status=%d\n", status); > > +"%s fail status=%d\n", __func__, status); > > But the call that failed was called usb_device_reset(), right? Why is > this function even needed at all, have the caller call the correct > function instead please, and then this whole function can be deleted. > thanks greg. Yes, I think that's a good approach as well. I initially wanted to fix a coding style problem without touching the function calls, but I can definitely do that as well. linsh
[PATCH 0/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
Hi All, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.12.2
[PATCH 0/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
Hi All, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.12.2
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
Swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the string: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: +"usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9daf4e..71c4511b4cff 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s fail status=%d\n", __func__, status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.12.2
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
Swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the string: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: +"usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9daf4e..71c4511b4cff 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s fail status=%d\n", __func__, status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.12.2
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
On Sat, Apr 01, 2017 at 04:32:39AM +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > Replace string with formatted arguments in the dev_warn() call. It removes
> > the checkpatch warning:
> >
> > WARNING: Prefer using "%s", __func__ to embedded function names
> > #417: FILE: main_usb.c:417:
> > +"usb_device_reset fail status=%d\n", status);
> >
> > total: 0 errors, 1 warnings, 1058 lines checked
> >
> > And after fix:
> >
> > main_usb.c has no obvious style problems and is ready for submission.
>
>
> > -"usb_device_reset fail status=%d\n", status);
> > +"%s=%d\n", "usb_device_reset fail status", status);
>
> Would you mind explaining the meaning of that warning? Incidentally, why not
> "%se_reset fail status=%d\n", "usb_devic", status);
> - it would produce the identical output and silences checkpatch even more
> reliably. Discuss.
>
> Sarcasm aside, when you are proposing a change, there are several questions
> you
> really must ask yourself and be able to answer. First and foremost, of
> course,
> is
> * Why is it an improvement?
> If the answer to that was "it makes a warning go away", the next questions are
> * What are we warned about?
> * What is problematic in the original variant?
> * Is the replacement free from the problem we had in the original?
> and if the answer to any of that is "I don't know", the next step is _not_
> "send it anyway". "Try to figure out" might be a good idea, with usual
> heuristics regarding the reading comprehension ("if a sentence remains
> a mystery, see if there are any unfamiliar words skipped at the first reading
> and find what they mean", etc.) applying.
>
> In this particular case the part you've apparently skipped was, indeed,
> critical - "__func__". I am not trying to defend the quality of checkpatch -
> the warning is badly worded, the tool is badly written and more often than
> not its suggestions reflect nothing but authors' arbitrary preferences.
>
> This one, however, does have some rationale behind it. Namely, if some
> debugging output contains the name of a function that has produced it,
> having that name spelled out in format string is not a good idea. If
> that code gets moved elsewhere one would have to replace the name in format
> string or face confusing messages refering to the function where that
> code used to be. Since __func__ is interpreted as a constant string
> initialized with the name of the function it's used in, it is possible
> to avoid spelling the function name out - instead of
> "my_function: pink elephants; reduce the daily intake to %d glasses\n", n
> one could use
> "%s: pink elephants; reduce the daily intake to %d glasses\n", __func__, n
> producing the same output and avoiding the need to adjust anything when
> the whole thing is moved to another function. It's not particularly big
> deal, but it's a more or less reasonable suggestion.
>
> Your change, of course, has achieved only one thing - it has moved the
> explicitly spelled out function name out of format string. It's still
> just as explicitly spelled out, still would need to be adjusted if moved
> to another function and the whole thing has become harder to read and
> understand since you've buried other parts of message in the place where
> it's harder to follow.
>
> Again, checkpatch warning is badly written, but the main problem with
> your posting is not that you had been confused by checkpatch - it's
> that you have posted it based on an incomprehensible message with no better
> rationale than "it shuts checkpatch up, dunno why and what about".
Al, brilliant, that's exactly what I was trying to do on my first try.
The checkpatch *is* confusing. It's fine with a simple string but doesn't
like it when it's formatted string. From what you said, I
think this may work better and more portable:
"%s: fail status = %d\n", "usb_device_reset", status)
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
On Sat, Apr 01, 2017 at 04:32:39AM +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > Replace string with formatted arguments in the dev_warn() call. It removes
> > the checkpatch warning:
> >
> > WARNING: Prefer using "%s", __func__ to embedded function names
> > #417: FILE: main_usb.c:417:
> > +"usb_device_reset fail status=%d\n", status);
> >
> > total: 0 errors, 1 warnings, 1058 lines checked
> >
> > And after fix:
> >
> > main_usb.c has no obvious style problems and is ready for submission.
>
>
> > -"usb_device_reset fail status=%d\n", status);
> > +"%s=%d\n", "usb_device_reset fail status", status);
>
> Would you mind explaining the meaning of that warning? Incidentally, why not
> "%se_reset fail status=%d\n", "usb_devic", status);
> - it would produce the identical output and silences checkpatch even more
> reliably. Discuss.
>
> Sarcasm aside, when you are proposing a change, there are several questions
> you
> really must ask yourself and be able to answer. First and foremost, of
> course,
> is
> * Why is it an improvement?
> If the answer to that was "it makes a warning go away", the next questions are
> * What are we warned about?
> * What is problematic in the original variant?
> * Is the replacement free from the problem we had in the original?
> and if the answer to any of that is "I don't know", the next step is _not_
> "send it anyway". "Try to figure out" might be a good idea, with usual
> heuristics regarding the reading comprehension ("if a sentence remains
> a mystery, see if there are any unfamiliar words skipped at the first reading
> and find what they mean", etc.) applying.
>
> In this particular case the part you've apparently skipped was, indeed,
> critical - "__func__". I am not trying to defend the quality of checkpatch -
> the warning is badly worded, the tool is badly written and more often than
> not its suggestions reflect nothing but authors' arbitrary preferences.
>
> This one, however, does have some rationale behind it. Namely, if some
> debugging output contains the name of a function that has produced it,
> having that name spelled out in format string is not a good idea. If
> that code gets moved elsewhere one would have to replace the name in format
> string or face confusing messages refering to the function where that
> code used to be. Since __func__ is interpreted as a constant string
> initialized with the name of the function it's used in, it is possible
> to avoid spelling the function name out - instead of
> "my_function: pink elephants; reduce the daily intake to %d glasses\n", n
> one could use
> "%s: pink elephants; reduce the daily intake to %d glasses\n", __func__, n
> producing the same output and avoiding the need to adjust anything when
> the whole thing is moved to another function. It's not particularly big
> deal, but it's a more or less reasonable suggestion.
>
> Your change, of course, has achieved only one thing - it has moved the
> explicitly spelled out function name out of format string. It's still
> just as explicitly spelled out, still would need to be adjusted if moved
> to another function and the whole thing has become harder to read and
> understand since you've buried other parts of message in the place where
> it's harder to follow.
>
> Again, checkpatch warning is badly written, but the main problem with
> your posting is not that you had been confused by checkpatch - it's
> that you have posted it based on an incomprehensible message with no better
> rationale than "it shuts checkpatch up, dunno why and what about".
Al, brilliant, that's exactly what I was trying to do on my first try.
The checkpatch *is* confusing. It's fine with a simple string but doesn't
like it when it's formatted string. From what you said, I
think this may work better and more portable:
"%s: fail status = %d\n", "usb_device_reset", status)
Re: [PATCH] drivers: fixed a checkpatch warning
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > > fixed a coding style error/warning. > > > > Signed-off-by: Chewie Lin <li...@oregonstate.edu> > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c > > b/drivers/staging/vt6656/main_usb.c > > index 9e074e9..2d9e7af 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(>usb->dev, > > -"usb_device_reset fail status=%d\n", status); > > +"%s=%d\n", "usb_device_reset fail status", status); > > Yeah, what Greg said. > > Also most likely this should be > > dev_warn(>usb->dev, >"usb_reset_device fail status=%d\n", status); > > Note the function is usb_device_reset, but the > function call that failed is usb_reset_device. yep, I had the comic book guy from the Simpsons voice when I read that. :) I submitted a separate patch, maybe I should have reply-to this instead? >
Re: [PATCH] drivers: fixed a checkpatch warning
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > > fixed a coding style error/warning. > > > > Signed-off-by: Chewie Lin > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c > > b/drivers/staging/vt6656/main_usb.c > > index 9e074e9..2d9e7af 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(>usb->dev, > > -"usb_device_reset fail status=%d\n", status); > > +"%s=%d\n", "usb_device_reset fail status", status); > > Yeah, what Greg said. > > Also most likely this should be > > dev_warn(>usb->dev, >"usb_reset_device fail status=%d\n", status); > > Note the function is usb_device_reset, but the > function call that failed is usb_reset_device. yep, I had the comic book guy from the Simpsons voice when I read that. :) I submitted a separate patch, maybe I should have reply-to this instead? >
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
On Fri, Mar 31, 2017 at 07:45:09PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 19:15 -0700, Randy Dunlap wrote: > > On 03/31/17 18:59, Chewie Lin wrote: > > > Replace string with formatted arguments in the dev_warn() call. It removes > > > the checkpatch warning: > > > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > > #417: FILE: main_usb.c:417: > > > +"usb_device_reset fail status=%d\n", status); > > > > > > total: 0 errors, 1 warnings, 1058 lines checked > > > > > > And after fix: > > > > > > main_usb.c has no obvious style problems and is ready for submission. > > > > > > Signed-off-by: Chewie Lin <li...@oregonstate.edu> > > > --- > > > drivers/staging/vt6656/main_usb.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vt6656/main_usb.c > > > b/drivers/staging/vt6656/main_usb.c > > > index 9e074e9..2d9e7af 100644 > > > --- a/drivers/staging/vt6656/main_usb.c > > > +++ b/drivers/staging/vt6656/main_usb.c > > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > > status = usb_reset_device(priv->usb); > > > if (status) > > > dev_warn(>usb->dev, > > > - "usb_device_reset fail status=%d\n", status); > > > + "%s=%d\n", "usb_device_reset fail status", status); > > > } > > > > > > static void vnt_free_int_bufs(struct vnt_private *priv) > > > > > > > As other people have said: > > > > This function is usb_device_reset(). If that function name string is to be > > used in the message, it should be done so by using __func__. > > See http://marc.info/?l=linux-driver-devel=149095639202492=2 > > > > Or is the called (failing) function name is to be kept in the message (as it > > is currently), then the message should contain "usb_reset_device" instead of > > "usb_device_reset". See > > http://marc.info/?l=linux-driver-devel=149098680312723=2 > > If this is to be changed at all, I suggest > just getting rid of the function. These are good points, but any feedback on the dev_warn() call itself? I was trying to fix the checkpatch warning on my first try.
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
On Fri, Mar 31, 2017 at 07:45:09PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 19:15 -0700, Randy Dunlap wrote: > > On 03/31/17 18:59, Chewie Lin wrote: > > > Replace string with formatted arguments in the dev_warn() call. It removes > > > the checkpatch warning: > > > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > > #417: FILE: main_usb.c:417: > > > +"usb_device_reset fail status=%d\n", status); > > > > > > total: 0 errors, 1 warnings, 1058 lines checked > > > > > > And after fix: > > > > > > main_usb.c has no obvious style problems and is ready for submission. > > > > > > Signed-off-by: Chewie Lin > > > --- > > > drivers/staging/vt6656/main_usb.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/vt6656/main_usb.c > > > b/drivers/staging/vt6656/main_usb.c > > > index 9e074e9..2d9e7af 100644 > > > --- a/drivers/staging/vt6656/main_usb.c > > > +++ b/drivers/staging/vt6656/main_usb.c > > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > > status = usb_reset_device(priv->usb); > > > if (status) > > > dev_warn(>usb->dev, > > > - "usb_device_reset fail status=%d\n", status); > > > + "%s=%d\n", "usb_device_reset fail status", status); > > > } > > > > > > static void vnt_free_int_bufs(struct vnt_private *priv) > > > > > > > As other people have said: > > > > This function is usb_device_reset(). If that function name string is to be > > used in the message, it should be done so by using __func__. > > See http://marc.info/?l=linux-driver-devel=149095639202492=2 > > > > Or is the called (failing) function name is to be kept in the message (as it > > is currently), then the message should contain "usb_reset_device" instead of > > "usb_device_reset". See > > http://marc.info/?l=linux-driver-devel=149098680312723=2 > > If this is to be changed at all, I suggest > just getting rid of the function. These are good points, but any feedback on the dev_warn() call itself? I was trying to fix the checkpatch warning on my first try.
[PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: +"usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: +"usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH] eudyptula challenge
Hi all: Better and improved changelog version 3. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] eudyptula challenge
Hi all: Better and improved changelog version 3. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] eudyptula challenge
Hi greg and forest: I hate to bother but one more, with better changelog. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] eudyptula challenge
Hi greg and forest: I hate to bother but one more, with better changelog. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning
Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning
Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH] Eudyptula challenge
Hi greg k-h and forest: Sorry about all the spam I've been sending earlier. One more try. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] Eudyptula challenge
Hi greg k-h and forest: Sorry about all the spam I've been sending earlier. One more try. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] Eudyptula challenge
Hi, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] Eudyptula challenge
Hi, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0
[PATCH] drivers: fixed a checkpatch warning
fixed a coding style error/warning. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
[PATCH] drivers: fixed a checkpatch warning
fixed a coding style error/warning. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(>usb->dev, -"usb_device_reset fail status=%d\n", status); +"%s=%d\n", "usb_device_reset fail status", status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.10.0
