Re: Linux 4.15-rc4

2017-12-18 Thread Donald Parsons 
Suspend still failing to start up again.  Screen is blank and ssh finds
no path but computer looks and sounds like it is running normally.
PC is 6 months old and suspend worked flawlessly until roughly 2 to 3
weeks ago.   This is Fedora 26 using always the latest Fedora provided
kernels or Linus' kernels compiled by me.  Both started to have resume
failures.  vmlinuz-4.13.15-200.fc26.x86_64 works usually (failed once
out of 3 or 4) and later ones never work(? fail 2 out of 2).

It seems a suspend problem was back-ported starting about vmlinuz-
4.13.15 because I never saw failure earlier, eg. vmlinuz-4.13.5--14-
200.fc26.x86_64

Also the chance of resume failure seems to increase the longer I wait,
like resume will probably work after 10 or 20 minutes but after 12
hours it seems to fail almost always.  But to be certain, this would
need much more testing!

Hardware in desktop PC:
Motherboard,  ASRock   Fata1ity Z270 Gaming K6 (2.11 beta bios)
Video card,   MSI  GeForce GTX 1070 Gaming X 8G
CPU,  Inteli7-7700K (not overclocked)
Memory,   G.SKILL  DDR4 3200 8GBx2 (F4-3200C16D-16GVK)
M.2 storage,  Samsung  1TB 960 EVO NVMe M.2 SSD
PSU,  EVGA 750BQ  model 110-BQ-0750

Don

Re: Linux 4.15-rc4

2017-12-18 Thread Donald Parsons 
Suspend still failing to start up again.  Screen is blank and ssh finds
no path but computer looks and sounds like it is running normally.
PC is 6 months old and suspend worked flawlessly until roughly 2 to 3
weeks ago.   This is Fedora 26 using always the latest Fedora provided
kernels or Linus' kernels compiled by me.  Both started to have resume
failures.  vmlinuz-4.13.15-200.fc26.x86_64 works usually (failed once
out of 3 or 4) and later ones never work(? fail 2 out of 2).

It seems a suspend problem was back-ported starting about vmlinuz-
4.13.15 because I never saw failure earlier, eg. vmlinuz-4.13.5--14-
200.fc26.x86_64

Also the chance of resume failure seems to increase the longer I wait,
like resume will probably work after 10 or 20 minutes but after 12
hours it seems to fail almost always.  But to be certain, this would
need much more testing!

Hardware in desktop PC:
Motherboard,  ASRock   Fata1ity Z270 Gaming K6 (2.11 beta bios)
Video card,   MSI  GeForce GTX 1070 Gaming X 8G
CPU,  Inteli7-7700K (not overclocked)
Memory,   G.SKILL  DDR4 3200 8GBx2 (F4-3200C16D-16GVK)
M.2 storage,  Samsung  1TB 960 EVO NVMe M.2 SSD
PSU,  EVGA 750BQ  model 110-BQ-0750

Don

Re: [PATCH 4.3 001/157] x86 smpboot: Re-enable init_udelay=0 by default on modern CPUs

2016-01-27 Thread Donald Parsons 
On Wed, 2016-01-27 at 10:11 -0800, Greg Kroah-Hartman wrote:

Tested with old Core 2 6600 Intel CPU and works still properly.
   (email written under linux-4.3.5-rc1)

Don

Re: [PATCH 4.3 001/157] x86 smpboot: Re-enable init_udelay=0 by default on modern CPUs

2016-01-27 Thread Donald Parsons 
On Wed, 2016-01-27 at 10:11 -0800, Greg Kroah-Hartman wrote:

Tested with old Core 2 6600 Intel CPU and works still properly.
   (email written under linux-4.3.5-rc1)

Don

Re: [PATCH/RFT 0/2] regression fix: "smpboot: do_boot_cpu failed(-1) to wakeup CPU#1"

2015-10-15 Thread Donald Parsons 
On Fri, 2015-10-16 at 00:14 -0400, Len Brown wrote:
> Shane, Donald,
> Please test this pair of patches.
> 
> If the default kernel still has a problem booting CPU #1 on your Core2 system,
> "cpu_init_udelay=1" should get you back to the legacy delays.

Applied patches to Linus' 4.3-rc4 (with none of our recently discussed
changes.) 

Result missing CPU is back!

I also tried the "cpu_init_udelay=1" with rc5 and that also gave me back
the missing CPU?  Previously I had tried "cpu_init_udelay=1" and it
did not get missing CPU back (with rc3 or rc4).

I can do more testing if you need it.

Thanks,
Don



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: Re[2]: 3.4-rc smpboot: do_boot_cpu failed(-1) to wakeup CPU#1

2015-10-15 Thread Donald Parsons 
On Thu, 2015-10-15 at 02:53 +, Brown, Len wrote:
> > > > Did you try reverting the "x86/smpboot: Remove
> > APIC.wait_for_init_deassert
> > > > and atomic init_deasserted"  patch?
> > >
> > > Yes, please let me know if reverting that patch helps you too.
> > 
> > How?  Please send a patch or git cmd(s).I have the
> > git/stable/linux-stable.git  on my PC.   Thanks.
> 
> git log calls it this:
> 
> commit 656bba306827a44ed73b3f93f75bb3147de17fae
> Author: Len Brown 
> Date:   Sun Aug 16 11:45:48 2015 -0400
> 
> x86/smpboot: Remove APIC.wait_for_init_deassert and atomic init_deasserted
> 
> So you want to simply do this:
> 
> $ git revert 656bba306827a44ed73b3f93f75bb3147de17fae
> 
> build and test.

I did the revert in linux-stable (last tag being v4.3-rc4) gave a revert
description so it would be applied.

built and tested.  Result:  did not help, still missing the second core.

I am sure the revert happened but I am uncertain as to how to build in a
git tree.  I think I did it correctly
   cp .config into   linux-stable   tree
   edit Makefile to add -rev to: EXTRAVERSION = -rc4-rev
   make oldconfig
   make -j3 >> ../mak/mak_430-rc4-rev.log 2>&1 &

The before/after kernels are:
3965280 Oct  4 15:20 vmlinuz-4.3.0-rc4
3965408 Oct 15 13:45 vmlinuz-4.3.0-rc4-rev
The reverted vmlinuz is 128 bytes bigger;  .config's are identical.  I
see the revert adds back in some code so sizes seem appropriate.

Don

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: Re[2]: 3.4-rc smpboot: do_boot_cpu failed(-1) to wakeup CPU#1

2015-10-15 Thread Donald Parsons 
On Thu, 2015-10-15 at 02:53 +, Brown, Len wrote:
> > > > Did you try reverting the "x86/smpboot: Remove
> > APIC.wait_for_init_deassert
> > > > and atomic init_deasserted"  patch?
> > >
> > > Yes, please let me know if reverting that patch helps you too.
> > 
> > How?  Please send a patch or git cmd(s).I have the
> > git/stable/linux-stable.git  on my PC.   Thanks.
> 
> git log calls it this:
> 
> commit 656bba306827a44ed73b3f93f75bb3147de17fae
> Author: Len Brown 
> Date:   Sun Aug 16 11:45:48 2015 -0400
> 
> x86/smpboot: Remove APIC.wait_for_init_deassert and atomic init_deasserted
> 
> So you want to simply do this:
> 
> $ git revert 656bba306827a44ed73b3f93f75bb3147de17fae
> 
> build and test.

I did the revert in linux-stable (last tag being v4.3-rc4) gave a revert
description so it would be applied.

built and tested.  Result:  did not help, still missing the second core.

I am sure the revert happened but I am uncertain as to how to build in a
git tree.  I think I did it correctly
   cp .config into   linux-stable   tree
   edit Makefile to add -rev to: EXTRAVERSION = -rc4-rev
   make oldconfig
   make -j3 >> ../mak/mak_430-rc4-rev.log 2>&1 &

The before/after kernels are:
3965280 Oct  4 15:20 vmlinuz-4.3.0-rc4
3965408 Oct 15 13:45 vmlinuz-4.3.0-rc4-rev
The reverted vmlinuz is 128 bytes bigger;  .config's are identical.  I
see the revert adds back in some code so sizes seem appropriate.

Don

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH/RFT 0/2] regression fix: "smpboot: do_boot_cpu failed(-1) to wakeup CPU#1"

2015-10-15 Thread Donald Parsons 
On Fri, 2015-10-16 at 00:14 -0400, Len Brown wrote:
> Shane, Donald,
> Please test this pair of patches.
> 
> If the default kernel still has a problem booting CPU #1 on your Core2 system,
> "cpu_init_udelay=1" should get you back to the legacy delays.

Applied patches to Linus' 4.3-rc4 (with none of our recently discussed
changes.) 

Result missing CPU is back!

I also tried the "cpu_init_udelay=1" with rc5 and that also gave me back
the missing CPU?  Previously I had tried "cpu_init_udelay=1" and it
did not get missing CPU back (with rc3 or rc4).

I can do more testing if you need it.

Thanks,
Don



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: Re[2]: 3.4-rc smpboot: do_boot_cpu failed(-1) to wakeup CPU#1

2015-10-14 Thread Donald Parsons 
On Thu, 2015-10-15 at 02:09 +, Brown, Len wrote:
> Donald, Shane,
> Thanks for reporting this.
> 
> > > I also tried suggested /vmlinuz-4.3.0-rc3 parameter in grub:
> > > "cpu_init_udelay=1"
> > > which did not help getting missing CPU back online.
> 
> right, if the issue is caused by the patch below,
> that cmdline will not help.
> 
> > Did you try reverting the "x86/smpboot: Remove APIC.wait_for_init_deassert
> > and atomic init_deasserted"  patch?
> 
> Yes, please let me know if reverting that patch helps you too.

How?  Please send a patch or git cmd(s).I have the
git/stable/linux-stable.git  on my PC.   Thanks.


> You have similar hardware:
> 
> Shane:
> 
> smpboot: CPU0: Intel(R) Core(TM)2 CPU  6400  @ 2.13GHz (fam: 06, 
> model: 0f, stepping: 06)
> 
> Donald:
> 
> CPU : Intel Core 2 CPU 6600 @ 2.4GHz

Mine is also same (fam: 06, model: 0f, stepping: 06).

> I think I can get ahold of a core2 6xxx box tomorrow.
> Please send me your .config directly, and I'll see if I can reproduce the 
> issue.

Will do.

Don

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: 3.4-rc smpboot: do_boot_cpu failed(-1) to wakeup CPU#1

2015-10-14 Thread Donald Parsons 
On Wed, 2015-10-14 at 12:20 -0400, shrybman wrote:
> All 3.4-rc kernels I have tried displayed this issue.

> This report looks similar https://lkml.org/lkml/2015/9/26/165.
> I also have a Core 2 cpu on a Asus P5B (not deluxe) board.

> ...
>  ACPI: Core revision 20150818
>  ACPI: 1 ACPI AML tables successfully acquired and loaded
>  Mount-cache hash table entries: 8192 (order: 4, 65536 bytes)
>  Mountpoint-cache hash table entries: 8192 (order: 4, 65536 bytes)
>  CPU: Physical Processor ID: 0
>  CPU: Processor Core ID: 0
>  mce: CPU supports 6 MCE banks
>  CPU0: Thermal monitoring enabled (TM2)
>  process: using mwait in idle threads
>  Last level iTLB entries: 4KB 128, 2MB 4, 4MB 4
>  Last level dTLB entries: 4KB 256, 2MB 0, 4MB 32, 1GB 0
>  Freeing SMP alternatives memory: 20K (819b5000 - 819ba000)
>  ftrace: allocating 18583 entries in 73 pages
>  ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
>  smpboot: CPU0: Intel(R) Core(TM)2 CPU  6400  @ 2.13GHz (fam: 06, 
> model: 0f, stepping: 06)
>  Performance Events: PEBS fmt0-, 4-deep LBR, Core2 events, Intel PMU driver.
>  perf_event_intel: PEBS disabled due to CPU errata
>  ... version:2
>  ... bit width:  40
>  ... generic registers:  2
>  ... value mask: 00ff
>  ... max period: 7fff
>  ... fixed-purpose events:   3
>  ... event mask: 00070003
>  x86: Booting SMP configuration:
>   node  #0, CPUs:  #1
>  smpboot: do_boot_cpu failed(-1) to wakeup CPU#1
>  x86: Booted up 1 node, 1 CPUs
>  smpboot: Total of 1 processors activated (4272.42 BogoMIPS)
>  devtmpfs: initialized
> I took a guess and got lucky.
> Reverting "x86/smpboot: Remove APIC.wait_for_init_deassert and atomic 
> init_deasserted" resolved the issue.


As a followup, I updated compiler to gcc-5.2 (no help or change).
I also tried suggested /vmlinuz-4.3.0-rc3 parameter in grub: 
"cpu_init_udelay=1"
which did not help getting missing CPU back online.

So all linux-4.3.0-rc[15] lose the second CPU core.

Don


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: 3.4-rc smpboot: do_boot_cpu failed(-1) to wakeup CPU#1

2015-10-14 Thread Donald Parsons 
On Wed, 2015-10-14 at 12:20 -0400, shrybman wrote:
> All 3.4-rc kernels I have tried displayed this issue.

> This report looks similar https://lkml.org/lkml/2015/9/26/165.
> I also have a Core 2 cpu on a Asus P5B (not deluxe) board.

> ...
>  ACPI: Core revision 20150818
>  ACPI: 1 ACPI AML tables successfully acquired and loaded
>  Mount-cache hash table entries: 8192 (order: 4, 65536 bytes)
>  Mountpoint-cache hash table entries: 8192 (order: 4, 65536 bytes)
>  CPU: Physical Processor ID: 0
>  CPU: Processor Core ID: 0
>  mce: CPU supports 6 MCE banks
>  CPU0: Thermal monitoring enabled (TM2)
>  process: using mwait in idle threads
>  Last level iTLB entries: 4KB 128, 2MB 4, 4MB 4
>  Last level dTLB entries: 4KB 256, 2MB 0, 4MB 32, 1GB 0
>  Freeing SMP alternatives memory: 20K (819b5000 - 819ba000)
>  ftrace: allocating 18583 entries in 73 pages
>  ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
>  smpboot: CPU0: Intel(R) Core(TM)2 CPU  6400  @ 2.13GHz (fam: 06, 
> model: 0f, stepping: 06)
>  Performance Events: PEBS fmt0-, 4-deep LBR, Core2 events, Intel PMU driver.
>  perf_event_intel: PEBS disabled due to CPU errata
>  ... version:2
>  ... bit width:  40
>  ... generic registers:  2
>  ... value mask: 00ff
>  ... max period: 7fff
>  ... fixed-purpose events:   3
>  ... event mask: 00070003
>  x86: Booting SMP configuration:
>   node  #0, CPUs:  #1
>  smpboot: do_boot_cpu failed(-1) to wakeup CPU#1
>  x86: Booted up 1 node, 1 CPUs
>  smpboot: Total of 1 processors activated (4272.42 BogoMIPS)
>  devtmpfs: initialized
> I took a guess and got lucky.
> Reverting "x86/smpboot: Remove APIC.wait_for_init_deassert and atomic 
> init_deasserted" resolved the issue.


As a followup, I updated compiler to gcc-5.2 (no help or change).
I also tried suggested /vmlinuz-4.3.0-rc3 parameter in grub: 
"cpu_init_udelay=1"
which did not help getting missing CPU back online.

So all linux-4.3.0-rc[15] lose the second CPU core.

Don


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: Re[2]: 3.4-rc smpboot: do_boot_cpu failed(-1) to wakeup CPU#1

2015-10-14 Thread Donald Parsons 
On Thu, 2015-10-15 at 02:09 +, Brown, Len wrote:
> Donald, Shane,
> Thanks for reporting this.
> 
> > > I also tried suggested /vmlinuz-4.3.0-rc3 parameter in grub:
> > > "cpu_init_udelay=1"
> > > which did not help getting missing CPU back online.
> 
> right, if the issue is caused by the patch below,
> that cmdline will not help.
> 
> > Did you try reverting the "x86/smpboot: Remove APIC.wait_for_init_deassert
> > and atomic init_deasserted"  patch?
> 
> Yes, please let me know if reverting that patch helps you too.

How?  Please send a patch or git cmd(s).I have the
git/stable/linux-stable.git  on my PC.   Thanks.


> You have similar hardware:
> 
> Shane:
> 
> smpboot: CPU0: Intel(R) Core(TM)2 CPU  6400  @ 2.13GHz (fam: 06, 
> model: 0f, stepping: 06)
> 
> Donald:
> 
> CPU : Intel Core 2 CPU 6600 @ 2.4GHz

Mine is also same (fam: 06, model: 0f, stepping: 06).

> I think I can get ahold of a core2 6xxx box tomorrow.
> Please send me your .config directly, and I'll see if I can reproduce the 
> issue.

Will do.

Don

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Linux 4.3-rc2

2015-09-26 Thread Donald Parsons 
Neither linux-4.3-rc1 nor linux-4.3-rc2 boot properly on my Intel
Core 2 E6600---lost one of two cores.   Google search found one
other person reporting linux-4.3-rc1 also booting with only one core.
His Intel CPU was a year or two newer than mine.

linux-4.3-rc1 showed more problems during boot including something
about mtrr and another thing I forgot.   The mtrr and ? are not
showing in -rc2.   I had to photograph early boot to capture boot
change from a normal working kernel.  (My Fedora is 14, gcc 4.5.1).


 (start insert 3 screen photos transcribed)
AMIBIOS
ASUS P5B-Deluxe ACPI BIOS Revision 1238
CPU : Intel Core 2 CPU 6600 @ 2.4GHz
 --
Booting Fedora (4.3.0-rc2) in 5 seconds...
 --
early console in decompress_kernel
 (next 5 lines never appear with 4.2.1 and older kernels)
input_data: 0x0181026e
input_len:  0x003c93c3
output: 0x0100
output_len: 0x00bc7870
run_size:   0x00c72000

Decompressing Linux... Parsing ELF... done.
Booting the kernel.
smpboot: do_boot_cpu failed(-1) to wakeup CPU#1
 (end insert)

but continues to bootup and works with one CPU.

/proc/cpuinfo shows only one of two CPU cores:
siblings: 1
cpu cores   : 1
(both should be : 2 )

With -rc2, /proc/mtrr is same as a working kernel (-rc1?):
reg00: base=0x0d000 ( 3328MB), size=  256MB, count=1: uncachable
reg01: base=0x0e000 ( 3584MB), size=  512MB, count=1: uncachable
reg02: base=0x0 (0MB), size= 8192MB, count=1: write-back

How can I fix this?

Thanks,
Don


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Linux 4.3-rc2

2015-09-26 Thread Donald Parsons 
Neither linux-4.3-rc1 nor linux-4.3-rc2 boot properly on my Intel
Core 2 E6600---lost one of two cores.   Google search found one
other person reporting linux-4.3-rc1 also booting with only one core.
His Intel CPU was a year or two newer than mine.

linux-4.3-rc1 showed more problems during boot including something
about mtrr and another thing I forgot.   The mtrr and ? are not
showing in -rc2.   I had to photograph early boot to capture boot
change from a normal working kernel.  (My Fedora is 14, gcc 4.5.1).


 (start insert 3 screen photos transcribed)
AMIBIOS
ASUS P5B-Deluxe ACPI BIOS Revision 1238
CPU : Intel Core 2 CPU 6600 @ 2.4GHz
 --
Booting Fedora (4.3.0-rc2) in 5 seconds...
 --
early console in decompress_kernel
 (next 5 lines never appear with 4.2.1 and older kernels)
input_data: 0x0181026e
input_len:  0x003c93c3
output: 0x0100
output_len: 0x00bc7870
run_size:   0x00c72000

Decompressing Linux... Parsing ELF... done.
Booting the kernel.
smpboot: do_boot_cpu failed(-1) to wakeup CPU#1
 (end insert)

but continues to bootup and works with one CPU.

/proc/cpuinfo shows only one of two CPU cores:
siblings: 1
cpu cores   : 1
(both should be : 2 )

With -rc2, /proc/mtrr is same as a working kernel (-rc1?):
reg00: base=0x0d000 ( 3328MB), size=  256MB, count=1: uncachable
reg01: base=0x0e000 ( 3584MB), size=  512MB, count=1: uncachable
reg02: base=0x0 (0MB), size= 8192MB, count=1: write-back

How can I fix this?

Thanks,
Don


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4.0 00/58] 4.0.9-stable review

2015-07-21 Thread Donald Parsons 
On Tue, 2015-07-21 at 14:10 -0700, Greg Kroah-Hartman wrote:
> > Andrew Morton (1):
> >   arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
> > 
> > which must be it.  Added Andrew to cc as he hopefully knows the
> answer to your question.
> 
> You can dig through git to find it pretty easily...
> 
> Anyway, given that the 4.0 release I'm doing at the moment is the last
> one, and it's end-of-life, this is a bit late and isn't going to
> matter much.  People should be on 4.1 already.

Okay. But just in case.  I had to learn about git and do a checkout.

git log v4.1-rc8 arch/x86/kvm/mmu.c  shows:

commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
Author: Andrew Morton 
Date:   Wed Jun 10 11:15:02 2015 -0700

arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug

Fix this compile issue with gcc-4.4.4:

   arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
   arch/x86/kvm/mmu.c:4256: error: unknown field 'cr0_wp' specified
in initializer
   arch/x86/kvm/mmu.c:4257: error: unknown field 'cr4_pae' specified
in initializer
   arch/x86/kvm/mmu.c:4257: warning: excess elements in union
initializer
   ...

gcc-4.4.4 (at least) has issues when using anonymous unions in
initializers.

Fixes: edc90b7dc4ceef6 ("KVM: MMU: fix SMAP virtualization")
Cc: Xiao Guangrong 
Cc: Paolo Bonzini 
Cc: Davidlohr Bueso 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 


Hopefully commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
is what you were looking for.  If not, very sorry for interrupting you.

Thanks,
Don



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4.0 00/58] 4.0.9-stable review

2015-07-21 Thread Donald Parsons 
On Tue, 2015-07-21 at 11:13 -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
> > Greg,
> > 
> > The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
> > a kvm back-port from 4.1-rc5 went in.  (This is on Linux 4.1.2 SMP Mon
> > Jul 13 18:08:30 EDT 2015 x86_64  Fedora 14)
> > 
> > This mis-compile was fixed in 4.1-rc8.  The diff was:
> > 
> > diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
> > linux-4.1-rc8/arch/x86/kvm/mmu.c
> > --- linux-4.1-rc7/arch/x86/kvm/mmu.c2015-07-15 00:05:34.0 
> > -0400
> > +++ linux-4.1-rc8/arch/x86/kvm/mmu.c2015-07-15 00:07:45.0 
> > -0400
> > @@ -4215,13 +4215,13 @@
> > u64 entry, gentry, *spte;
> > int npte;
> > bool remote_flush, local_flush, zap_page;
> > -   union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
> > -   .cr0_wp = 1,
> > -   .cr4_pae = 1,
> > -   .nxe = 1,
> > -   .smep_andnot_wp = 1,
> > -   .smap_andnot_wp = 1,
> > -   };
> > +   union kvm_mmu_page_role mask = { };
> > +
> > +   mask.cr0_wp = 1;
> > +   mask.cr4_pae = 1;
> > +   mask.nxe = 1;
> > +   mask.smep_andnot_wp = 1;
> > +   mask.smap_andnot_wp = 1;
> >  
> > /*
> >  * If we don't have indirect shadow pages, it means no page is
> > 
> > 
> > Please add to linux-4.0.9 so older compilers will work.
> 
> What is the commit id in Linus's tree that resolves this?

I do not know but I found this in Linus' linux-4.1-rc8 email announce:

Andrew Morton (1):
  arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug

which must be it.  Added Andrew to cc as he hopefully knows the answer
to your question.

Thanks,
Don Parsons





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4.0 00/58] 4.0.9-stable review

2015-07-21 Thread Donald Parsons 
Greg,

The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
a kvm back-port from 4.1-rc5 went in.  (This is on Linux 4.1.2 SMP Mon
Jul 13 18:08:30 EDT 2015 x86_64  Fedora 14)

This mis-compile was fixed in 4.1-rc8.  The diff was:

diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
linux-4.1-rc8/arch/x86/kvm/mmu.c
--- linux-4.1-rc7/arch/x86/kvm/mmu.c2015-07-15 00:05:34.0 -0400
+++ linux-4.1-rc8/arch/x86/kvm/mmu.c2015-07-15 00:07:45.0 -0400
@@ -4215,13 +4215,13 @@
u64 entry, gentry, *spte;
int npte;
bool remote_flush, local_flush, zap_page;
-   union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
-   .cr0_wp = 1,
-   .cr4_pae = 1,
-   .nxe = 1,
-   .smep_andnot_wp = 1,
-   .smap_andnot_wp = 1,
-   };
+   union kvm_mmu_page_role mask = { };
+
+   mask.cr0_wp = 1;
+   mask.cr4_pae = 1;
+   mask.nxe = 1;
+   mask.smep_andnot_wp = 1;
+   mask.smap_andnot_wp = 1;
 
/*
 * If we don't have indirect shadow pages, it means no page is


Please add to linux-4.0.9 so older compilers will work.

Thanks,
Don Parsons

PS: Compile error is :

CC [M]  arch/x86/kvm/mmu.o
arch/x86/kvm/mmu.c: In function kvm_mmu_pte_write:
arch/x86/kvm/mmu.c:4219:3: error: unknown field cr0_wp specified
in initializer
arch/x86/kvm/mmu.c:4220:3: error: unknown field cr4_pae specified
in initializer
arch/x86/kvm/mmu.c:4220:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4220:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4221:3: error: unknown field nxe specified in
initializer
arch/x86/kvm/mmu.c:4221:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4221:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4222:3: error: unknown field smep_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4222:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4222:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4223:3: error: unknown field smap_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4223:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4223:3: warning: (near initialization for
(anonymous))
make[2]: *** [arch/x86/kvm/mmu.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4.0 00/58] 4.0.9-stable review

2015-07-21 Thread Donald Parsons 
Greg,

The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
a kvm back-port from 4.1-rc5 went in.  (This is on Linux 4.1.2 SMP Mon
Jul 13 18:08:30 EDT 2015 x86_64  Fedora 14)

This mis-compile was fixed in 4.1-rc8.  The diff was:

diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
linux-4.1-rc8/arch/x86/kvm/mmu.c
--- linux-4.1-rc7/arch/x86/kvm/mmu.c2015-07-15 00:05:34.0 -0400
+++ linux-4.1-rc8/arch/x86/kvm/mmu.c2015-07-15 00:07:45.0 -0400
@@ -4215,13 +4215,13 @@
u64 entry, gentry, *spte;
int npte;
bool remote_flush, local_flush, zap_page;
-   union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
-   .cr0_wp = 1,
-   .cr4_pae = 1,
-   .nxe = 1,
-   .smep_andnot_wp = 1,
-   .smap_andnot_wp = 1,
-   };
+   union kvm_mmu_page_role mask = { };
+
+   mask.cr0_wp = 1;
+   mask.cr4_pae = 1;
+   mask.nxe = 1;
+   mask.smep_andnot_wp = 1;
+   mask.smap_andnot_wp = 1;
 
/*
 * If we don't have indirect shadow pages, it means no page is


Please add to linux-4.0.9 so older compilers will work.

Thanks,
Don Parsons

PS: Compile error is :

CC [M]  arch/x86/kvm/mmu.o
arch/x86/kvm/mmu.c: In function kvm_mmu_pte_write:
arch/x86/kvm/mmu.c:4219:3: error: unknown field cr0_wp specified
in initializer
arch/x86/kvm/mmu.c:4220:3: error: unknown field cr4_pae specified
in initializer
arch/x86/kvm/mmu.c:4220:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4220:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4221:3: error: unknown field nxe specified in
initializer
arch/x86/kvm/mmu.c:4221:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4221:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4222:3: error: unknown field smep_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4222:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4222:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4223:3: error: unknown field smap_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4223:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4223:3: warning: (near initialization for
(anonymous))
make[2]: *** [arch/x86/kvm/mmu.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4.0 00/58] 4.0.9-stable review

2015-07-21 Thread Donald Parsons 
On Tue, 2015-07-21 at 14:10 -0700, Greg Kroah-Hartman wrote:
  Andrew Morton (1):
arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
  
  which must be it.  Added Andrew to cc as he hopefully knows the
 answer to your question.
 
 You can dig through git to find it pretty easily...
 
 Anyway, given that the 4.0 release I'm doing at the moment is the last
 one, and it's end-of-life, this is a bit late and isn't going to
 matter much.  People should be on 4.1 already.

Okay. But just in case.  I had to learn about git and do a checkout.

git log v4.1-rc8 arch/x86/kvm/mmu.c  shows:

commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
Author: Andrew Morton a...@linux-foundation.org
Date:   Wed Jun 10 11:15:02 2015 -0700

arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug

Fix this compile issue with gcc-4.4.4:

   arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
   arch/x86/kvm/mmu.c:4256: error: unknown field 'cr0_wp' specified
in initializer
   arch/x86/kvm/mmu.c:4257: error: unknown field 'cr4_pae' specified
in initializer
   arch/x86/kvm/mmu.c:4257: warning: excess elements in union
initializer
   ...

gcc-4.4.4 (at least) has issues when using anonymous unions in
initializers.

Fixes: edc90b7dc4ceef6 (KVM: MMU: fix SMAP virtualization)
Cc: Xiao Guangrong guangrong.x...@linux.intel.com
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Davidlohr Bueso d...@stgolabs.net
Signed-off-by: Andrew Morton a...@linux-foundation.org
Signed-off-by: Linus Torvalds torva...@linux-foundation.org


Hopefully commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
is what you were looking for.  If not, very sorry for interrupting you.

Thanks,
Don



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 4.0 00/58] 4.0.9-stable review

2015-07-21 Thread Donald Parsons 
On Tue, 2015-07-21 at 11:13 -0700, Greg Kroah-Hartman wrote:
 On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
  Greg,
  
  The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
  a kvm back-port from 4.1-rc5 went in.  (This is on Linux 4.1.2 SMP Mon
  Jul 13 18:08:30 EDT 2015 x86_64  Fedora 14)
  
  This mis-compile was fixed in 4.1-rc8.  The diff was:
  
  diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
  linux-4.1-rc8/arch/x86/kvm/mmu.c
  --- linux-4.1-rc7/arch/x86/kvm/mmu.c2015-07-15 00:05:34.0 
  -0400
  +++ linux-4.1-rc8/arch/x86/kvm/mmu.c2015-07-15 00:07:45.0 
  -0400
  @@ -4215,13 +4215,13 @@
  u64 entry, gentry, *spte;
  int npte;
  bool remote_flush, local_flush, zap_page;
  -   union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
  -   .cr0_wp = 1,
  -   .cr4_pae = 1,
  -   .nxe = 1,
  -   .smep_andnot_wp = 1,
  -   .smap_andnot_wp = 1,
  -   };
  +   union kvm_mmu_page_role mask = { };
  +
  +   mask.cr0_wp = 1;
  +   mask.cr4_pae = 1;
  +   mask.nxe = 1;
  +   mask.smep_andnot_wp = 1;
  +   mask.smap_andnot_wp = 1;
   
  /*
   * If we don't have indirect shadow pages, it means no page is
  
  
  Please add to linux-4.0.9 so older compilers will work.
 
 What is the commit id in Linus's tree that resolves this?

I do not know but I found this in Linus' linux-4.1-rc8 email announce:

Andrew Morton (1):
  arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug

which must be it.  Added Andrew to cc as he hopefully knows the answer
to your question.

Thanks,
Don Parsons





--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Linux 4.1-rc5

2015-05-26 Thread Donald Parsons 
Compile fails with  gcc-4.5.1  on Fedora 14.

log shows...
  CALLscripts/checksyscalls.sh
  CHK include/generated/compile.h
  CC [M]  arch/x86/kvm/mmu.o
arch/x86/kvm/mmu.c: In function ���kvm_mmu_pte_write���:
arch/x86/kvm/mmu.c:4219:3: error: unknown field ���cr0_wp��� specified
in initializer
arch/x86/kvm/mmu.c:4220:3: error: unknown field ���cr4_pae��� specified
in initializer
arch/x86/kvm/mmu.c:4220:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4220:3: warning: (near initialization for
���(anonymous)���)
arch/x86/kvm/mmu.c:4221:3: error: unknown field ���nxe��� specified in
initializer
arch/x86/kvm/mmu.c:4221:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4221:3: warning: (near initialization for
���(anonymous)���)
arch/x86/kvm/mmu.c:4222:3: error: unknown field ���smep_andnot_wp���
specified in initializer
arch/x86/kvm/mmu.c:4222:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4222:3: warning: (near initialization for
���(anonymous)���)
arch/x86/kvm/mmu.c:4223:3: error: unknown field ���smap_andnot_wp���
specified in initializer
arch/x86/kvm/mmu.c:4223:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4223:3: warning: (near initialization for
���(anonymous)���)
make[2]: *** [arch/x86/kvm/mmu.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2

All previous versions including Linux 4.1-rc[234] compiled
successfully.

I cleaned cache too:  ccache -C, no help.

Do I need to upgrade Fedora or is gcc 4.5.1 supposed to work?

Thanks,
Don


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Linux 4.1-rc5

2015-05-26 Thread Donald Parsons 
Compile fails with  gcc-4.5.1  on Fedora 14.

log shows...
  CALLscripts/checksyscalls.sh
  CHK include/generated/compile.h
  CC [M]  arch/x86/kvm/mmu.o
arch/x86/kvm/mmu.c: In function ���kvm_mmu_pte_write���:
arch/x86/kvm/mmu.c:4219:3: error: unknown field ���cr0_wp��� specified
in initializer
arch/x86/kvm/mmu.c:4220:3: error: unknown field ���cr4_pae��� specified
in initializer
arch/x86/kvm/mmu.c:4220:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4220:3: warning: (near initialization for
���(anonymous)���)
arch/x86/kvm/mmu.c:4221:3: error: unknown field ���nxe��� specified in
initializer
arch/x86/kvm/mmu.c:4221:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4221:3: warning: (near initialization for
���(anonymous)���)
arch/x86/kvm/mmu.c:4222:3: error: unknown field ���smep_andnot_wp���
specified in initializer
arch/x86/kvm/mmu.c:4222:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4222:3: warning: (near initialization for
���(anonymous)���)
arch/x86/kvm/mmu.c:4223:3: error: unknown field ���smap_andnot_wp���
specified in initializer
arch/x86/kvm/mmu.c:4223:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4223:3: warning: (near initialization for
���(anonymous)���)
make[2]: *** [arch/x86/kvm/mmu.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2

All previous versions including Linux 4.1-rc[234] compiled
successfully.

I cleaned cache too:  ccache -C, no help.

Do I need to upgrade Fedora or is gcc 4.5.1 supposed to work?

Thanks,
Don


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/