driver/sound/soundcard.c lock_kernel()/unlock_kernel()
Hello all, I've been looking through the sound drivers in the 2.4.5-ac series . drivers/sound/soundcard.c has a few lock_kernel()/unlock_kernel() calls, esp. in the read() and write() functions. Could these calls be easily replaced with semaphores or spinlock calls? I vaguely remember emails on lkml a while ago regarding the removal of lock_kernel()/unlock_kernel(), but I'm don't recall what the replacement was (if any). Regards, Frank btw, Sorry in advance if the mailer causes probelms. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
driver/sound/soundcard.c lock_kernel()/unlock_kernel()
Hello all, I've been looking through the sound drivers in the 2.4.5-ac series . drivers/sound/soundcard.c has a few lock_kernel()/unlock_kernel() calls, esp. in the read() and write() functions. Could these calls be easily replaced with semaphores or spinlock calls? I vaguely remember emails on lkml a while ago regarding the removal of lock_kernel()/unlock_kernel(), but I'm don't recall what the replacement was (if any). Regards, Frank btw, Sorry in advance if the mailer causes probelms. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
sound driver locking patches
Hello all,
I have attached sound driver locking patches for:
drivers/sound/cs4281/cs4281m.c
drivers/sound/i810_audio.c
The patches are against 2.4.5-ac13, and address the sound driver locking
issue mentioned in the -ac series.
Please review. Thanks.
Regards,
Frank
--- drivers/sound/cs4281/cs4281m.c.old Mon Jun 11 00:23:02 2001
+++ drivers/sound/cs4281/cs4281m.c Tue Jun 12 01:17:14 2001
@@ -293,6 +293,7 @@
struct cs4281_pm pm;
struct cs4281_pipeline pl[CS4281_NUMBER_OF_PIPELINES];
+ struct semaphore sem;
};
#include "cs4281pm-24.c"
@@ -2876,7 +2877,7 @@
{
struct cs4281_state *s =
(struct cs4281_state *) file->private_data;
- ssize_t ret;
+ ssize_t ret = 0;
unsigned long flags;
unsigned swptr;
int cnt;
@@ -2890,11 +2891,12 @@
return -ESPIPE;
if (s->dma_adc.mapped)
return -ENXIO;
- if (!s->dma_adc.ready && (ret = prog_dmabuf_adc(s)))
- return ret;
if (!access_ok(VERIFY_WRITE, buffer, count))
return -EFAULT;
- ret = 0;
+
+ down(>sem);
+ if (!s->dma_adc.ready && (ret = prog_dmabuf_adc(s)))
+ goto out;
//
// "count" is the amount of bytes to read (from app), is decremented each loop
// by the amount of bytes that have been returned to the user buffer.
@@ -2950,10 +2952,23 @@
// the loop when wake up occurs.
start_adc(s);
if (file->f_flags & O_NONBLOCK)
- return ret ? ret : -EAGAIN;
+ {
+ if(!ret) ret = -EAGAIN;
+ goto out;
+ }
+ up(>sem);
interruptible_sleep_on(>dma_adc.wait);
if (signal_pending(current))
- return ret ? ret : -ERESTARTSYS;
+ {
+ if(!ret) ret = -ERESTARTSYS;
+ goto out;
+ }
+ down(>sem);
+ if (s->dma_adc.mapped)
+ {
+ ret = -ENXIO;
+ goto out;
+ }
continue;
}
// there are bytes in the buffer to read.
@@ -2971,7 +2986,10 @@
if (cs_copy_to_user
(s, buffer, s->dma_adc.rawbuf + swptr, cnt, ))
- return ret ? ret : -EFAULT;
+ {
+ if(!ret) ret = -EFAULT;
+ goto out;
+ }
swptr = (swptr + cnt) % s->dma_adc.dmasize;
spin_lock_irqsave(>lock, flags);
s->dma_adc.swptr = swptr;
@@ -2984,6 +3002,8 @@
}
CS_DBGOUT(CS_FUNCTION | CS_WAVE_READ, 2,
printk(KERN_INFO "cs4281: cs4281_read()- %d\n", ret));
+out:
+ up(>sem);
return ret;
}
@@ -3007,10 +3027,12 @@
return -ESPIPE;
if (s->dma_dac.mapped)
return -ENXIO;
- if (!s->dma_dac.ready && (ret = prog_dmabuf_dac(s)))
- return ret;
if (!access_ok(VERIFY_READ, buffer, count))
return -EFAULT;
+ down(>sem);
+ if (!s->dma_dac.ready && (ret = prog_dmabuf_dac(s)))
+ goto out;
+
ret = 0;
while (count > 0) {
spin_lock_irqsave(>lock, flags);
@@ -3035,14 +3057,30 @@
if (cnt <= 0) {
start_dac(s);
if (file->f_flags & O_NONBLOCK)
- return ret ? ret : -EAGAIN;
+ {
+ if(!ret) ret = -EAGAIN;
+ goto out;
+ }
+ up(>sem);
interruptible_sleep_on(>dma_dac.wait);
if (signal_pending(current))
- return ret ? ret : -ERESTARTSYS;
+ {
+ if(!ret) ret = -ERESTARTSYS;
+ goto out;
+ }
+ down(>sem);
+ if (s->dma_dac.mapped)
+ {
+ ret = -ENXIO;
+ goto out;
+ }
continue;
}
if (copy_from_user(s->dma_dac.rawbuf + swptr, buffer, cnt))
- return ret
Re: 2.4.5-ac13: Where is your change log gone? Can't find it on LKM.
Dieter, I don't believe Alan has posted it yet...should be out soon. Regards, Frank -On Sunday, June 10, 2001 9:54 PM +0200 Dieter Ntzel <[EMAIL PROTECTED]> wrote: > Thanks, > Dieter > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.5-ac13: Where is your change log gone? Can't find it on LKM.
Dieter, I don't believe Alan has posted it yet...should be out soon. Regards, Frank -On Sunday, June 10, 2001 9:54 PM +0200 Dieter Ntzel [EMAIL PROTECTED] wrote: Thanks, Dieter - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
patches sound driver locking issue
Hello all,
I have attached patches against the following sound drivers to fix the locking
issues mentioned in Alan's release notes for 2.4.5-ac9 . Please CC me on your comments
to the code (I can address the issues quicker). Thanks.
drivers/sound/esssolo1.c
drivers/sound/maestro.c
drivers/sound/maestro3.c
drivers/sound/cmpci.c
Regards,
Frank
--- drivers/sound/cmpci.c.old Tue Jun 5 21:21:39 2001
+++ drivers/sound/cmpci.c Tue Jun 5 23:20:41 2001
@@ -312,6 +312,7 @@
/* spdif frame counter */
int spdif_counter;
+ struct semaphore sem;
};
/* flags used for capability */
@@ -1653,7 +1654,7 @@
static ssize_t cm_read(struct file *file, char *buffer, size_t count, loff_t *ppos)
{
struct cm_state *s = (struct cm_state *)file->private_data;
- ssize_t ret;
+ ssize_t ret = 0;
unsigned long flags;
unsigned swptr;
int cnt;
@@ -1663,11 +1664,11 @@
return -ESPIPE;
if (s->dma_adc.mapped)
return -ENXIO;
- if (!s->dma_adc.ready && (ret = prog_dmabuf(s, 1)))
- return ret;
if (!access_ok(VERIFY_WRITE, buffer, count))
return -EFAULT;
- ret = 0;
+ down(>sem);
+ if (!s->dma_adc.ready && (ret = prog_dmabuf(s, 1)))
+ goto out;
#if 0
spin_lock_irqsave(>lock, flags);
cm_update_ptr(s);
@@ -1684,8 +1685,12 @@
cnt = count;
if (cnt <= 0) {
start_adc(s);
- if (file->f_flags & O_NONBLOCK)
- return ret ? ret : -EAGAIN;
+ if (file->f_flags & O_NONBLOCK)a
+ {
+ if(!ret) ret = -EAGAIN;
+ goto out;
+ }
+ up(>sem);
if (!interruptible_sleep_on_timeout(>dma_adc.wait, HZ)) {
printk(KERN_DEBUG "cm: read: chip lockup? dmasz %u
fragsz %u count %i hwptr %u swptr %u\n",
s->dma_adc.dmasize, s->dma_adc.fragsize,
s->dma_adc.count,
@@ -1698,12 +1703,24 @@
s->dma_adc.count = s->dma_adc.hwptr = s->dma_adc.swptr
= 0;
spin_unlock_irqrestore(>lock, flags);
}
- if (signal_pending(current))
- return ret ? ret : -ERESTARTSYS;
+ if (signal_pending(current))
+ {
+ if(!ret) ret = -ERESTARTSYS;
+ goto out;
+ }
+ down(>sem);
+ if (s->dma_adc.mapped)
+ {
+ ret = -ENXIO;
+ goto out;
+ }
continue;
}
if (copy_to_user(buffer, s->dma_adc.rawbuf + swptr, cnt))
- return ret ? ret : -EFAULT;
+ {
+ if(!ret) ret = -EFAULT;
+ goto out;
+ }
swptr = (swptr + cnt) % s->dma_adc.dmasize;
spin_lock_irqsave(>lock, flags);
s->dma_adc.swptr = swptr;
@@ -1714,6 +1731,8 @@
start_adc_unlocked(s);
spin_unlock_irqrestore(>lock, flags);
}
+out:
+ up(>sem);
return ret;
}
@@ -1730,18 +1749,20 @@
return -ESPIPE;
if (s->dma_dac.mapped)
return -ENXIO;
- if (!s->dma_dac.ready && (ret = prog_dmabuf(s, 0)))
- return ret;
if (!access_ok(VERIFY_READ, buffer, count))
return -EFAULT;
if (s->status & DO_DUAL_DAC) {
if (s->dma_adc.mapped)
return -ENXIO;
- if (!s->dma_adc.ready && (ret = prog_dmabuf(s, 1)))
- return ret;
if (!access_ok(VERIFY_READ, buffer, count))
return -EFAULT;
+ down(>sem);
+ if (!s->dma_adc.ready && (ret = prog_dmabuf(s, 1)))
+ goto out;
}
+ down(>sem);
+ if (!s->dma_dac.ready && (ret = prog_dmabuf(s, 0)))
+ goto out;
ret = 0;
#if 0
spin_lock_irqsave(>lock, flags);
@@ -1776,7 +1797,11 @@
if (cnt <= 0) {
start_dac(s);
if (file->f_flags & O_NONBLOCK)
- return ret ? ret : -EAGAIN;
+ {
+if(!ret) ret = -EAGAIN;
+goto out;
+ }
+ up(>sem);
if (!interruptible_sleep_on_timeout(>dma_dac.wait, HZ)) {
patches sound driver locking issue
Hello all,
I have attached patches against the following sound drivers to fix the locking
issues mentioned in Alan's release notes for 2.4.5-ac9 . Please CC me on your comments
to the code (I can address the issues quicker). Thanks.
drivers/sound/esssolo1.c
drivers/sound/maestro.c
drivers/sound/maestro3.c
drivers/sound/cmpci.c
Regards,
Frank
--- drivers/sound/cmpci.c.old Tue Jun 5 21:21:39 2001
+++ drivers/sound/cmpci.c Tue Jun 5 23:20:41 2001
@@ -312,6 +312,7 @@
/* spdif frame counter */
int spdif_counter;
+ struct semaphore sem;
};
/* flags used for capability */
@@ -1653,7 +1654,7 @@
static ssize_t cm_read(struct file *file, char *buffer, size_t count, loff_t *ppos)
{
struct cm_state *s = (struct cm_state *)file-private_data;
- ssize_t ret;
+ ssize_t ret = 0;
unsigned long flags;
unsigned swptr;
int cnt;
@@ -1663,11 +1664,11 @@
return -ESPIPE;
if (s-dma_adc.mapped)
return -ENXIO;
- if (!s-dma_adc.ready (ret = prog_dmabuf(s, 1)))
- return ret;
if (!access_ok(VERIFY_WRITE, buffer, count))
return -EFAULT;
- ret = 0;
+ down(s-sem);
+ if (!s-dma_adc.ready (ret = prog_dmabuf(s, 1)))
+ goto out;
#if 0
spin_lock_irqsave(s-lock, flags);
cm_update_ptr(s);
@@ -1684,8 +1685,12 @@
cnt = count;
if (cnt = 0) {
start_adc(s);
- if (file-f_flags O_NONBLOCK)
- return ret ? ret : -EAGAIN;
+ if (file-f_flags O_NONBLOCK)a
+ {
+ if(!ret) ret = -EAGAIN;
+ goto out;
+ }
+ up(s-sem);
if (!interruptible_sleep_on_timeout(s-dma_adc.wait, HZ)) {
printk(KERN_DEBUG cm: read: chip lockup? dmasz %u
fragsz %u count %i hwptr %u swptr %u\n,
s-dma_adc.dmasize, s-dma_adc.fragsize,
s-dma_adc.count,
@@ -1698,12 +1703,24 @@
s-dma_adc.count = s-dma_adc.hwptr = s-dma_adc.swptr
= 0;
spin_unlock_irqrestore(s-lock, flags);
}
- if (signal_pending(current))
- return ret ? ret : -ERESTARTSYS;
+ if (signal_pending(current))
+ {
+ if(!ret) ret = -ERESTARTSYS;
+ goto out;
+ }
+ down(s-sem);
+ if (s-dma_adc.mapped)
+ {
+ ret = -ENXIO;
+ goto out;
+ }
continue;
}
if (copy_to_user(buffer, s-dma_adc.rawbuf + swptr, cnt))
- return ret ? ret : -EFAULT;
+ {
+ if(!ret) ret = -EFAULT;
+ goto out;
+ }
swptr = (swptr + cnt) % s-dma_adc.dmasize;
spin_lock_irqsave(s-lock, flags);
s-dma_adc.swptr = swptr;
@@ -1714,6 +1731,8 @@
start_adc_unlocked(s);
spin_unlock_irqrestore(s-lock, flags);
}
+out:
+ up(s-sem);
return ret;
}
@@ -1730,18 +1749,20 @@
return -ESPIPE;
if (s-dma_dac.mapped)
return -ENXIO;
- if (!s-dma_dac.ready (ret = prog_dmabuf(s, 0)))
- return ret;
if (!access_ok(VERIFY_READ, buffer, count))
return -EFAULT;
if (s-status DO_DUAL_DAC) {
if (s-dma_adc.mapped)
return -ENXIO;
- if (!s-dma_adc.ready (ret = prog_dmabuf(s, 1)))
- return ret;
if (!access_ok(VERIFY_READ, buffer, count))
return -EFAULT;
+ down(s-sem);
+ if (!s-dma_adc.ready (ret = prog_dmabuf(s, 1)))
+ goto out;
}
+ down(s-sem);
+ if (!s-dma_dac.ready (ret = prog_dmabuf(s, 0)))
+ goto out;
ret = 0;
#if 0
spin_lock_irqsave(s-lock, flags);
@@ -1776,7 +1797,11 @@
if (cnt = 0) {
start_dac(s);
if (file-f_flags O_NONBLOCK)
- return ret ? ret : -EAGAIN;
+ {
+if(!ret) ret = -EAGAIN;
+goto out;
+ }
+ up(s-sem);
if (!interruptible_sleep_on_timeout(s-dma_dac.wait, HZ)) {
printk(KERN_DEBUG cm: write: chip
2.4.5-ac4 es1371.o unresolved symbols
Hello, While 'make modules_install' on 2.4.5-ac4, I received the following error: depmod: *** Unresolved symbols in /lib/modules/2.4.5-ac4/kernel/drivers/sound/es1371.o depmod: gameport_register_port_Rsmp_aa96bd99 depmod: gameport_unregister_port_Rsmp_ec101047 The previous steps make mrproper, make config, make clean, make bzImage, make modules all appeared to work. The .config is the same as 2.4.5-ac3 Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.5-ac4 es1371.o unresolved symbols
Hello, While 'make modules_install' on 2.4.5-ac4, I received the following error: depmod: *** Unresolved symbols in /lib/modules/2.4.5-ac4/kernel/drivers/sound/es1371.o depmod: gameport_register_port_Rsmp_aa96bd99 depmod: gameport_unregister_port_Rsmp_ec101047 The previous steps make mrproper, make config, make clean, make bzImage, make modules all appeared to work. The .config is the same as 2.4.5-ac3 Regards, Frank - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.3-ac9: af_wanpipe.o unresolved symbols
Hello, During the last stage of make modules_install on 2.4.3-ac9, I received the following: depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac9/kernel/net/wanrouter/af_wanpipe.o depmod: wanpipe_mark_bh depmod: wanpipe_queue_tq depmod: wanpipe_find_card Regards, Frank The previous build steps seemed to work without problems: make mrproper; make config;make dep;make clean;make bzImage;make modules - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.3-ac9: af_wanpipe.o unresolved symbols
Hello, During the last stage of make modules_install on 2.4.3-ac9, I received the following: depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac9/kernel/net/wanrouter/af_wanpipe.o depmod: wanpipe_mark_bh depmod: wanpipe_queue_tq depmod: wanpipe_find_card Regards, Frank The previous build steps seemed to work without problems: make mrproper; make config;make dep;make clean;make bzImage;make modules - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.2-ac13 make modules_install error
Hello, While 'make modules_install' on 2.4.2-ac13, I receive the following error: make -C kernel modules_install make[1]: Entering directory '/usr/src/linux/kernel' make[1]: Nothing to be done for 'modules_install'. .. make -C drivers modules_install make[1]: Entering directory ;/usr/src/linux/drivers' make -C arm modules_install make[2]: Entering directory '/usr/src/linux/drivers/atm' mkdir -p /lib/modules/2.4.2-ac13/kernel/$(shell ($CONFIG_SHELL) $(TOPDIR)/scripts/pathdown.sh) /bin/sh: CONFIG_SHELL: command not found /bin/sh: TOPDIR: command not found All previous steps appeared to work without any problems, and I performed a 'make mrproper'. The build worked in 2.4.2-ac11 . Any suggestions? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.2-ac13 make modules_install error
Hello, While 'make modules_install' on 2.4.2-ac13, I receive the following error: make -C kernel modules_install make[1]: Entering directory '/usr/src/linux/kernel' make[1]: Nothing to be done for 'modules_install'. .. make -C drivers modules_install make[1]: Entering directory ;/usr/src/linux/drivers' make -C arm modules_install make[2]: Entering directory '/usr/src/linux/drivers/atm' mkdir -p /lib/modules/2.4.2-ac13/kernel/$(shell ($CONFIG_SHELL) $(TOPDIR)/scripts/pathdown.sh) /bin/sh: CONFIG_SHELL: command not found /bin/sh: TOPDIR: command not found All previous steps appeared to work without any problems, and I performed a 'make mrproper'. The build worked in 2.4.2-ac11 . Any suggestions? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
clarification 2.4.2-ac5: trident.c
Hello, When I stated: 'off the root directory', I meant the root kernel directory: /usr/src/linux , not / Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.2-ac5: trident.c
Hello, In patch-2.4.2-ac5 , a trident.c is created off the root directory. Was that supposed to be a merge with drivers/sound/trident.c ? There is a separate patch on drivers/sound/trident.c in 2.4.2-ac5. The one I'm referring to is located last in the patch. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.2-ac5: trident.c
Hello, In patch-2.4.2-ac5 , a trident.c is created off the root directory. Was that supposed to be a merge with drivers/sound/trident.c ? There is a separate patch on drivers/sound/trident.c in 2.4.2-ac5. The one I'm referring to is located last in the patch. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
clarification 2.4.2-ac5: trident.c
Hello, When I stated: 'off the root directory', I meant the root kernel directory: /usr/src/linux , not / Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.4.1-ac10 compile error
Hello, I received the following while compiling 2.4.1-ac10: ... make[3]: *** No rule to make target '/usr/src/linux/drivers/pci/devlist.h', needed by names.o'. Stop make[3]: Leaving directory '/usr/src/linux/drivers/pci' make[2]: *** [first_rule] Error 2 ... I haven't looked into it, but the addition was between 2.4.1-ac9 and 2.4.1-ac10. 2.4.2-pre3 didn't have this problem. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.1-ac10 compile error
Hello, I received the following while compiling 2.4.1-ac10: ... make[3]: *** No rule to make target '/usr/src/linux/drivers/pci/devlist.h', needed by names.o'. Stop make[3]: Leaving directory '/usr/src/linux/drivers/pci' make[2]: *** [first_rule] Error 2 ... I haven't looked into it, but the addition was between 2.4.1-ac9 and 2.4.1-ac10. 2.4.2-pre3 didn't have this problem. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Hot swap CPU support for 2.4.1
Hello, Which archs still need to implement it? I briefly looked over the patch and noticed that it had i386, ppc, mips64, and s390 already there. Regards, Frank >Hi all, > >I did the infrastructure, Anton did the bugfinding and PPC >support, >aka. the hard stuff. Other architectures need to implement >__cpu_disable, __cpu_die and __cpu_up for them to work. >Volunteers >appreciated. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Hot swap CPU support for 2.4.1
Hello, Which archs still need to implement it? I briefly looked over the patch and noticed that it had i386, ppc, mips64, and s390 already there. Regards, Frank Hi all, I did the infrastructure, Anton did the bugfinding and PPC support, aka. the hard stuff. Other architectures need to implement __cpu_disable, __cpu_die and __cpu_up for them to work. Volunteers appreciated. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.0-ac10 patching issue
Hello, I just applied 2.4.0-ac10 to 2.4.0(patch -p1 http://www.tux.org/lkml/
2.4.0-ac10 patching issue
Hello, I just applied 2.4.0-ac10 to 2.4.0(patch -p1 patch-2.4.0-ac10), and include/iinux/autoconf.h and include/linux/modversion.h didn't apply cleanly. I received .rej files. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.0-ac6: mm/vmalloc.c compile error
Hello, The following error occurred while compiling 2.4.0-ac6..The strange thing is that I checked mm/vmalloc.c (line 188, and the entire file) and didn't see PKMAP_BASE mentioned. My guess is that there is a problem with one of the header files. Regards, Frank vmalloc.c: In function `get_vm_area':vmalloc.c:188: `PKMAP_BASE' undeclared (first use in this function)vmalloc.c:188: (Each undeclared identifier is reported only oncevmalloc.c:188: for each function it appears in.)make[2]: *** [vmalloc.o] Error 1make[2]: Leaving directory `/usr/src/linux/mm'make[1]: *** [first_rule] Error 2make[1]: Leaving directory `/usr/src/linux/mm'make: *** [_dir_mm] Error 2
2.4.0-ac6: mm/vmalloc.c compile error
Hello, The following error occurred while compiling 2.4.0-ac6..The strange thing is that I checked mm/vmalloc.c (line 188, and the entire file) and didn't see PKMAP_BASE mentioned. My guess is that there is a problem with one of the header files. Regards, Frank vmalloc.c: In function `get_vm_area':vmalloc.c:188: `PKMAP_BASE' undeclared (first use in this function)vmalloc.c:188: (Each undeclared identifier is reported only oncevmalloc.c:188: for each function it appears in.)make[2]: *** [vmalloc.o] Error 1make[2]: Leaving directory `/usr/src/linux/mm'make[1]: *** [first_rule] Error 2make[1]: Leaving directory `/usr/src/linux/mm'make: *** [_dir_mm] Error 2
[PATCH] 2.4.0-ac4 : Removal of drivers/misc/misc.o
Hello, The following patch removes drivers/misc/misc.o from the kernel build. It appears that drivers/misc isn't used for anything, and should be probably be removed. Regards, Frank --- Makefile.old Sun Jan 7 23:59:37 2001+++ Makefile Mon Jan 8 00:24:46 2001@@ -121,7 +121,6 @@ NETWORKS =net/network.o DRIVERS =drivers/block/block.o \ drivers/char/char.o \- drivers/misc/misc.o \ drivers/net/net.o \ drivers/media/media.o LIBS =$(TOPDIR)/lib/lib.a--- drivers/Makefile.old Sun Jan 7 23:59:48 2001+++ drivers/Makefile Mon Jan 8 20:25:57 2001@@ -9,7 +9,7 @@ mod-subdirs := dio mtd sbus video macintosh usb input telephony sgi message/i2o message/fusion ide \ scsi md ieee1394 pnp isdn atm fc4 net/hamradio i2c acpi -subdir-y := block char net parport sound misc media cdrom+subdir-y := block char net parport sound media cdrom subdir-m := $(subdir-y)
[PATCH] 2.4.0-ac4 : Removal of drivers/misc/misc.o
Hello, The following patch removes drivers/misc/misc.o from the kernel build. It appears that drivers/misc isn't used for anything, and should be probably be removed. Regards, Frank --- Makefile.old Sun Jan 7 23:59:37 2001+++ Makefile Mon Jan 8 00:24:46 2001@@ -121,7 +121,6 @@NETWORKS =net/network.oDRIVERS =drivers/block/block.o \ drivers/char/char.o \- drivers/misc/misc.o \ drivers/net/net.o \ drivers/media/media.oLIBS =$(TOPDIR)/lib/lib.a--- drivers/Makefile.old Sun Jan 7 23:59:48 2001+++ drivers/Makefile Mon Jan 8 20:25:57 2001@@ -9,7 +9,7 @@mod-subdirs := dio mtd sbus video macintosh usb input telephony sgi message/i2o message/fusion ide \ scsi md ieee1394 pnp isdn atm fc4 net/hamradio i2c acpi-subdir-y := block char net parport sound misc media cdrom+subdir-y := block char net parport sound media cdromsubdir-m := $(subdir-y)
[PATCH] 2.4.0-ac4 : fs/qnx4/inode.c
Hello, While compiling 2.4.0-ac4, I receivied the following..Looks like a typo...Patch is also below. Regards, Frank inode.c: In function `qnx4_read_super':inode.c:372: `sb' undeclared (first use in this function)inode.c:372: (Each undeclared identifier is reported only onceinode.c:372: for each function it appears in.)make[2]: *** [inode.o] Error 1make[2]: Leaving directory `/usr/src/linux/fs/qnx4'make[1]: *** [_modsubdir_qnx4] Error 2make[1]: Leaving directory `/usr/src/linux/fs'make: *** [_mod_fs] Error 2 --- fs/qnx4/inode.c.old Mon Jan 8 00:00:35 2001+++ fs/qnx4/inode.c Mon Jan 8 00:38:51 2001@@ -369,7 +369,7 @@ } s->s_op = _sops; s->s_magic = QNX4_SUPER_MAGIC;- sb->s_maxbytes = 0x7FFF;+ s->s_maxbytes = 0x7FFF; #ifndef CONFIG_QNX4FS_RW s->s_flags |= MS_RDONLY; /* Yup, read-only yet */ #endif
[PATCH] 2.4.0-ac4 : fs/qnx4/inode.c
Hello, While compiling 2.4.0-ac4, I receivied the following..Looks like a typo...Patch is also below. Regards, Frank inode.c: In function `qnx4_read_super':inode.c:372: `sb' undeclared (first use in this function)inode.c:372: (Each undeclared identifier is reported only onceinode.c:372: for each function it appears in.)make[2]: *** [inode.o] Error 1make[2]: Leaving directory `/usr/src/linux/fs/qnx4'make[1]: *** [_modsubdir_qnx4] Error 2make[1]: Leaving directory `/usr/src/linux/fs'make: *** [_mod_fs] Error 2 --- fs/qnx4/inode.c.old Mon Jan 8 00:00:35 2001+++ fs/qnx4/inode.c Mon Jan 8 00:38:51 2001@@ -369,7 +369,7 @@ } s-s_op = qnx4_sops; s-s_magic = QNX4_SUPER_MAGIC;- sb-s_maxbytes = 0x7FFF;+ s-s_maxbytes = 0x7FFF;#ifndef CONFIG_QNX4FS_RW s-s_flags |= MS_RDONLY; /* Yup, read-only yet */#endif
2.4.0-ac1 : 'make dep' drivers/acpi error
Hello, I just downloaded 2.4.0-ac1 , and received the following error during 'make dep': make -C acpi fastdep make[4]: Entering directory `/usr/src/linux/drivers/acpi' /usr/src/linux/Rules.make:224: *** Recursive variable `CFLAGS' references itself (eventually). Stop. I saw Keith's email about moving to make v3.77 or v3.79, if you are using v3.78 . I confirmed that I am using make version v3.77 . So, it appears that v3.77 doesn't work to compile drivers/acpi . Should we look into patching Changes to make 3.79 the minimum version for make, or 'fix' drivers/acpi (Makefile, Rules.make, etc.)? Has v3.79 been confirmed to work? I understand v3.78 is confirmed broken. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.0-ac1 : 'make dep' drivers/acpi error
Hello, I just downloaded 2.4.0-ac1 , and received the following error during 'make dep': make -C acpi fastdep make[4]: Entering directory `/usr/src/linux/drivers/acpi' /usr/src/linux/Rules.make:224: *** Recursive variable `CFLAGS' references itself (eventually). Stop. I saw Keith's email about moving to make v3.77 or v3.79, if you are using v3.78 . I confirmed that I am using make version v3.77 . So, it appears that v3.77 doesn't work to compile drivers/acpi . Should we look into patching Changes to make 3.79 the minimum version for make, or 'fix' drivers/acpi (Makefile, Rules.make, etc.)? Has v3.79 been confirmed to work? I understand v3.78 is confirmed broken. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.0-prerelease-ac5 : 'make dep' error
Hello, I received the following make dep error while compiling prerelease-ac5 . Regards, Frank make -C acpi fastdepmake[4]: Entering directory `/usr/src/linux/drivers/acpi'/usr/src/linux/Rules.make:224: *** Recursive variable `CFLAGS' references itself (eventually). Stop.make[4]: Leaving directory `/usr/src/linux/drivers/acpi'make[3]: *** [_sfdep_acpi] Error 2make[3]: Leaving directory `/usr/src/linux/drivers'make[2]: *** [fastdep] Error 2make[2]: Leaving directory `/usr/src/linux/drivers'make[1]: *** [_sfdep_drivers] Error 2make[1]: Leaving directory `/usr/src/linux'make: *** [dep-files] Error 2
2.4.0-prerelease-ac5 : 'make dep' error
Hello, I received the following make dep error while compiling prerelease-ac5 . Regards, Frank make -C acpi fastdepmake[4]: Entering directory `/usr/src/linux/drivers/acpi'/usr/src/linux/Rules.make:224: *** Recursive variable `CFLAGS' references itself (eventually). Stop.make[4]: Leaving directory `/usr/src/linux/drivers/acpi'make[3]: *** [_sfdep_acpi] Error 2make[3]: Leaving directory `/usr/src/linux/drivers'make[2]: *** [fastdep] Error 2make[2]: Leaving directory `/usr/src/linux/drivers'make[1]: *** [_sfdep_drivers] Error 2make[1]: Leaving directory `/usr/src/linux'make: *** [dep-files] Error 2
Re: [PATCH] 2.4.0-prerelease -- rcpci45 compile error
Mohammad,
This appears to be a merge mismatch between Alan and Linus..This is
sent to Alan shortly after test13pre4-ac2 was released.
Regards,
Frank
--- linux/drivers/net/rcpci45.c.orig Sun Dec 31 15:58:05 2000 +++
linux/drivers/net/rcpci45.c Sun Dec 31 16:27:04 2000 @@ -157,7
+157,7 @@ { RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 0}, {0, } };
-MODULE_DEVICE_TABLE(pci, rcpci_pci_table); +MODULE_DEVICE_TABLE(pci,
rcpci45_pci_table); static void
rcpci45_remove_one(struct pci_dev *pdev) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] 2.4.0-prerelease -- rcpci45 compile error
Mohammad,
This appears to be a merge mismatch between Alan and Linus..This is
sent to Alan shortly after test13pre4-ac2 was released.
Regards,
Frank
--- linux/drivers/net/rcpci45.c.orig Sun Dec 31 15:58:05 2000 +++
linux/drivers/net/rcpci45.c Sun Dec 31 16:27:04 2000 @@ -157,7
+157,7 @@ { RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 0}, {0, } };
-MODULE_DEVICE_TABLE(pci, rcpci_pci_table); +MODULE_DEVICE_TABLE(pci,
rcpci45_pci_table); static void
rcpci45_remove_one(struct pci_dev *pdev) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] test13-pre6 net/atm/lec.c
Hello, The following patch appears to fix 2 of the 3 undefined references: publish_netdev is still unresolved. Regards, Frank --- net/atm/lec.c.old Sat Dec 30 03:08:14 2000+++ net/atm/lec.c Sat Dec 30 03:17:44 2000@@ -772,10 +772,10 @@ size = sizeof(struct lec_priv); #ifdef CONFIG_TR if (is_trdev)- dev_lec[i] = prepare_trdev(NULL, size);+ dev_lec[i] = init_trdev(NULL, size); else #endif- dev_lec[i] = prepare_etherdev(NULL, size);+ dev_lec[i] = init_etherdev(NULL, size); if (!dev_lec[i]) return -ENOMEM;
[PATCH] test13-pre6 net/atm/lec.c
Hello, The following patch appears to fix 2 of the 3 undefined references: publish_netdev is still unresolved. Regards, Frank --- net/atm/lec.c.old Sat Dec 30 03:08:14 2000+++ net/atm/lec.c Sat Dec 30 03:17:44 2000@@ -772,10 +772,10 @@ size = sizeof(struct lec_priv);#ifdef CONFIG_TR if (is_trdev)- dev_lec[i] = prepare_trdev(NULL, size);+ dev_lec[i] = init_trdev(NULL, size); else#endif- dev_lec[i] = prepare_etherdev(NULL, size);+ dev_lec[i] = init_etherdev(NULL, size); if (!dev_lec[i]) return -ENOMEM;
test13-pre6 compile error..network.o
Hello, I received the following error while compiling test13-pre6 . net/network.o: In function `lecd_attach':net/network.o(.text+0x5ce78): undefined reference to `prepare_trdev'net/network.o(.text+0x5ce88): undefined reference to `prepare_etherdev'net/network.o(.text+0x5cee3): undefined reference to `publish_netdev'make: *** [vmlinux] Error 1 Regards, -Frank
test13-pre6 compile error..network.o
Hello, I received the following error while compiling test13-pre6 . net/network.o: In function `lecd_attach':net/network.o(.text+0x5ce78): undefined reference to `prepare_trdev'net/network.o(.text+0x5ce88): undefined reference to `prepare_etherdev'net/network.o(.text+0x5cee3): undefined reference to `publish_netdev'make: *** [vmlinux] Error 1 Regards, -Frank
test13-pre2, fpu_entry.c compile error
Hello, I haven't seen this posted yet, so I have included it below. Regards, Frank fpu_entry.c: In function `math_emulate':fpu_entry.c:194: structure has no member named `segments'make[2]: *** [fpu_entry.o] Error 1make[2]: Leaving directory `/usr/src/linux/arch/i386/math-emu'make[1]: *** [first_rule] Error 2make[1]: Leaving directory `/usr/src/linux/arch/i386/math-emu'make: *** [_dir_arch/i386/math-emu] Error 2
test13-pre2, fpu_entry.c compile error
Hello, Ihaven't seen this posted yet, so I have included it below. Regards, Frank fpu_entry.c: In function `math_emulate':fpu_entry.c:194: structure has no member named `segments'make[2]: *** [fpu_entry.o] Error 1make[2]: Leaving directory `/usr/src/linux/arch/i386/math-emu'make[1]: *** [first_rule] Error 2make[1]: Leaving directory `/usr/src/linux/arch/i386/math-emu'make: *** [_dir_arch/i386/math-emu] Error 2
Re: test13-pre1 changelog
Hello, Linus didn't annnounce test13-pre1 as far as I am aware of. Regards, Frank --On Thursday, December 14, 2000 12:11 PM -0800 "Dr. Kelsey Hudson" <[EMAIL PROTECTED]> wrote: > On Thu, 14 Dec 2000, David Riley wrote: > >> Did I miss a post from Linus on the list, or is there no posted >> changelog for test13-pre1? Nothing's posted at kernel.org yet, either. >> > > I musta missed the post too... But then again I went back and looked for > it and couldnt find it so... > > i'd like to know what changed, anyways :) > > Kelsey Hudson > [EMAIL PROTECTED] Software Engineer > Compendium Technologies, Inc (619) 725-0771 > - > -- > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test13-1, no subversion change on the Makefile
Hello, I downloaded test13-1.gz, and noticed that it didn't have a subversion change in it. eg: --- Makefile +++ Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 4 SUBLEVEL = 0 -EXTRAVERSION = -test12 +EXTRAVERSION = -test13 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test13-1, no subversion change on the Makefile
Hello, I downloaded test13-1.gz, and noticed that it didn't have a subversion change in it. eg: --- Makefile +++ Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 4 SUBLEVEL = 0 -EXTRAVERSION = -test12 +EXTRAVERSION = -test13 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: test13-pre1 changelog
Hello, Linus didn't annnounce test13-pre1 as far as I am aware of. Regards, Frank --On Thursday, December 14, 2000 12:11 PM -0800 "Dr. Kelsey Hudson" [EMAIL PROTECTED] wrote: On Thu, 14 Dec 2000, David Riley wrote: Did I miss a post from Linus on the list, or is there no posted changelog for test13-pre1? Nothing's posted at kernel.org yet, either. I musta missed the post too... But then again I went back and looked for it and couldnt find it so... i'd like to know what changed, anyways :) Kelsey Hudson [EMAIL PROTECTED] Software Engineer Compendium Technologies, Inc (619) 725-0771 - -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
RE: task queue updates status?
Hello, It appears that Linus has picked up most (if not all) of the patches with the release of 2.4.0-test12-final. I'm building 2.4.0-test12 now. Regards, -Frank --Original Message-- From: "Mohammad A. Haque" <[EMAIL PROTECTED]> To: linux-kernel <[EMAIL PROTECTED]> Sent: December 12, 2000 12:49:51 AM GMT Subject: task queue updates status? Hello all How are we doing on the task queue updates? -- = Mohammad A. Haque http://www.haque.net/ [EMAIL PROTECTED] "Alcohol and calculus don't mix. Project Lead Don't drink and derive." --Unknown http://wm.themes.org/ [EMAIL PROTECTED] = - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Trouble with 2.4.0-test12-pre8
Hello, > There is also a problem building fs/smbfs/inode.c at line 166 > > Is there a fix or have I got something really screwed up? If you are referring to 'next' is not a member of the structure? If so, known issue. Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Trouble with 2.4.0-test12-pre8
Hello, There is also a problem building fs/smbfs/inode.c at line 166 Is there a fix or have I got something really screwed up? If you are referring to 'next' is not a member of the structure? If so, known issue. Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
RE: task queue updates status?
Hello, It appears that Linus has picked up most (if not all) of the patches with the release of 2.4.0-test12-final. I'm building 2.4.0-test12 now. Regards, -Frank --Original Message-- From: "Mohammad A. Haque" [EMAIL PROTECTED] To: linux-kernel [EMAIL PROTECTED] Sent: December 12, 2000 12:49:51 AM GMT Subject: task queue updates status? Hello all How are we doing on the task queue updates? -- = Mohammad A. Haque http://www.haque.net/ [EMAIL PROTECTED] "Alcohol and calculus don't mix. Project Lead Don't drink and derive." --Unknown http://wm.themes.org/ [EMAIL PROTECTED] = - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
INIT_LIST_HEAD marco audit
Hello all, It looks like we need to perform an audit of test12-pre8 and find all the changes where INIT_LIST_HEAD should now be used. Does anyone have a complete list of all the problem drivers, as well as a list of the ones that have already been fixed? If so, please post it to l-k . I don't mind maintaining a list of those patches..Just send them to [EMAIL PROTECTED] . Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test12-pre8 ohci1394.c compile error
Hello, I also received this error: ohci1394.c:1588: structure has no member named 'next' make[2]:*** [ohci1394.o] Error 1 make[2]: Leaving directory '/usr/src/linux/drivers/ieee1394' ... Its the same case with drivers/i2o/i2o_lan.c I suspect there are more. Is there a simple patch that will fix all affected drivers? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
[PATCH]test12-pre8 i2o_lan.c
Hello, I just downloaded test12-pre8 from ftp.kernel.org and received the following error, as I did in the old test12-pre8. The following error appears to fix the problem. Regards, Frank i2o_lan.c:116: warning: initialization makes integer from pointer without a cast i2o_lan.c:1404: structure has no member named 'next' make[2]: *** [i2o_lan.o] Error 1 make[2]: *** Leaving directory '/usr/src/linux/drivers/i2o --- drivers/i2o/i2o_lan.c.old Sun Dec 10 18:02:22 2000 +++ drivers/i2o/i2o_lan.c Sun Dec 10 18:35:01 2000 @@ -1401,7 +1401,7 @@ atomic_set(>tx_out, 0); priv->tx_count = 0; - priv->i2o_batch_send_task.next= NULL; + INIT_LIST_HEAD(>i2o_batch_send_task.list); priv->i2o_batch_send_task.sync= 0; priv->i2o_batch_send_task.routine = (void *)i2o_lan_batch_send; priv->i2o_batch_send_task.data= (void *)dev; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test12-pre8 tq_struct compile failures
Hello, I sent Linus a patch a few minutes ago regarding a tq_struct issue within drivers/i2o/i2o_lan.c . Alan just sent out a MD5sum for test12-pre8 , so I would double check the MD5sum against your version of test12-pre8 to see if your errors are from 'old' test12-pre8 or 'new' test12-pre8 . Who knows, maybe will release a test12-pre9 soon. :-) Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test12-pre8 tq_struct compile failures
Hello, I sent Linus a patch a few minutes ago regarding a tq_struct issue within drivers/i2o/i2o_lan.c . Alan just sent out a MD5sum for test12-pre8 , so I would double check the MD5sum against your version of test12-pre8 to see if your errors are from 'old' test12-pre8 or 'new' test12-pre8 . Who knows, maybe will release a test12-pre9 soon. :-) Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
[PATCH]test12-pre8 i2o_lan.c
Hello, I just downloaded test12-pre8 from ftp.kernel.org and received the following error, as I did in the old test12-pre8. The following error appears to fix the problem. Regards, Frank i2o_lan.c:116: warning: initialization makes integer from pointer without a cast i2o_lan.c:1404: structure has no member named 'next' make[2]: *** [i2o_lan.o] Error 1 make[2]: *** Leaving directory '/usr/src/linux/drivers/i2o --- drivers/i2o/i2o_lan.c.old Sun Dec 10 18:02:22 2000 +++ drivers/i2o/i2o_lan.c Sun Dec 10 18:35:01 2000 @@ -1401,7 +1401,7 @@ atomic_set(priv-tx_out, 0); priv-tx_count = 0; - priv-i2o_batch_send_task.next= NULL; + INIT_LIST_HEAD(priv-i2o_batch_send_task.list); priv-i2o_batch_send_task.sync= 0; priv-i2o_batch_send_task.routine = (void *)i2o_lan_batch_send; priv-i2o_batch_send_task.data= (void *)dev; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test12-pre8 ohci1394.c compile error
Hello, I also received this error: ohci1394.c:1588: structure has no member named 'next' make[2]:*** [ohci1394.o] Error 1 make[2]: Leaving directory '/usr/src/linux/drivers/ieee1394' ... Its the same case with drivers/i2o/i2o_lan.c I suspect there are more. Is there a simple patch that will fix all affected drivers? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
INIT_LIST_HEAD marco audit
Hello all, It looks like we need to perform an audit of test12-pre8 and find all the changes where INIT_LIST_HEAD should now be used. Does anyone have a complete list of all the problem drivers, as well as a list of the ones that have already been fixed? If so, please post it to l-k . I don't mind maintaining a list of those patches..Just send them to [EMAIL PROTECTED] . Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
dmfe patch
Hello,
The following patch is a combo patch between a revised locking patch
and a transmission patch for drivers/net/dmfe . Please review this before
it goes to Linus for a final blessing. Please apply to
2.4.0-test12-pre5 . [For some reason, my juno account
truncates the following, but my CMU account doesn't.]
Regards,
Frank
--- drivers/net/dmfe.c.org Sat Dec 2 15:50:28 2000
+++ drivers/net/dmfe.c Sat Dec 2 17:02:03 2000
@@ -57,6 +57,13 @@
Resource usage cleanups.
Report driver version to user.
+ Tobias Ringstrm <[EMAIL PROTECTED]> :
+ Rewrote the transmit code to actually use the ring buffer,
+ and to generate a lot fewer interrupts.
+
+ Frank Davis <[EMAIL PROTECTED]>
+ Added SMP-safe locking mechanisms
+
TODO
Implement pci_driver::suspend() and pci_driver::resume()
@@ -68,7 +75,7 @@
*/
-#define DMFE_VERSION "1.30 (June 11, 2000)"
+#define DMFE_VERSION "1.30p2 (November 30, 2000)"
#include
@@ -88,6 +95,7 @@
#include
#include
#include
+#include
#include
#include
@@ -108,6 +116,7 @@
#define TX_MAX_SEND_CNT 0x1/* Maximum tx packet per time */
#define TX_DESC_CNT 0x10 /* Allocated Tx descriptors */
#define RX_DESC_CNT 0x10 /* Allocated Rx descriptors */
+#define TX_IRQ_THR 12
#define DESC_ALL_CNTTX_DESC_CNT+RX_DESC_CNT
#define TX_BUF_ALLOC0x600
#define RX_ALLOC_SIZE 0x620
@@ -178,7 +187,7 @@
u32 chip_id;/* Chip vendor/Device ID */
u32 chip_revision; /* Chip revision */
struct net_device *next_dev;/* next device */
-
+ spinlock_t lock; /* Spinlock */
struct pci_dev *net_dev;/* PCI device */
unsigned long ioaddr; /* I/O base address */
@@ -198,8 +207,7 @@
struct rx_desc *first_rx_desc;
struct rx_desc *rx_insert_ptr;
struct rx_desc *rx_ready_ptr; /* packet come pointer */
- u32 tx_packet_cnt; /* transmitted packet count */
- u32 tx_queue_cnt; /* wait to send packet count */
+ u32 tx_live_cnt;/* number of used/live tx slots */
u32 rx_avail_cnt; /* available rx descriptor count */
u32 interval_rx_cnt;/* rx packet count a callback time */
@@ -423,9 +431,17 @@
for (i = 0; i < 64; i++)
((u16 *) db->srom)[i] = read_srom_word(pci_iobase, i);
+ printk(KERN_INFO "%s: Davicom DM%04lx at 0x%lx,",
+ dev->name,
+ ent->driver_data >> 16,
+ pci_iobase);
+
/* Set Node address */
- for (i = 0; i < 6; i++)
+ for (i = 0; i < 6; i++) {
dev->dev_addr[i] = db->srom[20 + i];
+ printk("%c%02x", i ? ':' : ' ', dev->dev_addr[i]);
+ }
+ printk(", IRQ %d\n", pci_irqline);
return 0;
@@ -490,8 +506,6 @@
/* system variable init */
db->cr6_data = CR6_DEFAULT | dmfe_cr6_user_set;
- db->tx_packet_cnt = 0;
- db->tx_queue_cnt = 0;
db->rx_avail_cnt = 0;
db->link_failed = 0;
db->wait_reset = 0;
@@ -536,10 +550,12 @@
{
struct dmfe_board_info *db = dev->priv;
u32 ioaddr = db->ioaddr;
-
+ unsigned long flags;
+
DMFE_DBUG(0, "dmfe_init_dm910x()", 0);
/* Reset DM910x board : need 32 PCI clock to complete */
+ spin_lock_irqsave(>lock,flags);
outl(DM910X_RESET, ioaddr + DCR0); /* RESET MAC */
DELAY_5US;
outl(db->cr0_data, ioaddr + DCR0);
@@ -547,6 +563,7 @@
outl(0x180, ioaddr + DCR12);/* Let bit 7 output port */
outl(0x80, ioaddr + DCR12); /* RESET DM9102 phyxcer */
outl(0x0, ioaddr + DCR12); /* Clear RESET signal */
+ spin_unlock_irqrestore(>lock,flags);
/* Phy addr : DM910(A)2/DM9132/9801, phy address = 1 */
db->phy_addr = 1;
@@ -595,46 +612,38 @@
{
struct dmfe_board_info *db = dev->priv;
struct tx_desc *txptr;
+ static unsigned pkt_num = TX_IRQ_THR;
DMFE_DBUG(0, "dmfe_start_xmit", 0);
-
- netif_stop_queue(dev);
-
- /* Too large packet check */
- if (skb->len > MAX_PACKET_SIZE) {
- printk(KERN_ERR "%s: oversized frame (%d bytes) for
transmit.\n", dev->name, (u16) skb->len);
- dev_kfree_skb(skb);
- return 0;
- }
- /* No Tx resource check, it never happen nromally */
- if (db->tx_packet_cnt >= TX_FREE_DESC_CNT) {
- return 1;
- }
/* transmit this packet */
txptr = db->tx_insert_ptr;
memcpy((char *) txptr->tx_buf_ptr, (char *) skb->data, skb->len);
- txptr->tdes1 = 0xe100 | skb->len;
+ if (--pkt_num == 0)
+ {
+ txptr->tdes1 = 0xe1
test12-pre5: drivers/net/dummy.c compile error
Hello, The drivers/net/dummy.c compile error still exists..Looks like the module.h patch wasn't included. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test12-pre5: drivers/net/dummy.c compile error
Hello, The drivers/net/dummy.c compile error still exists..Looks like the module.h patch wasn't included. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
dmfe patch
Hello,
The following patch is a combo patch between a revised locking patch
and a transmission patch for drivers/net/dmfe . Please review this before
it goes to Linus for a final blessing. Please apply to
2.4.0-test12-pre5 . [For some reason, my juno account
truncates the following, but my CMU account doesn't.]
Regards,
Frank
--- drivers/net/dmfe.c.org Sat Dec 2 15:50:28 2000
+++ drivers/net/dmfe.c Sat Dec 2 17:02:03 2000
@@ -57,6 +57,13 @@
Resource usage cleanups.
Report driver version to user.
+ Tobias Ringstrm [EMAIL PROTECTED] :
+ Rewrote the transmit code to actually use the ring buffer,
+ and to generate a lot fewer interrupts.
+
+ Frank Davis [EMAIL PROTECTED]
+ Added SMP-safe locking mechanisms
+
TODO
Implement pci_driver::suspend() and pci_driver::resume()
@@ -68,7 +75,7 @@
*/
-#define DMFE_VERSION "1.30 (June 11, 2000)"
+#define DMFE_VERSION "1.30p2 (November 30, 2000)"
#include linux/module.h
@@ -88,6 +95,7 @@
#include linux/etherdevice.h
#include linux/skbuff.h
#include linux/delay.h
+#include linux/spinlock.h
#include asm/processor.h
#include asm/bitops.h
@@ -108,6 +116,7 @@
#define TX_MAX_SEND_CNT 0x1/* Maximum tx packet per time */
#define TX_DESC_CNT 0x10 /* Allocated Tx descriptors */
#define RX_DESC_CNT 0x10 /* Allocated Rx descriptors */
+#define TX_IRQ_THR 12
#define DESC_ALL_CNTTX_DESC_CNT+RX_DESC_CNT
#define TX_BUF_ALLOC0x600
#define RX_ALLOC_SIZE 0x620
@@ -178,7 +187,7 @@
u32 chip_id;/* Chip vendor/Device ID */
u32 chip_revision; /* Chip revision */
struct net_device *next_dev;/* next device */
-
+ spinlock_t lock; /* Spinlock */
struct pci_dev *net_dev;/* PCI device */
unsigned long ioaddr; /* I/O base address */
@@ -198,8 +207,7 @@
struct rx_desc *first_rx_desc;
struct rx_desc *rx_insert_ptr;
struct rx_desc *rx_ready_ptr; /* packet come pointer */
- u32 tx_packet_cnt; /* transmitted packet count */
- u32 tx_queue_cnt; /* wait to send packet count */
+ u32 tx_live_cnt;/* number of used/live tx slots */
u32 rx_avail_cnt; /* available rx descriptor count */
u32 interval_rx_cnt;/* rx packet count a callback time */
@@ -423,9 +431,17 @@
for (i = 0; i 64; i++)
((u16 *) db-srom)[i] = read_srom_word(pci_iobase, i);
+ printk(KERN_INFO "%s: Davicom DM%04lx at 0x%lx,",
+ dev-name,
+ ent-driver_data 16,
+ pci_iobase);
+
/* Set Node address */
- for (i = 0; i 6; i++)
+ for (i = 0; i 6; i++) {
dev-dev_addr[i] = db-srom[20 + i];
+ printk("%c%02x", i ? ':' : ' ', dev-dev_addr[i]);
+ }
+ printk(", IRQ %d\n", pci_irqline);
return 0;
@@ -490,8 +506,6 @@
/* system variable init */
db-cr6_data = CR6_DEFAULT | dmfe_cr6_user_set;
- db-tx_packet_cnt = 0;
- db-tx_queue_cnt = 0;
db-rx_avail_cnt = 0;
db-link_failed = 0;
db-wait_reset = 0;
@@ -536,10 +550,12 @@
{
struct dmfe_board_info *db = dev-priv;
u32 ioaddr = db-ioaddr;
-
+ unsigned long flags;
+
DMFE_DBUG(0, "dmfe_init_dm910x()", 0);
/* Reset DM910x board : need 32 PCI clock to complete */
+ spin_lock_irqsave(db-lock,flags);
outl(DM910X_RESET, ioaddr + DCR0); /* RESET MAC */
DELAY_5US;
outl(db-cr0_data, ioaddr + DCR0);
@@ -547,6 +563,7 @@
outl(0x180, ioaddr + DCR12);/* Let bit 7 output port */
outl(0x80, ioaddr + DCR12); /* RESET DM9102 phyxcer */
outl(0x0, ioaddr + DCR12); /* Clear RESET signal */
+ spin_unlock_irqrestore(db-lock,flags);
/* Phy addr : DM910(A)2/DM9132/9801, phy address = 1 */
db-phy_addr = 1;
@@ -595,46 +612,38 @@
{
struct dmfe_board_info *db = dev-priv;
struct tx_desc *txptr;
+ static unsigned pkt_num = TX_IRQ_THR;
DMFE_DBUG(0, "dmfe_start_xmit", 0);
-
- netif_stop_queue(dev);
-
- /* Too large packet check */
- if (skb-len MAX_PACKET_SIZE) {
- printk(KERN_ERR "%s: oversized frame (%d bytes) for
transmit.\n", dev-name, (u16) skb-len);
- dev_kfree_skb(skb);
- return 0;
- }
- /* No Tx resource check, it never happen nromally */
- if (db-tx_packet_cnt = TX_FREE_DESC_CNT) {
- return 1;
- }
/* transmit this packet */
txptr = db-tx_insert_ptr;
memcpy((char *) txptr-tx_buf_ptr, (char *) skb-data, skb-len);
- txptr-tdes1 = 0xe100 | skb-len;
+ if (--pkt_num == 0)
+ {
+ txptr-tdes1 = 0xe100 | skb-len;
+ pkt_num = TX_IR
Re: test12-pre3 (FireWire issue)
Dax,
What is your modutils version? Is this the first test12 that has caused this error?
Regards,
Frank
> Linus, Andreas,
>
> I've been using this same config since FireWire was merged, just tried out
> test12-pre3 and got an unresolved symbol problem with raw1394.o
>
> #
> # IEEE 1394 (FireWire) support
> #
> CONFIG_IEEE1394=y
> # CONFIG_IEEE1394_PCILYNX is not set
> CONFIG_IEEE1394_OHCI1394=y
> CONFIG_IEEE1394_VIDEO1394=m
> CONFIG_IEEE1394_RAWIO=m
> # CONFIG_IEEE1394_VERBOSEDEBUG is not set
>
>
> make bzImage; make modules; make modules_install
>
> modules_install bombs out with:
>
> cd /lib/modules/2.4.0-test12; \
> mkdir -p pcmcia; \
> find kernel -path '*/pcmcia/*' -name '*.o' | xargs -i -r ln -sf ../{}
> pcmcia if [ -r System.map ]; then /sbin/depmod -ae -F System.map
> 2.4.0-test12; fi depmod: *** Unresolved symbols in
> /lib/modules/2.4.0-test12/kernel/drivers/ieee1394/raw1394.o
> depmod: free_tlabel
> depmod: fill_iso_packet
> depmod: hpsb_register_highlevel
> depmod: highlevel_lock
> depmod: hpsb_unregister_highlevel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: test12-pre3 (FireWire issue)
Dax,
What is your modutils version? Is this the first test12 that has caused this error?
Regards,
Frank
Linus, Andreas,
I've been using this same config since FireWire was merged, just tried out
test12-pre3 and got an unresolved symbol problem with raw1394.o
#
# IEEE 1394 (FireWire) support
#
CONFIG_IEEE1394=y
# CONFIG_IEEE1394_PCILYNX is not set
CONFIG_IEEE1394_OHCI1394=y
CONFIG_IEEE1394_VIDEO1394=m
CONFIG_IEEE1394_RAWIO=m
# CONFIG_IEEE1394_VERBOSEDEBUG is not set
make bzImage; make modules; make modules_install
modules_install bombs out with:
cd /lib/modules/2.4.0-test12; \
mkdir -p pcmcia; \
find kernel -path '*/pcmcia/*' -name '*.o' | xargs -i -r ln -sf ../{}
pcmcia if [ -r System.map ]; then /sbin/depmod -ae -F System.map
2.4.0-test12; fi depmod: *** Unresolved symbols in
/lib/modules/2.4.0-test12/kernel/drivers/ieee1394/raw1394.o
depmod: free_tlabel
depmod: fill_iso_packet
depmod: hpsb_register_highlevel
depmod: highlevel_lock
depmod: hpsb_unregister_highlevel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
RE: videodev.c won't compile in test11-pre6/pre7/final
Hello,
The undeclared variables are defined in include/linux/videodev.h , which is included
in videodev.c .
...
#define VID_TYPE_SUBCAPTURE 512
#define VID_TYPE_MPEG_DECODER 1024
#define VID_TYPE_MPEG_ENCODER 2048
#define VID_TYPE_MJPEG_DECODER 4096
#define VID_TYPE_MJPEG_ENCODER 8192
...
Regards,
Frank
--On Sunday, November 19, 2000 9:43 PM -0500 Ari Pollak <[EMAIL PROTECTED]> wrote:
> I was going to report this back in pre6, but I thought someone had
> caught it already.. When the bttv driver is enbabled as a module in
> test11, make modules fails with:
>
> videodev.c: In function `videodev_proc_read':
> videodev.c:283: `VID_TYPE_MPEG_DECODER' undeclared (first use in this
> function)
> videodev.c:283: (Each undeclared identifier is reported only once
> videodev.c:283: for each function it appears in.)
> videodev.c:284: `VID_TYPE_MPEG_ENCODER' undeclared (first use in this
> function)
> videodev.c:285: `VID_TYPE_MJPEG_DECODER' undeclared (first use in this
> function)videodev.c:286: `VID_TYPE_MJPEG_ENCODER' undeclared (first use
> in this function)videodev.c: In function
> `video_register_device_Re1d5d9de':
> videodev.c:475: structure has no member named `devfs_handle'
> videodev.c:476: warning: implicit declaration of function
> `devfs_register_R346f2926'
> videodev.c:476: `DEVFS_FL_DEFAULT' undeclared (first use in this
> function)
> videodev.c: In function `video_unregister_device_R0e30839e':
> videodev.c:510: warning: implicit declaration of function
> `devfs_unregister_Rb8aa48ae'
> videodev.c:510: structure has no member named `devfs_handle'
> videodev.c: In function `videodev_init':
> videodev.c:538: warning: implicit declaration of function
> `devfs_register_chrdev_R46ccf2d8'
> videodev.c: In function `cleanup_module':
> videodev.c:572: warning: implicit declaration of function
> `devfs_unregister_chrdev_R77f3e0ce'
> {standard input}: Assembler messages:
> {standard input}:8: Warning: Ignoring changed section attributes for
> .modinfo
> make[3]: *** [videodev.o] Error 1
> make[3]: Leaving directory `/usr/src/linux/drivers/media/video'
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
RE: videodev.c won't compile in test11-pre6/pre7/final
Hello,
The undeclared variables are defined in include/linux/videodev.h , which is included
in videodev.c .
...
#define VID_TYPE_SUBCAPTURE 512
#define VID_TYPE_MPEG_DECODER 1024
#define VID_TYPE_MPEG_ENCODER 2048
#define VID_TYPE_MJPEG_DECODER 4096
#define VID_TYPE_MJPEG_ENCODER 8192
...
Regards,
Frank
--On Sunday, November 19, 2000 9:43 PM -0500 Ari Pollak [EMAIL PROTECTED] wrote:
I was going to report this back in pre6, but I thought someone had
caught it already.. When the bttv driver is enbabled as a module in
test11, make modules fails with:
videodev.c: In function `videodev_proc_read':
videodev.c:283: `VID_TYPE_MPEG_DECODER' undeclared (first use in this
function)
videodev.c:283: (Each undeclared identifier is reported only once
videodev.c:283: for each function it appears in.)
videodev.c:284: `VID_TYPE_MPEG_ENCODER' undeclared (first use in this
function)
videodev.c:285: `VID_TYPE_MJPEG_DECODER' undeclared (first use in this
function)videodev.c:286: `VID_TYPE_MJPEG_ENCODER' undeclared (first use
in this function)videodev.c: In function
`video_register_device_Re1d5d9de':
videodev.c:475: structure has no member named `devfs_handle'
videodev.c:476: warning: implicit declaration of function
`devfs_register_R346f2926'
videodev.c:476: `DEVFS_FL_DEFAULT' undeclared (first use in this
function)
videodev.c: In function `video_unregister_device_R0e30839e':
videodev.c:510: warning: implicit declaration of function
`devfs_unregister_Rb8aa48ae'
videodev.c:510: structure has no member named `devfs_handle'
videodev.c: In function `videodev_init':
videodev.c:538: warning: implicit declaration of function
`devfs_register_chrdev_R46ccf2d8'
videodev.c: In function `cleanup_module':
videodev.c:572: warning: implicit declaration of function
`devfs_unregister_chrdev_R77f3e0ce'
{standard input}: Assembler messages:
{standard input}:8: Warning: Ignoring changed section attributes for
.modinfo
make[3]: *** [videodev.o] Error 1
make[3]: Leaving directory `/usr/src/linux/drivers/media/video'
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [CFT] dmfe.c network driver update for 2.4
I would rather fix those non-SMP compliant drivers to be SMP compliant, then keeping them 'broken'. Adding the print statements would only be a temporary solution. Regards, Frank --On Friday, November 17, 2000 10:20 AM +0100 Tobias Ringstrom > How about adding an ifdef CONFIG_SMP then print ugly warning to all known > SMP unsafe drivers? A message could be printed booth at compile and load > time. > > /Tobias > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: [CFT] dmfe.c network driver update for 2.4
I would rather fix those non-SMP compliant drivers to be SMP compliant, then keeping them 'broken'. Adding the print statements would only be a temporary solution. Regards, Frank --On Friday, November 17, 2000 10:20 AM +0100 Tobias Ringstrom How about adding an ifdef CONFIG_SMP then print ugly warning to all known SMP unsafe drivers? A message could be printed booth at compile and load time. /Tobias - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.0-test11-pre6 ntfs compile error
Hello, I just try to compile 2.4.0-test11-pre6, and received the following error (make modules): inode.c:1054 conflicting types for 'new_inode' /usr/src/liunux/include/linux/fs.h:1153 previous declaration of 'new_inode' make[2]: ***[inode.o]Error 1 make[2]: Leaving directory '/usr/src/liunux/fs/ntfs' ... make[1]: *** [modsubdir_ntfs] Error 2 Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
2.4.0-test11-pre6 ntfs compile error
Hello, I just try to compile 2.4.0-test11-pre6, and received the following error (make modules): inode.c:1054 conflicting types for 'new_inode' /usr/src/liunux/include/linux/fs.h:1153 previous declaration of 'new_inode' make[2]: ***[inode.o]Error 1 make[2]: Leaving directory '/usr/src/liunux/fs/ntfs' ... make[1]: *** [modsubdir_ntfs] Error 2 Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: [CFT] dmfe.c network driver update for 2.4
Hello,
I'll double check the locking later today, but not sure about the
transmission changes.
Regards,
Frank
([EMAIL PROTECTED])
--On Wednesday, November 15, 2000 9:34 PM +0100 Tobias Ringstrom
<[EMAIL PROTECTED]> wrote:
> I have updated the dmfe.c network driver for 2.4.0-test by adding proper
> locking (I hope), and also made transmission much efficient.
>
> I would appreciate any feedback from people using this driver, to confirm
> that I did not break it.
>
> It would also be great if someone could take a look at the lock handling,
> to confirm that is is correct and sufficient.
>
> /Tobias
>
>
> --- dmfe.c.orig Wed Nov 15 19:53:48 2000
> +++ dmfe.cWed Nov 15 21:35:24 2000
> @@ -57,6 +57,11 @@
> Resource usage cleanups.
> Report driver version to user.
>
> + Tobias Ringström <[EMAIL PROTECTED]> :
> + Added proper locking.
> + Rewrote the transmit code to actually use the ring buffer,
> + and to generate a lot fewer interrupts.
> +
> TODO
>
> Implement pci_driver::suspend() and pci_driver::resume()
> @@ -108,6 +113,7 @@
> #define TX_MAX_SEND_CNT 0x1 /* Maximum tx packet per time */
> #define TX_DESC_CNT 0x10 /* Allocated Tx descriptors */
> #define RX_DESC_CNT 0x10 /* Allocated Rx descriptors */
> +#define TX_IRQ_THR 12
> #define DESC_ALL_CNTTX_DESC_CNT+RX_DESC_CNT
> #define TX_BUF_ALLOC0x600
> #define RX_ALLOC_SIZE 0x620
> @@ -188,6 +194,8 @@
>u32 cr7_data;
>u32 cr15_data;
>
> + spinlock_t lock;
> +
>/* descriptor pointer */
>unsigned char *buf_pool_ptr; /* Tx buffer pool memory */
>unsigned char *buf_pool_start; /* Tx buffer pool align dword */
> @@ -198,8 +206,7 @@
>struct rx_desc *first_rx_desc;
>struct rx_desc *rx_insert_ptr;
>struct rx_desc *rx_ready_ptr; /* packet come pointer */
> - u32 tx_packet_cnt; /* transmitted packet count */
> - u32 tx_queue_cnt; /* wait to send packet count */
> + u32 tx_live_cnt;/* number of used/live tx slots */
>u32 rx_avail_cnt; /* available rx descriptor count */
>u32 interval_rx_cnt; /* rx packet count a callback time */
>
> @@ -490,8 +497,6 @@
>
>/* system variable init */
>db->cr6_data = CR6_DEFAULT | dmfe_cr6_user_set;
> - db->tx_packet_cnt = 0;
> - db->tx_queue_cnt = 0;
>db->rx_avail_cnt = 0;
>db->link_failed = 0;
>db->wait_reset = 0;
> @@ -595,46 +600,42 @@
> {
>struct dmfe_board_info *db = dev->priv;
>struct tx_desc *txptr;
> + static unsigned pkt_num = TX_IRQ_THR;
>
>DMFE_DBUG(0, "dmfe_start_xmit", 0);
> -
> - netif_stop_queue(dev);
> -
> - /* Too large packet check */
> - if (skb->len > MAX_PACKET_SIZE) {
> - printk(KERN_ERR "%s: oversized frame (%d bytes) for transmit.\n",
> dev->name, (u16) skb->len); - dev_kfree_skb(skb);
> - return 0;
> - }
> - /* No Tx resource check, it never happen nromally */
> - if (db->tx_packet_cnt >= TX_FREE_DESC_CNT) {
> - return 1;
> - }
> +
> + spin_lock_irq(>lock);
>
>/* transmit this packet */
>txptr = db->tx_insert_ptr;
>memcpy((char *) txptr->tx_buf_ptr, (char *) skb->data, skb->len);
> - txptr->tdes1 = 0xe100 | skb->len;
> + if (--pkt_num == 0)
> + {
> + txptr->tdes1 = 0xe100 | skb->len;
> + pkt_num = TX_IRQ_THR;
> + }
> + else
> + txptr->tdes1 = 0x6100 | skb->len;
> +
> + /* Transmit Packet Process */
> + txptr->tdes0 = 0x8000; /* set owner bit to DM910X */
> + outl(0x1, dev->base_addr + DCR1); /* Issue Tx polling comand */
> + dev->trans_start = jiffies; /* saved the time stamp */
>
>/* Point to next transmit free descriptor */
> - db->tx_insert_ptr = (struct tx_desc *) txptr->next_tx_desc;
> + txptr = (struct tx_desc *)txptr->next_tx_desc;
>
> - /* Transmit Packet Process */
> - if (db->tx_packet_cnt < TX_MAX_SEND_CNT) {
> - txptr->tdes0 = 0x8000; /* set owner bit to DM910X */
> - db->tx_packet_cnt++;/* Ready to send count */
> - outl(0x1, dev->base_addr + DCR1); /* Issue Tx polling comand */
> - } else {
> - db->tx_queue_cnt++; /* queue the tx packet */
> - outl(0x1, dev->base_addr + DCR1); /* Issue Tx polling comand */
> - }
> + if (txptr->tdes0 & 0x8000)
> + netif_stop_queue(dev);
>
> - /* Tx resource check */
> - if (db->tx_packet_cnt < TX_FREE_DESC_CNT)
> - netif_wake_queue(dev);
> + db->tx_insert_ptr = txptr;
> + db->tx_live_cnt++;
> +
> + spin_unlock_irq(>lock);
>
>/* free this SKB */
>dev_kfree_skb(skb);
> +
>return 0;
> }
>
> @@ -713,12 +714,14 @@
>outl(0, ioaddr + DCR7);/* disable all interrupt */
>
Re: [CFT] dmfe.c network driver update for 2.4
Hello,
I'll double check the locking later today, but not sure about the
transmission changes.
Regards,
Frank
([EMAIL PROTECTED])
--On Wednesday, November 15, 2000 9:34 PM +0100 Tobias Ringstrom
[EMAIL PROTECTED] wrote:
I have updated the dmfe.c network driver for 2.4.0-test by adding proper
locking (I hope), and also made transmission much efficient.
I would appreciate any feedback from people using this driver, to confirm
that I did not break it.
It would also be great if someone could take a look at the lock handling,
to confirm that is is correct and sufficient.
/Tobias
--- dmfe.c.orig Wed Nov 15 19:53:48 2000
+++ dmfe.cWed Nov 15 21:35:24 2000
@@ -57,6 +57,11 @@
Resource usage cleanups.
Report driver version to user.
+ Tobias Ringström [EMAIL PROTECTED] :
+ Added proper locking.
+ Rewrote the transmit code to actually use the ring buffer,
+ and to generate a lot fewer interrupts.
+
TODO
Implement pci_driver::suspend() and pci_driver::resume()
@@ -108,6 +113,7 @@
#define TX_MAX_SEND_CNT 0x1 /* Maximum tx packet per time */
#define TX_DESC_CNT 0x10 /* Allocated Tx descriptors */
#define RX_DESC_CNT 0x10 /* Allocated Rx descriptors */
+#define TX_IRQ_THR 12
#define DESC_ALL_CNTTX_DESC_CNT+RX_DESC_CNT
#define TX_BUF_ALLOC0x600
#define RX_ALLOC_SIZE 0x620
@@ -188,6 +194,8 @@
u32 cr7_data;
u32 cr15_data;
+ spinlock_t lock;
+
/* descriptor pointer */
unsigned char *buf_pool_ptr; /* Tx buffer pool memory */
unsigned char *buf_pool_start; /* Tx buffer pool align dword */
@@ -198,8 +206,7 @@
struct rx_desc *first_rx_desc;
struct rx_desc *rx_insert_ptr;
struct rx_desc *rx_ready_ptr; /* packet come pointer */
- u32 tx_packet_cnt; /* transmitted packet count */
- u32 tx_queue_cnt; /* wait to send packet count */
+ u32 tx_live_cnt;/* number of used/live tx slots */
u32 rx_avail_cnt; /* available rx descriptor count */
u32 interval_rx_cnt; /* rx packet count a callback time */
@@ -490,8 +497,6 @@
/* system variable init */
db-cr6_data = CR6_DEFAULT | dmfe_cr6_user_set;
- db-tx_packet_cnt = 0;
- db-tx_queue_cnt = 0;
db-rx_avail_cnt = 0;
db-link_failed = 0;
db-wait_reset = 0;
@@ -595,46 +600,42 @@
{
struct dmfe_board_info *db = dev-priv;
struct tx_desc *txptr;
+ static unsigned pkt_num = TX_IRQ_THR;
DMFE_DBUG(0, "dmfe_start_xmit", 0);
-
- netif_stop_queue(dev);
-
- /* Too large packet check */
- if (skb-len MAX_PACKET_SIZE) {
- printk(KERN_ERR "%s: oversized frame (%d bytes) for transmit.\n",
dev-name, (u16) skb-len); - dev_kfree_skb(skb);
- return 0;
- }
- /* No Tx resource check, it never happen nromally */
- if (db-tx_packet_cnt = TX_FREE_DESC_CNT) {
- return 1;
- }
+
+ spin_lock_irq(db-lock);
/* transmit this packet */
txptr = db-tx_insert_ptr;
memcpy((char *) txptr-tx_buf_ptr, (char *) skb-data, skb-len);
- txptr-tdes1 = 0xe100 | skb-len;
+ if (--pkt_num == 0)
+ {
+ txptr-tdes1 = 0xe100 | skb-len;
+ pkt_num = TX_IRQ_THR;
+ }
+ else
+ txptr-tdes1 = 0x6100 | skb-len;
+
+ /* Transmit Packet Process */
+ txptr-tdes0 = 0x8000; /* set owner bit to DM910X */
+ outl(0x1, dev-base_addr + DCR1); /* Issue Tx polling comand */
+ dev-trans_start = jiffies; /* saved the time stamp */
/* Point to next transmit free descriptor */
- db-tx_insert_ptr = (struct tx_desc *) txptr-next_tx_desc;
+ txptr = (struct tx_desc *)txptr-next_tx_desc;
- /* Transmit Packet Process */
- if (db-tx_packet_cnt TX_MAX_SEND_CNT) {
- txptr-tdes0 = 0x8000; /* set owner bit to DM910X */
- db-tx_packet_cnt++;/* Ready to send count */
- outl(0x1, dev-base_addr + DCR1); /* Issue Tx polling comand */
- } else {
- db-tx_queue_cnt++; /* queue the tx packet */
- outl(0x1, dev-base_addr + DCR1); /* Issue Tx polling comand */
- }
+ if (txptr-tdes0 0x8000)
+ netif_stop_queue(dev);
- /* Tx resource check */
- if (db-tx_packet_cnt TX_FREE_DESC_CNT)
- netif_wake_queue(dev);
+ db-tx_insert_ptr = txptr;
+ db-tx_live_cnt++;
+
+ spin_unlock_irq(tp-lock);
/* free this SKB */
dev_kfree_skb(skb);
+
return 0;
}
@@ -713,12 +714,14 @@
outl(0, ioaddr + DCR7);/* disable all interrupt */
return;
}
+
+ spin_lock(db-lock);
+
/* Free the transmitted descriptor */
txptr = db-tx_remove_ptr;
- while (db-tx_packet_cnt) {
test11-pre4 ?
Hello, Did I miss an email from Linus to l-k announcing test11-pre4 or was it released w/o an announcement? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Compile error with 2.4.0-test11-pre3 PCMCIA
Hello, What are your modutils and pcmcia versions? Regards, Frank --On Sunday, November 12, 2000 11:41 PM +0100 "Peter H. Ruegg" <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hello there, > > I just tried to compile my first 2.4-Kernel. While dep, bzImage and > modules all seemed to work well, I've got the following errors while > trying to make modules_install: > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Compile error with 2.4.0-test11-pre3 PCMCIA
Hello, What are your modutils and pcmcia versions? Regards, Frank --On Sunday, November 12, 2000 11:41 PM +0100 "Peter H. Ruegg" [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello there, I just tried to compile my first 2.4-Kernel. While dep, bzImage and modules all seemed to work well, I've got the following errors while trying to make modules_install: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test11-pre4 ?
Hello, Did I miss an email from Linus to l-k announcing test11-pre4 or was it released w/o an announcement? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
[test11-pre2] rrunner.c compiler error
Hello, I received the following error while compiling test11-pre2: rrunner.c : In function 'rr_ioctl' rrunner.c:1558: label 'out' used but not defined make[2]: *** [rrunner.o] Error 1 make[2]: Leaving directory '/usr/src/linux/drivers/net' ... make: ** [mod_drivers] Error 2 out is located in the file, so I'm assuming its a bracing issue. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
[test11-pre2] rrunner.c compiler error
Hello, I received the following error while compiling test11-pre2: rrunner.c : In function 'rr_ioctl' rrunner.c:1558: label 'out' used but not defined make[2]: *** [rrunner.o] Error 1 make[2]: Leaving directory '/usr/src/linux/drivers/net' ... make: ** [mod_drivers] Error 2 out is located in the file, so I'm assuming its a bracing issue. Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Pentium IV-summary
Hello, I think I have summarized the discussion for clarity: 1. rep nop can used with all x86 boxes, unless a valid example can be found where it doesn't work. Athlon works with the rep nop. 2. There's a bug in get_model_name(), cpuid(0x8001, , , , &(c->x86_capability)); that overwrites the capability state. It will be fixed in 2.2.18 by Dave Jones. Should we also look at Peter Anvin's fix for the problem that Linus mentioned? What are the other features of the Pentium IV should be included in the kernel pending the capability state fix? 3. 2.4.x may support processor speeds up to 100GHz, as well as Pentium IV. Linus will have a Pentium IV available soon, but can someone test the kernel with a Pentium IV sooner? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Pentium IV-summary
Hello, I think I have summarized the discussion for clarity: 1. rep nop can used with all x86 boxes, unless a valid example can be found where it doesn't work. Athlon works with the rep nop. 2. There's a bug in get_model_name(), cpuid(0x8001, , , , &(c->x86_capability)); that overwrites the capability state. It will be fixed in 2.2.18 by Dave Jones. Should we also look at Peter Anvin's fix for the problem that Linus mentioned? What are the other features of the Pentium IV should be included in the kernel pending the capability state fix? 3. 2.4.x may support processor speeds up to 100GHz, as well as Pentium IV. Linus will have a Pentium IV available soon, but can someone test the kernel with a Pentium IV sooner? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Pentium IV-summary
Hello, I think I have summarized the discussion for clarity: 1. rep nop can used with all x86 boxes, unless a valid example can be found where it doesn't work. Athlon works with the rep nop. 2. There's a bug in get_model_name(), cpuid(0x8001, dummy, dummy, dummy, (c-x86_capability)); that overwrites the capability state. It will be fixed in 2.2.18 by Dave Jones. Should we also look at Peter Anvin's fix for the problem that Linus mentioned? What are the other features of the Pentium IV should be included in the kernel pending the capability state fix? 3. 2.4.x may support processor speeds up to 100GHz, as well as Pentium IV. Linus will have a Pentium IV available soon, but can someone test the kernel with a Pentium IV sooner? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Pentium IV-summary
Hello, I think I have summarized the discussion for clarity: 1. rep nop can used with all x86 boxes, unless a valid example can be found where it doesn't work. Athlon works with the rep nop. 2. There's a bug in get_model_name(), cpuid(0x8001, dummy, dummy, dummy, (c-x86_capability)); that overwrites the capability state. It will be fixed in 2.2.18 by Dave Jones. Should we also look at Peter Anvin's fix for the problem that Linus mentioned? What are the other features of the Pentium IV should be included in the kernel pending the capability state fix? 3. 2.4.x may support processor speeds up to 100GHz, as well as Pentium IV. Linus will have a Pentium IV available soon, but can someone test the kernel with a Pentium IV sooner? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Pentium 4 and 2.4/2.5
Alan, As for 'rep nop', couldn't we add in the code, as an example: #ifdef Pentium_4 rep nop #endif As for the 2.2.18 patch for correctly determining 2GHz and above, can it be easily merged into the 2.4.x kernel, and if so, what's the maximum clock speed that can be detected? Regards, -Frank On Tue, 7 Nov 2000 21:48:40 + (GMT) Alan Cox <[EMAIL PROTECTED]> writes: > > are you saying that rep;nop is not needed in the spinlocks? > (because they > > are for P4) > > rep;nop is a magic instruction on the PIV and possibly some PIII > series CPUs > [not sure]. As far as I can make out it naps momentarily or until > bus > activity thus saving power on spinlocks. > > The problem is 'rep nop' is not defined on other cpus so we can only > really use > it on the PIII/PIV kernel builds > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: Pentium 4 and 2.4/2.5
Alan, As for 'rep nop', couldn't we add in the code, as an example: #ifdef Pentium_4 rep nop #endif As for the 2.2.18 patch for correctly determining 2GHz and above, can it be easily merged into the 2.4.x kernel, and if so, what's the maximum clock speed that can be detected? Regards, -Frank On Tue, 7 Nov 2000 21:48:40 + (GMT) Alan Cox [EMAIL PROTECTED] writes: are you saying that rep;nop is not needed in the spinlocks? (because they are for P4) rep;nop is a magic instruction on the PIV and possibly some PIII series CPUs [not sure]. As far as I can make out it naps momentarily or until bus activity thus saving power on spinlocks. The problem is 'rep nop' is not defined on other cpus so we can only really use it on the PIII/PIV kernel builds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Pentium 4 and 2.4/2.5
Hello, I noticed that Pentium 4 isn't an config option in 2.4.0-test10. Is someone working on a patch for the the kernel (if needed) to support the Pentium 4 after 2.4.0 is released? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Pentium 4 and 2.4/2.5
Hello, I noticed that Pentium 4 isn't an config option in 2.4.0-test10. Is someone working on a patch for the the kernel (if needed) to support the Pentium 4 after 2.4.0 is released? Regards, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: That Dirty Son of a Bitch, Bill Gates!!!
Hello, Its a parody page from someone in LateSky Omaha, Nebraska, USA . Regards, -Frank --On Thursday, November 02, 2000 9:13 PM -0800 Andre Hedrick <[EMAIL PROTECTED]> wrote: > > http://mslinux.org > > Andre Hedrick > Linux ATA Development > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: That Dirty Son of a Bitch, Bill Gates!!!
Hello, Its a parody page from someone in LateSky Omaha, Nebraska, USA . Regards, -Frank --On Thursday, November 02, 2000 9:13 PM -0800 Andre Hedrick [EMAIL PROTECTED] wrote: http://mslinux.org Andre Hedrick Linux ATA Development - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
test10-6: can't mount root partition
Hello, I compiled 2.4.0-test10-6 finemodules and all, and for some reason I can't mount my root partition on boot..I get a VFS kernel panic. I thought it might have something to do with devfs, but I disabled it, and it still doesn't work. I'm using loadlin 1.6a..I haven't tried a boot disk yet. I have attached my .config and output from the ver_linux script (kernel 2.3.36 boots fine from loadlin). The machine is a Dell Latitude CPi laptop, 64MB. -- Versions installed: (if some fields are empty or look -- unusual then possibly you have very old versions) Linux localhost.localdomain 2.3.36 #55 SMP Tue Jan 4 20:53:13 EST 2000 i686 unknown Kernel modules 2.3.19 Gnu C egcs-2.91.66 Gnu Make 3.77 Binutils 2.9.1.0.23 Linux C Library2.1.1 Dynamic linker ldd (GNU libc) 2.1.1 Procps 2.0.2 Mount 2.9o Net-tools 1.51 Console-tools 1999.03.02 Sh-utils 1.16 Modules Loaded nfsd # # Automatically generated make config: don't edit # CONFIG_X86=y CONFIG_ISA=y # CONFIG_SBUS is not set CONFIG_UID16=y # # Code maturity level options # CONFIG_EXPERIMENTAL=y # # Loadable module support # CONFIG_MODULES=y CONFIG_MODVERSIONS=y CONFIG_KMOD=y # # Processor type and features # # CONFIG_M386 is not set # CONFIG_M486 is not set # CONFIG_M586 is not set # CONFIG_M586TSC is not set # CONFIG_M586MMX is not set CONFIG_M686=y # CONFIG_M686FXSR is not set # CONFIG_MK6 is not set # CONFIG_MK7 is not set # CONFIG_MCRUSOE is not set # CONFIG_MWINCHIPC6 is not set # CONFIG_MWINCHIP2 is not set # CONFIG_MWINCHIP3D is not set CONFIG_X86_WP_WORKS_OK=y CONFIG_X86_INVLPG=y CONFIG_X86_CMPXCHG=y CONFIG_X86_BSWAP=y CONFIG_X86_POPAD_OK=y CONFIG_X86_L1_CACHE_SHIFT=5 CONFIG_X86_TSC=y CONFIG_X86_GOOD_APIC=y CONFIG_X86_PGE=y CONFIG_X86_USE_PPRO_CHECKSUM=y # CONFIG_TOSHIBA is not set CONFIG_MICROCODE=y CONFIG_X86_MSR=y CONFIG_X86_CPUID=y # CONFIG_NOHIGHMEM is not set # CONFIG_HIGHMEM4G is not set CONFIG_HIGHMEM64G=y CONFIG_HIGHMEM=y CONFIG_X86_PAE=y CONFIG_MATH_EMULATION=y CONFIG_MTRR=y CONFIG_SMP=y CONFIG_HAVE_DEC_LOCK=y # # General setup # CONFIG_NET=y # CONFIG_VISWS is not set CONFIG_X86_IO_APIC=y CONFIG_X86_LOCAL_APIC=y CONFIG_PCI=y # CONFIG_PCI_GOBIOS is not set # CONFIG_PCI_GODIRECT is not set CONFIG_PCI_GOANY=y CONFIG_PCI_BIOS=y CONFIG_PCI_DIRECT=y CONFIG_PCI_NAMES=y # CONFIG_MCA is not set CONFIG_HOTPLUG=y # # PCMCIA/CardBus support # CONFIG_PCMCIA=m CONFIG_CARDBUS=y CONFIG_SYSVIPC=y CONFIG_BSD_PROCESS_ACCT=y CONFIG_SYSCTL=y CONFIG_KCORE_ELF=y # CONFIG_KCORE_AOUT is not set CONFIG_BINFMT_AOUT=m CONFIG_BINFMT_ELF=y CONFIG_BINFMT_MISC=m # CONFIG_PM is not set # CONFIG_ACPI is not set # CONFIG_APM is not set # # Memory Technology Devices (MTD) # CONFIG_MTD=m # CONFIG_MTD_DOC1000 is not set # CONFIG_MTD_DOC2000 is not set # CONFIG_MTD_DOC2001 is not set # CONFIG_MTD_DOCPROBE is not set # CONFIG_MTD_SLRAM is not set # CONFIG_MTD_PMC551 is not set # CONFIG_MTD_MTDRAM is not set # # MTD drivers for mapped chips # CONFIG_MTD_CFI=m CONFIG_MTD_CFI_INTELEXT=m # CONFIG_MTD_CFI_AMDSTD is not set # CONFIG_MTD_JEDEC is not set # CONFIG_MTD_RAM is not set # CONFIG_MTD_ROM is not set CONFIG_MTD_PHYSMAP=m CONFIG_MTD_PHYSMAP_START=800 CONFIG_MTD_PHYSMAP_LEN=400 # # Drivers for chip mappings # # CONFIG_MTD_MIXMEM is not set CONFIG_MTD_NORA=m # CONFIG_MTD_OCTAGON is not set # CONFIG_MTD_PNC2000 is not set # CONFIG_MTD_RPXLITE is not set # CONFIG_MTD_VMAX is not set # # User modules and translation layers for MTD devices # CONFIG_MTD_CHAR=m CONFIG_MTD_BLOCK=m CONFIG_FTL=m CONFIG_NFTL=m CONFIG_NFTL_RW=y # # Parallel port support # CONFIG_PARPORT=m CONFIG_PARPORT_PC=m CONFIG_PARPORT_PC_FIFO=y # CONFIG_PARPORT_PC_SUPERIO is not set # CONFIG_PARPORT_AMIGA is not set # CONFIG_PARPORT_MFC3 is not set # CONFIG_PARPORT_ATARI is not set # CONFIG_PARPORT_SUNBPP is not set # CONFIG_PARPORT_OTHER is not set CONFIG_PARPORT_1284=y # # Plug and Play configuration # CONFIG_PNP=m CONFIG_ISAPNP=m # # Block devices # CONFIG_BLK_DEV_FD=y CONFIG_BLK_DEV_XD=m CONFIG_PARIDE=m CONFIG_PARIDE_PARPORT=m # # Parallel IDE high-level drivers # CONFIG_PARIDE_PD=m CONFIG_PARIDE_PCD=m CONFIG_PARIDE_PF=m CONFIG_PARIDE_PT=m CONFIG_PARIDE_PG=m # # Parallel IDE protocol modules # # CONFIG_PARIDE_ATEN is not set # CONFIG_PARIDE_BPCK is not set # CONFIG_PARIDE_COMM is not set # CONFIG_PARIDE_DSTR is not set # CONFIG_PARIDE_FIT2 is not set # CONFIG_PARIDE_FIT3 is not set # CONFIG_PARIDE_EPAT is not set # CONFIG_PARIDE_EPIA is not set # CONFIG_PARIDE_FRIQ is not set # CONFIG_PARIDE_FRPW is not set # CONFIG_PARIDE_KBIC is not set # CONFIG_PARIDE_KTTI is not set # CONFIG_PARIDE_ON20 is not set # CONFIG_PARIDE_ON26 is not set # CONFIG_BLK_CPQ_DA is not set # CONFIG_BLK_CPQ_CISS_DA is not set # CONFIG_BLK_DEV_DAC960 is not set CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_NBD=y CONFIG_BLK_DEV_RAM=m CONFIG_BLK_DEV_RAM_SIZE=4096 #
set_current_state() vs current->state
Hello all, I've been going through the drivers/block code (almost done) and noticed the use of, eg.: set_current_state(TASK_RUNNING); and also current->state = TASK_RUNNING; Which one is most recent, and is there a suggestion on which one to use? -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
drivers/block: cpqarray.h,smart1,2.h and cciss.h question
Hello all, While looking through the block drivers, cpqarray.c/h, smart1,2.h and the recent cciss.c/h: they were all for the Compaq Smart Array Controllers. For 2.5.x or possibly prior, could we consolidate them into one file incorporating all types of controllers or is there reason there are 3 different files? Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
drivers/block: cpqarray.h,smart1,2.h and cciss.h question
Hello all, While looking through the block drivers, cpqarray.c/h, smart1,2.h and the recent cciss.c/h: they were all for the Compaq Smart Array Controllers. For 2.5.x or possibly prior, could we consolidate them into one file incorporating all types of controllers or is there reason there are 3 different files? Regards, -Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: 2.4.x driver audit help
Hello, Posting incremental changes to l-k is fine, just CC me, and I'll compile a list of patches for inclusion into 2.4.0 . Regards, -Frank --Original Message-- From: Jes Sorensen <[EMAIL PROTECTED]> To: Frank Davis <[EMAIL PROTECTED]> Sent: September 5, 2000 6:06:21 PM GMT Subject: Re: 2.4.x driver audit help >>>>> "Frank" == Frank Davis <[EMAIL PROTECTED]> writes: Frank> Hello all, Anyone wishing to re-audit the drivers/block and Frank> drivers/char for locking issues and submit their patches to me Frank> directly, feel free. I think if more people comb through the Frank> code than myself, patches I missed will be found (100 eyes are Frank> better than 2). Once I think I have all the neccessary patches, Frank> blessed by the current maintainers, then I'll submit the Frank> patches to Linus for a finally blessing for inclusion into Frank> 2.4.0. Regards, Frank [EMAIL PROTECTED] It would be a lot more useful if you posted incremental patches here instead of doing a giant mega patch once you decide it's done. Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
