Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write()
On Wed, 2017-01-18 12:50:17 +0100, SF Markus Elfring <elfr...@users.sourceforge.net> wrote: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Wed, 18 Jan 2017 12:08:44 +0100 > > A local variable was set to an error code in two cases before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Jan-Benedict Glaw <jbg...@lug-owl.de> MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write()
On Wed, 2017-01-18 12:50:17 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 18 Jan 2017 12:08:44 +0100 > > A local variable was set to an error code in two cases before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Jan-Benedict Glaw MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: [PATCH] Input: vsxxxaa - fix code dropping bytes from queue
On Fri, 2014-10-24 15:38:46 -0700, Dmitry Torokhov
wrote:
> I believe the intent of the code was to drop oldest bytes from the queue,
> not the latest if we drop one byte and both latest and some oldest of we
> are dropping more than one.
>
> Signed-off-by: Dmitry Torokhov
> ---
> drivers/input/mouse/vsxxxaa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/vsxxxaa.c b/drivers/input/mouse/vsxxxaa.c
> index 3829823..abd4944 100644
> --- a/drivers/input/mouse/vsxxxaa.c
> +++ b/drivers/input/mouse/vsxxxaa.c
> @@ -128,7 +128,7 @@ static void vsxxxaa_drop_bytes(struct vsxxxaa *mouse, int
> num)
> if (num >= mouse->count) {
> mouse->count = 0;
> } else {
> - memmove(mouse->buf, mouse->buf + num - 1, BUFLEN - num);
> + memmove(mouse->buf, mouse->buf + num, BUFLEN - num);
> mouse->count -= num;
> }
> }
Good catch! I fucked up the error recovery path.
Acked-by: Jan-Benedict Glaw
MfG, JBG
--
Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481
Signature of: Eine Freie Meinung in einem Freien Kopf
the second : für einen Freien Staat voll Freier Bürger.
signature.asc
Description: Digital signature
Re: [PATCH] Input: vsxxxaa - fix code dropping bytes from queue
On Fri, 2014-10-24 15:38:46 -0700, Dmitry Torokhov dmitry.torok...@gmail.com
wrote:
I believe the intent of the code was to drop oldest bytes from the queue,
not the latest if we drop one byte and both latest and some oldest of we
are dropping more than one.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/mouse/vsxxxaa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/vsxxxaa.c b/drivers/input/mouse/vsxxxaa.c
index 3829823..abd4944 100644
--- a/drivers/input/mouse/vsxxxaa.c
+++ b/drivers/input/mouse/vsxxxaa.c
@@ -128,7 +128,7 @@ static void vsxxxaa_drop_bytes(struct vsxxxaa *mouse, int
num)
if (num = mouse-count) {
mouse-count = 0;
} else {
- memmove(mouse-buf, mouse-buf + num - 1, BUFLEN - num);
+ memmove(mouse-buf, mouse-buf + num, BUFLEN - num);
mouse-count -= num;
}
}
Good catch! I fucked up the error recovery path.
Acked-by: Jan-Benedict Glaw jbg...@lug-owl.de
MfG, JBG
--
Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481
Signature of: Eine Freie Meinung in einem Freien Kopf
the second : für einen Freien Staat voll Freier Bürger.
signature.asc
Description: Digital signature
gma500_gfx: Black VGA display with Intel D2500CC board
_enable_connectors], connector 18 enabled? no [ 28.892073] [drm:drm_enable_connectors], connector 20 enabled? yes [ 28.892078] [drm:drm_target_preferred], looking for cmdline mode on connector 7 [ 28.892082] [drm:drm_target_preferred], looking for preferred mode on connector 7 [ 28.892086] [drm:drm_target_preferred], found mode 1280x1024 [ 28.892090] [drm:drm_target_preferred], looking for cmdline mode on connector 9 [ 28.892094] [drm:drm_target_preferred], looking for preferred mode on connector 9 [ 28.892099] [drm:drm_target_preferred], found mode 1920x1080 [ 28.892103] [drm:drm_target_preferred], looking for cmdline mode on connector 20 [ 28.892107] [drm:drm_target_preferred], looking for preferred mode on connector 20 [ 28.892111] [drm:drm_target_preferred], found mode 1024x768 [ 28.892115] [drm:drm_setup_crtcs], picking CRTCs for 4096x4096 config [ 28.892126] [drm:drm_setup_crtcs], desired mode 1280x1024 set on crtc 3 [ 28.892132] [drm:drm_setup_crtcs], desired mode 1920x1080 set on crtc 4 [ 28.892208] [drm:cdv_get_max_backlight], LVDS Panel PWM value is 0! [ 28.892213] [drm:cdv_get_max_backlight], LVDS Panel PWM value is 0! [ 28.892224] [drm] Initialized gma500 1.0.0 2011-06-06 for :00:02.0 on minor 0 -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: http://www.eyrie.org/~eagle/faqs/questions.html the second : signature.asc Description: Digital signature
gma500_gfx: Black VGA display with Intel D2500CC board
[ 28.892086] [drm:drm_target_preferred], found mode 1280x1024 [ 28.892090] [drm:drm_target_preferred], looking for cmdline mode on connector 9 [ 28.892094] [drm:drm_target_preferred], looking for preferred mode on connector 9 [ 28.892099] [drm:drm_target_preferred], found mode 1920x1080 [ 28.892103] [drm:drm_target_preferred], looking for cmdline mode on connector 20 [ 28.892107] [drm:drm_target_preferred], looking for preferred mode on connector 20 [ 28.892111] [drm:drm_target_preferred], found mode 1024x768 [ 28.892115] [drm:drm_setup_crtcs], picking CRTCs for 4096x4096 config [ 28.892126] [drm:drm_setup_crtcs], desired mode 1280x1024 set on crtc 3 [ 28.892132] [drm:drm_setup_crtcs], desired mode 1920x1080 set on crtc 4 [ 28.892208] [drm:cdv_get_max_backlight], LVDS Panel PWM value is 0! [ 28.892213] [drm:cdv_get_max_backlight], LVDS Panel PWM value is 0! [ 28.892224] [drm] Initialized gma500 1.0.0 2011-06-06 for :00:02.0 on minor 0 -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: http://www.eyrie.org/~eagle/faqs/questions.html the second : signature.asc Description: Digital signature
Re: new file in kernel.
On Sat, 2008-01-19 12:12:10 -0300, Rafael Sisto <[EMAIL PROTECTED]> wrote: > Dear Jan, > > The idea of the indirection is to make it transparent for the user. > The idea is to do almost the same as what IPC does. The user calls > "get", then "attach". In the "get" syscall I create a tmp file and > return some id. Then the user calls an "attach" syscall with the > returned id. > > The result is that he gets a shared memorymapped to his vma. So my understanding is that you want to get a "IPC shared memory for dummies" API. You're already willing to use custom-numbered system calls, requiring to recompile the Linux kernel, having to add these system calls to libc (or putting _syscallX macros into the application's code) and loosing all portability for the application using this API. My point of view is that this is a planed nightmare :) I'd suggest to dig into "Unix Network Programming, Volume 2. Interprocess Communications" and implement that API as a library instead of using a set of new kernel system calls. That way, the applications using it will use that API and only that. They won't require operatins system specific modifications afterwards. OTOH, this library will probably quite portable by itself and shouldn't need any kernel changes, independent of the underlying kernel. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
Re: new file in kernel.
On Sat, 2008-01-19 11:21:11 -0300, Rafael Sisto <[EMAIL PROTECTED]> wrote: > Dear Arnaldo, I didnt see your mail before. > I read some of the code you suggested, but it seems so complicated! I > just need to create a file named "file" on the path /tmp/.. Isn't > there an easier way? In my opinion, you're heading totally into the wrong direction. Nobody will help you solving your problem with a given fixed method (file accessing in kernel mode) unless you describe your problem in detail. There's probably a much better and cleaner way. But unless you describe your application and the overall goal in detail, please don't expect too much help. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature
Re: new file in kernel.
On Sat, 2008-01-19 11:21:11 -0300, Rafael Sisto [EMAIL PROTECTED] wrote: Dear Arnaldo, I didnt see your mail before. I read some of the code you suggested, but it seems so complicated! I just need to create a file named file on the path /tmp/.. Isn't there an easier way? In my opinion, you're heading totally into the wrong direction. Nobody will help you solving your problem with a given fixed method (file accessing in kernel mode) unless you describe your problem in detail. There's probably a much better and cleaner way. But unless you describe your application and the overall goal in detail, please don't expect too much help. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature
Re: new file in kernel.
On Sat, 2008-01-19 12:12:10 -0300, Rafael Sisto [EMAIL PROTECTED] wrote: Dear Jan, The idea of the indirection is to make it transparent for the user. The idea is to do almost the same as what IPC does. The user calls get, then attach. In the get syscall I create a tmp file and return some id. Then the user calls an attach syscall with the returned id. The result is that he gets a shared memorymapped to his vma. So my understanding is that you want to get a IPC shared memory for dummies API. You're already willing to use custom-numbered system calls, requiring to recompile the Linux kernel, having to add these system calls to libc (or putting _syscallX macros into the application's code) and loosing all portability for the application using this API. My point of view is that this is a planed nightmare :) I'd suggest to dig into Unix Network Programming, Volume 2. Interprocess Communications and implement that API as a library instead of using a set of new kernel system calls. That way, the applications using it will use that API and only that. They won't require operatins system specific modifications afterwards. OTOH, this library will probably quite portable by itself and shouldn't need any kernel changes, independent of the underlying kernel. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
Re: How to disable ECC with bootparam ?
On Sat, 2007-11-17 00:20:20 +0100, Xavier Bestel <[EMAIL PROTECTED]> wrote: > > I have replaced my machine with another one which gives many ECC errors. > At first sight they may be pessimistic because memtest (with ECC off) > doesn't find anything (I'm letting run it overnight, I'll see tomorrow > morning if it really didn't find anything). > I'd like to let it run without thoses ECC messages (which slow it down > pretty much), but Erm... "ECC" means there are extra bits that, with small amount of errors, allow to recalculate the initial value. If you're getting error messages with ECC errors, that means that your RAM really looses its contents. You should fix your machine. (Check that eg. timings are correct with RAM's specification, ...) You're on risk. Really. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Eine Freie Meinung in einem Freien Kopf the second : für einen Freien Staat voll Freier Bürger. signature.asc Description: Digital signature
Re: How to disable ECC with bootparam ?
On Sat, 2007-11-17 00:20:20 +0100, Xavier Bestel [EMAIL PROTECTED] wrote: I have replaced my machine with another one which gives many ECC errors. At first sight they may be pessimistic because memtest (with ECC off) doesn't find anything (I'm letting run it overnight, I'll see tomorrow morning if it really didn't find anything). I'd like to let it run without thoses ECC messages (which slow it down pretty much), but Erm... ECC means there are extra bits that, with small amount of errors, allow to recalculate the initial value. If you're getting error messages with ECC errors, that means that your RAM really looses its contents. You should fix your machine. (Check that eg. timings are correct with RAM's specification, ...) You're on risk. Really. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Eine Freie Meinung in einem Freien Kopf the second : für einen Freien Staat voll Freier Bürger. signature.asc Description: Digital signature
Re: wierd file perms
On Sun, 2007-10-14 09:29:01 -0400, Mark Lord <[EMAIL PROTECTED]> wrote: > vignesh babu wrote: > .. > >?- ? ? ? ?? fcntl.c > >?- ? ? ? ?? fifo.c > >?- ? ? ? ?? filesystems.c > >?- ? ? ? ?? file_table.c > >?- ? ? ? ?? freevxfs > > > >So end result is that, Im not able to delete the files or change perms > >or ownership even as root. > > > >Can some one help please? > > chmod a+x name_of_directory > > Now you can do "ls -l" and "rm" or whatever. *cough* The original mail you're replying to had this inside: > > I was hitting another issue with permissions-as root :( > > I really think he better starts a fsck... Soon. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature
Re: wierd file perms
On Sun, 2007-10-14 09:29:01 -0400, Mark Lord [EMAIL PROTECTED] wrote: vignesh babu wrote: .. ?- ? ? ? ?? fcntl.c ?- ? ? ? ?? fifo.c ?- ? ? ? ?? filesystems.c ?- ? ? ? ?? file_table.c ?- ? ? ? ?? freevxfs So end result is that, Im not able to delete the files or change perms or ownership even as root. Can some one help please? chmod a+x name_of_directory Now you can do ls -l and rm or whatever. *cough* The original mail you're replying to had this inside: I was hitting another issue with permissions-as root :( I really think he better starts a fsck... Soon. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature
Re: wierd file perms
On Sat, 2007-10-13 22:40:23 +0530, vignesh babu <[EMAIL PROTECTED]> wrote: > > I was surprised and did an ls -l on the files and guess what I found: > > total 0 > ?- ? ? ? ?? fcntl.c > ?- ? ? ? ?? fifo.c > ?- ? ? ? ?? filesystems.c > ?- ? ? ? ?? file_table.c > ?- ? ? ? ?? freevxfs > > So end result is that, Im not able to delete the files or change perms > or ownership even as root. Most probably, your filesystem is broken and needs a fsck. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Zensur im Internet? Nein danke! the second : signature.asc Description: Digital signature
Re: wierd file perms
On Sat, 2007-10-13 22:40:23 +0530, vignesh babu [EMAIL PROTECTED] wrote: I was surprised and did an ls -l on the files and guess what I found: total 0 ?- ? ? ? ?? fcntl.c ?- ? ? ? ?? fifo.c ?- ? ? ? ?? filesystems.c ?- ? ? ? ?? file_table.c ?- ? ? ? ?? freevxfs So end result is that, Im not able to delete the files or change perms or ownership even as root. Most probably, your filesystem is broken and needs a fsck. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Zensur im Internet? Nein danke! the second : signature.asc Description: Digital signature
Re: [LV] [PATCH] avoid negative shifts in radix-tree.c
On Sat, 2007-08-25 16:26:07 +0200, Peter Firefly Lund <[EMAIL PROTECTED]> wrote:
> --- lib/radix-tree-old.c 2007-08-25 15:36:40.0 +0200
> +++ lib/radix-tree.c 2007-08-25 15:36:51.0 +0200
> @@ -980,12 +980,14 @@ radix_tree_node_ctor(void *node, struct
>
> static __init unsigned long __maxindex(unsigned int height)
> {
> - unsigned int tmp = height * RADIX_TREE_MAP_SHIFT;
> - unsigned long index = (~0UL >> (RADIX_TREE_INDEX_BITS - tmp - 1)) >> 1;
> -
> - if (tmp >= RADIX_TREE_INDEX_BITS)
> - index = ~0UL;
> - return index;
> + unsigned inttmp =
> + int shift = RADIX_TREE_INDEX_BITS - height * RADIX_TREE_MAP_SHIFT;
> + unsigned long index;
> +
> + if (shift < 0)
> + return ~0UL;
> + else
> + return ~0UL >> shift;
> }
>
> static __init void radix_tree_init_maxindex(void)
`index' seems to be unused now? And indention does neither follow
kernel coding style, nor this file's style. You'd also hammer out
`tmp' and put its initializer right there where it's used.
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Träume nicht von Dein Leben: Lebe Deinen Traum!
the second :
signature.asc
Description: Digital signature
Re: [LV] [PATCH] avoid negative shifts in radix-tree.c
On Sat, 2007-08-25 16:26:07 +0200, Peter Firefly Lund [EMAIL PROTECTED] wrote:
--- lib/radix-tree-old.c 2007-08-25 15:36:40.0 +0200
+++ lib/radix-tree.c 2007-08-25 15:36:51.0 +0200
@@ -980,12 +980,14 @@ radix_tree_node_ctor(void *node, struct
static __init unsigned long __maxindex(unsigned int height)
{
- unsigned int tmp = height * RADIX_TREE_MAP_SHIFT;
- unsigned long index = (~0UL (RADIX_TREE_INDEX_BITS - tmp - 1)) 1;
-
- if (tmp = RADIX_TREE_INDEX_BITS)
- index = ~0UL;
- return index;
+ unsigned inttmp =
+ int shift = RADIX_TREE_INDEX_BITS - height * RADIX_TREE_MAP_SHIFT;
+ unsigned long index;
+
+ if (shift 0)
+ return ~0UL;
+ else
+ return ~0UL shift;
}
static __init void radix_tree_init_maxindex(void)
`index' seems to be unused now? And indention does neither follow
kernel coding style, nor this file's style. You'd also hammer out
`tmp' and put its initializer right there where it's used.
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Träume nicht von Dein Leben: Lebe Deinen Traum!
the second :
signature.asc
Description: Digital signature
Re: Git tree for old kernels from before the current tree
On Mon, 2007-07-23 20:10:23 -0400, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > > I have sanitized .tgz files that I use to stuff a Git repo with. I > recall that some of them were reconstructed through patching an earlier > or later kernel version because the original ones were corrupted. Some > patches were retrieved from other archival sites, etc. Then the result > was > cross checked with summary lists like this one: > > http://www.uwsg.iu.edu/hypermail/linux/kernel/0110.1/1684.html > > This was a while ago so I don't remember the exact steps, but that > wasn't always trivial. Some years ago, I also worked on old Linux releases. Have you found the tarballs in my directory at kernel.org? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: Git tree for old kernels from before the current tree
On Mon, 2007-07-23 20:10:23 -0400, Nicolas Pitre [EMAIL PROTECTED] wrote: I have sanitized .tgz files that I use to stuff a Git repo with. I recall that some of them were reconstructed through patching an earlier or later kernel version because the original ones were corrupted. Some patches were retrieved from other archival sites, etc. Then the result was cross checked with summary lists like this one: http://www.uwsg.iu.edu/hypermail/linux/kernel/0110.1/1684.html This was a while ago so I don't remember the exact steps, but that wasn't always trivial. Some years ago, I also worked on old Linux releases. Have you found the tarballs in my directory at kernel.org? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: [PATCH] [460/2many] MAINTAINERS - SRM (Alpha) environment access
On Sun, 2007-08-12 23:36:44 -0700, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index fa8fb1c..3c134fa 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4386,6 +4386,8 @@ P: Jan-Benedict Glaw > M: [EMAIL PROTECTED] > L: linux-kernel@vger.kernel.org > S: Maintained > +F: arch/alpha/kernel/*srm* > +F: arch/alpha/lib/srm* > > STARFIRE/DURALAN NETWORK DRIVER > P: Ion Badulescu NACK. I only care about arch/alpha/kernel/srm_env.c and don't know about all the others that match. So this should simply be: F: arch/alpha/kernel/srm_env.c MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck. the second : Langsam möchte ich mal wieder weiterträumen können. -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de) signature.asc Description: Digital signature
Re: [PATCH] [460/2many] MAINTAINERS - SRM (Alpha) environment access
On Sun, 2007-08-12 23:36:44 -0700, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index fa8fb1c..3c134fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4386,6 +4386,8 @@ P: Jan-Benedict Glaw M: [EMAIL PROTECTED] L: linux-kernel@vger.kernel.org S: Maintained +F: arch/alpha/kernel/*srm* +F: arch/alpha/lib/srm* STARFIRE/DURALAN NETWORK DRIVER P: Ion Badulescu NACK. I only care about arch/alpha/kernel/srm_env.c and don't know about all the others that match. So this should simply be: F: arch/alpha/kernel/srm_env.c MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck. the second : Langsam möchte ich mal wieder weiterträumen können. -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de) signature.asc Description: Digital signature
Re: [RFH] Partition table recovery
On Mon, 2007-07-23 14:39:11 +0200, Rene Herman <[EMAIL PROTECTED]> wrote:
> On 07/23/2007 12:54 PM, Rene Herman wrote:
>
> > static inline uint32_t le_32(uint32_t n)
> > {
> > #ifdef __LITTLE_ENDIAN
> > return n;
> > #else
> > return bswap_32(n);
> > #endif
> > }
>
> #if __BYTE_ORDER == __LITTLE_ENDIAN, that is. sigh.
Don't forget PDP11 byteorder :-)
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Wenn ich wach bin, träume ich.
the second :
signature.asc
Description: Digital signature
Re: [RFH] Partition table recovery
;
> entry->size = cur->size;
LE/BE issues here...
> }
> if (ext)
> ret = do_sector(fd, offset, ext->start);
> out:
> put_sector(sector);
> return ret;
> }
>
> void show_backup(void)
> {
> #ifdef DEBUG
>
> int i;
>
> fprintf(stderr, "signature: ");
> for (i = 0; i < 8; i++)
> fprintf(stderr, "%c", backup.signature[i]);
> fprintf(stderr, "\n");
>
> fprintf(stderr, " type: %d\n", backup.type);
> fprintf(stderr, "heads: %d\n", backup.heads);
> fprintf(stderr, " sectors: %d\n", backup.sectors);
> fprintf(stderr, "count: %d\n", backup.count);
>
> for (i = 0; i < backup.count; i++) {
> fprintf(stderr, "\n");
> fprintf(stderr, "%2d: flags: %02x\n", i, backup.table[i].flags);
> fprintf(stderr, "%2d: type: %02x\n", i, backup.table[i].type);
> fprintf(stderr, "%2d: start: %llu\n", i, backup.table[i].start);
> fprintf(stderr, "%2d: size: %u\n", i, backup.table[i].size);
You'll output wrong values here, depending on your host system.
> }
> #endif
> }
>
> int main(int argc, char *argv[])
> {
> int fd;
> struct stat buf;
>
> if (argc != 2) {
> printf("%s \n", argv[0]);
> return EXIT_FAILURE;
> }
> fd = open(argv[1], O_RDONLY);
> if (fd < 0) {
> perror("open");
> return EXIT_FAILURE;
> }
> if (fstat(fd, ) < 0) {
> perror("stat");
> return EXIT_FAILURE;
> }
> if (!S_ISBLK(buf.st_mode))
> fprintf(stderr, "warning: not a block device\n");
>
> if (do_sector(fd, 0, 0) < 0)
> return EXIT_FAILURE;
>
> if (close(fd) < 0) {
> perror("close");
> return EXIT_FAILURE;
> }
> if (write(STDOUT_FILENO, , sizeof backup) != sizeof backup) {
> perror("write");
> return EXIT_FAILURE;
> }
>
> show_backup();
>
> return EXIT_SUCCESS;
> }
Looks like a useful program, but you'd definively fix the LE/BE
issues. If you do that, it'll be able to even run on BE machines, too.
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Träume nicht von Dein Leben: Lebe Deinen Traum!
the second :
signature.asc
Description: Digital signature
Re: [RFH] Partition table recovery
\n, i, backup.table[i].flags);
fprintf(stderr, %2d: type: %02x\n, i, backup.table[i].type);
fprintf(stderr, %2d: start: %llu\n, i, backup.table[i].start);
fprintf(stderr, %2d: size: %u\n, i, backup.table[i].size);
You'll output wrong values here, depending on your host system.
}
#endif
}
int main(int argc, char *argv[])
{
int fd;
struct stat buf;
if (argc != 2) {
printf(%s blkdev\n, argv[0]);
return EXIT_FAILURE;
}
fd = open(argv[1], O_RDONLY);
if (fd 0) {
perror(open);
return EXIT_FAILURE;
}
if (fstat(fd, buf) 0) {
perror(stat);
return EXIT_FAILURE;
}
if (!S_ISBLK(buf.st_mode))
fprintf(stderr, warning: not a block device\n);
if (do_sector(fd, 0, 0) 0)
return EXIT_FAILURE;
if (close(fd) 0) {
perror(close);
return EXIT_FAILURE;
}
if (write(STDOUT_FILENO, backup, sizeof backup) != sizeof backup) {
perror(write);
return EXIT_FAILURE;
}
show_backup();
return EXIT_SUCCESS;
}
Looks like a useful program, but you'd definively fix the LE/BE
issues. If you do that, it'll be able to even run on BE machines, too.
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Träume nicht von Dein Leben: Lebe Deinen Traum!
the second :
signature.asc
Description: Digital signature
Re: [RFH] Partition table recovery
On Mon, 2007-07-23 14:39:11 +0200, Rene Herman [EMAIL PROTECTED] wrote:
On 07/23/2007 12:54 PM, Rene Herman wrote:
static inline uint32_t le_32(uint32_t n)
{
#ifdef __LITTLE_ENDIAN
return n;
#else
return bswap_32(n);
#endif
}
#if __BYTE_ORDER == __LITTLE_ENDIAN, that is. sigh.
Don't forget PDP11 byteorder :-)
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Wenn ich wach bin, träume ich.
the second :
signature.asc
Description: Digital signature
Re: from where comes "__moddi3"?
On Sat, 2007-07-21 21:31:13 +0200, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Sat, 2007-07-21 at 15:21 -0400, Robert P. J. Day wrote: > > use do_div(). > > 16 works because gcc translates that into a right shift. Right shift? Doesn't it just mask out everything but the low 4 bit? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: from where comes __moddi3?
On Sat, 2007-07-21 21:31:13 +0200, Peter Zijlstra [EMAIL PROTECTED] wrote: On Sat, 2007-07-21 at 15:21 -0400, Robert P. J. Day wrote: use do_div(). 16 works because gcc translates that into a right shift. Right shift? Doesn't it just mask out everything but the low 4 bit? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: [RFH] Partition table recovery
On Fri, 2007-07-20 14:29:34 +0300, Al Boldi <[EMAIL PROTECTED]> wrote:
>
> But, I want something much more automated. And the partition table backup
> per partition entry isn't really a bad idea.
That's called `gpart'.
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Fortschritt bedeutet, einen Schritt so zu machen,
the second : daß man den nächsten auch noch machen kann.
signature.asc
Description: Digital signature
Re: [RFH] Partion table recovery
On Thu, 2007-07-19 22:25:49 -0700, James Lamanna <[EMAIL PROTECTED]> wrote: > On 7/19/07, Al Boldi <[EMAIL PROTECTED]> wrote: > > > > I tried parted, but it's not working out for me. Does anybody know of a > > simple partition recovery tool, that would just scan the disk for lost > > partions? > > Tried gpart? > http://www.stud.uni-hannover.de/user/76201/gpart/ Right, gpart should be the way to go. I used that several times and it always worked great. You'll probably loose the first partition at first (it searches for filesystem signatures and may fail to find the first partition's filesystem), but it should find all the rest. Once you've written the guessed partition table, just use cfdisk (or any other fdisk you're comfy with) to create a maximum-sized partition in the first free area. Depending on the filesystem used there, you may even be able to get back the remaining data. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: [RFH] Partition table recovery
On Fri, 2007-07-20 14:29:34 +0300, Al Boldi [EMAIL PROTECTED] wrote: But, I want something much more automated. And the partition table backup per partition entry isn't really a bad idea. That's called `gpart'. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Fortschritt bedeutet, einen Schritt so zu machen, the second : daß man den nächsten auch noch machen kann. signature.asc Description: Digital signature
Re: [RFH] Partion table recovery
On Thu, 2007-07-19 22:25:49 -0700, James Lamanna [EMAIL PROTECTED] wrote: On 7/19/07, Al Boldi [EMAIL PROTECTED] wrote: I tried parted, but it's not working out for me. Does anybody know of a simple partition recovery tool, that would just scan the disk for lost partions? Tried gpart? http://www.stud.uni-hannover.de/user/76201/gpart/ Right, gpart should be the way to go. I used that several times and it always worked great. You'll probably loose the first partition at first (it searches for filesystem signatures and may fail to find the first partition's filesystem), but it should find all the rest. Once you've written the guessed partition table, just use cfdisk (or any other fdisk you're comfy with) to create a maximum-sized partition in the first free area. Depending on the filesystem used there, you may even be able to get back the remaining data. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: Linux Kernel include files
On Thu, 2007-06-28 12:39:57 +0200, Joerg Schilling <[EMAIL PROTECTED]> wrote: > > > > By the way, your mailer seems to be sometimes omitting In-Reply-To: and > > > > References: headers, which RFC2822 says you SHOULD include in replies. > > > > > > Sending such accusation without knowing the reason is not polite. > > > > It's not an accusation -- it's merely an observation. You may not have > > noticed that your mailer was misbehaving; now you _do_ know, and if you > > care about RFC compliance you might want to fix it. You're not _obliged_ > > to fix it, of course. I just thought you'd like to know. > > Well there you are: my mailer is definitely NOT missbehaving. > Please do not repeat similar accusations when not knowing the reason. Just out of interest: In which cases do you want to break threading? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: What we do for ourselves dies with us. What we do for the second : others and the world remains and is immortal. (Albert Pine) signature.asc Description: Digital signature
Re: Linux Kernel include files
On Thu, 2007-06-28 12:39:57 +0200, Joerg Schilling [EMAIL PROTECTED] wrote: By the way, your mailer seems to be sometimes omitting In-Reply-To: and References: headers, which RFC2822 says you SHOULD include in replies. Sending such accusation without knowing the reason is not polite. It's not an accusation -- it's merely an observation. You may not have noticed that your mailer was misbehaving; now you _do_ know, and if you care about RFC compliance you might want to fix it. You're not _obliged_ to fix it, of course. I just thought you'd like to know. Well there you are: my mailer is definitely NOT missbehaving. Please do not repeat similar accusations when not knowing the reason. Just out of interest: In which cases do you want to break threading? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: What we do for ourselves dies with us. What we do for the second : others and the world remains and is immortal. (Albert Pine) signature.asc Description: Digital signature
Re: NAK (bashizm in the /bin/sh script): [PATCH v3] doc/oops-tracing: add Code: decode info
On Tue, 2007-06-26 12:16:39 +0200, DervishD <[EMAIL PROTECTED]> wrote: > * Matthieu CASTET <[EMAIL PROTECTED]> dixit: > > On Sat, 23 Jun 2007 10:43:03 -0700, Randy Dunlap wrote: > > > > > OTOH, you also didn't supply a patch. If you do this, I'll be glad to > > > consider it. If I can read it, that is. > > > > "s|/bin/sh|/bin/bash" is so hard to do ? > > Given that it happens too with "ldd", it really *is* that hard. I > don't know why still people think that /bin/sh is always /bin/bash. If > they want/need bash, that's ok to me, I will have it installed for such > tasks, but they should call it "#!/bin/bash". ...or "#!/usr/bin/env bash" for what it's worth... The same for plain `sh'. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
Re: NAK (bashizm in the /bin/sh script): [PATCH v3] doc/oops-tracing: add Code: decode info
On Tue, 2007-06-26 12:16:39 +0200, DervishD [EMAIL PROTECTED] wrote: * Matthieu CASTET [EMAIL PROTECTED] dixit: On Sat, 23 Jun 2007 10:43:03 -0700, Randy Dunlap wrote: OTOH, you also didn't supply a patch. If you do this, I'll be glad to consider it. If I can read it, that is. s|/bin/sh|/bin/bash is so hard to do ? Given that it happens too with ldd, it really *is* that hard. I don't know why still people think that /bin/sh is always /bin/bash. If they want/need bash, that's ok to me, I will have it installed for such tasks, but they should call it #!/bin/bash. ...or #!/usr/bin/env bash for what it's worth... The same for plain `sh'. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
Re: [KJ] Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
On Mon, 2007-06-11 19:47:06 +0200, Karsten Keil <[EMAIL PROTECTED]> wrote:
> diff --git a/drivers/isdn/hisax/callc.c b/drivers/isdn/hisax/callc.c
> index 7c56c44..0b9ed8e 100644
> --- a/drivers/isdn/hisax/callc.c
> +++ b/drivers/isdn/hisax/callc.c
> @@ -834,8 +834,6 @@ static struct FsmNode fnlist[] __initdata =
> };
> /* *INDENT-ON* */
>
> -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
> -
> int __init
> CallcNew(void)
> {
> @@ -843,7 +841,7 @@ CallcNew(void)
> callcfsm.event_count = EVENT_COUNT;
> callcfsm.strEvent = strEvent;
> callcfsm.strState = strState;
> - return FsmNew(, fnlist, FNCOUNT);
> + return FsmNew(, fnlist, ARRAY_SIZE(fnlist));
> }
>
> void
I think that's really a nice improvement :) Thanks for the work,
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second : Langsam möchte ich mal wieder weiterträumen können.
-- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)
signature.asc
Description: Digital signature
Re: [KJ] Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
On Mon, 2007-06-11 19:47:06 +0200, Karsten Keil [EMAIL PROTECTED] wrote:
diff --git a/drivers/isdn/hisax/callc.c b/drivers/isdn/hisax/callc.c
index 7c56c44..0b9ed8e 100644
--- a/drivers/isdn/hisax/callc.c
+++ b/drivers/isdn/hisax/callc.c
@@ -834,8 +834,6 @@ static struct FsmNode fnlist[] __initdata =
};
/* *INDENT-ON* */
-#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
-
int __init
CallcNew(void)
{
@@ -843,7 +841,7 @@ CallcNew(void)
callcfsm.event_count = EVENT_COUNT;
callcfsm.strEvent = strEvent;
callcfsm.strState = strState;
- return FsmNew(callcfsm, fnlist, FNCOUNT);
+ return FsmNew(callcfsm, fnlist, ARRAY_SIZE(fnlist));
}
void
I think that's really a nice improvement :) Thanks for the work,
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second : Langsam möchte ich mal wieder weiterträumen können.
-- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)
signature.asc
Description: Digital signature
Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
On Sun, 2007-06-10 15:11:22 +0200, Karsten Keil <[EMAIL PROTECTED]> wrote: > > --- a/drivers/isdn/hisax/callc.c > > +++ b/drivers/isdn/hisax/callc.c > > @@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata = > > }; > > /* *INDENT-ON* */ > > > > -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode)) > > +#define FNCOUNT ARRAY_SIZE(fnlist) > > > > int __init > > CallcNew(void) > > This is OK, thanks for changing. I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck. the second : Langsam möchte ich mal wieder weiterträumen können. -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de) signature.asc Description: Digital signature
Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
On Sun, 2007-06-10 15:11:22 +0200, Karsten Keil [EMAIL PROTECTED] wrote: --- a/drivers/isdn/hisax/callc.c +++ b/drivers/isdn/hisax/callc.c @@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata = }; /* *INDENT-ON* */ -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode)) +#define FNCOUNT ARRAY_SIZE(fnlist) int __init CallcNew(void) This is OK, thanks for changing. I'd suggest to not use another define, but use ARRAY_SIZE(foo) _instead of_ eg. FNCOUNT. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck. the second : Langsam möchte ich mal wieder weiterträumen können. -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de) signature.asc Description: Digital signature
Re: beeping patch for debugging acpi sleep
On Sat, 2007-06-09 15:08:17 +0200, Pavel Machek <[EMAIL PROTECTED]> wrote: > > Starting beeper as soon as ACPI sleep returns is very useful in > debugging "apparently dead" machines. If it beeps at all, it makes > sense to start playing with CMOS tracer. I'd even go so far and implement it unconditionally. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Eine Freie Meinung in einem Freien Kopf the second : für einen Freien Staat voll Freier Bürger. signature.asc Description: Digital signature
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
On Sat, 2007-06-09 15:57:55 +1000, Neil Brown <[EMAIL PROTECTED]> wrote: > On Saturday June 9, [EMAIL PROTECTED] wrote: > > As we know the forthcoming GPL V3 will be not compatible with the GPL V2 > > and Linux Kernel is GPL V2 only. > > So, another point is, which is previously mentioned by Linus and others, > > that if it is decided to upgrade the Linux Kernel's License to GPL V3, > > it is needed the permission of all the maintainers permission who > > contributed to the Linux Kernel and there are a lot of lost or dead > > maintainers. Which makes it impossible to get all the maintainers' > > permission. > > You don't need the permission of maintainers. You need the permission > of copyright owners. The two groups overlap, but are not the same. > Dead people cannot own anything, even copyright. Their estate > probably can. I don't think it is theoretically impossible to get > everyone's permission, though it may be quite close to practically > impossible. And the next question is: How much copyright does a copyright owner own? For example, think of drivers written by one person, but a small number of lines changed here and there by others to adopt the code to new APIs. Ask them all, I think? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
On Sat, 2007-06-09 15:57:55 +1000, Neil Brown [EMAIL PROTECTED] wrote: On Saturday June 9, [EMAIL PROTECTED] wrote: As we know the forthcoming GPL V3 will be not compatible with the GPL V2 and Linux Kernel is GPL V2 only. So, another point is, which is previously mentioned by Linus and others, that if it is decided to upgrade the Linux Kernel's License to GPL V3, it is needed the permission of all the maintainers permission who contributed to the Linux Kernel and there are a lot of lost or dead maintainers. Which makes it impossible to get all the maintainers' permission. You don't need the permission of maintainers. You need the permission of copyright owners. The two groups overlap, but are not the same. Dead people cannot own anything, even copyright. Their estate probably can. I don't think it is theoretically impossible to get everyone's permission, though it may be quite close to practically impossible. And the next question is: How much copyright does a copyright owner own? For example, think of drivers written by one person, but a small number of lines changed here and there by others to adopt the code to new APIs. Ask them all, I think? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature
Re: beeping patch for debugging acpi sleep
On Sat, 2007-06-09 15:08:17 +0200, Pavel Machek [EMAIL PROTECTED] wrote: Starting beeper as soon as ACPI sleep returns is very useful in debugging apparently dead machines. If it beeps at all, it makes sense to start playing with CMOS tracer. I'd even go so far and implement it unconditionally. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Eine Freie Meinung in einem Freien Kopf the second : für einen Freien Staat voll Freier Bürger. signature.asc Description: Digital signature
Re: [PATCH] update checkpatch.pl to version 0.03
On Fri, 2007-06-08 02:04:55 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Fri, Jun 08, 2007 at 12:41:17AM +0100, Alan Cox wrote: > > (And incidentially since the Linux fs has been defined to be utf-8 for > > naming for many years you'll find the same problem using "ls") > > No, "ls" can handle it perfectly: > > # echo $LANG > C > # ls > ??rsted > # `ls' may be playing tricks by checking whether its output goes to a TTY. Does the terminal also hang for $ ls | cat or $ ls -N MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:http://catb.org/~esr/faqs/smart-questions.html the second : signature.asc Description: Digital signature
Re: [PATCH] update checkpatch.pl to version 0.03
On Fri, 2007-06-08 02:04:55 +0200, Adrian Bunk [EMAIL PROTECTED] wrote: On Fri, Jun 08, 2007 at 12:41:17AM +0100, Alan Cox wrote: (And incidentially since the Linux fs has been defined to be utf-8 for naming for many years you'll find the same problem using ls) No, ls can handle it perfectly: # echo $LANG C # ls ??rsted # `ls' may be playing tricks by checking whether its output goes to a TTY. Does the terminal also hang for $ ls | cat or $ ls -N MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:http://catb.org/~esr/faqs/smart-questions.html the second : signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 12:52:13 +0200, Lars K.W. Gohlke <[EMAIL PROTECTED]> wrote: > Jan-Benedict Glaw schrieb: > > On Wed, 2007-06-06 12:39:17 +0200, Lars K.W. Gohlke <[EMAIL PROTECTED]> > > wrote: > > > Jan-Benedict Glaw schrieb: > > > > OTOH, why do you want to do the serial stuff in kernel land? Isn't it > > > > a *lot* easier to do it in userspace? What's your specific device you > > > > want to work on? > > > You didn't actually answer any of my questions. > sorry. > > I want to use the interface aka /dev/ttyS0. > I want to process data inside of a kernel module to provide it /proc > (done) or as own char-dev (done). > > but I can not grab the data. > > It is part of my project in my studies. > > It is more a conceptual work, but important. I want to release a howto, > when I complete. You still answer unasked questions. Please answer inline: * Why do you wanto to do the serial stuff in kernel land? * Isn't it easier to do it in userspace? * What specific device do you work on? * New: Is it a wise idea to do it in kernel land? The /proc filesystem has been somewhat obsoleted in favour of sysfs for device/driver information. -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: ...und wenn Du denkst, es geht nicht mehr, the second : kommt irgendwo ein Lichtlein her. signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 12:39:17 +0200, Lars K.W. Gohlke <[EMAIL PROTECTED]> wrote: > Jan-Benedict Glaw schrieb: > > OTOH, why do you want to do the serial stuff in kernel land? Isn't it > > a *lot* easier to do it in userspace? What's your specific device you > > want to work on? [snip] You didn't actually answer any of my questions. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: "really soon now": an unspecified period of time, likly to the second : be greater than any reasonable definition of "soon". signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 11:34:49 +0200, Lars K.W. Gohlke <[EMAIL PROTECTED]> wrote: > Jan-Benedict Glaw schrieb: > > On Wed, 2007-06-06 11:11:23 +0200, Lars K.W. Gohlke <[EMAIL PROTECTED]> > > wrote: > > > wouldsomebody explain me the serio interface or give me a code link for > > > very simple example. > > > > What do you want to do with it? Do you want on the serial port side, > > or on the mouse/keyboard/gadget side? See for example the various > > serial keyboards and mice drivers. > > I want on the kernelside process data from first uart-hardware interface > aka ttyS0. > > I don't understand the structure of e.g. input/mouse/sermouse.c > > where is said, which hardware is used for reading data from? I'm not entirely sure, but I guess that most of the time, you assign a serial port with the help of `inputattach' to a given device driver, which expects to find its hardware on that port. OTOH, why do you want to do the serial stuff in kernel land? Isn't it a *lot* easier to do it in userspace? What's your specific device you want to work on? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Eine Freie Meinung in einem Freien Kopf the second : für einen Freien Staat voll Freier Bürger. signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 11:11:23 +0200, Lars K.W. Gohlke <[EMAIL PROTECTED]> wrote: > wouldsomebody explain me the serio interface or give me a code link for > very simple example. What do you want to do with it? Do you want on the serial port side, or on the mouse/keyboard/gadget side? See for example the various serial keyboards and mice drivers. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 11:11:23 +0200, Lars K.W. Gohlke [EMAIL PROTECTED] wrote: wouldsomebody explain me the serio interface or give me a code link for very simple example. What do you want to do with it? Do you want on the serial port side, or on the mouse/keyboard/gadget side? See for example the various serial keyboards and mice drivers. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 11:34:49 +0200, Lars K.W. Gohlke [EMAIL PROTECTED] wrote: Jan-Benedict Glaw schrieb: On Wed, 2007-06-06 11:11:23 +0200, Lars K.W. Gohlke [EMAIL PROTECTED] wrote: wouldsomebody explain me the serio interface or give me a code link for very simple example. What do you want to do with it? Do you want on the serial port side, or on the mouse/keyboard/gadget side? See for example the various serial keyboards and mice drivers. I want on the kernelside process data from first uart-hardware interface aka ttyS0. I don't understand the structure of e.g. input/mouse/sermouse.c where is said, which hardware is used for reading data from? I'm not entirely sure, but I guess that most of the time, you assign a serial port with the help of `inputattach' to a given device driver, which expects to find its hardware on that port. OTOH, why do you want to do the serial stuff in kernel land? Isn't it a *lot* easier to do it in userspace? What's your specific device you want to work on? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Eine Freie Meinung in einem Freien Kopf the second : für einen Freien Staat voll Freier Bürger. signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 12:39:17 +0200, Lars K.W. Gohlke [EMAIL PROTECTED] wrote: Jan-Benedict Glaw schrieb: OTOH, why do you want to do the serial stuff in kernel land? Isn't it a *lot* easier to do it in userspace? What's your specific device you want to work on? [snip] You didn't actually answer any of my questions. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: really soon now: an unspecified period of time, likly to the second : be greater than any reasonable definition of soon. signature.asc Description: Digital signature
Re: serio interface
On Wed, 2007-06-06 12:52:13 +0200, Lars K.W. Gohlke [EMAIL PROTECTED] wrote: Jan-Benedict Glaw schrieb: On Wed, 2007-06-06 12:39:17 +0200, Lars K.W. Gohlke [EMAIL PROTECTED] wrote: Jan-Benedict Glaw schrieb: OTOH, why do you want to do the serial stuff in kernel land? Isn't it a *lot* easier to do it in userspace? What's your specific device you want to work on? You didn't actually answer any of my questions. sorry. I want to use the interface aka /dev/ttyS0. I want to process data inside of a kernel module to provide it /proc (done) or as own char-dev (done). but I can not grab the data. It is part of my project in my studies. It is more a conceptual work, but important. I want to release a howto, when I complete. You still answer unasked questions. Please answer inline: * Why do you wanto to do the serial stuff in kernel land? * Isn't it easier to do it in userspace? * What specific device do you work on? * New: Is it a wise idea to do it in kernel land? The /proc filesystem has been somewhat obsoleted in favour of sysfs for device/driver information. -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: ...und wenn Du denkst, es geht nicht mehr, the second : kommt irgendwo ein Lichtlein her. signature.asc Description: Digital signature
Re: LogFS take four
On Sun, 2007-06-03 20:38:46 +0200, Jörn Engel <[EMAIL PROTECTED]> wrote:
> This round the patch is split into file-sized hunks. There actually
> seem to be kernel developers not manly enough to digest 6000+ lines of
> code at once. An I thought I was the only wimp around.
Though it would be nice to have them as a pile of patches so that
after applying them one-by-one, the kernel still compiles.
Eg. if the first patches wire up the new feature into the build
system, but the actual .c file aren't yet there, that won't compile
and thus make git-bisect'ing harder...
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Alles wird gut! ...und heute wirds schon ein bißchen
besser.
the second :
signature.asc
Description: Digital signature
Re: LogFS take four
On Sun, 2007-06-03 20:38:46 +0200, Jörn Engel [EMAIL PROTECTED] wrote: This round the patch is split into file-sized hunks. There actually seem to be kernel developers not manly enough to digest 6000+ lines of code at once. An I thought I was the only wimp around. Though it would be nice to have them as a pile of patches so that after applying them one-by-one, the kernel still compiles. Eg. if the first patches wire up the new feature into the build system, but the actual .c file aren't yet there, that won't compile and thus make git-bisect'ing harder... MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser. the second : signature.asc Description: Digital signature
Re: [RFC] - LXR on kernel.org ? was: Re: What tools to use?
On Fri, 2007-05-11 10:06:17 +0200, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Jesper Juhl wrote: > > On 10/05/07, Shahbaz Khan <[EMAIL PROTECTED]> wrote: > > > All the experts on this list plz let me know of any good cross > > > referencing tool for source code navigation. I have tried LXR but its > > > not easy to configure for a rookie like me. Anyother as good as LXR? > > > > > lxr is pretty good (glimpse on its own as well can be useful). If you > > don't want to set it up yourself, then you could consider to use the > > online version at http://lxr.linux.no/ One "problem" with lxr.linux.no is that it's only updated from time to time. Maximilian Wilhelm and I added some preliminary GIT support to LXR, and we're working on a patch to present the list of versions as drop-down boxes (instead of a long link list.) This should allow to index all and any tagged versions of the Linux kernel and present them. However, I don't have a box that's equipped properly (HDD, CPU as well as network connectivity) to offer such a setup, but I'd help in setting it up if somebody provides the machine! > > Another good thing is "make ctags" in the kernel source dir - this > > will let you quickly jump to declarations etc and back with a few > > simple keystrokes in editors like vim. > > http://www.faqs.org/docs/ldev/0130091154_64.htm > > http://applications.linux.com/article.pl?sid=07/01/22/167212=13=47 > > http://cscope.sourceforge.net/cscope_vim_tutorial.html > > > > "make cscope" is another good option. It'll generate an index usable > > by the cscope tool (http://cscope.sourceforge.net/). > > I like lxr pretty much. > i`m not a programmer, but i often need some information on "what`s > the driver version of xyz in latest kernel" or "was this or that > feature/patch already being merged" or "i have this line of code > in kernel - how does it look in recent kernel , did it change " ? You can easily get this information from http://git.kernel.org/git . > why not adding a link to every kernel an kernel.org kernel, > pointing to recent lxr`ed kernel source - or - even better - > make lxr`ed kernel source part of kernel.org (so we > have "B V VI C Changelog LXR" ) ? I'd support the idea, but somebody needs to offer a machine or two and enough bandwidth. (Though I hope that it's used rarely enough so that only one machine is needed.) > sure, i know kernel.org itself is very busy, but maybe this can > be done via dedicated lxr machine/webserver someone is willing > to donate !? There's *no* way to add this to the current kernel.org machines. There's quite some DB access during indexing, and making up the sources on request takes some CPU cycles, too. > for myself, i would happily donate some bucks for this. As I said: If you manage to prepare the box, I'll offer to do the LXR setup and automate the indexing. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
Re: [RFC] - LXR on kernel.org ? was: Re: What tools to use?
On Fri, 2007-05-11 10:06:17 +0200, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Jesper Juhl jesper.juhl () gmail ! com wrote: On 10/05/07, Shahbaz Khan [EMAIL PROTECTED] wrote: All the experts on this list plz let me know of any good cross referencing tool for source code navigation. I have tried LXR but its not easy to configure for a rookie like me. Anyother as good as LXR? lxr is pretty good (glimpse on its own as well can be useful). If you don't want to set it up yourself, then you could consider to use the online version at http://lxr.linux.no/ One problem with lxr.linux.no is that it's only updated from time to time. Maximilian Wilhelm and I added some preliminary GIT support to LXR, and we're working on a patch to present the list of versions as drop-down boxes (instead of a long link list.) This should allow to index all and any tagged versions of the Linux kernel and present them. However, I don't have a box that's equipped properly (HDD, CPU as well as network connectivity) to offer such a setup, but I'd help in setting it up if somebody provides the machine! Another good thing is make ctags in the kernel source dir - this will let you quickly jump to declarations etc and back with a few simple keystrokes in editors like vim. http://www.faqs.org/docs/ldev/0130091154_64.htm http://applications.linux.com/article.pl?sid=07/01/22/167212tid=13tid=47 http://cscope.sourceforge.net/cscope_vim_tutorial.html make cscope is another good option. It'll generate an index usable by the cscope tool (http://cscope.sourceforge.net/). I like lxr pretty much. i`m not a programmer, but i often need some information on what`s the driver version of xyz in latest kernel or was this or that feature/patch already being merged or i have this line of code in kernel - how does it look in recent kernel , did it change ? You can easily get this information from http://git.kernel.org/git . why not adding a link to every kernel an kernel.org kernel, pointing to recent lxr`ed kernel source - or - even better - make lxr`ed kernel source part of kernel.org (so we have B V VI C Changelog LXR ) ? I'd support the idea, but somebody needs to offer a machine or two and enough bandwidth. (Though I hope that it's used rarely enough so that only one machine is needed.) sure, i know kernel.org itself is very busy, but maybe this can be done via dedicated lxr machine/webserver someone is willing to donate !? There's *no* way to add this to the current kernel.org machines. There's quite some DB access during indexing, and making up the sources on request takes some CPU cycles, too. for myself, i would happily donate some bucks for this. As I said: If you manage to prepare the box, I'll offer to do the LXR setup and automate the indexing. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second : signature.asc Description: Digital signature
Re: mkfs.ext2 triggerd RAM corruption
On Fri, 2007-05-04 16:59:51 +0200, Bernd Schubert <[EMAIL PROTECTED]> wrote: > To see whats going on, I copied the entire / (so the initrd) into a tmpfs > root, chrooted into it, also bind mounted the main / into this chroot and > compared several times /bin of chroot/bin and the bind-mounted /bin while the > mkfs.ext2 command was running. > > beo-05:/# diff -r /bin /oldroot/bin/ > beo-05:/# diff -r /bin /oldroot/bin/ > beo-05:/# diff -r /bin /oldroot/bin/ > Binary files /bin/sleep and /oldroot/bin/sleep differ > beo-05:/# diff -r /bin /oldroot/bin/ > Binary files /bin/bsd-csh and /oldroot/bin/bsd-csh differ > Binary files /bin/cat and /oldroot/bin/cat differ > ... > > Also tested different schedulers, at least happens with deadline and > anticipatory. > > The corruption does NOT happen on running the mkfs command on /dev/sda1, but > happens with sda2, sda3 and sda3. Also doesn't happen with extended > partitions of sda1. Is sda2 the largest filesystem out of sda2, sda3 (and the logical partitions within the extended sda1, if these get mkfs'ed, too)? I'm not too sure that this is a kernel bug, but probably a bad RAM chip. Did you run memtest86 for a while? ...and can you reproduce this problem on different machines? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : signature.asc Description: Digital signature
Re: mkfs.ext2 triggerd RAM corruption
On Fri, 2007-05-04 16:59:51 +0200, Bernd Schubert [EMAIL PROTECTED] wrote: To see whats going on, I copied the entire / (so the initrd) into a tmpfs root, chrooted into it, also bind mounted the main / into this chroot and compared several times /bin of chroot/bin and the bind-mounted /bin while the mkfs.ext2 command was running. beo-05:/# diff -r /bin /oldroot/bin/ beo-05:/# diff -r /bin /oldroot/bin/ beo-05:/# diff -r /bin /oldroot/bin/ Binary files /bin/sleep and /oldroot/bin/sleep differ beo-05:/# diff -r /bin /oldroot/bin/ Binary files /bin/bsd-csh and /oldroot/bin/bsd-csh differ Binary files /bin/cat and /oldroot/bin/cat differ ... Also tested different schedulers, at least happens with deadline and anticipatory. The corruption does NOT happen on running the mkfs command on /dev/sda1, but happens with sda2, sda3 and sda3. Also doesn't happen with extended partitions of sda1. Is sda2 the largest filesystem out of sda2, sda3 (and the logical partitions within the extended sda1, if these get mkfs'ed, too)? I'm not too sure that this is a kernel bug, but probably a bad RAM chip. Did you run memtest86 for a while? ...and can you reproduce this problem on different machines? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : signature.asc Description: Digital signature
Re: about linux console and printk
On Wed, 2007-04-25 22:22:22 +0800, Shan, Guo Wen (Gavin) <[EMAIL PROTECTED]> wrote: > The linux could support several console driver at same time? If so, > what I need to do is call register_console() for several times? Did you try that? Have you read through the register_console() code as well as printk() and how it actually outputs its output? MfG, JBG PS: netdev no longer Cc'ed. It's not a networking topic. -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: about linux console and printk
On Wed, 2007-04-25 22:22:22 +0800, Shan, Guo Wen (Gavin) [EMAIL PROTECTED] wrote: The linux could support several console driver at same time? If so, what I need to do is call register_console() for several times? Did you try that? Have you read through the register_console() code as well as printk() and how it actually outputs its output? MfG, JBG PS: netdev no longer Cc'ed. It's not a networking topic. -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: [PATCH] add two SCSI command opcodes
On Thu, 2007-04-19 18:10:54 +0300, Dan Aloni <[EMAIL PROTECTED]> wrote: > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > index 5c0e979..dff842a 100644 > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -103,6 +103,7 @@ extern const unsigned char scsi_command_size[8]; > #define READ_12 0xa8 > #define WRITE_12 0xaa > #define WRITE_VERIFY_12 0xae > +#define VERIFY_12 0xaf > #define SEARCH_HIGH_120xb0 > #define SEARCH_EQUAL_12 0xb1 > #define SEARCH_LOW_12 0xb2 > @@ -111,6 +112,7 @@ extern const unsigned char scsi_command_size[8]; > #define WRITE_LONG_2 0xea > #define READ_16 0x88 > #define WRITE_16 0x8a > +#define WRITE_VERIFY_16 0x8e > #define VERIFY_16 0x8f > #define SERVICE_ACTION_IN 0x9e > /* values for service action in */ Where's the user? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Zensur im Internet? Nein danke! the second : signature.asc Description: Digital signature
Re: [PATCH] add two SCSI command opcodes
On Thu, 2007-04-19 18:10:54 +0300, Dan Aloni [EMAIL PROTECTED] wrote: diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h index 5c0e979..dff842a 100644 --- a/include/scsi/scsi.h +++ b/include/scsi/scsi.h @@ -103,6 +103,7 @@ extern const unsigned char scsi_command_size[8]; #define READ_12 0xa8 #define WRITE_12 0xaa #define WRITE_VERIFY_12 0xae +#define VERIFY_12 0xaf #define SEARCH_HIGH_120xb0 #define SEARCH_EQUAL_12 0xb1 #define SEARCH_LOW_12 0xb2 @@ -111,6 +112,7 @@ extern const unsigned char scsi_command_size[8]; #define WRITE_LONG_2 0xea #define READ_16 0x88 #define WRITE_16 0x8a +#define WRITE_VERIFY_16 0x8e #define VERIFY_16 0x8f #define SERVICE_ACTION_IN 0x9e /* values for service action in */ Where's the user? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Zensur im Internet? Nein danke! the second : signature.asc Description: Digital signature
Re: [PATCH] HPA support: Revised patch
On Thu, 2007-04-05 14:13:52 +0100, Alan Cox <[EMAIL PROTECTED]> wrote: > diff -u --new-file --recursive --exclude-from /usr/src/exclude > linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c > linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c > --- linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c2007-04-03 > 16:56:32.0 +0100 > +++ linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c2007-04-03 > 17:08:28.0 +0100 > @@ -90,6 +90,10 @@ > module_param_named(fua, libata_fua, int, 0444); > MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on)"); > > +static int ata_ignore_hpa = 0; > +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); > +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)"); > + > static int ata_probe_timeout = ATA_TMOUT_INTERNAL / HZ; > module_param(ata_probe_timeout, int, 0444); > MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout (seconds)"); For ignore_hpa, it would be nice to not go through inverse logic and fix the help text a bit (0=honor HPA, 1=ignore HPA). MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: [PATCH] HPA support: Revised patch
On Thu, 2007-04-05 14:13:52 +0100, Alan Cox [EMAIL PROTECTED] wrote: diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c --- linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c2007-04-03 16:56:32.0 +0100 +++ linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c2007-04-03 17:08:28.0 +0100 @@ -90,6 +90,10 @@ module_param_named(fua, libata_fua, int, 0444); MODULE_PARM_DESC(fua, FUA support (0=off, 1=on)); +static int ata_ignore_hpa = 0; +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); +MODULE_PARM_DESC(ignore_hpa, Ignore HPA (0=off 1=on)); + static int ata_probe_timeout = ATA_TMOUT_INTERNAL / HZ; module_param(ata_probe_timeout, int, 0444); MODULE_PARM_DESC(ata_probe_timeout, Set ATA probing timeout (seconds)); For ignore_hpa, it would be nice to not go through inverse logic and fix the help text a bit (0=honor HPA, 1=ignore HPA). MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html the second : signature.asc Description: Digital signature
Re: [PATCH] Complain about missing system calls.
On Fri, 2007-03-09 20:00:51 +0100, Andi Kleen <[EMAIL PROTECTED]> wrote: > > Not everybody has a simple indexed list of pointers :) For example, > > for vax-linux, we use a struct per syscall with the expected number of > > on-stack longwords for the call. > > > > So if something "new" is coming up, please keep in mind that it should > > be flexible enough to represent that. :) > > Are there plans to merge vax any time soon to mainline? Well... That depends :) For now, I'd prefer to stay out of mainline, until we're having gcc-trunk with a current GNU libc up'n'running. Until then, I plan to at least break the complete ABI once (drop old syscals and _only_ wire up their modern counterparts.) > Normally we don't care very much about out of tree code, especially > if it adds complexity like this. Sure, but at least mentioning that there's more than only a simple table of function pointers may or may not help to *plan* the code to fit future needs. > But I suspect s390 would need number of arguments anyways. Any they're already merged. Yay :) MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature
Re: [PATCH] Complain about missing system calls.
On Fri, 2007-03-09 17:11:10 +0100, Andi Kleen <[EMAIL PROTECTED]> wrote: > David Woodhouse <[EMAIL PROTECTED]> writes: > > Most system calls seem to get added to i386 first. This patch > > automatically generates a warning for any new system call which is > > implemented on i386 but not the architecture currently being compiled. > > On PowerPC at the moment, for example, it results in these warnings: > > init/missing_syscalls.h:935:3: warning: #warning syscall sync_file_range > > not implemented > > init/missing_syscalls.h:947:3: warning: #warning syscall getcpu not > > implemented > > init/missing_syscalls.h:950:3: warning: #warning syscall epoll_pwait not > > implemented > > I think a better solution would be to finally switch to auto generated > system call tables for newer system calls. The original reason why the > architectures have different system call numbers -- compatibility with > another "native" Unix -- is completely obsolete now. This leaves only > minor differences of compat stub vs non compat stub and a few > architecture specific calls. > > Of course the existing syscall numbers can't be changed, but for all new > calls one could just add automatically for everybody. > > A global table with two entries (compat and non compat) and a per arch > override table should be sufficient. Not everybody has a simple indexed list of pointers :) For example, for vax-linux, we use a struct per syscall with the expected number of on-stack longwords for the call. So if something "new" is coming up, please keep in mind that it should be flexible enough to represent that. :) MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: "really soon now": an unspecified period of time, likly to the second : be greater than any reasonable definition of "soon". signature.asc Description: Digital signature
Re: [PATCH] Complain about missing system calls.
On Fri, 2007-03-09 17:11:10 +0100, Andi Kleen [EMAIL PROTECTED] wrote: David Woodhouse [EMAIL PROTECTED] writes: Most system calls seem to get added to i386 first. This patch automatically generates a warning for any new system call which is implemented on i386 but not the architecture currently being compiled. On PowerPC at the moment, for example, it results in these warnings: init/missing_syscalls.h:935:3: warning: #warning syscall sync_file_range not implemented init/missing_syscalls.h:947:3: warning: #warning syscall getcpu not implemented init/missing_syscalls.h:950:3: warning: #warning syscall epoll_pwait not implemented I think a better solution would be to finally switch to auto generated system call tables for newer system calls. The original reason why the architectures have different system call numbers -- compatibility with another native Unix -- is completely obsolete now. This leaves only minor differences of compat stub vs non compat stub and a few architecture specific calls. Of course the existing syscall numbers can't be changed, but for all new calls one could just add automatically for everybody. A global table with two entries (compat and non compat) and a per arch override table should be sufficient. Not everybody has a simple indexed list of pointers :) For example, for vax-linux, we use a struct per syscall with the expected number of on-stack longwords for the call. So if something new is coming up, please keep in mind that it should be flexible enough to represent that. :) MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: really soon now: an unspecified period of time, likly to the second : be greater than any reasonable definition of soon. signature.asc Description: Digital signature
Re: [PATCH] Complain about missing system calls.
On Fri, 2007-03-09 20:00:51 +0100, Andi Kleen [EMAIL PROTECTED] wrote: Not everybody has a simple indexed list of pointers :) For example, for vax-linux, we use a struct per syscall with the expected number of on-stack longwords for the call. So if something new is coming up, please keep in mind that it should be flexible enough to represent that. :) Are there plans to merge vax any time soon to mainline? Well... That depends :) For now, I'd prefer to stay out of mainline, until we're having gcc-trunk with a current GNU libc up'n'running. Until then, I plan to at least break the complete ABI once (drop old syscals and _only_ wire up their modern counterparts.) Normally we don't care very much about out of tree code, especially if it adds complexity like this. Sure, but at least mentioning that there's more than only a simple table of function pointers may or may not help to *plan* the code to fit future needs. But I suspect s390 would need number of arguments anyways. Any they're already merged. Yay :) MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Wenn ich wach bin, träume ich. the second : signature.asc Description: Digital signature
Re: GPL vs non-GPL device drivers
On Tue, 2007-02-20 15:36:56 +0100, Helge Hafting <[EMAIL PROTECTED]> wrote: > If you have a need for "secret" source code, stuff most of it > in userspace. Make the drivers truly minimal; perhaps their > open/closed status won't matter that much when the bulk > of the code and the cleverness is kept safe in userspace. > > Note that keeping drivers small this way is the recommended > way of working anyway. It isn't merely a way to keep your > code away from the GPL - you always want a small kernel. Keeping the legal stuff out of sight for a second, this'll solve the "problem" for the embedded developer, but surely not for the Linux community. Would you ever expect that eg. the thin GPL layer used by ATI/NVidia would be merged iff the rest would run in userland? It's just a workaround for the linking-the-object-file-into-the-kernel-image problem, but after all, it doesn't lead to a working driver being freely available. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:If it doesn't work, force it. the second : If it breaks, it needed replacing anyway. signature.asc Description: Digital signature
Re: GPL vs non-GPL device drivers
On Tue, 2007-02-20 15:36:56 +0100, Helge Hafting [EMAIL PROTECTED] wrote: If you have a need for secret source code, stuff most of it in userspace. Make the drivers truly minimal; perhaps their open/closed status won't matter that much when the bulk of the code and the cleverness is kept safe in userspace. Note that keeping drivers small this way is the recommended way of working anyway. It isn't merely a way to keep your code away from the GPL - you always want a small kernel. Keeping the legal stuff out of sight for a second, this'll solve the problem for the embedded developer, but surely not for the Linux community. Would you ever expect that eg. the thin GPL layer used by ATI/NVidia would be merged iff the rest would run in userland? It's just a workaround for the linking-the-object-file-into-the-kernel-image problem, but after all, it doesn't lead to a working driver being freely available. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of:If it doesn't work, force it. the second : If it breaks, it needed replacing anyway. signature.asc Description: Digital signature
Re: xfs internal error on a new filesystem
On Wed, 2007-02-14 10:24:27 +, Ramy M. Hassan <[EMAIL PROTECTED]> wrote: > Feb 14 08:28:52 info6 kernel: [238186.945610] Filesystem "sdd8": Corruption > of in-memory data detected. Shutting down filesystem: sdd8 [...] > We are wondering here if this problem is an indicator to data corruption on > disk ? is it really necessary to run xfs_repair ? Do u recommend that we > switch back to reiserfs ? Could it be a hardware related problems ? any > clues how to verify that ? Running memtest86 for some hours could at least help to verify that you don't see bad memory... MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: 23:53 <@jbglaw> So, ich kletter' jetzt mal ins Bett. the second : 23:57 <@jever2> .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?) 00:00 <@jbglaw> jever2: *patsch* 00:01 <@jever2> *aua*, wofür, Gedanken sind frei! 00:02 <@jbglaw> Nee, freie Gedanken, die sind seit 1984 doch aus! 00:03 <@jever2> 1984? ich bin erst seit 1985 verheiratet! signature.asc Description: Digital signature
Re: xfs internal error on a new filesystem
On Wed, 2007-02-14 10:24:27 +, Ramy M. Hassan [EMAIL PROTECTED] wrote: Feb 14 08:28:52 info6 kernel: [238186.945610] Filesystem sdd8: Corruption of in-memory data detected. Shutting down filesystem: sdd8 [...] We are wondering here if this problem is an indicator to data corruption on disk ? is it really necessary to run xfs_repair ? Do u recommend that we switch back to reiserfs ? Could it be a hardware related problems ? any clues how to verify that ? Running memtest86 for some hours could at least help to verify that you don't see bad memory... MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: 23:53 @jbglaw So, ich kletter' jetzt mal ins Bett. the second : 23:57 @jever2 .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?) 00:00 @jbglaw jever2: *patsch* 00:01 @jever2 *aua*, wofür, Gedanken sind frei! 00:02 @jbglaw Nee, freie Gedanken, die sind seit 1984 doch aus! 00:03 @jever2 1984? ich bin erst seit 1985 verheiratet! signature.asc Description: Digital signature
Re: [PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)
On Wed, 2007-02-07 10:23:46 +, Richard Purdie <[EMAIL PROTECTED]> wrote: > On Tue, 2007-02-06 at 20:52 -0800, Andrew Morton wrote: > > On Tue, 06 Feb 2007 16:42:39 + Richard Purdie <[EMAIL PROTECTED]> wrote: > --- linux.orig/drivers/input/tsdev.c 2007-01-18 00:52:44.0 + > +++ linux/drivers/input/tsdev.c 2007-02-07 09:32:15.0 + > @@ -151,6 +151,10 @@ static int tsdev_open(struct inode *inod > int i = iminor(inode) - TSDEV_MINOR_BASE; > struct tsdev_list *list; > > + printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled " > + "for removal.\nSee Documentation/feature-removal-schedule.txt " > + "for details.\n"); > + > if (i >= TSDEV_MINORS || !tsdev_table[i & TSDEV_MINOR_MASK]) > return -ENODEV; > What about a hugh annoying mdelay()? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: 23:53 <@jbglaw> So, ich kletter' jetzt mal ins Bett. the second : 23:57 <@jever2> .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?) 00:00 <@jbglaw> jever2: *patsch* 00:01 <@jever2> *aua*, wofür, Gedanken sind frei! 00:02 <@jbglaw> Nee, freie Gedanken, die sind seit 1984 doch aus! 00:03 <@jever2> 1984? ich bin erst seit 1985 verheiratet! signature.asc Description: Digital signature
Re: [PATCH] input: Schedule removal of compaq touchscreen emulation (tsdev.c)
On Wed, 2007-02-07 10:23:46 +, Richard Purdie [EMAIL PROTECTED] wrote: On Tue, 2007-02-06 at 20:52 -0800, Andrew Morton wrote: On Tue, 06 Feb 2007 16:42:39 + Richard Purdie [EMAIL PROTECTED] wrote: --- linux.orig/drivers/input/tsdev.c 2007-01-18 00:52:44.0 + +++ linux/drivers/input/tsdev.c 2007-02-07 09:32:15.0 + @@ -151,6 +151,10 @@ static int tsdev_open(struct inode *inod int i = iminor(inode) - TSDEV_MINOR_BASE; struct tsdev_list *list; + printk(KERN_WARNING tsdev (compaq touchscreen emulation) is scheduled + for removal.\nSee Documentation/feature-removal-schedule.txt + for details.\n); + if (i = TSDEV_MINORS || !tsdev_table[i TSDEV_MINOR_MASK]) return -ENODEV; What about a hugh annoying mdelay()? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: 23:53 @jbglaw So, ich kletter' jetzt mal ins Bett. the second : 23:57 @jever2 .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?) 00:00 @jbglaw jever2: *patsch* 00:01 @jever2 *aua*, wofür, Gedanken sind frei! 00:02 @jbglaw Nee, freie Gedanken, die sind seit 1984 doch aus! 00:03 @jever2 1984? ich bin erst seit 1985 verheiratet! signature.asc Description: Digital signature
Re: Free Linux Driver Development!
On Wed, 2007-01-31 22:56:03 +0100, Willy Tarreau <[EMAIL PROTECTED]> wrote: > On Wed, Jan 31, 2007 at 10:13:12PM +0100, Jan-Benedict Glaw wrote: > > On Tue, 2007-01-30 21:23:34 +0100, Diego Calleja <[EMAIL PROTECTED]> wrote: > > > El Tue, 30 Jan 2007 20:31:01 +0100 (MET), Jan Engelhardt <[EMAIL > > > PROTECTED]> escribió: > > > > Don't they claim 50+? Already browsing > > > > ftp://ftp.de.netbsd.org/pub/NetBSD/NetBSD-3.1 gives more than 2 > > > > screenfuls [à 25]. > > > > > > Sure, Linux doesn't support vax and the like, but it does support lots of > > > architectures that matter. In http://netbsd.org/Ports/#ports-by-cpu > > > there's a > > > > Well, there *is* a 2.6.x based VAX port, though it needs some updates > > to incorporate the last few months of upstream development. But NetBSD > > still does better hardware support. > > a few years ago, I installed NetBSD 1.6 on my VLC4000. It hanged every now > and then (several times a month). I finally tried OpenBSD 3.1 and it never > hanged nor crashed since. It's been running 3.7 fine from its release till > now. I don't know if NetBSD's VAX support has stabilized now, but I thought > it might be of interest to you to be aware that at least another OS runs > fine on this hardware. Already knew that :) There isn't much traffic on the VAX related development lists (neither for *BSD not for Linux), but things are slowly progressing. These days, we try to work together (eg. we wrote a graphics driver or two together, after we disassembled the machine's ROMs.) So unfortunately the userbase is small, but we perfectly work together. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: The real problem with C++ for kernel modules is: the second : the language just sucks. -- Linus Torvalds signature.asc Description: Digital signature
Re: Rewriting floppy.c was Re: Free Linux Driver Development!
On Wed, 2007-01-31 19:24:54 +0100, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > How much different hardware does the (old)floppy.c do? I imagine that > today, where floppies phase out, there will be, in descending order: > > * USB floppy drives (atm handled by sd.c, could be better to have sf.c) > * FDCs on mainboards > * 1.44M drives > * 1.2M drives > > Even a working 2.88M, as cool as it sounds, never landed in my hands ever > since I've been into computing. Perhaps the oldest, smallest disk I once I do own a machine that has one :) Those original IBM PS/2 machines had them. On the other hand, Linux' floppy.c could do a bit better to help archiveing some of the scurrile floppy formats. There is at least one floppy imaging project to store floppy images for uncommon formats. It would be nice it the Linux driver could handle something like that... MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser. the second : signature.asc Description: Digital signature
Re: Free Linux Driver Development!
On Tue, 2007-01-30 21:23:34 +0100, Diego Calleja <[EMAIL PROTECTED]> wrote: > El Tue, 30 Jan 2007 20:31:01 +0100 (MET), Jan Engelhardt <[EMAIL PROTECTED]> > escribió: > > Don't they claim 50+? Already browsing > > ftp://ftp.de.netbsd.org/pub/NetBSD/NetBSD-3.1 gives more than 2 > > screenfuls [à 25]. > > Sure, Linux doesn't support vax and the like, but it does support lots of > architectures that matter. In http://netbsd.org/Ports/#ports-by-cpu there's a Well, there *is* a 2.6.x based VAX port, though it needs some updates to incorporate the last few months of upstream development. But NetBSD still does better hardware support. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://www.eyrie.org/~eagle/faqs/questions.html the second : signature.asc Description: Digital signature
Re: Free Linux Driver Development!
On Tue, 2007-01-30 21:23:34 +0100, Diego Calleja [EMAIL PROTECTED] wrote: El Tue, 30 Jan 2007 20:31:01 +0100 (MET), Jan Engelhardt [EMAIL PROTECTED] escribió: Don't they claim 50+? Already browsing ftp://ftp.de.netbsd.org/pub/NetBSD/NetBSD-3.1 gives more than 2 screenfuls [à 25]. Sure, Linux doesn't support vax and the like, but it does support lots of architectures that matter. In http://netbsd.org/Ports/#ports-by-cpu there's a Well, there *is* a 2.6.x based VAX port, though it needs some updates to incorporate the last few months of upstream development. But NetBSD still does better hardware support. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: http://www.eyrie.org/~eagle/faqs/questions.html the second : signature.asc Description: Digital signature
Re: Rewriting floppy.c was Re: Free Linux Driver Development!
On Wed, 2007-01-31 19:24:54 +0100, Jan Engelhardt [EMAIL PROTECTED] wrote: How much different hardware does the (old)floppy.c do? I imagine that today, where floppies phase out, there will be, in descending order: * USB floppy drives (atm handled by sd.c, could be better to have sf.c) * FDCs on mainboards * 1.44M drives * 1.2M drives Even a working 2.88M, as cool as it sounds, never landed in my hands ever since I've been into computing. Perhaps the oldest, smallest disk I once I do own a machine that has one :) Those original IBM PS/2 machines had them. On the other hand, Linux' floppy.c could do a bit better to help archiveing some of the scurrile floppy formats. There is at least one floppy imaging project to store floppy images for uncommon formats. It would be nice it the Linux driver could handle something like that... MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser. the second : signature.asc Description: Digital signature
Re: Free Linux Driver Development!
On Wed, 2007-01-31 22:56:03 +0100, Willy Tarreau [EMAIL PROTECTED] wrote: On Wed, Jan 31, 2007 at 10:13:12PM +0100, Jan-Benedict Glaw wrote: On Tue, 2007-01-30 21:23:34 +0100, Diego Calleja [EMAIL PROTECTED] wrote: El Tue, 30 Jan 2007 20:31:01 +0100 (MET), Jan Engelhardt [EMAIL PROTECTED] escribió: Don't they claim 50+? Already browsing ftp://ftp.de.netbsd.org/pub/NetBSD/NetBSD-3.1 gives more than 2 screenfuls [à 25]. Sure, Linux doesn't support vax and the like, but it does support lots of architectures that matter. In http://netbsd.org/Ports/#ports-by-cpu there's a Well, there *is* a 2.6.x based VAX port, though it needs some updates to incorporate the last few months of upstream development. But NetBSD still does better hardware support. a few years ago, I installed NetBSD 1.6 on my VLC4000. It hanged every now and then (several times a month). I finally tried OpenBSD 3.1 and it never hanged nor crashed since. It's been running 3.7 fine from its release till now. I don't know if NetBSD's VAX support has stabilized now, but I thought it might be of interest to you to be aware that at least another OS runs fine on this hardware. Already knew that :) There isn't much traffic on the VAX related development lists (neither for *BSD not for Linux), but things are slowly progressing. These days, we try to work together (eg. we wrote a graphics driver or two together, after we disassembled the machine's ROMs.) So unfortunately the userbase is small, but we perfectly work together. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: The real problem with C++ for kernel modules is: the second : the language just sucks. -- Linus Torvalds signature.asc Description: Digital signature
Re: two architectures,same source tree
On Wed, 2006-12-20 20:32:20 +0200, Yakov Lerner <[EMAIL PROTECTED]> wrote:
> Is it easily possible to build two architectures in
> the same source tree (so that intermediate fles
> and resut files do not interfere ) ?
Sure. Use a common source tree and two separate output directories.
You can set these with O=/path/to/output, but you need to do that
during *any* make calls, eg. already for make oldconfig/menuconfig.
MfG, JBG
--
Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481
Signature of: Friends are relatives you make for yourself.
the second :
signature.asc
Description: Digital signature
Re: two architectures,same source tree
On Wed, 2006-12-20 20:32:20 +0200, Yakov Lerner [EMAIL PROTECTED] wrote: Is it easily possible to build two architectures in the same source tree (so that intermediate fles and resut files do not interfere ) ? Sure. Use a common source tree and two separate output directories. You can set these with O=/path/to/output, but you need to do that during *any* make calls, eg. already for make oldconfig/menuconfig. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : signature.asc Description: Digital signature
Re: Segmentation fault on modprobe depca
On Mon, 2006-12-11 12:06:08 +0100, Tom Kerremans <[EMAIL PROTECTED]> wrote: > I 'm the maintainter of Trinity Rescue Kit (http://trinityhome.org/trk) , > a live rescue distribution that tries (amongst many other features) to be > as generic as possible in terms of hardware detection. Therefore I include > all network and disk controller drivers in the kernel or as module. > I recently tried kernel 2.6.19 and stumbled upon the fact that the module > DEPCA seems to be broken. When I compile it in the kernel, the kernel > crashes at boot time. Compiled as module it creates a segmentation fault > on modprobe. > I 've tested compilation on two different systems: first is my TRK > workbench, which is a Mandriva 2005 with gcc 3.4.3-7mdk and > module-init-tools 3.0 (later upgraded to 3.2.2, recompiled kernel, but > same result). The other system I compiled and tried it on is an > out-of-the-box Mandriva 2007, which is quite new and has more recent > compilers and libraries. The result was the same. > When I do a "modprobe depca", even though there is no hardware that could > use this module (it 's for old DEC nics..), I get the following output: > > [EMAIL PROTECTED] ~]# modprobe depca > Segmentation fault > [EMAIL PROTECTED] ~]# Please use `dmesg' the next time to generate output and don't cut'n'paste it if this adds extra \n into the output. Just reworked your stuff to get it remotely readable: Kernel BUG at [verbose debug info unavailable] invalid opcode: [#1] CPU:0 EIP:0060:[]Not tainted VLI EFLAGS: 00010006 (2.6.19 #2) EIP is at kfree+0x32/0x59 eax: ef632674 ebx: f64f7800 ecx: f64f7870 edx: c180 esi: 0206 edi: 0300 ebp: ea4a5e1c esp: ea4a5e10 ds: 007b es: 007b ss: 0068 Process modprobe (pid: 26866, ti=ea4a4000 task=c1a74a70 task.ti=ea4a4000) Stack: f64f7800 f64f7870 c0552580 ea4a5e2c c0279ecc 0300 c05525dc ea4a5e44 c0275ccf f64f7808 ea4a5e44 c0275de3 f64f7870 ea4a5e60 c020d3a2 f64f7870 c05528c8 f64f7888 c020d3c9 ea4a5e6c c020d3dd f64f7870 ea4a5e8c Call Trace: [] show_trace_log_lvl+0x26/0x3c [] show_stack_log_lvl+0x9b/0xa3 [] show_registers+0x18f/0x229 [] die+0x12a/0x1ef [] do_trap+0x80/0x88 [] do_invalid_op+0xa0/0xaa [] error_code+0x39/0x40 [] platform_device_release+0x1b/0x35 [] device_release+0x2f/0x71 [] kobject_cleanup+0x49/0x70 [] kobject_release+0x14/0x16 [] kref_put+0x6a/0x78 [] kobject_put+0x20/0x22 [] put_device+0x18/0x1a [] platform_device_put+0x18/0x1a [] depca_module_init+0x79/0xc4 [depca] [] sys_init_module+0x1332/0x14b9 [] sysenter_past_esp+0x56/0x79 === Code: 56 53 85 ff 74 47 9c 5e fa 8d 97 00 00 00 40 c1 ea 0c c1 e2 05 03 15 a0 26 68 c0 8b 02 f6 c4 40 74 03 8b 52 0c 8b 02 84 c0 78 02 <0f> 0b 8b 4a 18 8b 19 8b 03 3b 43 04 72 0b 89 c8 89 da e8 25 ff EIP: [] kfree+0x32/0x59 SS:ESP 0068:ea4a5e10 MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: The real problem with C++ for kernel modules is: the language just sucks. the second :-- Linus Torvalds signature.asc Description: Digital signature
Re: Segmentation fault on modprobe depca
On Mon, 2006-12-11 12:06:08 +0100, Tom Kerremans [EMAIL PROTECTED] wrote: I 'm the maintainter of Trinity Rescue Kit (http://trinityhome.org/trk) , a live rescue distribution that tries (amongst many other features) to be as generic as possible in terms of hardware detection. Therefore I include all network and disk controller drivers in the kernel or as module. I recently tried kernel 2.6.19 and stumbled upon the fact that the module DEPCA seems to be broken. When I compile it in the kernel, the kernel crashes at boot time. Compiled as module it creates a segmentation fault on modprobe. I 've tested compilation on two different systems: first is my TRK workbench, which is a Mandriva 2005 with gcc 3.4.3-7mdk and module-init-tools 3.0 (later upgraded to 3.2.2, recompiled kernel, but same result). The other system I compiled and tried it on is an out-of-the-box Mandriva 2007, which is quite new and has more recent compilers and libraries. The result was the same. When I do a modprobe depca, even though there is no hardware that could use this module (it 's for old DEC nics..), I get the following output: [EMAIL PROTECTED] ~]# modprobe depca Segmentation fault [EMAIL PROTECTED] ~]# Please use `dmesg' the next time to generate output and don't cut'n'paste it if this adds extra \n into the output. Just reworked your stuff to get it remotely readable: Kernel BUG at [verbose debug info unavailable] invalid opcode: [#1] CPU:0 EIP:0060:[c014b738]Not tainted VLI EFLAGS: 00010006 (2.6.19 #2) EIP is at kfree+0x32/0x59 eax: ef632674 ebx: f64f7800 ecx: f64f7870 edx: c180 esi: 0206 edi: 0300 ebp: ea4a5e1c esp: ea4a5e10 ds: 007b es: 007b ss: 0068 Process modprobe (pid: 26866, ti=ea4a4000 task=c1a74a70 task.ti=ea4a4000) Stack: f64f7800 f64f7870 c0552580 ea4a5e2c c0279ecc 0300 c05525dc ea4a5e44 c0275ccf f64f7808 ea4a5e44 c0275de3 f64f7870 ea4a5e60 c020d3a2 f64f7870 c05528c8 f64f7888 c020d3c9 ea4a5e6c c020d3dd f64f7870 ea4a5e8c Call Trace: [c010317a] show_trace_log_lvl+0x26/0x3c [c010322b] show_stack_log_lvl+0x9b/0xa3 [c01035f6] show_registers+0x18f/0x229 [c01037ba] die+0x12a/0x1ef [c01038ff] do_trap+0x80/0x88 [c01040fa] do_invalid_op+0xa0/0xaa [c047f329] error_code+0x39/0x40 [c0279ecc] platform_device_release+0x1b/0x35 [c0275ccf] device_release+0x2f/0x71 [c020d3a2] kobject_cleanup+0x49/0x70 [c020d3dd] kobject_release+0x14/0x16 [c020df30] kref_put+0x6a/0x78 [c020d357] kobject_put+0x20/0x22 [c0275de3] put_device+0x18/0x1a [c0279efe] platform_device_put+0x18/0x1a [f8ac98a0] depca_module_init+0x79/0xc4 [depca] [c012be5a] sys_init_module+0x1332/0x14b9 [c0102c9d] sysenter_past_esp+0x56/0x79 === Code: 56 53 85 ff 74 47 9c 5e fa 8d 97 00 00 00 40 c1 ea 0c c1 e2 05 03 15 a0 26 68 c0 8b 02 f6 c4 40 74 03 8b 52 0c 8b 02 84 c0 78 02 0f 0b 8b 4a 18 8b 19 8b 03 3b 43 04 72 0b 89 c8 89 da e8 25 ff EIP: [c014b738] kfree+0x32/0x59 SS:ESP 0068:ea4a5e10 MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: The real problem with C++ for kernel modules is: the language just sucks. the second :-- Linus Torvalds signature.asc Description: Digital signature
[GIT PULL] Remove old address from lkkbd.c
Hi! Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbglaw/vax-linux.git fixes4linus You'll get: drivers/input/keyboard/lkkbd.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) commit 1d08811d0c05cd54a778f45588ec22eee027ff89 Author: Jan-Benedict Glaw <[EMAIL PROTECTED]> Date: Fri Nov 17 10:32:04 2006 +0100 lkkbd: Remove my old snail-mail address I moved to a different town and my old snail-mail address is invalid now. Also, there's no need at all to have any address like that in the sources, so remove it completely. Signed-off-by: Jan-Benedict Glaw <[EMAIL PROTECTED]> diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c index 708d5a1..979b93e 100644 --- a/drivers/input/keyboard/lkkbd.c +++ b/drivers/input/keyboard/lkkbd.c @@ -59,11 +59,6 @@ * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * - * Should you need to contact me, the author, you can do so either by - * email or by paper mail: - * Jan-Benedict Glaw, Lilienstraße 16, 33790 Hörste (near Halle/Westf.), - * Germany. */ #include MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser. the second : signature.asc Description: Digital signature
[GIT PULL] Remove old address from lkkbd.c
Hi! Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbglaw/vax-linux.git fixes4linus You'll get: drivers/input/keyboard/lkkbd.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) commit 1d08811d0c05cd54a778f45588ec22eee027ff89 Author: Jan-Benedict Glaw [EMAIL PROTECTED] Date: Fri Nov 17 10:32:04 2006 +0100 lkkbd: Remove my old snail-mail address I moved to a different town and my old snail-mail address is invalid now. Also, there's no need at all to have any address like that in the sources, so remove it completely. Signed-off-by: Jan-Benedict Glaw [EMAIL PROTECTED] diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c index 708d5a1..979b93e 100644 --- a/drivers/input/keyboard/lkkbd.c +++ b/drivers/input/keyboard/lkkbd.c @@ -59,11 +59,6 @@ * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * - * Should you need to contact me, the author, you can do so either by - * email or by paper mail: - * Jan-Benedict Glaw, Lilienstraße 16, 33790 Hörste (near Halle/Westf.), - * Germany. */ #include linux/delay.h MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED] +49-172-7608481 Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser. the second : signature.asc Description: Digital signature
Re: [RFC] Consistently use the name asm-offsets.h
On Thu, 2005-09-08 23:15:39 +0200, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > I suggest moving all the logic required to build the asm-offsets.h file > to a common places and do proper search in architectures to make > the naming consitent. For frv, m32r and sparc64 we will need to create a > dummy file until they start using asm-offsets.h Yay! Another rule we can kill from arch-specific Makefile :-) > --- a/Makefile > +++ b/Makefile > @@ -776,14 +776,14 @@ $(vmlinux-dirs): prepare-all scripts > # A multi level approach is used. prepare1 is updated first, then prepare0. > # prepare-all is the collection point for the prepare targets. > > -.PHONY: prepare-all prepare prepare0 prepare1 prepare2 > +.PHONY: prepare-all prepare prepare0 prepare1 prepare2 prepare3 > > -# prepare2 is used to check if we are building in a separate output > directory, > +# preparei3 is used to check if we are building in a separate output > directory, ^^^ Typo? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ "Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [RFC] Consistently use the name asm-offsets.h
On Thu, 2005-09-08 23:15:39 +0200, Sam Ravnborg [EMAIL PROTECTED] wrote: I suggest moving all the logic required to build the asm-offsets.h file to a common places and do proper searchreplace in architectures to make the naming consitent. For frv, m32r and sparc64 we will need to create a dummy file until they start using asm-offsets.h Yay! Another rule we can kill from arch-specific Makefile :-) --- a/Makefile +++ b/Makefile @@ -776,14 +776,14 @@ $(vmlinux-dirs): prepare-all scripts # A multi level approach is used. prepare1 is updated first, then prepare0. # prepare-all is the collection point for the prepare targets. -.PHONY: prepare-all prepare prepare0 prepare1 prepare2 +.PHONY: prepare-all prepare prepare0 prepare1 prepare2 prepare3 -# prepare2 is used to check if we are building in a separate output directory, +# preparei3 is used to check if we are building in a separate output directory, ^^^ Typo? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O für einen Freien Staat voll Freier Bürger | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: serial port multiplexing
On Wed, 2005-08-31 11:10:48 +0100, Russell King <[EMAIL PROTECTED]> wrote: > On Thu, Aug 25, 2005 at 01:20:45PM +0100, Rahul Tank wrote: > > I am a newbee tryinging for serial port > > multiplexing. Currently my driver supports for one > > port > > (/dev/ttyS0). However i want to use the same physical > > port for 2 virtual ports.I am NOT sending two type of > > data simultaneously. I want to first reigister my > > driver for /dev/ttyS0. When the kernel has booted ,i > > want to disable it. Then i want to enable the driver > > to register for say /dev/ttyS1. > > in short i don't want the console to have controle > > over the serial port. > > Try setting the kernel message level to zero after boot. That > will prevent the kernel from displaying any further messages to > that serial port, except when a serious problem (eg, oops) occurs. Alternatively, IIRC one of the printk-nullifying patches were taken some time ago. You should be able to eleminate any printk()s through kernel configuration in the embedded menu. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ "Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: serial port multiplexing
On Wed, 2005-08-31 11:10:48 +0100, Russell King [EMAIL PROTECTED] wrote: On Thu, Aug 25, 2005 at 01:20:45PM +0100, Rahul Tank wrote: I am a newbee tryinging for serial port multiplexing. Currently my driver supports for one port (/dev/ttyS0). However i want to use the same physical port for 2 virtual ports.I am NOT sending two type of data simultaneously. I want to first reigister my driver for /dev/ttyS0. When the kernel has booted ,i want to disable it. Then i want to enable the driver to register for say /dev/ttyS1. in short i don't want the console to have controle over the serial port. Try setting the kernel message level to zero after boot. That will prevent the kernel from displaying any further messages to that serial port, except when a serious problem (eg, oops) occurs. Alternatively, IIRC one of the printk-nullifying patches were taken some time ago. You should be able to eleminate any printk()s through kernel configuration in the embedded menu. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O für einen Freien Staat voll Freier Bürger | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: starting a user defined daemon at linux startup.
On Sat, 2005-08-13 15:42:37 +0530, P.Manohar <[EMAIL PROTECTED]> wrote: > Hai > I want to start a daemon at startup in linux. > I came to know that we need to put a script into /etc/rc.d/init.d/ > similar to sshd or atd. Do we need to write a script to run my daemon? This isn't exactly a Linux kernel-related question, but to answer it anyways: that's the way to go. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ "Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [2.6 patch] remove support for gcc < 3.2
On Thu, 2005-08-04 22:38:31 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Thu, Aug 04, 2005 at 08:54:47AM +0200, Jan-Benedict Glaw wrote: > > I guess that if you remove -fno-unit-at-a-time from i386 and use a > > current GCC, you'll run into that fun, too. > > What bug exactly? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23237 MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ "Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [2.6 patch] remove support for gcc 3.2
On Thu, 2005-08-04 22:38:31 +0200, Adrian Bunk [EMAIL PROTECTED] wrote: On Thu, Aug 04, 2005 at 08:54:47AM +0200, Jan-Benedict Glaw wrote: I guess that if you remove -fno-unit-at-a-time from i386 and use a current GCC, you'll run into that fun, too. What bug exactly? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23237 MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: starting a user defined daemon at linux startup.
On Sat, 2005-08-13 15:42:37 +0530, P.Manohar [EMAIL PROTECTED] wrote: Hai I want to start a daemon at startup in linux. I came to know that we need to put a script into /etc/rc.d/init.d/ similar to sshd or atd. Do we need to write a script to run my daemon? This isn't exactly a Linux kernel-related question, but to answer it anyways: that's the way to go. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [2.6 patch] remove support for gcc < 3.2
On Fri, 2005-08-12 09:40:18 +0200, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > On Thu, 4 Aug 2005, Jan-Benedict Glaw wrote: > > -sh-3.00# cat cpuinfo > > cpu : VAX > > cpu type: KA43 > > cpu sid : 0x0b06 > > cpu sidex : 0x04010002 > > page size : 4096 > > BogoMIPS: 10.08 > > -sh-3.00# cat version > > Linux version 2.6.12 ([EMAIL PROTECTED]) (gcc version 4.1.0 20050803 > > (experimental)) #2 Wed Aug 3 23:42:11 CEST 2005 > > Any change we will see this code in mainline? That's the plan. We haven't publically talked about it yet, but we'd probably like to present the code for review once we - have enough hardware supported. At least local SCSI drivers for the most common machines should be available, as well as network drivers. That's not yet the case. - have userspace working again. Currently, a very old gcc is used. I'm working on uClibc (and thereafter GNU libc) in conjunction with gcc-HEAD as time allows. So yes, we want to show off the code, but we don't want to do that publically and right now. There are still to many places where the code needs some tidy-up (and be it whitespace and comment fixes), but everybody is welcome to peek at our CVS repo (http://sourceforge.net/cvs/?group_id=2626) or to join the mailing list (at http://www.pergamentum.com/mailman/listinfo/linux-vax). So if *you* are looking for some beginner's task to start with kernel development, here you go! Oh, and SMP fun will hopefully start soon. A machine is on the way and I hope it'll survive shipping :-) VAX is also an interesting platform because it's another platform offering TurboChannel slots. So if you're interested in those old Alphas or DECstations, VAX is for you, too. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ "Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [2.6 patch] remove support for gcc 3.2
On Fri, 2005-08-12 09:40:18 +0200, Geert Uytterhoeven [EMAIL PROTECTED] wrote: On Thu, 4 Aug 2005, Jan-Benedict Glaw wrote: -sh-3.00# cat cpuinfo cpu : VAX cpu type: KA43 cpu sid : 0x0b06 cpu sidex : 0x04010002 page size : 4096 BogoMIPS: 10.08 -sh-3.00# cat version Linux version 2.6.12 ([EMAIL PROTECTED]) (gcc version 4.1.0 20050803 (experimental)) #2 Wed Aug 3 23:42:11 CEST 2005 Any change we will see this code in mainline? That's the plan. We haven't publically talked about it yet, but we'd probably like to present the code for review once we - have enough hardware supported. At least local SCSI drivers for the most common machines should be available, as well as network drivers. That's not yet the case. - have userspace working again. Currently, a very old gcc is used. I'm working on uClibc (and thereafter GNU libc) in conjunction with gcc-HEAD as time allows. So yes, we want to show off the code, but we don't want to do that publically and right now. There are still to many places where the code needs some tidy-up (and be it whitespace and comment fixes), but everybody is welcome to peek at our CVS repo (http://sourceforge.net/cvs/?group_id=2626) or to join the mailing list (at http://www.pergamentum.com/mailman/listinfo/linux-vax). So if *you* are looking for some beginner's task to start with kernel development, here you go! Oh, and SMP fun will hopefully start soon. A machine is on the way and I hope it'll survive shipping :-) VAX is also an interesting platform because it's another platform offering TurboChannel slots. So if you're interested in those old Alphas or DECstations, VAX is for you, too. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [-mm patch] DLM must depend on IPV6 || IPV6=n
On Tue, 2005-08-09 17:50:01 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch fixes the following compile error with CONFIG_DLM=y and > CONFIG_IPV6=m: [...] > --- linux-2.6.13-rc3-mm3-modular/drivers/dlm/Kconfig.old 2005-07-30 > 14:07:12.0 +0200 > +++ linux-2.6.13-rc3-mm3-modular/drivers/dlm/Kconfig 2005-07-30 > 14:07:41.0 +0200 > @@ -3,6 +3,7 @@ > > config DLM > tristate "Distributed Lock Manager (DLM)" > + depends on IPV6 || IPV6=n > select IP_SCTP > help > A general purpose distributed lock manager for kernel or userspace Why don't you allow modular builds of both? ...or aren't the IPv6 symbols exported? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ "Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
Re: [-mm patch] DLM must depend on IPV6 || IPV6=n
On Tue, 2005-08-09 17:50:01 +0200, Adrian Bunk [EMAIL PROTECTED] wrote: This patch fixes the following compile error with CONFIG_DLM=y and CONFIG_IPV6=m: [...] --- linux-2.6.13-rc3-mm3-modular/drivers/dlm/Kconfig.old 2005-07-30 14:07:12.0 +0200 +++ linux-2.6.13-rc3-mm3-modular/drivers/dlm/Kconfig 2005-07-30 14:07:41.0 +0200 @@ -3,6 +3,7 @@ config DLM tristate Distributed Lock Manager (DLM) + depends on IPV6 || IPV6=n select IP_SCTP help A general purpose distributed lock manager for kernel or userspace Why don't you allow modular builds of both? ...or aren't the IPv6 symbols exported? MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]. +49-172-7608481 _ O _ Eine Freie Meinung in einem Freien Kopf| Gegen Zensur | Gegen Krieg _ _ O fuer einen Freien Staat voll Freier Bürger | im Internet! | im Irak! O O O ret = do_actions((curr | FREE_SPEECH) ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); signature.asc Description: Digital signature
