RE: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range()
-Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Thursday, August 21, 2014 4:10 AM To: Alexander Gordeev; linux-kernel@vger.kernel.org Cc: Jayamohan Kallickal; linux-s...@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range() On 08/18/2014 08:01 AM, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers using these > two interfaces need to be updated to use the new > pci_enable_msi_range() and pci_enable_msix_range() interfaces. Patch looks good to me. Reviewed-by: Tomas Henzl > Signed-off-by: Alexander Gordeev > Cc: Jayamohan Kallickal > Cc: linux-s...@vger.kernel.org > Cc: linux-...@vger.kernel.org > --- > drivers/scsi/be2iscsi/be_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c > b/drivers/scsi/be2iscsi/be_main.c index 915c26b..b422659 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -5276,9 +5276,9 @@ static void beiscsi_msix_enable(struct beiscsi_hba > *phba) > for (i = 0; i <= phba->num_cpus; i++) > phba->msix_entries[i].entry = i; > > - status = pci_enable_msix(phba->pcidev, phba->msix_entries, > - (phba->num_cpus + 1)); > - if (!status) > + status = pci_enable_msix_range(phba->pcidev, phba->msix_entries, > +phba->num_cpus + 1, phba->num_cpus + 1); > + if (status > 0) > phba->msix_enabled = true; > > return; Looks Good. Acked-by: Jayamohan Kallickal -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()
-Original Message- From: Alexander Gordeev [mailto:agord...@redhat.com] Sent: Saturday, July 26, 2014 1:09 AM To: linux-kernel@vger.kernel.org; Jayamohan Kallickal Subject: Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() On Wed, Jul 16, 2014 at 08:05:05PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers using these > two interfaces need to be updated to use the new > pci_enable_msi_range() or pci_enable_msi_exact() and > pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Hi Jayamohan, Could you please review this patch? Thanks! > Signed-off-by: Alexander Gordeev > --- > drivers/scsi/be2iscsi/be_main.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c > b/drivers/scsi/be2iscsi/be_main.c index 56467df..1f63169 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -5278,12 +5278,10 @@ static void beiscsi_msix_enable(struct beiscsi_hba > *phba) > for (i = 0; i <= phba->num_cpus; i++) > phba->msix_entries[i].entry = i; > > - status = pci_enable_msix(phba->pcidev, phba->msix_entries, > - (phba->num_cpus + 1)); > + status = pci_enable_msix_exact(phba->pcidev, phba->msix_entries, > +phba->num_cpus + 1); > if (!status) > phba->msix_enabled = true; > - > - return; > } > > static void be_eqd_update(struct beiscsi_hba *phba) > -- > 1.7.7.6 > Looks Good. Acked-by: Jayamohan Kallickal -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 02/55] scsi: Mark function as static in be2iscsi/be_cmds.c
Looks good
Acked-by: Jayamohan Kallickal
---
-Original Message-
From: Rashika Kheria [mailto:rashika.khe...@gmail.com]
Sent: Saturday, March 29, 2014 10:44 AM
To: linux-kernel@vger.kernel.org
Cc: Jayamohan Kallickal; James E.J. Bottomley; linux-s...@vger.kernel.org;
j...@joshtriplett.org
Subject: [PATCH 02/55] scsi: Mark function as static in be2iscsi/be_cmds.c
Mark function as static in be2iscsi/be_cmds.c because it is not used outside
this file.
This eliminates the following warning in be2iscsi/be_cmds.c:
drivers/scsi/be2iscsi/be_cmds.c:401:5: warning: no previous prototype for
‘beiscsi_process_mcc’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
---
drivers/scsi/be2iscsi/be_cmds.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 3338391..026c3e3 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -398,7 +398,7 @@ static void beiscsi_cq_notify(struct beiscsi_hba *phba, u16
qid, bool arm, }
-int beiscsi_process_mcc(struct beiscsi_hba *phba)
+static int beiscsi_process_mcc(struct beiscsi_hba *phba)
{
struct be_mcc_compl *compl;
int num = 0, status = 0;
--
1.7.9.5
RE: [PATCH v2 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()
-Original Message- From: Alexander Gordeev [mailto:agord...@redhat.com] Sent: Monday, February 24, 2014 12:02 AM To: linux-kernel@vger.kernel.org Cc: Alexander Gordeev; Jayamohan Kallickal; linux-s...@vger.kernel.org; linux-...@vger.kernel.org Subject: [PATCH v2 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev Cc: Jayamohan Kallickal Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/be2iscsi/be_main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 1f37505..580192f 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5284,12 +5284,10 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba) for (i = 0; i <= phba->num_cpus; i++) phba->msix_entries[i].entry = i; - status = pci_enable_msix(phba->pcidev, phba->msix_entries, -(phba->num_cpus + 1)); + status = pci_enable_msix_exact(phba->pcidev, phba->msix_entries, + phba->num_cpus + 1); if (!status) phba->msix_enabled = true; - - return; } /* -- 1.7.7.6 Acked-By: Jayamohan Kallickal -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
-Original Message-
From: Daeseok Youn [mailto:daeseok.y...@gmail.com]
Sent: Thursday, February 20, 2014 5:13 PM
To: jbottom...@parallels.com
Cc: Jayamohan Kallickal; linux-s...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer
Signed-off-by: Daeseok Youn
---
drivers/scsi/be2iscsi/be_cmds.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 3338391..1ec9793 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -24,9 +24,9 @@
int beiscsi_pci_soft_reset(struct beiscsi_hba *phba) {
u32 sreset;
- u8 *pci_reset_offset = 0;
- u8 *pci_online0_offset = 0;
- u8 *pci_online1_offset = 0;
+ u8 *pci_reset_offset = NULL;
+ u8 *pci_online0_offset = NULL;
+ u8 *pci_online1_offset = NULL;
u32 pconline0 = 0;
u32 pconline1 = 0;
u32 i;
--
1.7.9.5
Acked-By: Jayamohan Kallickal
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 01/22] be2iscsi: Use pci_enable_msix_range()
-Original Message- From: Alexander Gordeev [mailto:agord...@redhat.com] Sent: Tuesday, February 04, 2014 3:17 AM To: linux-kernel@vger.kernel.org Cc: Alexander Gordeev; Jayamohan Kallickal; linux-s...@vger.kernel.org; linux-...@vger.kernel.org Subject: [PATCH 01/22] be2iscsi: Use pci_enable_msix_range() As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev Cc: Jayamohan Kallickal Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/be2iscsi/be_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 1f37505..5878f3e 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5284,9 +5284,9 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba) for (i = 0; i <= phba->num_cpus; i++) phba->msix_entries[i].entry = i; - status = pci_enable_msix(phba->pcidev, phba->msix_entries, -(phba->num_cpus + 1)); - if (!status) + status = pci_enable_msix_range(phba->pcidev, phba->msix_entries, + phba->num_cpus + 1, phba->num_cpus + 1); + if (status > 0) phba->msix_enabled = true; return; Looks OK to me Acked-by: Jayamohan Kallickal -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: scsi-mq + open-iscsi support patches..?
-Original Message- From: open-is...@googlegroups.com [mailto:open-is...@googlegroups.com] On Behalf Of Nicholas A. Bellinger Sent: Friday, November 01, 2013 1:37 PM To: Mike Christie Cc: open-is...@googlegroups.com; linux-scsi; LKML; target-devel; Or Gerlitz Subject: Re: scsi-mq + open-iscsi support patches..? On Fri, 2013-11-01 at 09:46 -0500, Mike Christie wrote: > On 10/28/13 5:03 PM, Nicholas A. Bellinger wrote: > > Hi Mike, > > > > Just curious as to the status of the scsi-mq conversion patches for > > open-iscsi that you where working on a while back..? > > > > I'm asking because recently I've been spending alot of time with > > scsi-mq > > + virtio-scsi, and would really to start banging on iser-target > > + ports > > using an scsi-mq enabled iser-initiator as well.. > > > > So that said, are there any blockers holding things up towards > > getting a working prototype..? > > > > Just time. Just finished a release at work and just got back from > vacation so hoping to work on this some more in the next weeks. > >Btw, I'm happy to help move things along here too, and have a few extra cycles >to spare.. >> On a related note, some iscsi vendor has been hitting a crash with >> your tree. >I got an email from Jayamohan recently, but the OOPs did not appear to be >scsi-mq related.. I do see the crash on my Ubuntu VM running on VirtualBox but don't see the crash on a Standalone system. Attaching the screenshot > Have you rebased it it to take in Christoph's changes and fixes that > are in Jens's tree? The code here > > https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/lo > g/?h=scsi-mq > > looks ok. That is the current code right? > It's current as of a few weeks ago, but does not include the very latest blk-mq code that's now in next from Jens. I'll be rebasing once blk-mq hits mainline over the next weeks.. ;) --nab -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-is...@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out. <>
