Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
On Mon, 24 Feb 2014 09:30:39 -0500,
Steven Rostedt wrote:
On Sun, 23 Feb 2014 10:19:28 +0900
Satoru Takeuchi wrote:
From: Satoru Takeuchi
As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.
Signed-off-by: Satoru Takeuchi
Cc: Steven Rostedt
---
tools/testing/ktest/examples/kvm.conf | 4
1 file changed, 4 insertions(+)
diff --git a/tools/testing/ktest/examples/kvm.conf
b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..40356f7 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
Thanks, I'll add this to my 3.15 queue.
Hmm, it seems that we need a following patch as well.
Or, please merge with the orignal patch.
Thanks,
Takahiro
==
From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
From: MUNEDA Takahiro
Date: Tue, 25 Feb 2014 15:32:35 -0500
Subject: [PATCH] ktest: Fixes a trivial typo
Signed-off-by: MUNEDA Takahiro
Cc: Satoru Takeuchi
Cc: Steven Rostedt
---
tools/testing/ktest/examples/kvm.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/ktest/examples/kvm.conf
b/tools/testing/ktest/examples/kvm.conf
index 40356f7..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,7 +10,7 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
-# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
# by the default signal, SIGINT.
CLOSE_CONSOLE_SIGNAL = KILL
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
On Mon, 24 Feb 2014 09:30:39 -0500,
Steven Rostedt rost...@goodmis.org wrote:
On Sun, 23 Feb 2014 10:19:28 +0900
Satoru Takeuchi satoru.takeu...@gmail.com wrote:
From: Satoru Takeuchi satoru.takeu...@gmail.com
As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.
Signed-off-by: Satoru Takeuchi satoru.takeu...@gmail.com
Cc: Steven Rostedt rost...@goodmis.org
---
tools/testing/ktest/examples/kvm.conf | 4
1 file changed, 4 insertions(+)
diff --git a/tools/testing/ktest/examples/kvm.conf
b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..40356f7 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
Thanks, I'll add this to my 3.15 queue.
Hmm, it seems that we need a following patch as well.
Or, please merge with the orignal patch.
Thanks,
Takahiro
==
From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
From: MUNEDA Takahiro muneda.takah...@jp.fujitsu.com
Date: Tue, 25 Feb 2014 15:32:35 -0500
Subject: [PATCH] ktest: Fixes a trivial typo
Signed-off-by: MUNEDA Takahiro muneda.takah...@jp.fujitsu.com
Cc: Satoru Takeuchi satoru.takeu...@gmail.com
Cc: Steven Rostedt rost...@goodmis.org
---
tools/testing/ktest/examples/kvm.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/ktest/examples/kvm.conf
b/tools/testing/ktest/examples/kvm.conf
index 40356f7..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,7 +10,7 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
-# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
# by the default signal, SIGINT.
CLOSE_CONSOLE_SIGNAL = KILL
--
1.8.3.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu
On Tue, 27 Nov 2012 09:42:20 +0900 (JST),
Takao Indoh wrote:
> These patches reset PCIe devices at boot time to address DMA problem on
> kdump with iommu. When "reset_devices" is specified, a hot reset is
> triggered on each PCIe root port and downstream port to reset its
> downstream endpoint.
>
> Background:
> A kdump problem about DMA has been discussed for a long time. That is,
> when a kernel is switched to the kdump kernel, DMA derived from first
> kernel affects second kernel. Especially this problem surfaces when
> iommu is used for PCI passthrough on KVM guest. In the case of the
> machine I use, when intel_iommu=on is specified, DMAR error is detected
> in kdump kernel and PCI SERR is also detected. Finally kdump fails
> because some devices does not work correctly.
>
> The root cause is that ongoing DMA from first kernel causes DMAR fault
> because page table of DMAR is initialized while kdump kernel is booting
> up. Therefore to solve this problem DMA needs to be stopped before DMAR
> is initialized at kdump kernel boot time. By these patches, PCIe devices
> are reset by hot reset and its DMA is stopped when reset_devices is
> specified. One problem of this solution is that the monitor blacks out
> when VGA controller is reset. So this patch does not reset the port
> whose child endpoint is VGA device.
>
> What I tried:
> - Clearing bus master bit and INTx disable bit at boot time
> This did not solve this problem. I still got DMAR error on devices.
> - Resetting devices in fixup_final(v1 patch)
> DMAR error disappeared, but sometimes PCI SERR was detected. This
> is well explained here.
> https://lkml.org/lkml/2012/9/9/245
> This PCI SERR seems to be related to interrupt remapping.
> - Clearing bus master in setup_arch() and resetting devices in
>fixup_final
> Neither DMAR error nor PCI SERR occurred. But on certain machine
> kdump kernel hung up when resetting devices. It seems to be a
> problem specific to the platform.
> - Resetting devices in setup_arch() (v2 and later patch)
> This solution solves all problems I found so far.
Thank you for updating a patchset.
I have a server which raises PCI Error while system is rebooting when
I set intel_iommu=on. With v7 on top of 3.7-rc7, I don't see any PCI
Errors or other hardware related errors. So,
Tested-by: MUNEDA Takahiro
Thanks,
Takahiro
>
> Changelog:
> v7:
> Update Yinghai's dummy-pci patch with macros in linux/pci.h, and fix
> some bugs
>
> v6:
> Rewrite using Yinghai's dummy-pci patch
> https://lkml.org/lkml/2012/11/13/118
>
> v5:
> Do bus reset after all devices are scanned and its config registers are
> saved. This fixes a bug that config register is accessed without delay
> after reset.
> https://lkml.org/lkml/2012/10/17/47
>
> v4:
> Reduce waiting time after resetting devices. A previous patch does reset
> like this:
>for (each device) {
> save config registers
> reset
> wait for 500 ms
> restore config registers
>}
>
> If there are N devices to be reset, it takes N*500 ms. On the other
> hand, the v4 patch does:
>for (each device) {
> save config registers
> reset
>}
>wait 500 ms
>for (each device) {
> restore config registers
>}
> Though it needs more memory space to save config registers, the waiting
> time is always 500ms.
> https://lkml.org/lkml/2012/10/15/49
>
> v3:
> Move alloc_bootmem and free_bootmem to early_reset_pcie_devices so that
> they are called only once.
> https://lkml.org/lkml/2012/10/10/57
>
> v2:
> Reset devices in setup_arch() because reset need to be done before
> interrupt remapping is initialized.
> https://lkml.org/lkml/2012/10/2/54
>
> v1:
> Add fixup_final quirk to reset PCIe devices
> https://lkml.org/lkml/2012/8/3/160
>
> Takao Indoh (5):
>x86, pci: add dummy pci device for early stage
>PCI: Define the maximum number of PCI function
>Make reset_devices available at early stage
>x86, pci: Reset PCIe devices at boot time
>x86, pci: Enable PCI INTx when MSI is disabled
>
> arch/x86/include/asm/pci-direct.h |3 +
> arch/x86/kernel/setup.c |3 +
> arch/x86/pci/common.c |4 +-
> arch/x86/pci/early.c | 315
> +
> include/linux/pci.h |2 +
> init/main.c |4 +-
> 6 files changed, 328 insertions(+), 3 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu
On Tue, 27 Nov 2012 09:42:20 +0900 (JST),
Takao Indoh indou.ta...@jp.fujitsu.com wrote:
These patches reset PCIe devices at boot time to address DMA problem on
kdump with iommu. When reset_devices is specified, a hot reset is
triggered on each PCIe root port and downstream port to reset its
downstream endpoint.
Background:
A kdump problem about DMA has been discussed for a long time. That is,
when a kernel is switched to the kdump kernel, DMA derived from first
kernel affects second kernel. Especially this problem surfaces when
iommu is used for PCI passthrough on KVM guest. In the case of the
machine I use, when intel_iommu=on is specified, DMAR error is detected
in kdump kernel and PCI SERR is also detected. Finally kdump fails
because some devices does not work correctly.
The root cause is that ongoing DMA from first kernel causes DMAR fault
because page table of DMAR is initialized while kdump kernel is booting
up. Therefore to solve this problem DMA needs to be stopped before DMAR
is initialized at kdump kernel boot time. By these patches, PCIe devices
are reset by hot reset and its DMA is stopped when reset_devices is
specified. One problem of this solution is that the monitor blacks out
when VGA controller is reset. So this patch does not reset the port
whose child endpoint is VGA device.
What I tried:
- Clearing bus master bit and INTx disable bit at boot time
This did not solve this problem. I still got DMAR error on devices.
- Resetting devices in fixup_final(v1 patch)
DMAR error disappeared, but sometimes PCI SERR was detected. This
is well explained here.
https://lkml.org/lkml/2012/9/9/245
This PCI SERR seems to be related to interrupt remapping.
- Clearing bus master in setup_arch() and resetting devices in
fixup_final
Neither DMAR error nor PCI SERR occurred. But on certain machine
kdump kernel hung up when resetting devices. It seems to be a
problem specific to the platform.
- Resetting devices in setup_arch() (v2 and later patch)
This solution solves all problems I found so far.
Thank you for updating a patchset.
I have a server which raises PCI Error while system is rebooting when
I set intel_iommu=on. With v7 on top of 3.7-rc7, I don't see any PCI
Errors or other hardware related errors. So,
Tested-by: MUNEDA Takahiro muneda.takah...@jp.fujitsu.com
Thanks,
Takahiro
Changelog:
v7:
Update Yinghai's dummy-pci patch with macros in linux/pci.h, and fix
some bugs
v6:
Rewrite using Yinghai's dummy-pci patch
https://lkml.org/lkml/2012/11/13/118
v5:
Do bus reset after all devices are scanned and its config registers are
saved. This fixes a bug that config register is accessed without delay
after reset.
https://lkml.org/lkml/2012/10/17/47
v4:
Reduce waiting time after resetting devices. A previous patch does reset
like this:
for (each device) {
save config registers
reset
wait for 500 ms
restore config registers
}
If there are N devices to be reset, it takes N*500 ms. On the other
hand, the v4 patch does:
for (each device) {
save config registers
reset
}
wait 500 ms
for (each device) {
restore config registers
}
Though it needs more memory space to save config registers, the waiting
time is always 500ms.
https://lkml.org/lkml/2012/10/15/49
v3:
Move alloc_bootmem and free_bootmem to early_reset_pcie_devices so that
they are called only once.
https://lkml.org/lkml/2012/10/10/57
v2:
Reset devices in setup_arch() because reset need to be done before
interrupt remapping is initialized.
https://lkml.org/lkml/2012/10/2/54
v1:
Add fixup_final quirk to reset PCIe devices
https://lkml.org/lkml/2012/8/3/160
Takao Indoh (5):
x86, pci: add dummy pci device for early stage
PCI: Define the maximum number of PCI function
Make reset_devices available at early stage
x86, pci: Reset PCIe devices at boot time
x86, pci: Enable PCI INTx when MSI is disabled
arch/x86/include/asm/pci-direct.h |3 +
arch/x86/kernel/setup.c |3 +
arch/x86/pci/common.c |4 +-
arch/x86/pci/early.c | 315
+
include/linux/pci.h |2 +
init/main.c |4 +-
6 files changed, 328 insertions(+), 3 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe linux-pci in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Documentation/filesystems/proc.txt alignment
A word was left behind... Signed-off-by: MUNEDA Takahiro Cc: Davidlohr Bueso --- Documentation/filesystems/proc.txt |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt index a1793d6..df358b1 100644 --- a/Documentation/filesystems/proc.txt +++ b/Documentation/filesystems/proc.txt @@ -33,8 +33,7 @@ Table of Contents 2Modifying System Parameters 3Per-Process Parameters - 3.1 /proc//oom_score_adj - Adjust the oom-killer - score + 3.1 /proc//oom_score_adj - Adjust the oom-killer score 3.2 /proc//oom_score - Display current oom-killer score 3.3 /proc//io - Display the IO accounting fields 3.4 /proc//coredump_filter - Core dump filtering settings -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Documentation/filesystems/proc.txt alignment
A word was left behind... Signed-off-by: MUNEDA Takahiro muneda.takah...@jp.fujitsu.com Cc: Davidlohr Bueso d...@gnu.org --- Documentation/filesystems/proc.txt |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt index a1793d6..df358b1 100644 --- a/Documentation/filesystems/proc.txt +++ b/Documentation/filesystems/proc.txt @@ -33,8 +33,7 @@ Table of Contents 2Modifying System Parameters 3Per-Process Parameters - 3.1 /proc/pid/oom_score_adj - Adjust the oom-killer - score + 3.1 /proc/pid/oom_score_adj - Adjust the oom-killer score 3.2 /proc/pid/oom_score - Display current oom-killer score 3.3 /proc/pid/io - Display the IO accounting fields 3.4 /proc/pid/coredump_filter - Core dump filtering settings -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.22-rc7] remove duplicate header include line
Hi,
is included twice. This patch removes the duplication.
I've confirmed the binary file with/without patch is completely same.
Thanks,
MUNE
Remove duplicate header include line from arch/i386/kernel/pci-dma.c
Signed-off-by: MUNEDA Takahiro <[EMAIL PROTECTED]>
---
arch/i386/kernel/pci-dma.c |1 -
1 file changed, 1 deletion(-)
Index: linux-2.6.22-rc7/arch/i386/kernel/pci-dma.c
===
--- linux-2.6.22-rc7.orig/arch/i386/kernel/pci-dma.c2007-07-04
17:09:03.0 +0900
+++ linux-2.6.22-rc7/arch/i386/kernel/pci-dma.c 2007-07-04 17:09:14.0
+0900
@@ -12,7 +12,6 @@
#include
#include
#include
-#include
#include
struct dma_coherent_mem {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.22-rc7] remove duplicate header include line
Hi,
linux/pci.h is included twice. This patch removes the duplication.
I've confirmed the binary file with/without patch is completely same.
Thanks,
MUNE
Remove duplicate header include line from arch/i386/kernel/pci-dma.c
Signed-off-by: MUNEDA Takahiro [EMAIL PROTECTED]
---
arch/i386/kernel/pci-dma.c |1 -
1 file changed, 1 deletion(-)
Index: linux-2.6.22-rc7/arch/i386/kernel/pci-dma.c
===
--- linux-2.6.22-rc7.orig/arch/i386/kernel/pci-dma.c2007-07-04
17:09:03.0 +0900
+++ linux-2.6.22-rc7/arch/i386/kernel/pci-dma.c 2007-07-04 17:09:14.0
+0900
@@ -12,7 +12,6 @@
#include linux/string.h
#include linux/pci.h
#include linux/module.h
-#include linux/pci.h
#include asm/io.h
struct dma_coherent_mem {
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] PCI: fix pci_remove_legacy_files() crash
Hi,
The legacy_io which is the member of pci_bus struct might be
NULL. It should be checked.
This patch checks 'b->legacy_io', NULL or not.
Signed-off-by: MUNEDA Takahiro <[EMAIL PROTECTED]>
---
probe.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff -Npur a/drivers/pci/probe.c b/drivers/pci/probe.c
--- a/drivers/pci/probe.c 2005-01-31 13:31:27.0 +0900
+++ b/drivers/pci/probe.c 2005-02-03 11:21:51.0 +0900
@@ -64,9 +64,11 @@ static void pci_create_legacy_files(stru
void pci_remove_legacy_files(struct pci_bus *b)
{
- class_device_remove_bin_file(>class_dev, b->legacy_io);
- class_device_remove_bin_file(>class_dev, b->legacy_mem);
- kfree(b->legacy_io); /* both are allocated here */
+ if (b->legacy_io) {
+ class_device_remove_bin_file(>class_dev, b->legacy_io);
+ class_device_remove_bin_file(>class_dev, b->legacy_mem);
+ kfree(b->legacy_io); /* both are allocated here */
+ }
}
#else /* !HAVE_PCI_LEGACY */
static inline void pci_create_legacy_files(struct pci_bus *bus) { return; }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] PCI: fix pci_remove_legacy_files() crash
Hi,
The legacy_io which is the member of pci_bus struct might be
NULL. It should be checked.
This patch checks 'b-legacy_io', NULL or not.
Signed-off-by: MUNEDA Takahiro [EMAIL PROTECTED]
---
probe.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff -Npur a/drivers/pci/probe.c b/drivers/pci/probe.c
--- a/drivers/pci/probe.c 2005-01-31 13:31:27.0 +0900
+++ b/drivers/pci/probe.c 2005-02-03 11:21:51.0 +0900
@@ -64,9 +64,11 @@ static void pci_create_legacy_files(stru
void pci_remove_legacy_files(struct pci_bus *b)
{
- class_device_remove_bin_file(b-class_dev, b-legacy_io);
- class_device_remove_bin_file(b-class_dev, b-legacy_mem);
- kfree(b-legacy_io); /* both are allocated here */
+ if (b-legacy_io) {
+ class_device_remove_bin_file(b-class_dev, b-legacy_io);
+ class_device_remove_bin_file(b-class_dev, b-legacy_mem);
+ kfree(b-legacy_io); /* both are allocated here */
+ }
}
#else /* !HAVE_PCI_LEGACY */
static inline void pci_create_legacy_files(struct pci_bus *bus) { return; }
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
