AW: [PATCH 0/4] Add AVX512 optimized gen_syndrome and recovery functions
> Von: linux-raid-ow...@vger.kernel.org > [linux-raid-ow...@vger.kernel.org] im Auftrag von Gayatri Kammela > [gayatri.kamm...@intel.com] > Gesendet: Mittwoch, 3. August 2016 01:28 > An: linux-r...@vger.kernel.org > Cc: s...@kernel.org; linux-kernel@vger.kernel.org; h...@zytor.com; > james.t.kuku...@linux.intel.com; fenghua...@intel.com; > megha@linux.intel.com; ravi.v.shan...@intel.com; Gayatri Kammela > Betreff: [PATCH 0/4] Add AVX512 optimized gen_syndrome and recovery functions > > This is the patch set for adding AVX512 optimized gen_syndrome > and recovery functions. > > Optimization of RAID6 using AVX512 instructions should improve the > RAID6 performance.These patches are tested and observed the improvement > in performance. Hi Gayatri, as you already implemented the gen_syndrome() functions it should be a piece of cake to add the xor_syndrome() ones. Only if these are implemented we can make use of Read-Modify-Write operations if the kernel chooses an processor optimized algorithm. They are already in the SSE2 path but are still missing from the current AVX2 implementation. More infos here: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fe5cbc6e06c7d8b3a86f6f5491d74766bb5c2827 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a582564b24bec0443b5c5ff43ee6d1258f8bd658 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0e833e697bcf4c2f3f7fb9fce39d08cd4439e5d7 It would give the final touch to the patches. Best regards. Markus Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. Ãber das Internet versandte E-Mails können unter fremden Namen erstellt oder manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine rechtsverbindliche Willenserklärung. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln Vorstand: Kadir Akin Dr. Michael Höhnerbach Vorsitzender des Aufsichtsrates: Hans Kristian Langva Registergericht: Amtsgericht Köln Registernummer: HRB 52 497 This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. e-mails sent over the internet may have been written under a wrong name or been manipulated. That is why this message sent as an e-mail is not a legally binding declaration of intention. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln executive board: Kadir Akin Dr. Michael Höhnerbach President of the supervisory board: Hans Kristian Langva Registry office: district court Cologne Register number: HRB 52 497
AW: [PATCH 0/4] Add AVX512 optimized gen_syndrome and recovery functions
> Von: linux-raid-ow...@vger.kernel.org > [linux-raid-ow...@vger.kernel.org] im Auftrag von Gayatri Kammela > [gayatri.kamm...@intel.com] > Gesendet: Mittwoch, 3. August 2016 01:28 > An: linux-r...@vger.kernel.org > Cc: s...@kernel.org; linux-kernel@vger.kernel.org; h...@zytor.com; > james.t.kuku...@linux.intel.com; fenghua...@intel.com; > megha@linux.intel.com; ravi.v.shan...@intel.com; Gayatri Kammela > Betreff: [PATCH 0/4] Add AVX512 optimized gen_syndrome and recovery functions > > This is the patch set for adding AVX512 optimized gen_syndrome > and recovery functions. > > Optimization of RAID6 using AVX512 instructions should improve the > RAID6 performance.These patches are tested and observed the improvement > in performance. Hi Gayatri, as you already implemented the gen_syndrome() functions it should be a piece of cake to add the xor_syndrome() ones. Only if these are implemented we can make use of Read-Modify-Write operations if the kernel chooses an processor optimized algorithm. They are already in the SSE2 path but are still missing from the current AVX2 implementation. More infos here: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fe5cbc6e06c7d8b3a86f6f5491d74766bb5c2827 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a582564b24bec0443b5c5ff43ee6d1258f8bd658 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0e833e697bcf4c2f3f7fb9fce39d08cd4439e5d7 It would give the final touch to the patches. Best regards. Markus Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. Ãber das Internet versandte E-Mails können unter fremden Namen erstellt oder manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine rechtsverbindliche Willenserklärung. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln Vorstand: Kadir Akin Dr. Michael Höhnerbach Vorsitzender des Aufsichtsrates: Hans Kristian Langva Registergericht: Amtsgericht Köln Registernummer: HRB 52 497 This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. e-mails sent over the internet may have been written under a wrong name or been manipulated. That is why this message sent as an e-mail is not a legally binding declaration of intention. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln executive board: Kadir Akin Dr. Michael Höhnerbach President of the supervisory board: Hans Kristian Langva Registry office: district court Cologne Register number: HRB 52 497
AW: Possible RAID6 regression with ASYNC_TX_DMA enabled in 4.1
Hi Maxime,
> Von: linux-raid-ow...@vger.kernel.org
> [linux-raid-ow...@vger.kernel.org] im Auftrag von Maxime Ripard
> [maxime.rip...@free-electrons.com]
> Gesendet: Donnerstag, 7. Mai 2015 14:57
> An: Neil Brown; Shaohua Li
> Cc: linux-r...@vger.kernel.org; linux-kernel@vger.kernel.org; Lior Amsalem;
> Thomas Petazzoni; Gregory Clement; Boris Brezillon
> Betreff: Possible RAID6 regression with ASYNC_TX_DMA enabled in 4.1
>
> Hi,
>
> I'm currently trying to add support for the PQ operations on the
> marvell XOR engine, in dmaengine, obviously to be able to use async_tx
> to offload these operations.
>
> I'm testing these patches with a RAID6 array with 4 disks.
>
> However, since the commit 59fc630b8b5f ("RAID5: batch adjacent full
> stripe write", every write to that array fails with the following
> stacktrace.
>
> http://code.bulix.org/eh8iew-88342?raw
I don't know if it might be related. I added support for RAID6 Read-Modify-Write
in software XOR with some patches. The following commit mangles some lines in
async_pq.c:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?
id=584acdd49cd2472ca0f5a06adbe979db82d0b4af
I introduced a new flag ASYNC_TX_PQ_XOR_DST that notifies the async layer
that we want to do a XOR syndrome operation instead of a full calculation.
This will enforce the software path because I guessed that hardware does not
support that case. Without hardware to check I might have missed some
checks in the async layer.
In the upper layer ops_run_reconstruct6 will set the flag if we determined
that rmw is faster than rcw.
Can you check if rmw_level=0 fixes the issue. See:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?
id=d06f191f8ecaef4d524e765fdb455f96392fbd42
> It seems to be generated by that warning here:
>
> http://lxr.free-electrons.com/source/crypto/async_tx/async_tx.c#L173
>
> And indeed, if we dump the status of depend_tx here, it's already been
> acked.
>
> That doesn't happen if ASYNC_TX_DMA is disabled, hence using the
> software version of it, instead of relying on our XOR engine. It
> doesn't happen on any commit prior to the one mentionned above, with
> the exact same changes applied. These changes are meant to be
> contributed, so I can definitely push them somewhere if needed.
>
> I don't really know where to look for though, the change that is
> causing this is probably the change in ops_run_reconstruct6, but I'm
> not sure that this partial revert alone would work with regard to the
> rest of the patch.
>
> Maxime
Markus
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail
irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte
Weitergabe dieser Mail ist nicht gestattet.
Ãber das Internet versandte E-Mails können unter fremden Namen erstellt oder
manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine
rechtsverbindliche Willenserklärung.
Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln
Vorstand:
Kadir Akin
Dr. Michael Höhnerbach
Vorsitzender des Aufsichtsrates:
Hans Kristian Langva
Registergericht: Amtsgericht Köln
Registernummer: HRB 52 497
This e-mail may contain confidential and/or privileged information. If you
are not the intended recipient (or have received this e-mail in error)
please notify the sender immediately and destroy this e-mail. Any
unauthorized copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.
e-mails sent over the internet may have been written under a wrong name or
been manipulated. That is why this message sent as an e-mail is not a
legally binding declaration of intention.
Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln
executive board:
Kadir Akin
Dr. Michael Höhnerbach
President of the supervisory board:
Hans Kristian Langva
Registry office: district court Cologne
Register number: HRB 52 497
AW: Possible RAID6 regression with ASYNC_TX_DMA enabled in 4.1
Hi Maxime, Von: linux-raid-ow...@vger.kernel.org [linux-raid-ow...@vger.kernel.org]quot; im Auftrag von quot;Maxime Ripard [maxime.rip...@free-electrons.com] Gesendet: Donnerstag, 7. Mai 2015 14:57 An: Neil Brown; Shaohua Li Cc: linux-r...@vger.kernel.org; linux-kernel@vger.kernel.org; Lior Amsalem; Thomas Petazzoni; Gregory Clement; Boris Brezillon Betreff: Possible RAID6 regression with ASYNC_TX_DMA enabled in 4.1 Hi, I'm currently trying to add support for the PQ operations on the marvell XOR engine, in dmaengine, obviously to be able to use async_tx to offload these operations. I'm testing these patches with a RAID6 array with 4 disks. However, since the commit 59fc630b8b5f (RAID5: batch adjacent full stripe write, every write to that array fails with the following stacktrace. http://code.bulix.org/eh8iew-88342?raw I don't know if it might be related. I added support for RAID6 Read-Modify-Write in software XOR with some patches. The following commit mangles some lines in async_pq.c: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/? id=584acdd49cd2472ca0f5a06adbe979db82d0b4af I introduced a new flag ASYNC_TX_PQ_XOR_DST that notifies the async layer that we want to do a XOR syndrome operation instead of a full calculation. This will enforce the software path because I guessed that hardware does not support that case. Without hardware to check I might have missed some checks in the async layer. In the upper layer ops_run_reconstruct6 will set the flag if we determined that rmw is faster than rcw. Can you check if rmw_level=0 fixes the issue. See: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/? id=d06f191f8ecaef4d524e765fdb455f96392fbd42 It seems to be generated by that warning here: http://lxr.free-electrons.com/source/crypto/async_tx/async_tx.c#L173 And indeed, if we dump the status of depend_tx here, it's already been acked. That doesn't happen if ASYNC_TX_DMA is disabled, hence using the software version of it, instead of relying on our XOR engine. It doesn't happen on any commit prior to the one mentionned above, with the exact same changes applied. These changes are meant to be contributed, so I can definitely push them somewhere if needed. I don't really know where to look for though, the change that is causing this is probably the change in ops_run_reconstruct6, but I'm not sure that this partial revert alone would work with regard to the rest of the patch. Maxime Markus Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. Ãber das Internet versandte E-Mails können unter fremden Namen erstellt oder manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine rechtsverbindliche Willenserklärung. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln Vorstand: Kadir Akin Dr. Michael Höhnerbach Vorsitzender des Aufsichtsrates: Hans Kristian Langva Registergericht: Amtsgericht Köln Registernummer: HRB 52 497 This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. e-mails sent over the internet may have been written under a wrong name or been manipulated. That is why this message sent as an e-mail is not a legally binding declaration of intention. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln executive board: Kadir Akin Dr. Michael Höhnerbach President of the supervisory board: Hans Kristian Langva Registry office: district court Cologne Register number: HRB 52 497
AW: [PATCH] crypto: powerpc - move files to fix build error
> Von: Kim Phillips [kim.phill...@freescale.com]
> Gesendet: Samstag, 7. März 2015 01:46
> An: Herbert Xu; Benjamin Herrenschmidt; Paul Mackerras; Michael Ellerman
> Cc: Markus Stockhausen; linux-cry...@vger.kernel.org;
> linuxppc-...@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Betreff: [PATCH] crypto: powerpc - move files to fix build error
>
> The current cryptodev-2.6 tree commits:
>
> d9850fc529ef ("crypto: powerpc/sha1 - kernel config")
> 50ba29aaa7b0 ("crypto: powerpc/sha1 - glue")
>
> failed to properly place files under arch/powerpc/crypto, which
> leads to build errors:
>
> make[1]: *** No rule to make target 'arch/powerpc/crypto/sha1-spe-asm.o',
> needed by 'arch/powerpc/crypto/sha1-ppc-spe.o'. Stop.
> make[1]: *** No rule to make target 'arch/powerpc/crypto/sha1_spe_glue.o',
> needed by 'arch/powerpc/crypto/sha1-ppc-spe.o'. Stop.
> Makefile:947: recipe for target 'arch/powerpc/crypto' failed
>
> Move the two sha1 spe files under crypto/, and whilst there, rename
> other powerpc crypto files with underscores to use dashes for
> consistency.
Sorry for the glitches. Did not notice that I had the files in adjacent folders
and finally added the wrong ones to my git. Thanks a lot for fixing that.
Markus
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail
irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte
Weitergabe dieser Mail ist nicht gestattet.
Ãber das Internet versandte E-Mails können unter fremden Namen erstellt oder
manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine
rechtsverbindliche Willenserklärung.
Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln
Vorstand:
Kadir Akin
Dr. Michael Höhnerbach
Vorsitzender des Aufsichtsrates:
Hans Kristian Langva
Registergericht: Amtsgericht Köln
Registernummer: HRB 52 497
This e-mail may contain confidential and/or privileged information. If you
are not the intended recipient (or have received this e-mail in error)
please notify the sender immediately and destroy this e-mail. Any
unauthorized copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.
e-mails sent over the internet may have been written under a wrong name or
been manipulated. That is why this message sent as an e-mail is not a
legally binding declaration of intention.
Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln
executive board:
Kadir Akin
Dr. Michael Höhnerbach
President of the supervisory board:
Hans Kristian Langva
Registry office: district court Cologne
Register number: HRB 52 497
AW: [PATCH] crypto: powerpc - move files to fix build error
Von: Kim Phillips [kim.phill...@freescale.com] Gesendet: Samstag, 7. März 2015 01:46 An: Herbert Xu; Benjamin Herrenschmidt; Paul Mackerras; Michael Ellerman Cc: Markus Stockhausen; linux-cry...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux-kernel@vger.kernel.org Betreff: [PATCH] crypto: powerpc - move files to fix build error The current cryptodev-2.6 tree commits: d9850fc529ef (crypto: powerpc/sha1 - kernel config) 50ba29aaa7b0 (crypto: powerpc/sha1 - glue) failed to properly place files under arch/powerpc/crypto, which leads to build errors: make[1]: *** No rule to make target 'arch/powerpc/crypto/sha1-spe-asm.o', needed by 'arch/powerpc/crypto/sha1-ppc-spe.o'. Stop. make[1]: *** No rule to make target 'arch/powerpc/crypto/sha1_spe_glue.o', needed by 'arch/powerpc/crypto/sha1-ppc-spe.o'. Stop. Makefile:947: recipe for target 'arch/powerpc/crypto' failed Move the two sha1 spe files under crypto/, and whilst there, rename other powerpc crypto files with underscores to use dashes for consistency. Sorry for the glitches. Did not notice that I had the files in adjacent folders and finally added the wrong ones to my git. Thanks a lot for fixing that. Markus Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. Ãber das Internet versandte E-Mails können unter fremden Namen erstellt oder manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine rechtsverbindliche Willenserklärung. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln Vorstand: Kadir Akin Dr. Michael Höhnerbach Vorsitzender des Aufsichtsrates: Hans Kristian Langva Registergericht: Amtsgericht Köln Registernummer: HRB 52 497 This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden. e-mails sent over the internet may have been written under a wrong name or been manipulated. That is why this message sent as an e-mail is not a legally binding declaration of intention. Collogia Unternehmensberatung AG Ubierring 11 D-50678 Köln executive board: Kadir Akin Dr. Michael Höhnerbach President of the supervisory board: Hans Kristian Langva Registry office: district court Cologne Register number: HRB 52 497
