Re: [PATCH] perf session: Fix undeclared 'oe'

[Murilo Opsfelder Araújo]

On 04/11/2018 04:33 PM, Greg Kroah-Hartman wrote:
> On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote:
>> Using linux-3.18.y branch, perf build fails with the following:
>>
>> $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 
>> HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 
>> prefix=/usr DESTDIR=/tmp/builddir/build all
>> [...]
>> util/session.c: In function ‘__perf_session__process_pipe_events’:
>> util/session.c:1093:36: error: ‘oe’ undeclared (first use in this 
>> function)
>>   ordered_events__set_copy_on_queue(oe, true);
>> ^
>> util/session.c:1093:36: note: each undeclared identifier is reported 
>> only once for each function it appears in
>>
>> This patch fixes it for linux-3.18.y branch.
> 
> Why is this failing now?  Has it always been broken?  Is there an
> upstream patch that fixed this instead?
> 

Hi, Greg.

We've caught this build issue this week. I'm not sure since when it's
failing.

The upstream patch that fixes this is:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d

commit fa713a4eb9cebe5dec71b1bd11429603e17d841d
Author: Arnaldo Carvalho de Melo 
Date:   Tue Mar 3 11:48:12 2015 -0300

perf ordered_events: Untangle from perf_session

But it doesn't apply straightforwardly.  At
fa713a4eb9cebe5dec71b1bd11429603e17d841d, perf API and perf_evlist
struct are slightly different from linux-3.18.y.

A list of upstream patches for a clean backport (I think) would be:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=54245fdc357613633954bfd38cffb71cb9def067

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75be989a7a18e9666efd92b846ee48bed79e8086

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=313e53b08e99b1dacf9ea2b0fbe97890db1ea95f

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9fa8727aa4d98d35ca50ef9cd8a50c6468af921d

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d

Do you prefer all above patches backported to linux-3.18.y or just the
one-line fix I sent?

>> Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in 
>> pipe mode")
> 
> Was this just a bad backport?

Some patches were left behind, I guess.

> 
> thanks,
> 
> greg k-h
> 

Cheers
Murilo

Re: [PATCH] perf session: Fix undeclared 'oe'

[Murilo Opsfelder Araújo]

On 04/11/2018 04:33 PM, Greg Kroah-Hartman wrote:
> On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote:
>> Using linux-3.18.y branch, perf build fails with the following:
>>
>> $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 
>> HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 
>> prefix=/usr DESTDIR=/tmp/builddir/build all
>> [...]
>> util/session.c: In function ‘__perf_session__process_pipe_events’:
>> util/session.c:1093:36: error: ‘oe’ undeclared (first use in this 
>> function)
>>   ordered_events__set_copy_on_queue(oe, true);
>> ^
>> util/session.c:1093:36: note: each undeclared identifier is reported 
>> only once for each function it appears in
>>
>> This patch fixes it for linux-3.18.y branch.
> 
> Why is this failing now?  Has it always been broken?  Is there an
> upstream patch that fixed this instead?
> 

Hi, Greg.

We've caught this build issue this week. I'm not sure since when it's
failing.

The upstream patch that fixes this is:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d

commit fa713a4eb9cebe5dec71b1bd11429603e17d841d
Author: Arnaldo Carvalho de Melo 
Date:   Tue Mar 3 11:48:12 2015 -0300

perf ordered_events: Untangle from perf_session

But it doesn't apply straightforwardly.  At
fa713a4eb9cebe5dec71b1bd11429603e17d841d, perf API and perf_evlist
struct are slightly different from linux-3.18.y.

A list of upstream patches for a clean backport (I think) would be:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=54245fdc357613633954bfd38cffb71cb9def067

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75be989a7a18e9666efd92b846ee48bed79e8086

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=313e53b08e99b1dacf9ea2b0fbe97890db1ea95f

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9fa8727aa4d98d35ca50ef9cd8a50c6468af921d

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d

Do you prefer all above patches backported to linux-3.18.y or just the
one-line fix I sent?

>> Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in 
>> pipe mode")
> 
> Was this just a bad backport?

Some patches were left behind, I guess.

> 
> thanks,
> 
> greg k-h
> 

Cheers
Murilo

Re: [PATCH v2] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 07/26/2017 04:37 PM, Alex Williamson wrote:
[...]
> Applied to my for-linus branch with David and Alexey's R-b for v4.13.
> Thanks,
> 
> Alex

Thank you all!

-- 
Murilo

Re: [PATCH v2] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 07/26/2017 04:37 PM, Alex Williamson wrote:
[...]
> Applied to my for-linus branch with David and Alexey's R-b for v4.13.
> Thanks,
> 
> Alex

Thank you all!

-- 
Murilo

Re: [PATCH v2] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 07/18/2017 02:22 PM, Murilo Opsfelder Araujo wrote:
> When CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n, build fails with the
> following:
> 
> drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release':
> vfio_pci.c:(.text+0xa98): undefined reference to 
> `.vfio_spapr_pci_eeh_release'
> drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open':
> vfio_pci.c:(.text+0x1420): undefined reference to 
> `.vfio_spapr_pci_eeh_open'
> 
> In this case, vfio_pci.c should use the empty definitions of
> vfio_spapr_pci_eeh_open and vfio_spapr_pci_eeh_release functions.
> 
> This patch fixes it by guarding these function definitions with
> CONFIG_VFIO_SPAPR_EEH, the symbol that controls whether vfio_spapr_eeh.c is
> built, which is where the non-empty versions of these functions are. We need 
> to
> make use of IS_ENABLED() macro because CONFIG_VFIO_SPAPR_EEH is a tristate
> option.
> 
> This issue was found during a randconfig build. Logs are here:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/
> 
> Signed-off-by: Murilo Opsfelder Araujo 
> ---
> 
> Changes from v1:
> - Rebased on top of next-20170718.

Hi, Alex.

Are you applying this?

Thanks!

-- 
Murilo

Re: [PATCH v2] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 07/18/2017 02:22 PM, Murilo Opsfelder Araujo wrote:
> When CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n, build fails with the
> following:
> 
> drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release':
> vfio_pci.c:(.text+0xa98): undefined reference to 
> `.vfio_spapr_pci_eeh_release'
> drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open':
> vfio_pci.c:(.text+0x1420): undefined reference to 
> `.vfio_spapr_pci_eeh_open'
> 
> In this case, vfio_pci.c should use the empty definitions of
> vfio_spapr_pci_eeh_open and vfio_spapr_pci_eeh_release functions.
> 
> This patch fixes it by guarding these function definitions with
> CONFIG_VFIO_SPAPR_EEH, the symbol that controls whether vfio_spapr_eeh.c is
> built, which is where the non-empty versions of these functions are. We need 
> to
> make use of IS_ENABLED() macro because CONFIG_VFIO_SPAPR_EEH is a tristate
> option.
> 
> This issue was found during a randconfig build. Logs are here:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/
> 
> Signed-off-by: Murilo Opsfelder Araujo 
> ---
> 
> Changes from v1:
> - Rebased on top of next-20170718.

Hi, Alex.

Are you applying this?

Thanks!

-- 
Murilo

Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 06/08/2017 10:10 AM, Alexey Kardashevskiy wrote:
[...]
> The config you attached in the first mail has CONFIG_VFIO_SPAPR_EEH=m, here
> is my confusion. The config from the link below does not have KVM_BOOK3S_64
> which selects SPAPR_TCE_IOMMU and which in turn selects VFIO_IOMMU_SPAPR_TCE.
> 
> So
> https://github.com/0day-ci/linux/commit/36ed1ddb05e132aa3cfbb610f0f8402a0774da12
> looks correct.

It wasn't me that attached the .config.gz, it was this 0dayci robot.

When CONFIG_VFIO_SPAPR_EEH=m, there is no definition of it in autoconf.h, only
CONFIG_VFIO_SPAPR_EEH_MODULE is defined:

$ grep 'VFIO_SPAPR_EEH' ./include/generated/autoconf.h
#define CONFIG_VFIO_SPAPR_EEH_MODULE 1

In this case, `#ifdef CONFIG_VFIO_SPAPR_EEH` will be false. That's why my v1
patch failed with the 0dayci .config and robot reported back.

This was addressed in my v2 patch using the IS_ENABLED() macro, which checks for
both CONFIG_ and CONFIG__MODULE definitions.

-- 
Murilo

Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 06/08/2017 10:10 AM, Alexey Kardashevskiy wrote:
[...]
> The config you attached in the first mail has CONFIG_VFIO_SPAPR_EEH=m, here
> is my confusion. The config from the link below does not have KVM_BOOK3S_64
> which selects SPAPR_TCE_IOMMU and which in turn selects VFIO_IOMMU_SPAPR_TCE.
> 
> So
> https://github.com/0day-ci/linux/commit/36ed1ddb05e132aa3cfbb610f0f8402a0774da12
> looks correct.

It wasn't me that attached the .config.gz, it was this 0dayci robot.

When CONFIG_VFIO_SPAPR_EEH=m, there is no definition of it in autoconf.h, only
CONFIG_VFIO_SPAPR_EEH_MODULE is defined:

$ grep 'VFIO_SPAPR_EEH' ./include/generated/autoconf.h
#define CONFIG_VFIO_SPAPR_EEH_MODULE 1

In this case, `#ifdef CONFIG_VFIO_SPAPR_EEH` will be false. That's why my v1
patch failed with the 0dayci .config and robot reported back.

This was addressed in my v2 patch using the IS_ENABLED() macro, which checks for
both CONFIG_ and CONFIG__MODULE definitions.

-- 
Murilo

Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 06/08/2017 08:41 AM, Michael Ellerman wrote:
> Alexey Kardashevskiy  writes:
> 
>> Hi,
>>
>> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make
>> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y.
> 
> Hmm, Murilo did you confirm the bug still happens on upstream with that
> rand config?

Yes, it's still happening with next-20170607.

For me, `make oldconfig` hasn't changed it to CONFIG_VFIO_SPAPR_EEH=y. See:

$ git clean -dfxq
$ git reset --hard origin/master
HEAD is now at 8d1b80c Add linux-next specific files for 20170607

$ curl http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/config/ -o 
.config
$ grep -E 'EEH|SPAPR' .config
CONFIG_EEH=y
# CONFIG_SPAPR_TCE_IOMMU is not set

$ yes '' | make oldconfig

$ grep -E 'EEH|SPAPR' .config
CONFIG_EEH=y
# CONFIG_SPAPR_TCE_IOMMU is not set

$ make -j 160 ARCH=powerpc
...
drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release':
vfio_pci.c:(.text+0xa98): undefined reference to 
`.vfio_spapr_pci_eeh_release'
drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open':
vfio_pci.c:(.text+0x1420): undefined reference to `.vfio_spapr_pci_eeh_open'
make: *** [vmlinux] Error 1

-- 
Murilo

Re: [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH

[Murilo Opsfelder Araújo]

On 06/08/2017 08:41 AM, Michael Ellerman wrote:
> Alexey Kardashevskiy  writes:
> 
>> Hi,
>>
>> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make
>> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y.
> 
> Hmm, Murilo did you confirm the bug still happens on upstream with that
> rand config?

Yes, it's still happening with next-20170607.

For me, `make oldconfig` hasn't changed it to CONFIG_VFIO_SPAPR_EEH=y. See:

$ git clean -dfxq
$ git reset --hard origin/master
HEAD is now at 8d1b80c Add linux-next specific files for 20170607

$ curl http://kisskb.ellerman.id.au/kisskb/buildresult/12982362/config/ -o 
.config
$ grep -E 'EEH|SPAPR' .config
CONFIG_EEH=y
# CONFIG_SPAPR_TCE_IOMMU is not set

$ yes '' | make oldconfig

$ grep -E 'EEH|SPAPR' .config
CONFIG_EEH=y
# CONFIG_SPAPR_TCE_IOMMU is not set

$ make -j 160 ARCH=powerpc
...
drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_release':
vfio_pci.c:(.text+0xa98): undefined reference to 
`.vfio_spapr_pci_eeh_release'
drivers/vfio/pci/vfio_pci.o: In function `.vfio_pci_open':
vfio_pci.c:(.text+0x1420): undefined reference to `.vfio_spapr_pci_eeh_open'
make: *** [vmlinux] Error 1

-- 
Murilo

Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies

[Murilo Opsfelder Araújo]

On 05/28/2017 11:08 PM, Michael Ellerman wrote:
[...]
> We could stub out the RTAS pieces it needs. But I don't think it buys us
> much, for compile testing you may as well just build a config which has
> PPC_RTAS enabled, there are several.
> 
> So I think it should just depend on PPC_RTAS.
> 
> Murilo can you send a v2?
> 
> cheers

Thanks, Guenter and Michael, for reviewing!

I sent out a v2.

-- 
Murilo

Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies

[Murilo Opsfelder Araújo]

On 05/28/2017 11:08 PM, Michael Ellerman wrote:
[...]
> We could stub out the RTAS pieces it needs. But I don't think it buys us
> much, for compile testing you may as well just build a config which has
> PPC_RTAS enabled, there are several.
> 
> So I think it should just depend on PPC_RTAS.
> 
> Murilo can you send a v2?
> 
> cheers

Thanks, Guenter and Michael, for reviewing!

I sent out a v2.

-- 
Murilo

Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

[Murilo Opsfelder Araújo]

On Thu, Aug 20, 2015 at 8:27 AM, David Vrabel  wrote:
> On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of 
>> ‘xen_tmem_get_page’ makes pointer from integer without a cast
>>   ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>>^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of 
>> type ‘long unsigned int’
>>  static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>
> I've folded this in, thanks.
>
> David

Thanks, David.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

[Murilo Opsfelder Araújo]

On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall  wrote:
> Hi,
>
> On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
>>
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of
>> ‘xen_tmem_get_page’ makes pointer from integer without a cast
>>ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>> ^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is
>> of type ‘long unsigned int’
>>   static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>>  ^
>>
>> Signed-off-by: Murilo Opsfelder Araujo 
>
>
> Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not
> enabled on my config.
>
> Reviewed-by: Julien Grall 
>
> Regards,
>
> --
> Julien Grall

Hi, Julien.

No need to apologize, and thanks for reviewing that.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

[Murilo Opsfelder Araújo]

On Thu, Aug 20, 2015 at 8:27 AM, David Vrabel david.vra...@citrix.com wrote:
 On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
 The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 xen/tmem: Use
 xen_page_to_gfn rather than pfn_to_gfn left behind a call to
 xen_tmem_get_page() receiving pfn instead of page.

 This change also fixes the following build warning:

 drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
 drivers/xen/tmem.c:194:47: warning: passing argument 4 of 
 ‘xen_tmem_get_page’ makes pointer from integer without a cast
   ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
^
 drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of 
 type ‘long unsigned int’
  static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,

 I've folded this in, thanks.

 David

Thanks, David.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

[Murilo Opsfelder Araújo]

On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall julien.gr...@citrix.com wrote:
 Hi,

 On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:

 The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 xen/tmem: Use
 xen_page_to_gfn rather than pfn_to_gfn left behind a call to
 xen_tmem_get_page() receiving pfn instead of page.

 This change also fixes the following build warning:

 drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
 drivers/xen/tmem.c:194:47: warning: passing argument 4 of
 ‘xen_tmem_get_page’ makes pointer from integer without a cast
ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
 ^
 drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is
 of type ‘long unsigned int’
   static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
  ^

 Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com


 Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not
 enabled on my config.

 Reviewed-by: Julien Grall julien.gr...@citrix.com

 Regards,

 --
 Julien Grall

Hi, Julien.

No need to apologize, and thanks for reviewing that.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] security/smack/smack_lsm.c: Fix build error when CONFIG_SECURITY_SMACK_BRINGUP is not defined

[Murilo Opsfelder Araújo]

On Fri, Aug 14, 2015 at 1:06 AM, Casey Schaufler  wrote:
> On 8/13/2015 5:52 PM, Murilo Opsfelder Araujo wrote:
>> This change fixes the following build error when
>> CONFIG_SECURITY_SMACK_BRINGUP is not defined:
>>
>> security/smack/smack_lsm.c: In function ‘smack_parse_opts_str’:
>> security/smack/smack_lsm.c:618:26: error: ‘tokens’ undeclared (first use in 
>> this function)
>>token = match_token(p, tokens, args);
>>   ^
>> security/smack/smack_lsm.c:618:26: note: each undeclared identifier is 
>> reported only once for each function it appears in
>>
>> The above has been introduced by commit
>> 3bf2789cad9e6573dc19a6c3d123c2c049f2d90f "smack: allow mount opts setting 
>> over filesystems with binary mount data".
>>
>> Signed-off-by: Murilo Opsfelder Araujo 
>
> I have already made a pull request for an almost identical patch
> to James' next tree.
>

Thanks for the reply, Casey.  The fix has already landed -next tree.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] security/smack/smack_lsm.c: Fix build error when CONFIG_SECURITY_SMACK_BRINGUP is not defined

[Murilo Opsfelder Araújo]

On Fri, Aug 14, 2015 at 1:06 AM, Casey Schaufler ca...@schaufler-ca.com wrote:
 On 8/13/2015 5:52 PM, Murilo Opsfelder Araujo wrote:
 This change fixes the following build error when
 CONFIG_SECURITY_SMACK_BRINGUP is not defined:

 security/smack/smack_lsm.c: In function ‘smack_parse_opts_str’:
 security/smack/smack_lsm.c:618:26: error: ‘tokens’ undeclared (first use in 
 this function)
token = match_token(p, tokens, args);
   ^
 security/smack/smack_lsm.c:618:26: note: each undeclared identifier is 
 reported only once for each function it appears in

 The above has been introduced by commit
 3bf2789cad9e6573dc19a6c3d123c2c049f2d90f smack: allow mount opts setting 
 over filesystems with binary mount data.

 Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com

 I have already made a pull request for an almost identical patch
 to James' next tree.


Thanks for the reply, Casey.  The fix has already landed -next tree.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] drivers: clk: clk.c: Make clk_is_orphan() dependent of CONFIG_OF

[Murilo Opsfelder Araújo]

On Wed, May 6, 2015 at 9:55 PM, Stephen Boyd  wrote:
> On 05/06/15 17:51, Murilo Opsfelder Araujo wrote:
>> The function clk_is_orphan() is called only by
>> __of_clk_get_from_provider(), which depends on CONFIG_OF, so it does
>> make sense the move.
>>
>> This change also gets rid of the following build message when CONFIG_OF
>> is not set:
>>
>> drivers/clk/clk.c:2231:13: warning: ‘clk_is_orphan’ defined but not used 
>> [-Wunused-function]
>>
>> Signed-off-by: Murilo Opsfelder Araujo 
>
> The patch that introduces this problem is gone now.
>

Nice to know it is gone.  I'm using next-20150506 which still contains
that.  Probably the fix will land a next -next release.

Thanks, Stephen.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] drivers: clk: clk.c: Make clk_is_orphan() dependent of CONFIG_OF

[Murilo Opsfelder Araújo]

On Wed, May 6, 2015 at 9:55 PM, Stephen Boyd sb...@codeaurora.org wrote:
 On 05/06/15 17:51, Murilo Opsfelder Araujo wrote:
 The function clk_is_orphan() is called only by
 __of_clk_get_from_provider(), which depends on CONFIG_OF, so it does
 make sense the move.

 This change also gets rid of the following build message when CONFIG_OF
 is not set:

 drivers/clk/clk.c:2231:13: warning: ‘clk_is_orphan’ defined but not used 
 [-Wunused-function]

 Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com

 The patch that introduces this problem is gone now.


Nice to know it is gone.  I'm using next-20150506 which still contains
that.  Probably the fix will land a next -next release.

Thanks, Stephen.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

On Sun, Apr 19, 2015 at 2:08 PM, Murilo Opsfelder Araújo
 wrote:
> On Fri, Apr 17, 2015 at 11:00 PM, Herbert Xu
>  wrote:
>> On Fri, Apr 17, 2015 at 06:38:49PM -0400, Mike Snitzer wrote:
>>>
>>> There are also some crypto changes that could very easily be the cause
>>> of your problem (cc'ing Herbert), e.g.:
>>>
>>> $ git diff next-20150410^..next-20150413 -- crypto | diffstat
>>
>> My guess is that you guys need this patch:
>>
>> commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085
>> Author: Herbert Xu 
>> Date:   Thu Apr 16 11:07:13 2015 +0800
>>
>> crypto: fix broken crypto_register_instance() module handling
>>
>> Cheers,
>> --
>> Email: Herbert Xu 
>> Home Page: http://gondor.apana.org.au/~herbert/
>> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
> Hello, Herbert.
>
> Sorry for my ignorance but which tree and branch does this commit come from?
>
> --
> Murilo

I tried next-20150422 (that contained Herbert's patch) and it worked just fine.

Thank you, guys.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

On Sun, Apr 19, 2015 at 2:08 PM, Murilo Opsfelder Araújo
mopsfel...@gmail.com wrote:
 On Fri, Apr 17, 2015 at 11:00 PM, Herbert Xu
 herb...@gondor.apana.org.au wrote:
 On Fri, Apr 17, 2015 at 06:38:49PM -0400, Mike Snitzer wrote:

 There are also some crypto changes that could very easily be the cause
 of your problem (cc'ing Herbert), e.g.:

 $ git diff next-20150410^..next-20150413 -- crypto | diffstat

 My guess is that you guys need this patch:

 commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085
 Author: Herbert Xu herb...@gondor.apana.org.au
 Date:   Thu Apr 16 11:07:13 2015 +0800

 crypto: fix broken crypto_register_instance() module handling

 Cheers,
 --
 Email: Herbert Xu herb...@gondor.apana.org.au
 Home Page: http://gondor.apana.org.au/~herbert/
 PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

 Hello, Herbert.

 Sorry for my ignorance but which tree and branch does this commit come from?

 --
 Murilo

I tried next-20150422 (that contained Herbert's patch) and it worked just fine.

Thank you, guys.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

On Fri, Apr 17, 2015 at 11:00 PM, Herbert Xu
 wrote:
> On Fri, Apr 17, 2015 at 06:38:49PM -0400, Mike Snitzer wrote:
>>
>> There are also some crypto changes that could very easily be the cause
>> of your problem (cc'ing Herbert), e.g.:
>>
>> $ git diff next-20150410^..next-20150413 -- crypto | diffstat
>
> My guess is that you guys need this patch:
>
> commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085
> Author: Herbert Xu 
> Date:   Thu Apr 16 11:07:13 2015 +0800
>
> crypto: fix broken crypto_register_instance() module handling
>
> Cheers,
> --
> Email: Herbert Xu 
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Hello, Herbert.

Sorry for my ignorance but which tree and branch does this commit come from?

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

On Fri, Apr 17, 2015 at 7:38 PM, Mike Snitzer  wrote:
> On Fri, Apr 17 2015 at  4:11pm -0400,
> Murilo Opsfelder Araújo  wrote:
>
>> Hello, everyone.
>>
>> Right after I enter my passphrase to unlock my cryptsetup partition,
>> it displays the following error and asks for cryptsetup password again
>> (it got stuck on this loop).
>>
>> This issue was introduced in next-20150413.  next-20150410 is working just 
>> fine.
>>
>> Any hint on how to debug this?
>>
>> Unlocking the disk /dev/disk/by-uuid/ (sda5_crypt)
>> Enter passphrase: *
>> [  244.239821] device-mapper: table: 252:0: crypt: Error allocating crypto 
>> tfm
>> device-mapper: reload ioctl on  failed: No such file or directory
>> Failed to open temporary keystore device.
>> device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
>> such device or address
>> device-mapper: reload ioctl on temporary-cryptsetup-239 failed: No
>> such device or address
>> device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
>> such device or address
>> device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
>> such device or address
>> device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
>> such device or address
>> device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
>> such device or address
>
> git diff next-20150410^..next-20150413 drivers/md/dm-crypt.c points to
> this commit as the nly dm-crpt.c change:
> https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next=5977907937afa2b5584a874d44ba6c0f56aeaa9c
>
> Which appears unrelated given your "crypt: Error allocating crypto tfm"
> error.
>
> But any chance you can try reverting that commit from next-20150413 and
> re-test just to be absolutely sure?

Hello, Mike.

I've reverted that commit from both next-20150413 and next-20150415.
In both cases, I got the same error, no success.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

On Fri, Apr 17, 2015 at 11:00 PM, Herbert Xu
herb...@gondor.apana.org.au wrote:
 On Fri, Apr 17, 2015 at 06:38:49PM -0400, Mike Snitzer wrote:

 There are also some crypto changes that could very easily be the cause
 of your problem (cc'ing Herbert), e.g.:

 $ git diff next-20150410^..next-20150413 -- crypto | diffstat

 My guess is that you guys need this patch:

 commit 34c9a0ffc75ad25b6a60f61e27c4a4b1189b8085
 Author: Herbert Xu herb...@gondor.apana.org.au
 Date:   Thu Apr 16 11:07:13 2015 +0800

 crypto: fix broken crypto_register_instance() module handling

 Cheers,
 --
 Email: Herbert Xu herb...@gondor.apana.org.au
 Home Page: http://gondor.apana.org.au/~herbert/
 PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Hello, Herbert.

Sorry for my ignorance but which tree and branch does this commit come from?

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

On Fri, Apr 17, 2015 at 7:38 PM, Mike Snitzer snit...@redhat.com wrote:
 On Fri, Apr 17 2015 at  4:11pm -0400,
 Murilo Opsfelder Araújo mopsfel...@gmail.com wrote:

 Hello, everyone.

 Right after I enter my passphrase to unlock my cryptsetup partition,
 it displays the following error and asks for cryptsetup password again
 (it got stuck on this loop).

 This issue was introduced in next-20150413.  next-20150410 is working just 
 fine.

 Any hint on how to debug this?

 Unlocking the disk /dev/disk/by-uuid/uuid (sda5_crypt)
 Enter passphrase: *
 [  244.239821] device-mapper: table: 252:0: crypt: Error allocating crypto 
 tfm
 device-mapper: reload ioctl on  failed: No such file or directory
 Failed to open temporary keystore device.
 device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
 such device or address
 device-mapper: reload ioctl on temporary-cryptsetup-239 failed: No
 such device or address
 device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
 such device or address
 device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
 such device or address
 device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
 such device or address
 device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
 such device or address

 git diff next-20150410^..next-20150413 drivers/md/dm-crypt.c points to
 this commit as the nly dm-crpt.c change:
 https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-nextid=5977907937afa2b5584a874d44ba6c0f56aeaa9c

 Which appears unrelated given your crypt: Error allocating crypto tfm
 error.

 But any chance you can try reverting that commit from next-20150413 and
 re-test just to be absolutely sure?

Hello, Mike.

I've reverted that commit from both next-20150413 and next-20150415.
In both cases, I got the same error, no success.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

Hello, everyone.

Right after I enter my passphrase to unlock my cryptsetup partition,
it displays the following error and asks for cryptsetup password again
(it got stuck on this loop).

This issue was introduced in next-20150413.  next-20150410 is working just fine.

Any hint on how to debug this?

Unlocking the disk /dev/disk/by-uuid/ (sda5_crypt)
Enter passphrase: *
[  244.239821] device-mapper: table: 252:0: crypt: Error allocating crypto tfm
device-mapper: reload ioctl on  failed: No such file or directory
Failed to open temporary keystore device.
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: reload ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Device mapper failed to open temporary keystore device

[Murilo Opsfelder Araújo]

Hello, everyone.

Right after I enter my passphrase to unlock my cryptsetup partition,
it displays the following error and asks for cryptsetup password again
(it got stuck on this loop).

This issue was introduced in next-20150413.  next-20150410 is working just fine.

Any hint on how to debug this?

Unlocking the disk /dev/disk/by-uuid/uuid (sda5_crypt)
Enter passphrase: *
[  244.239821] device-mapper: table: 252:0: crypt: Error allocating crypto tfm
device-mapper: reload ioctl on  failed: No such file or directory
Failed to open temporary keystore device.
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: reload ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address
device-mapper: remove ioctl on temporary-cryptsetup-239 failed: No
such device or address

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] gpio: sx150x: Fix compile issue when CONFIG_OF_GPIO is not defined

[Murilo Opsfelder Araújo]

On Thu, Jan 22, 2015 at 10:45 PM, Alexandre Courbot  wrote:
[...]
> Linus just sent a patch to fix this, see
> http://patchwork.ozlabs.org/patch/431704/

Nice to know it has already been addressed.  Thanks for the link, Alexandre.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] gpio: sx150x: Fix compile issue when CONFIG_OF_GPIO is not defined

[Murilo Opsfelder Araújo]

On Thu, Jan 22, 2015 at 10:45 PM, Alexandre Courbot gnu...@gmail.com wrote:
[...]
 Linus just sent a patch to fix this, see
 http://patchwork.ozlabs.org/patch/431704/

Nice to know it has already been addressed.  Thanks for the link, Alexandre.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] rtlwifi: Add more checks for get_btc_status callback

[Murilo Opsfelder Araújo]

On Thu, Nov 6, 2014 at 9:30 PM, Larry Finger  wrote:
> On 11/06/2014 04:52 PM, Murilo Opsfelder Araujo wrote:
>>
>> On 11/06/2014 09:40 AM, Murilo Opsfelder Araujo wrote:
>>>
>>> On 11/05/2014 04:12 PM, Larry Finger wrote:

 On 11/05/2014 03:16 AM, Mike Galbraith wrote:
>
> On Wed, 2014-10-29 at 23:30 -0500, Larry Finger wrote:
>>
>> On 10/29/2014 06:28 PM, Murilo Opsfelder Araujo wrote:
>>>
>>> This is a complement of commit
>>> 08054200117a95afc14c3d2ed3a38bf4e345bf78
>>> "rtlwifi: Add check for get_btc_status callback".
>>>
>>> With this patch, next-20141029 at least does not panic with rtl8192se
>>> device.
>>>
>>
>> This patch is OK, but as noted it is not complete.
>>
>> I have patches to fix all the kernel panics for rtl8192se AND
>> rtl8192ce. There
>> are missing parts, but I would prefer submitting mine, which would
>> conflict with
>> this one. For that reason, NACK for this one, and please apply the
>> set I am
>> submitting now.
>
>
> It's all in there now, but my RTL8191SEvB is still dead.  Squabbling
> with it isn't going all that well either.
>
> As soon as 38506ece rtlwifi: rtl_pci: Start modification for new
> drivers
> is applied, explosions appear.  Subsequently applying...
>
> 08054200 rtlwifi: Add check for get_btc_status callback
> c0386f15 rtlwifi: rtl8192ce: rtl8192de: rtl8192se: Fix handling for
> missing get_btc_status
> 50147969 rtlwifi: rtl8192se: Fix duplicate calls to
> ieee80211_register_hw()
> 30c5ccc6 rtlwifi: rtl8192se: Add missing section to read descriptor
> setting
> 75a916e1 rtlwifi: rtl8192se: Fix firmware loading
>
> ...fixes that mess up, but leaves the interface dead in the same manner
> as if nothing has been reverted.  So it _seems_ the bustage lurks in
> 38506ece somewhere.  Too bad it's non-dinky, and written in wifi-ese :)


 Yes, I am aware that rtl8192se is failing, and now that I am back from
 vacation, I am working on the problem. If you want to use the driver
 with kernel 3.18, clone the repo at
 http://github.com/lwfinger/rtlwifi_new.git and build and install either
 the master or kernel_version branches. Both work.

 I am in the process of trying to find what the crucial difference is
 between that repo and the kernel version.

 Larry


>>> I'm sending to everyone so others can jump in as well.
>>>
>>> Here are the steps I've followed.
>>>
>>> Installed and booted my kernel:
>>>
>>> $ sudo dpkg -i
>>> linux-image-3.18.0-rc3-next-20141105-panda_3.18.0-rc3-next-20141105-panda-1_amd64.deb
>>> linux-headers-3.18.0-rc3-next-20141105-panda_3.18.0-rc3-next-20141105-panda-1_amd64.deb
>>>
>>> Built modules from Larry's github repository.
>>>
>>> $ cd rtlwifi_new
>>> $ make
>>> $ sudo make install
>>>
>>> $ sudo modprobe -rv rtl8192se
>>> rmmod rtl8192se
>>> rmmod rtl_pci
>>> rmmod rtlwifi
>>> rmmod mac80211
>>> rmmod cfg80211
>>>
>>> The module does not load:
>>>
>>> $ sudo modprobe -v rtl8192se
>>> insmod
>>> /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/net/wireless/cfg80211.ko
>>> insmod
>>> /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/net/mac80211/mac80211.ko
>>> insmod
>>> /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/drivers/net/wireless/rtlwifi/rtlwifi.ko
>>> insmod
>>> /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/drivers/net/wireless/rtlwifi/rtl_pci.ko
>>> insmod /lib/modules/3.18.0-rc3-next-20141105-panda/extra/rtl8192se.ko
>>> ERROR: could not insert 'rtl8192se': Invalid argument
>>>
>>> And /var/log/messages showed:
>>>
>>> Nov  5 22:28:01 laptop kernel: [  301.276806] rtl8192se: disagrees about
>>> version of symbol rtl_process_phyinfo
>>> Nov  5 22:28:01 laptop kernel: [  301.276812] rtl8192se: Unknown symbol
>>> rtl_process_phyinfo (err -22)
>>> Nov  5 22:28:01 laptop kernel: [  301.276864] rtl8192se: disagrees about
>>> version of symbol rtl_get_tcb_desc
>>> Nov  5 22:28:01 laptop kernel: [  301.276866] rtl8192se: Unknown symbol
>>> rtl_get_tcb_desc (err -22)
>>>
>>
>> Here is what I did in order to get the rtl8192se from Larry's repo to
>> work:
>>
>> $ cd rtlwifi_new
>> $ make
>>
>> $ sudo modprobe -rv rtl8192se
>> rmmod rtl8192se
>> rmmod rtl_pci
>> rmmod rtlwifi
>> rmmod mac80211
>> rmmod cfg80211
>>
>> $ sudo modprobe -v cfg80211
>> insmod
>> /lib/modules/3.18.0-rc3-next-20141106-panda/kernel/net/wireless/cfg80211.ko
>>
>> $ sudo modprobe -v mac80211
>> insmod
>> /lib/modules/3.18.0-rc3-next-20141106-panda/kernel/net/mac80211/mac80211.ko
>>
>> $ sudo insmod ./rtlwifi.ko
>> $ sudo insmod ./rtl_pci.ko
>> $ sudo insmod ./rtl8192se/rtl8192se.ko
>>
>> Cascardo helped me to investigate this and the issue was that modprobe
>> was loading the core rtl drivers from the next-20141105 and the
>> rtl8192se from Larry's repo.  Thus, rtl8192se didn't have all its
>> required symbols at loading time.

Re: [PATCH] rtlwifi: Add more checks for get_btc_status callback

[Murilo Opsfelder Araújo]

On Thu, Nov 6, 2014 at 9:30 PM, Larry Finger larry.fin...@lwfinger.net wrote:
 On 11/06/2014 04:52 PM, Murilo Opsfelder Araujo wrote:

 On 11/06/2014 09:40 AM, Murilo Opsfelder Araujo wrote:

 On 11/05/2014 04:12 PM, Larry Finger wrote:

 On 11/05/2014 03:16 AM, Mike Galbraith wrote:

 On Wed, 2014-10-29 at 23:30 -0500, Larry Finger wrote:

 On 10/29/2014 06:28 PM, Murilo Opsfelder Araujo wrote:

 This is a complement of commit
 08054200117a95afc14c3d2ed3a38bf4e345bf78
 rtlwifi: Add check for get_btc_status callback.

 With this patch, next-20141029 at least does not panic with rtl8192se
 device.


 This patch is OK, but as noted it is not complete.

 I have patches to fix all the kernel panics for rtl8192se AND
 rtl8192ce. There
 are missing parts, but I would prefer submitting mine, which would
 conflict with
 this one. For that reason, NACK for this one, and please apply the
 set I am
 submitting now.


 It's all in there now, but my RTL8191SEvB is still dead.  Squabbling
 with it isn't going all that well either.

 As soon as 38506ece rtlwifi: rtl_pci: Start modification for new
 drivers
 is applied, explosions appear.  Subsequently applying...

 08054200 rtlwifi: Add check for get_btc_status callback
 c0386f15 rtlwifi: rtl8192ce: rtl8192de: rtl8192se: Fix handling for
 missing get_btc_status
 50147969 rtlwifi: rtl8192se: Fix duplicate calls to
 ieee80211_register_hw()
 30c5ccc6 rtlwifi: rtl8192se: Add missing section to read descriptor
 setting
 75a916e1 rtlwifi: rtl8192se: Fix firmware loading

 ...fixes that mess up, but leaves the interface dead in the same manner
 as if nothing has been reverted.  So it _seems_ the bustage lurks in
 38506ece somewhere.  Too bad it's non-dinky, and written in wifi-ese :)


 Yes, I am aware that rtl8192se is failing, and now that I am back from
 vacation, I am working on the problem. If you want to use the driver
 with kernel 3.18, clone the repo at
 http://github.com/lwfinger/rtlwifi_new.git and build and install either
 the master or kernel_version branches. Both work.

 I am in the process of trying to find what the crucial difference is
 between that repo and the kernel version.

 Larry


 I'm sending to everyone so others can jump in as well.

 Here are the steps I've followed.

 Installed and booted my kernel:

 $ sudo dpkg -i
 linux-image-3.18.0-rc3-next-20141105-panda_3.18.0-rc3-next-20141105-panda-1_amd64.deb
 linux-headers-3.18.0-rc3-next-20141105-panda_3.18.0-rc3-next-20141105-panda-1_amd64.deb

 Built modules from Larry's github repository.

 $ cd rtlwifi_new
 $ make
 $ sudo make install

 $ sudo modprobe -rv rtl8192se
 rmmod rtl8192se
 rmmod rtl_pci
 rmmod rtlwifi
 rmmod mac80211
 rmmod cfg80211

 The module does not load:

 $ sudo modprobe -v rtl8192se
 insmod
 /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/net/wireless/cfg80211.ko
 insmod
 /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/net/mac80211/mac80211.ko
 insmod
 /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/drivers/net/wireless/rtlwifi/rtlwifi.ko
 insmod
 /lib/modules/3.18.0-rc3-next-20141105-panda/kernel/drivers/net/wireless/rtlwifi/rtl_pci.ko
 insmod /lib/modules/3.18.0-rc3-next-20141105-panda/extra/rtl8192se.ko
 ERROR: could not insert 'rtl8192se': Invalid argument

 And /var/log/messages showed:

 Nov  5 22:28:01 laptop kernel: [  301.276806] rtl8192se: disagrees about
 version of symbol rtl_process_phyinfo
 Nov  5 22:28:01 laptop kernel: [  301.276812] rtl8192se: Unknown symbol
 rtl_process_phyinfo (err -22)
 Nov  5 22:28:01 laptop kernel: [  301.276864] rtl8192se: disagrees about
 version of symbol rtl_get_tcb_desc
 Nov  5 22:28:01 laptop kernel: [  301.276866] rtl8192se: Unknown symbol
 rtl_get_tcb_desc (err -22)


 Here is what I did in order to get the rtl8192se from Larry's repo to
 work:

 $ cd rtlwifi_new
 $ make

 $ sudo modprobe -rv rtl8192se
 rmmod rtl8192se
 rmmod rtl_pci
 rmmod rtlwifi
 rmmod mac80211
 rmmod cfg80211

 $ sudo modprobe -v cfg80211
 insmod
 /lib/modules/3.18.0-rc3-next-20141106-panda/kernel/net/wireless/cfg80211.ko

 $ sudo modprobe -v mac80211
 insmod
 /lib/modules/3.18.0-rc3-next-20141106-panda/kernel/net/mac80211/mac80211.ko

 $ sudo insmod ./rtlwifi.ko
 $ sudo insmod ./rtl_pci.ko
 $ sudo insmod ./rtl8192se/rtl8192se.ko

 Cascardo helped me to investigate this and the issue was that modprobe
 was loading the core rtl drivers from the next-20141105 and the
 rtl8192se from Larry's repo.  Thus, rtl8192se didn't have all its
 required symbols at loading time.

 Loading the drivers in reverse order using insmod did the trick.

 Larry, your rtl8192se from rtlwifi_new repository is working pretty
 fine on my hardware.  I'm looking forward to see that code landing
 linux 3.18.


 I am happy that it is working now; however, if you had done sudo make
 install, the new drivers would have been in the proper directories, and you
 would not have gotten the incorrect symbol errors, or need to use the insmod
 commands that you post.

 Larry


Hello, Larry.

I'd 

Re: [PATCH] fs: Initialize mountpoint list head in new_mountpoint()

[Murilo Opsfelder Araújo]

On Tue, Aug 19, 2014 at 4:01 AM, Thierry Reding
 wrote:
> On Mon, Aug 18, 2014 at 11:43:54PM -0300, Murilo Opsfelder Araujo wrote:
>> The commit 89f7ca1af15bdfe7a6aed343032a84af2a69f736 makes next-20140818
>> to panic because mountpoint list head was not initialized.  Initializing
>> it with NULL fixes the problem.
>>
>> commit 89f7ca1af15bdfe7a6aed343032a84af2a69f736
>> Author: Eric W. Biederman 
>> Date:   Sun Sep 22 19:37:01 2013 -0700
>>
>> vfs: Keep a list of mounts on a mount point
>>
>> To spot any possible problems call BUG if a mountpoint
>> is put when it's list of mounts is not empty.
>>
>> AV: use hlist instead of list_head
>>
>> Signed-off-by: Murilo Opsfelder Araujo 
>> ---
>>  fs/namespace.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> It's considered good etiquette and polite to credit the original author
> of a patch. This should be:
>
> Originally-by: Thierry Reding 

(resending to the lists)

Hello, Thierry.

I didn't know about it and you deserve all the credits, for sure.

I'm away from computer today. I'll send a v2 tomorrow night.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] fs: Initialize mountpoint list head in new_mountpoint()

[Murilo Opsfelder Araújo]

On Tue, Aug 19, 2014 at 4:01 AM, Thierry Reding
thierry.red...@gmail.com wrote:
 On Mon, Aug 18, 2014 at 11:43:54PM -0300, Murilo Opsfelder Araujo wrote:
 The commit 89f7ca1af15bdfe7a6aed343032a84af2a69f736 makes next-20140818
 to panic because mountpoint list head was not initialized.  Initializing
 it with NULL fixes the problem.

 commit 89f7ca1af15bdfe7a6aed343032a84af2a69f736
 Author: Eric W. Biederman ebieder...@twitter.com
 Date:   Sun Sep 22 19:37:01 2013 -0700

 vfs: Keep a list of mounts on a mount point

 To spot any possible problems call BUG if a mountpoint
 is put when it's list of mounts is not empty.

 AV: use hlist instead of list_head

 Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
 ---
  fs/namespace.c | 1 +
  1 file changed, 1 insertion(+)

 It's considered good etiquette and polite to credit the original author
 of a patch. This should be:

 Originally-by: Thierry Reding tred...@nvidia.com

(resending to the lists)

Hello, Thierry.

I didn't know about it and you deserve all the credits, for sure.

I'm away from computer today. I'll send a v2 tomorrow night.

-- 
Murilo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/