DC390: replace pci_module_init in dc390_module_init

2007-05-05 Thread Niklas Steinkamp

Hi,

while compiling the DC930 SCSI driver, i got this message:

drivers/built-in.o: In function `dc390_module_init':
tmscsim.c:(.init.text+0x124c4): undefined reference to `pci_module_init'
make: *** [.tmp_vmlinux1] Fehler 1

so i replaced "pci_module_init" with "pci_register_device"
and it works just fine.
--

diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..3158949 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
printk (KERN_INFO "DC390: Using safe settings.\n");
}

-   return pci_module_init(_driver);
+   return pci_register_driver(_driver);
 }

 static void __exit dc390_module_exit(void)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


DC390: replace pci_module_init in dc390_module_init

2007-05-05 Thread Niklas Steinkamp

Hi,

while compiling the DC930 SCSI driver, i got this message:

drivers/built-in.o: In function `dc390_module_init':
tmscsim.c:(.init.text+0x124c4): undefined reference to `pci_module_init'
make: *** [.tmp_vmlinux1] Fehler 1

so i replaced pci_module_init with pci_register_device
and it works just fine.
--

diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..3158949 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
printk (KERN_INFO DC390: Using safe settings.\n);
}

-   return pci_module_init(dc390_driver);
+   return pci_register_driver(dc390_driver);
 }

 static void __exit dc390_module_exit(void)
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-22 Thread Niklas Steinkamp
Hi,

Pavel wrote:
> Something is very wrong with German legal system, I'm afraid.
 
In this case you are right. Our legal system is often very strange.
__
"Ein Herz für Kinder" - Ihre Spende hilft! Aktion: www.deutschlandsegelt.de
Unser Dankeschön: Ihr Name auf dem Segel der 1. deutschen America's Cup-Yacht!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-22 Thread Niklas Steinkamp
Hi,

Pavel wrote:
 Something is very wrong with German legal system, I'm afraid.
 
In this case you are right. Our legal system is often very strange.
__
Ein Herz für Kinder - Ihre Spende hilft! Aktion: www.deutschlandsegelt.de
Unser Dankeschön: Ihr Name auf dem Segel der 1. deutschen America's Cup-Yacht!

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: Binary Drivers

2006-12-21 Thread Niklas Steinkamp
David wrote: 
> Honestly, I think it *is* wrong to sell someone a physical product and then
> not tell them how to make it work. If you're not actually selling them the
> physical product but selling them a way to get a particular thing done, then
> don't represent that you're selling them physical product because that would
> presumably include the right to use it any way they wanted provided it was
> lawful.
> 
> How would you feel if you bought a car and then discovered that the
> manufacturer had welded the hood shut? How many people still do their own
> oil changes anyway?

I think he is right. The linux kernel is free software and there should be no 
closed source in it.
When Windows uses closed-source drivers, it doesnt matter, but the in the 
linux kernel should be only open-source.




__
"Ein Herz für Kinder" - Ihre Spende hilft! Aktion: www.deutschlandsegelt.de
Unser Dankeschön: Ihr Name auf dem Segel der 1. deutschen America's Cup-Yacht!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: Binary Drivers

2006-12-21 Thread Niklas Steinkamp
David wrote: 
 Honestly, I think it *is* wrong to sell someone a physical product and then
 not tell them how to make it work. If you're not actually selling them the
 physical product but selling them a way to get a particular thing done, then
 don't represent that you're selling them physical product because that would
 presumably include the right to use it any way they wanted provided it was
 lawful.
 
 How would you feel if you bought a car and then discovered that the
 manufacturer had welded the hood shut? How many people still do their own
 oil changes anyway?

I think he is right. The linux kernel is free software and there should be no 
closed source in it.
When Windows uses closed-source drivers, it doesn#180;t matter, but the in the 
linux kernel should be only open-source.




__
Ein Herz für Kinder - Ihre Spende hilft! Aktion: www.deutschlandsegelt.de
Unser Dankeschön: Ihr Name auf dem Segel der 1. deutschen America's Cup-Yacht!

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/