SPARSE_IRQ
Hi; Perhaps Im being an idiot, but it looks to me like the menu-item for SPARSE_IRQ (under General setup -> IRQ subsystem) depends solely on MAY_HAVE_SPARSE_IRQ, but I only see *one* user for that in the kernel now, the SuperH arch (arch/sh/Kconfig). It looks like everyone else explicitly sets SPARSE_IRQ. However the menu-items description implies it is a more generic option... It seems like this menu item used to appear, in a forced on state, then this condition made it disapear, leaving a blank IRQ subsystem menu for me. I was trying to work around that, but now, I am not sure exactly what is supposed to be going on here... Paul (from kernel/irq/Kconfig) config SPARSE_IRQ bool "Support sparse irq numbering" if MAY_HAVE_SPARSE_IRQ ---help--- Sparse irq numbering is useful for distro kernels that want to define a high CONFIG_NR_CPUS value but still want to have low kernel memory footprint on smaller machines. ( Sparse irqs can also be beneficial on NUMA boxes, as they spread out the interrupt descriptors in a more NUMA-friendly way. ) If you don't know what to do here, say N. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
SPARSE_IRQ
Hi; Perhaps Im being an idiot, but it looks to me like the menu-item for SPARSE_IRQ (under General setup - IRQ subsystem) depends solely on MAY_HAVE_SPARSE_IRQ, but I only see *one* user for that in the kernel now, the SuperH arch (arch/sh/Kconfig). It looks like everyone else explicitly sets SPARSE_IRQ. However the menu-items description implies it is a more generic option... It seems like this menu item used to appear, in a forced on state, then this condition made it disapear, leaving a blank IRQ subsystem menu for me. I was trying to work around that, but now, I am not sure exactly what is supposed to be going on here... Paul (from kernel/irq/Kconfig) config SPARSE_IRQ bool Support sparse irq numbering if MAY_HAVE_SPARSE_IRQ ---help--- Sparse irq numbering is useful for distro kernels that want to define a high CONFIG_NR_CPUS value but still want to have low kernel memory footprint on smaller machines. ( Sparse irqs can also be beneficial on NUMA boxes, as they spread out the interrupt descriptors in a more NUMA-friendly way. ) If you don't know what to do here, say N. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix Irq Subsystem menu
Hi; In menuconfig, General setup -> Irq subsystem contains two possible menu-items. Sometimes, neither menu-item exists. This patch prevents the Irq susystem menu from appearing at all unless it will contain at least one menu-item, preventing a confusing, empty menu. --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu "IRQ subsystem" # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu "IRQ subsystem" + depends on ( IRQ_DOMAIN && DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool "Expose hardware/virtual IRQ mapping via debugfs" depends on IRQ_DOMAIN && DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool "Support sparse irq numbering" if MAY_HAVE_SPARSE_IRQ ---help--- Signed-off-by: Paul Thompson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix Irq Subsystem menu
Hi; In menuconfig, General setup - Irq subsystem contains two possible menu-items. Sometimes, neither menu-item exists. This patch prevents the Irq susystem menu from appearing at all unless it will contain at least one menu-item, preventing a confusing, empty menu. --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu IRQ subsystem # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu IRQ subsystem + depends on ( IRQ_DOMAIN DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool Expose hardware/virtual IRQ mapping via debugfs depends on IRQ_DOMAIN DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool Support sparse irq numbering if MAY_HAVE_SPARSE_IRQ ---help--- Signed-off-by: Paul Thompson set.mailingl...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
Grant Likely , on Thu 2012.11.29 said: > On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek wrote: > > (Adding lkml and Thomas as IRQ subsystem maintainer to CC) > > > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > > > Hi; > > > > > > In menuconfig, General setup -> IRQ subsystem, there are two > > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > > > on MAY_HAVE_SPARSE_IRQ. > > > [...] > > > > > > Ideally, the "IRQ subsystem" menu would not even show up > > > if it would contain no menu-items, but I do not know enough to > > > formulate that constraint. > > First, move the 'menu "IRQ subsystem"' line does to right before the > IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you > can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right > below the menu item. > > You'll also need to move the IRQ_FORCED_THREADING line out from inside > the menu block. > > Try it out and let me know how it goes. > > g. Hi; The logic makes sense to me, and makes the menus appearance dependent on if either option setting can exist. So, on my system, the IRQ subsystem menu does not appear. Paul See if this attached patch looks right: --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu "IRQ subsystem" # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu "IRQ subsystem" + depends on ( IRQ_DOMAIN && DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool "Expose hardware/virtual IRQ mapping via debugfs" depends on IRQ_DOMAIN && DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool "Support sparse irq numbering" if MAY_HAVE_SPARSE_IRQ ---help---
Re: IRQ subsystem menu
Grant Likely grant.lik...@secretlab.ca, on Thu 2012.11.29 said: On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek mma...@suse.cz wrote: (Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: Hi; In menuconfig, General setup - IRQ subsystem, there are two possible menu-items. One depends partly on IRQ_DOMAIN, and the other on MAY_HAVE_SPARSE_IRQ. [...] Ideally, the IRQ subsystem menu would not even show up if it would contain no menu-items, but I do not know enough to formulate that constraint. First, move the 'menu IRQ subsystem' line does to right before the IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you can add a depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN line right below the menu item. You'll also need to move the IRQ_FORCED_THREADING line out from inside the menu block. Try it out and let me know how it goes. g. Hi; The logic makes sense to me, and makes the menus appearance dependent on if either option setting can exist. So, on my system, the IRQ subsystem menu does not appear. Paul See if this attached patch looks right: --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu IRQ subsystem # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu IRQ subsystem + depends on ( IRQ_DOMAIN DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool Expose hardware/virtual IRQ mapping via debugfs depends on IRQ_DOMAIN DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool Support sparse irq numbering if MAY_HAVE_SPARSE_IRQ ---help---
BUG: using smp_processor_id() in preemptible
Hi; Just saw this after invoking cpufreq-set -g performance in an attempt to enhance a stuttering mpeg transcode for ps3mediaserver. This repeats in the logs about 10 times. If anyone cares, I will be responsive. Paul 2012 Oct 24 01:39:14: BUG: using smp_processor_id() in preemptible [] code: cpufreq-set/22941 2012 Oct 24 01:39:14: caller is powernowk8_target+0x19/0x50 2012 Oct 24 01:39:14: Pid: 22941, comm: cpufreq-set Not tainted 3.6.2-low-lat #13 2012 Oct 24 01:39:14: Call Trace: 2012 Oct 24 01:39:14: [] ? debug_smp_processor_id+0xd6/0xf0 2012 Oct 24 01:39:14: [] ? powernowk8_target+0x19/0x50 2012 Oct 24 01:39:14: [] ? cpufreq_governor_performance+0x25/0x30 2012 Oct 24 01:39:14: [] ? __cpufreq_governor+0x47/0xc0 2012 Oct 24 01:39:14: [] ? __cpufreq_set_policy+0x164/0x1a0 2012 Oct 24 01:39:14: [] ? store_scaling_governor+0xc9/0x1b0 2012 Oct 24 01:39:15: [] ? cpufreq_update_policy+0xf0/0xf0 2012 Oct 24 01:39:15: [] ? store+0x65/0xb0 2012 Oct 24 01:39:15: [] ? sysfs_write_file+0xcd/0x150 2012 Oct 24 01:39:15: [] ? vfs_write+0xa7/0x180 2012 Oct 24 01:39:15: [] ? sys_write+0x47/0x90 2012 Oct 24 01:39:15: [] ? system_call_fastpath+0x1a/0x1f -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
BUG: using smp_processor_id() in preemptible
Hi; Just saw this after invoking cpufreq-set -g performance in an attempt to enhance a stuttering mpeg transcode for ps3mediaserver. This repeats in the logs about 10 times. If anyone cares, I will be responsive. Paul 2012 Oct 24 01:39:14: BUG: using smp_processor_id() in preemptible [] code: cpufreq-set/22941 2012 Oct 24 01:39:14: caller is powernowk8_target+0x19/0x50 2012 Oct 24 01:39:14: Pid: 22941, comm: cpufreq-set Not tainted 3.6.2-low-lat #13 2012 Oct 24 01:39:14: Call Trace: 2012 Oct 24 01:39:14: [811b0476] ? debug_smp_processor_id+0xd6/0xf0 2012 Oct 24 01:39:14: [812eb6e9] ? powernowk8_target+0x19/0x50 2012 Oct 24 01:39:14: [812e9a95] ? cpufreq_governor_performance+0x25/0x30 2012 Oct 24 01:39:14: [812e7f87] ? __cpufreq_governor+0x47/0xc0 2012 Oct 24 01:39:14: [812e8164] ? __cpufreq_set_policy+0x164/0x1a0 2012 Oct 24 01:39:14: [812e8849] ? store_scaling_governor+0xc9/0x1b0 2012 Oct 24 01:39:15: [812e8c40] ? cpufreq_update_policy+0xf0/0xf0 2012 Oct 24 01:39:15: [812e9005] ? store+0x65/0xb0 2012 Oct 24 01:39:15: [8112574d] ? sysfs_write_file+0xcd/0x150 2012 Oct 24 01:39:15: [810ca9a7] ? vfs_write+0xa7/0x180 2012 Oct 24 01:39:15: [810cacd7] ? sys_write+0x47/0x90 2012 Oct 24 01:39:15: [813d8526] ? system_call_fastpath+0x1a/0x1f -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
