RE: [PATCH] media: fix Omnivision Intel MAINTAINERS entry
Thanks Dave. The change is correct. Btw, I remember this has already been corrected some time ago. Thanks Tianshu Qiu > -Original Message- > From: Dave Hansen > Sent: Thursday, September 24, 2020 3:34 AM > To: linux-kernel@vger.kernel.org > Cc: Dave Hansen ; Qiu, Tian Shu > ; Tu, ShawnX ; Cao, > Bingbu ; linux-me...@vger.kernel.org; mche...@kernel.org > Subject: [PATCH] media: fix Omnivision Intel MAINTAINERS entry > > > From: Dave Hansen > > Tianshu Qiu has three MAINTAINERS entries, and one typo. After being > notified if the typo a few months ago, they didn't act, so here's a > patch. > > Tianshu, an ack would be appreciated. > > Signed-off-by: Dave Hansen > Cc: Tianshu Qiu > Cc: Shawn Tu > Cc: Bingbu Cao > Cc: linux-me...@vger.kernel.org > Cc: Mauro Carvalho Chehab > Cc: linux-kernel@vger.kernel.org > --- > > b/MAINTAINERS |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN MAINTAINERS~bad-intel-maintainers MAINTAINERS > --- a/MAINTAINERS~bad-intel-maintainers 2020-09-23 12:24:01.585676846 > -0700 > +++ b/MAINTAINERS 2020-09-23 12:25:02.959676693 -0700 > @@ -12766,7 +12766,7 @@ T:git git://linuxtv.org/media_tree.git > F: drivers/media/i2c/ov2685.c > > OMNIVISION OV2740 SENSOR DRIVER > -M: Tianshu Qiu > +M: Tianshu Qiu > R: Shawn Tu > R: Bingbu Cao > L: linux-me...@vger.kernel.org > _
RE: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
> -Original Message- > From: Bjorn Helgaas > Sent: Tuesday, July 28, 2020 1:31 AM > To: Qiu, Tian Shu > Cc: Cao, Bingbu ; linux-me...@vger.kernel.org; > linux-kernel@vger.kernel.org; sakari.ai...@linux.intel.com; > bingbu@linux.intel.com > Subject: Re: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu > > On Mon, Jul 27, 2020 at 04:20:39AM +, Qiu, Tian Shu wrote: > > Reviewed-by: Tianshu Qiu > > This doesn't really make sense. The patch already contains your > Signed-off-by, which means you participated in its development (see > Documentation/process/submitting-patches.rst), and I don't think it > makes sense to review your own patch. Thanks for pointing this out. Sorry I did not pay attention to this. > > > > -Original Message- > > > From: Cao, Bingbu > > > Sent: Monday, July 27, 2020 12:12 PM > > > To: linux-me...@vger.kernel.org; linux-kernel@vger.kernel.org; > > > helg...@kernel.org > > > Cc: sakari.ai...@linux.intel.com; Qiu, Tian Shu ; > > > Cao, Bingbu ; > > > bingbu@linux.intel.com > > > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu > > > > > > Fix the typo in email address of Tianshu Qiu and correct the name. > > > > > > Signed-off-by: Bingbu Cao > > > Signed-off-by: Tianshu Qiu > > Also, Documentation/process/submitting-patches.rst says "the last > Signed-off-by: must always be that of the developer submitting the > patch," which means these should be reversed, since Bingbu submitted > the patch. > > > > Reported-by: Bjorn Helgaas > > I don't care whether you include this or not, but if you do, it would > typically go first, since the report comes before the writing of the > patch. > > > > --- > > > MAINTAINERS | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 5392f00cec46..638dfa99751b 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER > > > M: Yong Zhi > > > M: Sakari Ailus > > > M: Bingbu Cao > > > -R: Tian Shu Qiu > > > +R: Tianshu Qiu > > > L: linux-me...@vger.kernel.org > > > S: Maintained > > > F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst > > > @@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/ > > > INTEL IPU3 CSI-2 IMGU DRIVER > > > M: Sakari Ailus > > > R: Bingbu Cao > > > -R: Tian Shu Qiu > > > +R: Tianshu Qiu > > > L: linux-me...@vger.kernel.org > > > S: Maintained > > > F: Documentation/admin-guide/media/ipu3.rst > > > @@ -12609,7 +12609,7 @@ T:git git://linuxtv.org/media_tree.git > > > F: drivers/media/i2c/ov2685.c > > > > > > OMNIVISION OV2740 SENSOR DRIVER > > > -M: Tianshu Qiu > > > +M: Tianshu Qiu > > > R: Shawn Tu > > > R: Bingbu Cao > > > L: linux-me...@vger.kernel.org > > > -- > > > 2.7.4 > >
RE: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu
Reviewed-by: Tianshu Qiu > -Original Message- > From: Cao, Bingbu > Sent: Monday, July 27, 2020 12:12 PM > To: linux-me...@vger.kernel.org; linux-kernel@vger.kernel.org; > helg...@kernel.org > Cc: sakari.ai...@linux.intel.com; Qiu, Tian Shu ; > Cao, Bingbu ; > bingbu@linux.intel.com > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu > > Fix the typo in email address of Tianshu Qiu and correct the name. > > Signed-off-by: Bingbu Cao > Signed-off-by: Tianshu Qiu > Reported-by: Bjorn Helgaas > --- > MAINTAINERS | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5392f00cec46..638dfa99751b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER > M: Yong Zhi > M: Sakari Ailus > M: Bingbu Cao > -R: Tian Shu Qiu > +R: Tianshu Qiu > L: linux-me...@vger.kernel.org > S: Maintained > F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst > @@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/ > INTEL IPU3 CSI-2 IMGU DRIVER > M: Sakari Ailus > R: Bingbu Cao > -R: Tian Shu Qiu > +R: Tianshu Qiu > L: linux-me...@vger.kernel.org > S: Maintained > F: Documentation/admin-guide/media/ipu3.rst > @@ -12609,7 +12609,7 @@ T:git git://linuxtv.org/media_tree.git > F: drivers/media/i2c/ov2685.c > > OMNIVISION OV2740 SENSOR DRIVER > -M: Tianshu Qiu > +M: Tianshu Qiu > R: Shawn Tu > R: Bingbu Cao > L: linux-me...@vger.kernel.org > -- > 2.7.4
RE: [PATCH] media: intel-ipu3: cio2: register the mdev on v4l2 async notifier complete
Hi,
Raise my point.
The case here is that we have multiple sensors connected to CIO2. The sensors
work independently. So failure on one sensor should not block the function of
the other.
That is, we should not rely on that all sensors are ready before allowing user
to operate on the ready cameras.
Sometimes due to hardware issues or incompleteness, we did met the case that
one sensor is not probing properly. And in this case, the current
implementation blocks us using the working one.
What I can think now to solve this are:
1. Register multiple media devices. One for each sensor path. This will
increase media device count.
2. Use .bound callback to create the link and register the subdev node for each
sensor. Leave .complete empty.
Not sure if this breaks the rule of media framework. And also have not
found an API to register one single subdev node.
Thanks
Tianshu Qiu
> -Original Message-
> From: Javier Martinez Canillas [mailto:javi...@redhat.com]
> Sent: Monday, September 3, 2018 4:52 PM
> To: Bing Bu Cao ; linux-kernel@vger.kernel.org
> Cc: Mauro Carvalho Chehab ; Qiu, Tian Shu
> ; Zheng, Jian Xu
> ; Sakari Ailus ; Zhi,
> Yong ; Cao, Bingbu
> ; linux-me...@vger.kernel.org
> Subject: Re: [PATCH] media: intel-ipu3: cio2: register the mdev on v4l2 async
> notifier complete
>
> On 09/03/2018 10:49 AM, Bing Bu Cao wrote:
> >
> >
> > On 09/03/2018 03:35 PM, Javier Martinez Canillas wrote:
> >> Hi,
> >>
> >> Thanks a lot your feedback.
> >>
> >> On 09/03/2018 09:25 AM, Bing Bu Cao wrote:
> >>>
> >>> On 08/31/2018 11:20 PM, Javier Martinez Canillas wrote:
> >>>> Commit 9832e155f1ed ("[media] media-device: split media initialization
> >>>> and
> >>>> registration") split the media_device_register() function in two, to
> >>>> avoid
> >>>> a race condition that can happen when the media device node is accessed
> >>>> by
> >>>> userpace before the pending subdevices have been asynchronously
> >>>> registered.
> >>>>
> >>>> But the ipu3-cio2 driver calls the media_device_register() function right
> >>>> after calling media_device_init() which defeats the purpose of having two
> >>>> separate functions.
> >>>>
> >>>> In that case, userspace could have a partial view of the media device if
> >>>> it opened the media device node before all the pending devices have been
> >>>> bound. So instead, only register the media device once all pending v4l2
> >>>> subdevices have been registered.
> >>> Javier, Thanks for your patch.
> >>> IMHO, there are no big differences for registering the cio2 before and
> >>> after all the subdevices are ready.
> >>> User may see a partial view of media graph but it presents what it really
> >>> is then.
> >>> It indicate that device is not available currently not it is not there.
> >> I disagree that there are no differences. The media graph shouldn't be
> >> exposed
> >> until its complete. That's the reason why we have a v4l2 async notifier
> >> .bound
> >> and .complete callbacks (otherwise the .bound would be enough).
> >>
> >> It's also the reason why media register was split in _init and _register,
> >> as I
> >> mentioned in the commit message.
> > I revisit the commit 9832e155f1ed and understand and agree that.
>
> Great. Does this mean the patch has your Reviewed-by / Acked-by ?
>
> > Seems like there are some other drivers (such as rcar-vin and omap4iss)
> > still have similar issues.
>
> Yes it seems so. I don't have access to hardware with these IP blocks though,
> I'm hesitant to attempt to fix them.
>
> Best regards,
> --
> Javier Martinez Canillas
> Software Engineer - Desktop Hardware Enablement
> Red Hat
